Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 9:
Hi,
I think the init tasks could be moved to vdsm-tool in future
Well, I think that it only makes it even more
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 9:
Thanks Alon!
I agree on most of your suggestions. I just have 1 different ideas and 1
question.
1. About
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 9: (8 inline comments)
Hi!
I understand that I commented too much this work. Other people should comment
as well.
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 9:
please rebase over http://gerrit.ovirt.org/#/c/15216/
--
To view, visit http://gerrit.ovirt.org/14826
To
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 7: (14 inline comments)
File vdsm/init/init_dummybr.sh
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3010/ : SUCCESS
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 8: (6 inline comments)
File vdsm/init/init_gencerts.sh
Line 22:
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 7: (6 inline comments)
File vdsm/init/init_gencerts.sh
Line 19:
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 7: (4 inline comments)
File vdsm/init/init_gencerts.sh
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3012/ : SUCCESS
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 9: Verified
Test on Fedora and RHEL.
The new patch set fix most of the historical problems spotted by Alon and
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2979/ : SUCCESS
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 7: Verified
In this patch set:
Divide the tasks into the default ones and extra ones. The default tasks are
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 7: (14 inline comments)
I just think that if most stuff here are single line of vdsm-tool usage, we can
consider
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 6: Verified
The new patch set add pre-start and post-stop subcommand to the run_task script.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2748/ : SUCCESS
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 3: (1 inline comment)
File configure.ac
Line 206:
Line 207:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2694/ : SUCCESS
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 4: Verified
Test on Fedora17 and RHEL6.
As Dan suggests, hook is for optional tasks, not for crucial tasks, and
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2695/ : SUCCESS
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 5:
Great!
Where is the generic script that gets the --background --pidfile=, and where is
the systemd wrapper?
For
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 5: Verified
Thanks Alon. I was planning to add that init wrapper in another patch. Your
idea is good. Do you
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 5:
Well, I think the split is really a cleanup, what important for supporting
other distributions is the interaction
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 5:
OK. I'll submit another one. I appreciate your comments on the usage of
vdsm_init pre-start and post-stop. I
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 5:
Consider merging these pre/post into vdsm-tool like we have done with libvirt.
--
To view, visit
25 matches
Mail list logo
