gerrit-hooks has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: Move saveState() out of constructor
..
vm: Move saveState() out of constructor
Moved saveState() call to the begining of async start of VM in
Francesco Romani has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 8: Code-Review+2
after second review, seems correct.
--
To view, visit https://gerrit.ovirt.org/53950
gerrit-hooks has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 7: Code-Review+1
seems fine. I will do another deeper review later, hopefully with no surprises
--
To
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 7: Verified+1
Verified using standard mass migration process with extreme throttling to
trigger multiple
gerrit-hooks has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/53950/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 685:
Francesco Romani has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/53950/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 685:
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/53950/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 685:
Francesco Romani has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 6:
(1 comment)
I'm thinking again about the error paths.
gerrit-hooks has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53950/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 686:
Francesco Romani has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 5: Code-Review+1
seems OK (partial ACK), but I need to think a bit more about the error path(s).
--
To
Francesco Romani has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53950/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 686:
gerrit-hooks has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 3: Code-Review-1
this is raceful - please keep saveState on the syncronous part, or we may loose
a VM and
Francesco Romani has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 3: Code-Review-1
-1 for visibility, please read.
This change looks correct, but devil's in the details.
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/53950
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 1:
this should be safe, but I need to have a deeper luck.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has uploaded a new change for review.
Change subject: vm: Move saveState() out of constructor
..
vm: Move saveState() out of constructor
Moved saveState() call to the begining of async start of VM in order to:
*
25 matches
Mail list logo
