Change in vdsm[master]: Add hostusbdirect hook to vdsm_hooks.

2013-07-30 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: Add hostusbdirect hook to vdsm_hooks. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17428 To

Change in vdsm[master]: Improved ip rule and route robustness + improved logging

2013-07-30 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Improved ip rule and route robustness + improved logging .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/17425 To unsubscribe, visit

Change in vdsm[master]: Support for multiple heads for Qxl display device

2013-07-30 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Support for multiple heads for Qxl display device .. Patch Set 6: Hi Shahar, I am curious about how to verify this patch. It seems that the attribute 'heads'

Change in vdsm[master]: Improved ip rule and route robustness + improved logging

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Improved ip rule and route robustness + improved logging .. Patch Set 2: Looks good to me, approved Thanks! -- To view, visit http://gerrit.ovirt.org/17425

Change in vdsm[master]: Improved ip rule and route robustness + improved logging

2013-07-30 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Improved ip rule and route robustness + improved logging .. Improved ip rule and route robustness + improved logging * SuperVDSM should no longer

Change in vdsm[master]: Support for multiple heads for Qxl display device

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Support for multiple heads for Qxl display device .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: typo in guest agent channel timeout handling

2013-07-30 Thread michal . skrivanek
Michal Skrivanek has uploaded a new change for review. Change subject: typo in guest agent channel timeout handling .. typo in guest agent channel timeout handling Change-Id: I63a8a5aa098101ebb3e3c4de2b2dddae4c158490

Change in vdsm[master]: typo in guest agent channel timeout handling

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: typo in guest agent channel timeout handling .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17456 To unsubscribe, visit

Change in vdsm[master]: Unified network persistence [3/3] - Restore network configur...

2013-07-30 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Unified network persistence [3/3] - Restore network configuration .. Patch Set 2: I would prefer that you didn't submit this Assaf, could you please take a look at

Change in vdsm[master]: Support for multiple heads for Qxl display device

2013-07-30 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: Support for multiple heads for Qxl display device .. Patch Set 6: (1 inline comment) Mark, You can test it by looking at libvirt xml and see that you have the

Change in vdsm[master]: Unified network persistence [3/3] - Restore network configur...

2013-07-30 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [3/3] - Restore network configuration .. Patch Set 2: Mark, Work on this featurette has been delayed due to the pending release of

Change in vdsm[master]: typo in guest agent channel timeout handling

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: typo in guest agent channel timeout handling .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2735/ : SUCCESS

Change in vdsm[master]: Support for multiple heads for Qxl display device

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Support for multiple heads for Qxl display device .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2736/ :

Change in vdsm[master]: java_bindings: Java client

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: java_bindings: Java client .. Patch Set 17: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2737/ : FAILURE

Change in vdsm[master]: infra: Rearrange PYTHONPATH for remoteFileHandler

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: infra: Rearrange PYTHONPATH for remoteFileHandler .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2738/ :

Change in vdsm[master]: jsonrpc: Introduce the definitive JsonRpcClient

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Introduce the definitive JsonRpcClient .. Patch Set 13: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2740/ :

Change in vdsm[master]: infra: Add logging in case PoolHandler crashes

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: infra: Add logging in case PoolHandler crashes .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2739/ :

Change in vdsm[master]: java_bindings: Minor imporovements

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: java_bindings: Minor imporovements .. Patch Set 9: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2741/ : FAILURE

Change in vdsm[master]: jsonrpc: Make proton reactor client capable as well

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Make proton reactor client capable as well .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2742/ :

Change in vdsm[master]: Add hostusbdirect hook to vdsm_hooks.

2013-07-30 Thread lyarwood
Lee Yarwood has posted comments on this change. Change subject: Add hostusbdirect hook to vdsm_hooks. .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: fileSD: remove reference to the removed safeUnlink

2013-07-30 Thread obasan
Ohad Basan has posted comments on this change. Change subject: fileSD: remove reference to the removed safeUnlink .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/17173 To unsubscribe, visit

Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: QoS host networks: caps now reports QoS for networks. .. Patch Set 4: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: fileSD: remove reference to the removed safeUnlink

2013-07-30 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: fileSD: remove reference to the removed safeUnlink .. fileSD: remove reference to the removed safeUnlink the method safeUnlink was replaced by rmFile

Change in vdsm[master]: Capabilities: List capabilities of the IBM POWER familiy

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Capabilities: List capabilities of the IBM POWER familiy .. Patch Set 2: Build Successful

Change in vdsm[master]: Changing libvirt configure print

2013-07-30 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Changing libvirt configure print .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/17296 To unsubscribe, visit

Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: QoS host networks: caps now reports QoS for networks. .. Patch Set 4: (3 inline comments) File

Change in vdsm[master]: Changing libvirt configure print

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Changing libvirt configure print .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: vdsm: Do not fail releasing a VM due to agent stopping error...

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Do not fail releasing a VM due to agent stopping errors .. Patch Set 3: (1 inline comment) File

Change in vdsm[master]: vdsm: Do not fail releasing a VM due to agent stopping error...

2013-07-30 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Do not fail releasing a VM due to agent stopping errors .. vdsm: Do not fail releasing a VM due to agent stopping errors If the guest agent

Change in vdsm[master]: vdsm: Do not fail releasing a VM due to agent stopping error...

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Do not fail releasing a VM due to agent stopping errors .. Patch Set 5: Looks good to me, approved Thanks, Vinzenz! -- To view, visit

Change in vdsm[master]: multipath: Reload multipathd instead of restart on setup

2013-07-30 Thread ykaplan
Yeela Kaplan has uploaded a new change for review. Change subject: multipath: Reload multipathd instead of restart on setup .. multipath: Reload multipathd instead of restart on setup Multipathd is required by vdsmd. We should

Change in vdsm[master]: multipath: Reload multipathd instead of restart on setup

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath: Reload multipathd instead of restart on setup .. Patch Set 1: Build Successful

Change in vdsm[master]: multipath: Reload multipathd instead of restart on setup

2013-07-30 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: multipath: Reload multipathd instead of restart on setup .. Patch Set 1: Verified Verified on Fedora 19 -- To view, visit http://gerrit.ovirt.org/17487 To

Change in vdsm[master]: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR

2013-07-30 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR .. Patch Set 2: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: Add hostusbdirect hook to vdsm_hooks.

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add hostusbdirect hook to vdsm_hooks. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2745/ : SUCCESS

Change in vdsm[master]: multipath: Reload multipathd instead of restart on setup

2013-07-30 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: multipath: Reload multipathd instead of restart on setup .. multipath: Reload multipathd instead of restart on setup Multipathd is required by vdsmd.

Change in vdsm[master]: multipath: Reload multipathd instead of restart on setup

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: multipath: Reload multipathd instead of restart on setup .. Patch Set 1: Looks good to me, approved Thanks! this is achingly needed. -- To view, visit

Change in vdsm[master]: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2746/ : SUCCESS

Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.

2013-07-30 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: QoS host networks: caps now reports QoS for networks. .. Patch Set 4: No score (2 inline comments) Ok thanks for the feedback I will update the patch

Change in vdsm[master]: One shot teardown.

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: One shot teardown. .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2747/ : SUCCESS

Change in vdsm[master]: One shot prepare.

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: One shot prepare. .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2748/ : SUCCESS

Change in vdsm[master]: Don't reconfigure vlan devs unless necessary.

2013-07-30 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: Don't reconfigure vlan devs unless necessary. .. Don't reconfigure vlan devs unless necessary. When adding vlans on top of devices, a configure of the

Change in vdsm[master]: Don't reconfigure vlan devs unless necessary.

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Don't reconfigure vlan devs unless necessary. .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2749/ :

Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.

2013-07-30 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: QoS host networks: caps now reports QoS for networks. .. Patch Set 5: Verified It can be verified as previously said before and also by using networks()

Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: QoS host networks: caps now reports QoS for networks. .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2751/

Change in vdsm[master]: vdscli: update cannonize helper function for IPv6 environmen...

2013-07-30 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdscli: update cannonize helper function for IPv6 environment .. vdscli: update cannonize helper function for IPv6 environment The original approach

Change in vdsm[master]: vdscli: update cannonize helper function for IPv6 environmen...

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdscli: update cannonize helper function for IPv6 environment .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16225 To

Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. .. Patch Set 3: Looks good to me, approved -- To view, visit

Change in vdsm[master]: Refactoring: changing nic_devices visilibity, now private.

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Refactoring: changing nic_devices visilibity, now private. .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17274 To

Change in vdsm[master]: Refactoring: changing nic_devices visilibity, now private.

2013-07-30 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Refactoring: changing nic_devices visilibity, now private. .. Refactoring: changing nic_devices visilibity, now private. nic_devices is used in the as

Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. .. Patch Set 3: I would prefer that you didn't submit this -- To view, visit

Change in vdsm[master]: refactoring: Configurator base class making attributes expli...

2013-07-30 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: refactoring: Configurator base class making attributes explicit. .. refactoring: Configurator base class making attributes explicit. Currently the

Change in vdsm[master]: Don't reconfigure vlan devs unless necessary.

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Don't reconfigure vlan devs unless necessary. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2752/ :

Change in vdsm[master]: [WIP] java_biniding: Simplify bindings by using object mappe...

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] java_biniding: Simplify bindings by using object mappers .. Patch Set 3: Build Successful

Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...

2013-07-30 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. .. Patch Set 4: Verified Simply a rebase. -- To view, visit

Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. .. Patch Set 4: Build Successful

Change in vdsm[master]: mom: Require latest mom

2013-07-30 Thread dfediuck
Doron Fediuck has uploaded a new change for review. Change subject: mom: Require latest mom .. mom: Require latest mom Latest mom build uses strings for the balloon info, needed for proper ballooning integration. This patch

Change in vdsm[master]: mom: Require latest mom

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: mom: Require latest mom .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2755/ : SUCCESS

Change in vdsm[master]: clientIF: automatically unpause vms in EIO when SD becomes a...

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: clientIF: automatically unpause vms in EIO when SD becomes active .. Patch Set 7: I would prefer that you didn't submit this (8 inline comments)

Change in vdsm[master]: Support for multiple heads for Qxl display device

2013-07-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Support for multiple heads for Qxl display device .. Patch Set 7: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: Support for multiple heads for Qxl display device

2013-07-30 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Support for multiple heads for Qxl display device .. Patch Set 7: Shahar, Thanks for your answer. But what's the difference between with the attribute 'heads=N' and

Change in vdsm[master]: Too many True sizes for a False Volume class.

2013-07-30 Thread ewarszaw
Eduardo has uploaded a new change for review. Change subject: Too many True sizes for a False Volume class. .. Too many True sizes for a False Volume class. Since an (abstract) volume never will be instantiated alone, get the

Change in vdsm[master]: Avoid Img and Vol produces in fileVolume.getV*Size

2013-07-30 Thread ewarszaw
Eduardo has uploaded a new change for review. Change subject: Avoid Img and Vol produces in fileVolume.getV*Size .. Avoid Img and Vol produces in fileVolume.getV*Size No need for produce Images and Volumes for get the volume

Change in vdsm[master]: Avoid Img and Vol produces in fileVolume.getV*Size

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid Img and Vol produces in fileVolume.getV*Size .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2757/ :

Change in vdsm[master]: Too many True sizes for a False Volume class.

2013-07-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Too many True sizes for a False Volume class. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2756/ :