Assaf Muller has posted comments on this change.
Change subject: Ifcfg: Fix file writing races
..
Patch Set 1: Code-Review+1
Wow, big up Antoni... Sounds like a painful debug session.
--
To view, visit
Aravinda VK has uploaded a new change for review.
Change subject: gluster: Replace bricks verbs removed
..
gluster: Replace bricks verbs removed
glusterfs phased out replace-brick feature.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Replace bricks verbs removed
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4888/ : SUCCESS
Bala.FA has posted comments on this change.
Change subject: vdsmapi: gluster: vdsmapi schema definitions for existing
gluster verbs
..
Patch Set 7: Code-Review-1
(21 comments)
Overall, please check and sync with
Yaniv Bronhaim has posted comments on this change.
Change subject: Changing return method from vdsmd start function
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Changing return method from vdsmd start function
..
Patch Set 6:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Ifcfg: Fix file writing races
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4887/ : SUCCESS
Alon Bar-Lev has posted comments on this change.
Change subject: Changing return method from vdsmd start function
..
Patch Set 6:
(1 comment)
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Changing return method from vdsmd start function
..
Patch Set 6:
(1 comment)
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: testrunner P_VDSM path fix
..
testrunner P_VDSM path fix
when running run_tests_local.sh the tests that want to find modules
that would usually be
Dan Kenigsberg has posted comments on this change.
Change subject: testrunner P_VDSM path fix
..
Patch Set 2: Code-Review+2
In a private communication I've understood that this currently affects only
looking for
Nir Soffer has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1: Code-Review+1
(7 comments)
The change is good and important, and having a test for this is even more
Yaniv Bronhaim has posted comments on this change.
Change subject: Avoiding automatically restart of sanlock service when starting
vdsmd
..
Patch Set 8:
(1 comment)
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Changing return method from vdsmd start function
..
Changing return method from vdsmd start function
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: Changing return method from vdsmd start function
..
Patch Set 6:
(1 comment)
File
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Removing unnecessary subshell call
..
Removing unnecessary subshell call
Change-Id: If938a322836a82090671483f47a6a0c49878556a
Signed-off-by: Yaniv Bronhaim
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Avoiding automatically restart of sanlock service when starting
vdsmd
..
Patch Set 9:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Moving coredump configuration to common script
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4890/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Modifying libvirt_configure usage print
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4889/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1: Code-Review+1
(1 comment)
Commit Message
Line 12: *
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Removing unnecessary subshell call
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4893/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Removing libvirt_configure from pre-start and ask for manual run
..
Patch Set 11:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1:
I think that the commit message should explain which user flow exposes this
severe bug, so that our users
Yaniv Bronhaim has posted comments on this change.
Change subject: Moving coredump configuration to common script
..
Patch Set 7: Verified+1
sorry for the rebasing once again ..
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing libvirt_configure from pre-start and ask for manual run
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/19737
To unsubscribe,
Alon Bar-Lev has posted comments on this change.
Change subject: Avoiding automatically restart of sanlock service when starting
vdsmd
..
Patch Set 9:
(8 comments)
File
Sergey Gotliv has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1: Code-Review+1
Since this patch cost me 2 destroyed VMs I definitely will give it +1.
--
To view, visit
Sergey Gotliv has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1:
(1 comment)
Commit Message
Line 12: * a new comment
Dan Kenigsberg has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1: Code-Review+2
(1 comment)
Commit Message
Line 12: *
Yaniv Bronhaim has posted comments on this change.
Change subject: Avoiding automatically restart of sanlock service when starting
vdsmd
..
Patch Set 9:
(2 comments)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: Removing unnecessary subshell call
..
Patch Set 1:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line
Alon Bar-Lev has posted comments on this change.
Change subject: Avoiding automatically restart of sanlock service when starting
vdsmd
..
Patch Set 9:
(1 comment)
File
Hello Nir Soffer, Sergey Gotliv, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/20063
to review the following change.
Change subject: oop: improve safety for truncateFile
..
oop:
Hello Yeela Kaplan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/20062
to review the following change.
Change subject: remoteFileHandler: Add create exclusive option for truncateFile
Dan Kenigsberg has posted comments on this change.
Change subject: Removing unnecessary subshell call
..
Patch Set 1:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 68:
Zhou Zheng Sheng has posted comments on this change.
Change subject: Changing return method from vdsmd start function
..
Patch Set 6:
(1 comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1: Verified+1 Code-Review+2
Same as master.
--
To view, visit http://gerrit.ovirt.org/20063
To
Alon Bar-Lev has posted comments on this change.
Change subject: Removing unnecessary subshell call
..
Patch Set 1:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 68:
Federico Simoncelli has posted comments on this change.
Change subject: remoteFileHandler: Add create exclusive option for truncateFile
..
Patch Set 1: Verified+1 Code-Review+2
Same as master.
--
To view, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: Ifcfg: Fix file writing races
..
Patch Set 1: Verified+1
Passes the whole functional test suite on my host.
--
To view, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: oop: improve safety for truncateFile
..
oop: improve safety for truncateFile
In order to make truncateFile safer and to avoid any confusion on
Federico Simoncelli has submitted this change and it was merged.
Change subject: remoteFileHandler: Add create exclusive option for truncateFile
..
remoteFileHandler: Add create exclusive option for truncateFile
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: Removing libvirt_configure from pre-start and ask for manual run
..
Patch Set 9:
(1 comment)
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Removing libvirt_configure from pre-start and ask for manual run
..
Removing libvirt_configure from pre-start and ask for manual run
Before starting
Dan Kenigsberg has posted comments on this change.
Change subject: Removing libvirt_configure from pre-start and ask for manual run
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19737
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virtTests: fix initramfs permission detection
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4894/ : SUCCESS
Zhou Zheng Sheng has posted comments on this change.
Change subject: Removing unnecessary subshell call
..
Patch Set 1:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line
Zhou Zheng Sheng has posted comments on this change.
Change subject: virtTests: fix initramfs permission detection
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20031
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Ifcfg: Fix file writing races
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4887/ : SUCCESS
Martin Polednik has posted comments on this change.
Change subject: virtTests: fix initramfs permission detection
..
Patch Set 2: Verified+1
initramfs generator works as expected and tests are being skipped on unreadable
Federico Simoncelli has posted comments on this change.
Change subject: Avoiding automatically restart of sanlock service when starting
vdsmd
..
Patch Set 9:
(2 comments)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Ifcfg: Fix file writing races
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4887/ : SUCCESS
Alon Bar-Lev has posted comments on this change.
Change subject: Avoiding automatically restart of sanlock service when starting
vdsmd
..
Patch Set 9:
(2 comments)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bugfix: UpdateVmDevice QoS
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4895/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: virtTests: fix initramfs permission detection
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20031
To unsubscribe, visit
Petr Šebek has posted comments on this change.
Change subject: bugfix: UpdateVmDevice QoS
..
Patch Set 6: Verified+1
Verified with ovirt-engine webadmin. Before update nic's bandwidth looks like
this:
bandwidth
inbound
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Ifcfg: Fix file writing races
..
Patch Set 1: -Verified
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4887/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Ifcfg: Fix file writing races
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/20050
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Ifcfg: Fix file writing races
..
Ifcfg: Fix file writing races
On a fast enough computer, it could very well happen that we'd do:
open('foo',
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
vdsm: prepareVolumePath correct path handling for cdrom
prepareVolumePath checked looked 'path'
Alex Lourie has posted comments on this change.
Change subject: vdsm: pre-defined range for spice/vnc ports
..
Patch Set 2:
When adding new hosts, engine will configure the iptables to open legacy ports
5634 to 6166.
If this
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4896/ :
Federico Simoncelli has uploaded a new change for review.
Change subject: test: add ddWatchCopy append tests
..
test: add ddWatchCopy append tests
Change-Id: Ib3a8cc6b59b356b333f4338103e7b665af584cdc
Signed-off-by: Federico
oVirt Jenkins CI Server has posted comments on this change.
Change subject: test: add ddWatchCopy append tests
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4897/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4898/ :
Federico Simoncelli has posted comments on this change.
Change subject: test: add ddWatchCopy append tests
..
Patch Set 1: Verified+1
Verified running unit tests.
--
To view, visit http://gerrit.ovirt.org/20075
To
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: pre-defined range for spice/vnc ports
..
Patch Set 2: Code-Review-1
see additional comments in the bug
--
To view, visit
Doron Fediuck has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 14:
No.
I'd like to resume the work on this patch and make sure it is merged.
--
To view, visit
Ayal Baron has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm hooks: this patch provides after/before_network_setup
hooks.
..
Patch Set 1: Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm hooks: this patch provides after/before_network_setup
hooks.
..
Patch Set 2: Verified-1
Build Failed
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Properly cleanup after using bond in test
..
Properly cleanup after using bond in test
Change-Id: I98a4766911dc541e6f309b7155fde8a466483ff5
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Properly cleanup after using bond in test
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4901/ :
Ayal Baron has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18326
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Properly cleanup after using bond in test
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4902/ : SUCCESS
Doron Fediuck has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 14:
Adding some more info;
The previously mentioned watchdog is missing drivers in some
Windows versions. This feature is
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 2: Verified+1
path is now set even if specParams['path'] is empty
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4903/ :
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/20074
To unsubscribe, visit
Nir Soffer has uploaded a new change for review.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
tests: refactor remoteFileHandler truncateFile tests
Old test was too big, causing one test to fail if the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
Antoni Segura Puimedon has posted comments on this change.
Change subject: Properly cleanup after using bond in test
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/20077
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: bugfix: UpdateVmDevice QoS
..
Patch Set 6: Code-Review+1
(1 comment)
File vdsm.spec.in
Line 117:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4905/ :
Nir Soffer has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 3:
Remove nice empty line at end of file to make pep8 happy and unneeded print.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/20084
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm hooks: this patch provides after/before_network_setup
hooks.
..
Patch Set 2:
(4 comments)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add logging to _getUnderlyingDriveInfo
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4907/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm hooks: this patch provides after/before_network_setup
hooks.
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
Allon Mureinik has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 3: Code-Review+1
(2 comments)
Commit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm hooks: this patch provides after/before_network_setup
hooks.
..
Patch Set 4: Code-Review-1
Please note few nit-picking on PS2 and PS3.
Other than that,
Dan Kenigsberg has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 12:
(1 comment)
File vdsm/vm.py
Line 412: class
Yaniv Bronhaim has posted comments on this change.
Change subject: multipath: Move all calls to multipath exe to a single method
..
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19255
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: iscsi: Iscsi rescan cleanup
..
Patch Set 12: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19256
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20084
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Removing unnecessary subshell call
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4910/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing unnecessary subshell call
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/20061
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 4:
Address Allon comments
--
To view, visit http://gerrit.ovirt.org/20084
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/20084
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: refactor remoteFileHandler truncateFile tests
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4911/ :
1 - 100 of 156 matches
Mail list logo
