oVirt Jenkins CI Server has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5070/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5071/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5072/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: More explicit octal values (pep-3127)
..
Patch Set 2: Verified+1
➜ vdsm git:(9370bb0) gitpydiff
checking lib/vdsm/tool/transient.py
checking
oVirt Jenkins CI Server has posted comments on this change.
Change subject: More explicit octal values (pep-3127)
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5073/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5074/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: cleanup: drop several unused local variables
..
Patch Set 1:
(8 comments)
Thanks a lot for the fast review Dan!
Pavel Zhukov has uploaded a new change for review.
Change subject: Add additional vgck.
..
Add additional vgck.
vgscan doesn't return nonzero return code if one or more phisycal
volumes are filtered (missed). As a result
Nir Soffer has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 3:
I am wondering why you don't want to move step by step, I mean writing this
log to another file first.
Writing
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cleanup: drop several unused local variables
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5075/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add additional vgck.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5076/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cleanup: drop several unused local variables
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5077/ : SUCCESS
Eduardo has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 3:
There is no necessity for this RFE or this way is questionable IMHO.
(As I wrote there.)
The bottom line is that
Pavel Zhukov has abandoned this change.
Change subject: Add additional vgck.
..
Abandoned
need to resubmit the patch
--
To view, visit http://gerrit.ovirt.org/20546
To unsubscribe, visit http://gerrit.ovirt.org/settings
Pavel Zhukov has uploaded a new change for review.
Change subject: vgscan doesn't return nonzero return code if one or more
phisycal volumes are filtered (missed). We should check vg before raising of
the exception. chkVG itself raises storageAccessError if failed, so selftest
doesn't have to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vgscan doesn't return nonzero return code if one or more
phisycal volumes are filtered (missed). We should check vg before raising of
the exception. chkVG itself raises storageAccessError if failed, so selftest
doesn't
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: cleanup: Networking code logging and docstring fixes
..
cleanup: Networking code logging and docstring fixes
Change-Id:
Tomáš Došek has posted comments on this change.
Change subject: vgscan doesn't return nonzero return code if one or more
phisycal volumes are filtered (missed). We should check vg before raising of
the exception. chkVG itself raises storageAccessError if failed, so selftest
doesn't have to it
Tomáš Došek has posted comments on this change.
Change subject: vgscan doesn't return nonzero return code if one or more
phisycal volumes are filtered (missed). We should check vg before raising of
the exception. chkVG itself raises storageAccessError if failed, so selftest
doesn't have to it
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vgscan doesn't return nonzero return code if one or more
phisycal volumes are filtered (missed). We should check vg before raising of
the exception. chkVG itself raises storageAccessError if failed, so selftest
doesn't
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cleanup: Networking code logging and docstring fixes
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5079/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vgscan doesn't return nonzero return code if one or more
phisycal volumes are filtered (missed). We should check vg before raising of
the exception. chkVG itself raises storageAccessError if failed, so selftest
doesn't
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: cleanup: Improve networking imports (PEP328)
..
cleanup: Improve networking imports (PEP328)
PEP328 ( http://www.python.org/dev/peps/pep-0328/ ) does
Nir Soffer has posted comments on this change.
Change subject: cleanup: Improve networking imports (PEP328)
..
Patch Set 1: Code-Review-1
(16 comments)
Important cleanup - but mixes many unrelated cleanups.
This patch does
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vgscan doesn't return nonzero return code if one or more
phisycal volumes are filtered (missed). We should check vg before raising of
the exception. chkVG itself raises storageAccessError if failed, so selftest
doesn't
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cleanup: Improve networking imports (PEP328)
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5084/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cleanup: Networking code logging and docstring fixes
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5083/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vgscan doesn't return nonzero return code if one or more
phisycal volumes are filtered (missed). We should check vg before raising of
the exception. chkVG itself raises storageAccessError if failed, so selftest
doesn't
Nir Soffer has posted comments on this change.
Change subject: lvm: Ensure active LVs are refreshed before use.
..
Patch Set 5:
(1 comment)
Must warn when finding unexpected active lvs.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cleanup: drop several unused local variables
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
Nir Soffer has posted comments on this change.
Change subject: getFileList() filters files in case incensitive manner
..
Patch Set 1:
Sergey, Dan and me discussed the wanted api, and agreed that:
- Change the name to
Antoni Segura Puimedon has posted comments on this change.
Change subject: cleanup: Improve networking imports (PEP328)
..
Patch Set 1:
(4 comments)
Thanks a lot for the review Nir!
Important cleanup - but mixes many
Dan Kenigsberg has posted comments on this change.
Change subject: vgscan doesn't return nonzero return code if one or more
phisycal volumes are filtered (missed). We should check vg before raising of
the exception. chkVG itself raises storageAccessError if failed, so selftest
doesn't have to
Antoni Segura Puimedon has posted comments on this change.
Change subject: cleanup: Improve networking imports (PEP328)
..
Patch Set 1:
Thanks a lot for the review Nir!
Important cleanup - but mixes many unrelated
Nir Soffer has posted comments on this change.
Change subject: cleanup: Improve networking imports (PEP328)
..
Patch Set 1:
Please do not change import order in this patch - it is not related to absolute
imports and just make
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cleanup: drop several unused local variables
..
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5087/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add additional vgcheck.
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5088/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add additional vgcheck.
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5089/ : SUCCESS
Tomáš Došek has posted comments on this change.
Change subject: Add additional vgcheck.
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20552
To unsubscribe, visit http://gerrit.ovirt.org/settings
Pavel Zhukov has posted comments on this change.
Change subject: Add additional vgcheck to fix vgextend workflow on HSMs.
..
Patch Set 8:
I'm sorry for the push flooding. Added the main reason of the patch (vgextend
workflow)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add additional vgcheck to fix vgextend workflow on HSMs.
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5090/ :
Tomáš Došek has posted comments on this change.
Change subject: Add additional vgcheck to fix vgextend workflow on HSMs.
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20552
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: bz#831938 raise exception when error occurs in
connectStorageServer
..
Patch Set 1:
still relevant or should be abandoned?
--
To view, visit
Itamar Heim has posted comments on this change.
Change subject: Adjust width for usage_command in vdsm-tool
..
Patch Set 2:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/4648
To
Itamar Heim has posted comments on this change.
Change subject: Reorganized host network APIs in API bridge
..
Patch Set 3:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/2663
To
Itamar Heim has posted comments on this change.
Change subject: [WIP] rest-api: Model Networks
..
Patch Set 2:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/5881
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: minimalistic (incomplete) test for mkimage.py with fail for
non-64base data
..
Patch Set 1:
still relevant or should be abandoned?
--
To view, visit
Itamar Heim has posted comments on this change.
Change subject: avoid redundant domain produce() in createStoragePool
..
Patch Set 2:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/7347
To
Itamar Heim has posted comments on this change.
Change subject: Add functions getNetworkList and getNetworkInfo to API
..
Patch Set 4:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/2664
To
Itamar Heim has posted comments on this change.
Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
..
Patch Set 4:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/9655
To
Itamar Heim has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/4526
To
Itamar Heim has posted comments on this change.
Change subject: get max_tasks and thread_pool_size from config by getint()
..
Patch Set 1:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/9035
Itamar Heim has posted comments on this change.
Change subject: Move start_needed_srv and shutdown_conflicting_srv to vdsm-tool
..
Patch Set 2:
still relevant or should be abandoned?
--
To view, visit
Itamar Heim has posted comments on this change.
Change subject: Fix vm block stats lost after recovery
..
Patch Set 2:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/6056
To unsubscribe,
Itamar Heim has posted comments on this change.
Change subject: Source image exception when querying source image
..
Patch Set 2:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/8479
To
Itamar Heim has posted comments on this change.
Change subject: Include vds_name parameter for node registration
..
Patch Set 3:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/8036
To
Itamar Heim has posted comments on this change.
Change subject: Misc storage exception class name style
..
Patch Set 1:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/8847
To unsubscribe,
Itamar Heim has posted comments on this change.
Change subject: move get-conf-item/set-conf-item to vdsm-tool
..
Patch Set 5:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/7695
To
Itamar Heim has posted comments on this change.
Change subject: persist state in _changeBlockDev
..
Patch Set 1:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/8617
To unsubscribe, visit
Dan Kenigsberg has abandoned this change.
Change subject: minimalistic (incomplete) test for mkimage.py with fail for
non-64base data
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/6275
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: More explicit octal values (pep-3127)
..
More explicit octal values (pep-3127)
Change 0XXX to 0oXXX so that that these values are more visibly octal
Dan Kenigsberg has posted comments on this change.
Change subject: More explicit octal values (pep-3127)
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/20534
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: cleanup: drop several unused local variables
..
Patch Set 5: Code-Review-1
(1 comment)
This patch is growing too quickly and produces too frequent risks.
Sergey Gotliv has posted comments on this change.
Change subject: getFileList() filters files in case incensitive manner
..
Patch Set 1:
Dan,
getFileList() is exposed in vdsClient. Does it mean that customer potentially
can
Antoni Segura Puimedon has posted comments on this change.
Change subject: cleanup: drop several unused local variables
..
Patch Set 5:
(1 comment)
Will split it in smaller parts.
Nir Soffer has posted comments on this change.
Change subject: cleanup: drop several unused local variables
..
Patch Set 5: Code-Review-1
(33 comments)
Most of these changes do not improve the code.
Place where unused
Dan Kenigsberg has posted comments on this change.
Change subject: Network functional tests assertion improvements
..
Patch Set 8: Code-Review+1
Toni, do you understand why this fails on el6?
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: getFileList() filters files in case incensitive manner
..
Patch Set 1:
Theoretically speaking, there might exist a hermit that uses the getFileList
API in its
Sergey Gotliv has posted comments on this change.
Change subject: Add additional vgcheck to fix vgextend workflow on HSMs.
..
Patch Set 8:
(2 comments)
Commit Message
Line
69 matches
Mail list logo
