Antoni Segura Puimedon has uploaded a new change for review.
Change subject: F20 netinfo: fix linkShowDev parsing in getVlanID
..
F20 netinfo: fix linkShowDev parsing in getVlanID
Newer linux distributions return more detailed
Antoni Segura Puimedon has abandoned this change.
Change subject: F20 netinfo: fix linkShowDev parsing in getVlanID
..
Abandoned
Was supposed to be in ovirt-3.3.
--
To view, visit http://gerrit.ovirt.org/21758
To
Antoni Segura Puimedon has abandoned this change.
Change subject: F20 netinfo: fix linkShowDev parsing in getVlanID
..
Abandoned
gerrit has some issues with changing this patchset.
--
To view, visit
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: F20 netinfo: fix linkShowDev parsing in getVlanID
..
F20 netinfo: fix linkShowDev parsing in getVlanID
Newer linux distributions return more detailed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: F20 netinfo: fix linkShowDev parsing in getVlanID
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4907/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: F20 netinfo: fix linkShowDev parsing in getVlanID
..
Patch Set 1: Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4908/ : SUCCESS
Assaf Muller has posted comments on this change.
Change subject: Added lib/vdsm/utils.py:touchFile
..
Patch Set 1:
(2 comments)
File lib/vdsm/utils.py
Line 102: path =
Dan Kenigsberg has posted comments on this change.
Change subject: fuserTests fix for f20 and arch
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21740
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Added lib/vdsm/utils.py:touchFile
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21590
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Added lib/vdsm/utils.py:touchFile
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4909/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: F20 netinfo: fix linkShowDev parsing in getVlanID
..
Patch Set 1: Code-Review-1
(1 comment)
Commit
Antoni Segura Puimedon has posted comments on this change.
Change subject: F20 netinfo: fix linkShowDev parsing in getVlanID
..
Patch Set 1:
(1 comment)
Commit Message
Line
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 14: Verified+1
--
To view, visit http://gerrit.ovirt.org/19091
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: F20 netinfo: fix linkShowDev parsing in getVlanID
..
Patch Set 2: Verified-1
Build Failed
Antoni Segura Puimedon has posted comments on this change.
Change subject: F20 netinfo: fix linkShowDev parsing in getVlanID
..
Patch Set 2: Verified+1
Verified on Arch linux (iproute version like F20) and on el6.
--
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: Added lib/vdsm/utils.py:touchFile
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21590
To unsubscribe, visit
Martin Sivák has uploaded a new change for review.
Change subject: Reorder limit checks in grow quest
..
Reorder limit checks in grow quest
balloon_min is a computed value that can (and will) go over
balloon_max. When the
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Get rid of legacy status 'Running'
..
Get rid of legacy status 'Running'
The status 'Running' means 'Up' for any case, now we get rid of it
completely as
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Get rid of legacy status 'Running'
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4910/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: allow hooks to pass down dictionaries in json format
..
Patch Set 4: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/20330
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: allow hooks to pass down dictionaries in json format
..
Patch Set 4:
(1 comment)
Overall looks good to me, but needs a semantic change in the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: fix vdsmapi gluster json schema error
..
Patch Set 1: -Verified
Build Successful
Yaniv Bronhaim has posted comments on this change.
Change subject: use defined options from configure
..
Patch Set 1: Code-Review+1
(1 comment)
Thanks!
Can you rebase? or I'll take over?
Antoni Segura Puimedon has posted comments on this change.
Change subject: Get rid of legacy status 'Running'
..
Patch Set 1: Code-Review-1
I think 'Up' and the other states deserve a constant (I don't know in which
module
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21767
to review the following change.
Change subject: Disable exception on after hooks failures
..
Disable exception on after
Yaniv Bronhaim has posted comments on this change.
Change subject: Disable exception on after hooks failures
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21767
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: Get rid of legacy status 'Running'
..
Patch Set 1: -Code-Review
I guess making a constant out of it is out of scope for this patch...
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: netconf: Add limit to rollback for recursive configurator
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21615
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: add logging to _getUnderlyingDriveInfo
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/19928
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Log exceptions in domain monitor thread
..
Patch Set 2:
After discussion with Federico, the plan is to add a @traceback decorator,
logging a
Federico Simoncelli has posted comments on this change.
Change subject: sp: move reconnection info check to StoragePool
..
Patch Set 3:
(4 comments)
File
Alexey Shabalin has posted comments on this change.
Change subject: use defined options from configure
..
Patch Set 1:
Take over, please.
--
To view, visit http://gerrit.ovirt.org/18694
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20209
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2:
We need this patch in order to fix BZ#10133942.
--
To view, visit http://gerrit.ovirt.org/20209
To
Sergey Gotliv has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2:
The correct bug is BZ#1033942.
--
To view, visit http://gerrit.ovirt.org/20209
To unsubscribe, visit
Martin Sivák has posted comments on this change.
Change subject: Reorder limit checks in grow quest
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21765
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Adding debian folder makefile
..
Patch Set 1: Code-Review+2
(1 comment)
I see no harm in including debian stuff in our tarball, given that we have it
in git
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Adding debian folder makefile
..
Adding debian folder makefile
Change-Id: I31dad533c70b501c3d521364bd98eb30517d2f3f
Signed-off-by: Yaniv Bronhaim
Michal Skrivanek has posted comments on this change.
Change subject: Get rid of legacy status 'Running'
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21766
To unsubscribe, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding remove\disable verbs to vdsm-tool for admin usages
..
Adding remove\disable verbs to vdsm-tool for admin usages
The spec will be modified separately to
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding remove\disable verbs to vdsm-tool for admin usages
..
Patch Set 1:
(2 comments)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding remove\disable verbs to vdsm-tool for admin usages
..
Patch Set 1: Verified-1
Build Failed
Yaniv Bronhaim has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8: Code-Review-1
I created http://gerrit.ovirt.org/#/c/21772/ to replace this work. It is too
Assaf Muller has posted comments on this change.
Change subject: Added lib/vdsm/utils.py:touchFile
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21590
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Report device to engine in a new fashion
..
Patch Set 4: Verified-1
Needs more work. Fails vdsGetCaps on a local host.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Added lib/vdsm/utils.py:touchFile
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4913/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: allow hooks to pass down dictionaries in json format
..
Patch Set 4:
(1 comment)
File
Alon Bar-Lev has posted comments on this change.
Change subject: Adding remove\disable verbs to vdsm-tool for admin usages
..
Patch Set 1:
(7 comments)
File
Nir Soffer has uploaded a new change for review.
Change subject: utils: Add unhandled exceptions logging decorator
..
utils: Add unhandled exceptions logging decorator
We at least two places where expections in thread main
Lei Li has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8:
I am glad that this still could be useful, it'd be great if
you could help on the rebase the pushing!
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4914/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: provide a default rollback for configurators
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4904/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread
..
Patch Set 3: Verified-1
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 1: Code-Review+1
Every Thread.run should be decorated with this.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 1: -Code-Review
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: Log unhandled exceptions in storage refresh thread
..
Patch Set 2: Verified-1
Build Failed
Nir Soffer has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 1:
(1 comment)
File lib/vdsm/utils.py
Line
Vered Volansky has posted comments on this change.
Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21487
To unsubscribe,
Kiril Nesenko has posted comments on this change.
Change subject: Adding debian folder makefile
..
Patch Set 2:
Yaniv,
Please cherry-pick to ovirt-3.3
--
To view, visit http://gerrit.ovirt.org/21695
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread
..
Patch Set 4:
Add missing import.
--
To view, visit http://gerrit.ovirt.org/21487
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread
..
Patch Set 4:
Build Successful
Nir Soffer has posted comments on this change.
Change subject: hsm: Log unhandled exceptions in storage refresh thread
..
Patch Set 3:
Fix logger name.
--
To view, visit http://gerrit.ovirt.org/21486
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: Log unhandled exceptions in storage refresh thread
..
Patch Set 3:
Build Successful
Nir Soffer has uploaded a new change for review.
Change subject: vm: Fix vm unpausing during recovery
..
vm: Fix vm unpausing during recovery
Domain monitor thread was not reporting when going from unknown state to
known state.
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 1:
(1 comment)
File lib/vdsm/utils.py
Line
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: remove the getFormat method
..
sp: remove the getFormat method
Change-Id: Ifb292ef57f94e1fea67f3111e5f414cc41c346a9
Signed-off-by: Federico
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: refresh metadata on hsm when listing domains
..
sp: refresh metadata on hsm when listing domains
In this patch:
- validatePoolSD and
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: move validatePoolSD in the StoragePool class
..
sp: move validatePoolSD in the StoragePool class
It's the StoragePool duty to validate if an
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: move reconnection info check to StoragePool
..
Patch Set 5: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove unused recoveryMode from spmStart
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4920/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4924/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove unused scsiFencing parameter
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4923/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: encapsulate spm status in StoragePool
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4922/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove the getFormat method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4925/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: refresh metadata on hsm when listing domains
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4927/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: move validatePoolSD in the StoragePool class
..
Patch Set 1: Verified-1
Build Failed
Assaf Muller has uploaded a new change for review.
Change subject: Made ipwrapper.py:Route class more robust
..
Made ipwrapper.py:Route class more robust
Change-Id: Id2d62ad31bd9d5c7bea28605a0b195c1886f0dab
Signed-off-by: Assaf
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Report device to engine in a new fashion
..
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4928/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Made ipwrapper.py:Route class more robust
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4929/ :
Assaf Muller has posted comments on this change.
Change subject: Made ipwrapper.py:Route class more robust
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21788
To unsubscribe, visit
Roy Golan has uploaded a new change for review.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
set the # of vcpus for a VM (hot plug/unplug)
RFE https://bugzilla.redhat.com/show_bug.cgi?id=833102
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4930/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4931/ :
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Convert vm status strings to constants
..
Convert vm status strings to constants
This patch replaces all vmstatuses to constants.
Additionally added not
Allon Mureinik has posted comments on this change.
Change subject: vm: Fix vm unpausing during recovery
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21782
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: bootstrap: Return recovery error during lvm bootstrap
..
Patch Set 4: Code-Review+1
(2 comments)
The patch seems more or less ok to me. But I am really
Antoni Segura Puimedon has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line 228:
Nir Soffer has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 2:
Dropping the use case of looping function; explicit error handling is better in
this case.
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4932/ :
Nir Soffer has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 3:
Spelling
--
To view, visit http://gerrit.ovirt.org/21778
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Made ipwrapper.py:Route class more robust
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4934/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Report device to engine in a new fashion
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4933/ :
Vinzenz Feenstra has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line 228: #
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4935/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4936/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 1:
(1 comment)
File vdsm/API.py
Line 473:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Made ipwrapper.py:Route class more robust
..
Patch Set 2: -Verified
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4934/ :
Antoni Segura Puimedon has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 2:
(1 comment)
File vdsm/API.py
Line 473:
Assaf Muller has posted comments on this change.
Change subject: Made ipwrapper.py:Route class more robust
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21788
To unsubscribe, visit
1 - 100 of 185 matches
Mail list logo
