Change in vdsm[master]: vdsm: Hardware information about POWER hosts

2013-11-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 4: Code-Review+1 (2 comments) Minor nits remain. Please add yourself as an AUTHOR, too.

Change in vdsm[master]: clientIF: Decouple HSM and clientIF

2013-11-30 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: clientIF: Decouple HSM and clientIF .. clientIF: Decouple HSM and clientIF clientIF.irs is currently created in clientIF.__init__, coupling clientIF and HSM and

Change in vdsm[master]: clientIF: Decouple HSM and clientIF

2013-11-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Decouple HSM and clientIF .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5832/ : SUCCESS

Change in vdsm[master]: tests: declate alignmentScanTests as broken

2013-11-30 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: declate alignmentScanTests as broken .. Patch Set 1: Code-Review-1 I would personally prefer to have a modification of the jenkins job that does

Change in vdsm[master]: tests: declate alignmentScanTests as broken

2013-11-30 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: declate alignmentScanTests as broken .. Patch Set 1: I will contact dcaro about it. -- To view, visit http://gerrit.ovirt.org/21871 To

Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value

2013-11-30 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: domainMonitor: Separate change detection from lastCheck value .. domainMonitor: Separate change detection from lastCheck value Since commit b4b8a7666b68,

Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value

2013-11-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5833/ :

Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable

2013-11-30 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: domainMonitor: Rename confusing lastCheck variable .. domainMonitor: Rename confusing lastCheck variable In repoStats we use the lastCheck value as the time since

Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable

2013-11-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: domainMonitor: Rename confusing lastCheck variable .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5834/ : SUCCESS

Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value

2013-11-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 2: Fix time() usage. -- To view, visit http://gerrit.ovirt.org/21878 To unsubscribe,

Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value

2013-11-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5835/ :

Change in vdsm[master]: tests: declate alignmentScanTests as broken

2013-11-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: declate alignmentScanTests as broken .. Patch Set 1: I would personally prefer to have a modification of the jenkins job that does NOSE_EXCLUDE on these

Change in vdsm[master]: Adding ppc64 handling to getVdsCaps

2013-11-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit

Change in vdsm[master]: vdsm: Report fake capabilities

2013-11-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Report fake capabilities .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19396 To unsubscribe, visit

Change in vdsm[master]: netconf: drop rollback to last persisted if mem rollback fails

2013-11-30 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netconf: drop rollback to last persisted if mem rollback fails .. netconf: drop rollback to last persisted if mem rollback fails When memory rollback

Change in vdsm[master]: netconf: drop rollback to last persisted if mem rollback fails

2013-11-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netconf: drop rollback to last persisted if mem rollback fails .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21867 To unsubscribe,

Change in vdsm[master]: netconf: define rollback contract at internal API

2013-11-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netconf: define rollback contract at internal API .. Patch Set 10: (3 comments) A question and a half.

Change in vdsm[master]: netconf: privatize inRollback and use it for persistent roll...

2013-11-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netconf: privatize inRollback and use it for persistent rollback .. Patch Set 2: Code-Review-1 (1 comment)

Change in vdsm[master]: sp: remove the getFormat method

2013-11-30 Thread abaron
Ayal Baron has posted comments on this change. Change subject: sp: remove the getFormat method .. Patch Set 3: Are you saying that there's a logical difference between getVersion and getFormat? Or you're saying that we can