Change in vdsm[master]: hooks: Extract function for command execution

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Extract function for command execution .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6535/ :

Change in vdsm[master]: hooks: Security groups support for OVS

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Security groups support for OVS .. Patch Set 2: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: hooks: Extract devName function for openstacknet

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Extract devName function for openstacknet .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6536/ :

Change in vdsm[master]: Updating README with vdsm-tool new api

2014-01-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Updating README with vdsm-tool new api .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/22910 To unsubscribe, visit

Change in vdsm[master]: hooks: Extract function for command execution

2014-01-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hooks: Extract function for command execution .. Patch Set 2: Code-Review-1 (1 comment) File

Change in vdsm[master]: vdsm: allow hooks to pass down dictionaries in json format

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format .. Patch Set 7: A humble request: Please give enough time for the thread on arch/vdsm to die down

Change in vdsm[master]: vm: Unify checks for vdsm image

2014-01-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: vm: Unify checks for vdsm image .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22370 To unsubscribe, visit

Change in vdsm[master]: bootstrap: Return recovery error until hsm is ready

2014-01-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: bootstrap: Return recovery error until hsm is ready .. Patch Set 5: Code-Review+1 (3 comments) +1 on the code, a few nits about the commit message.

Change in vdsm[master]: hooks: Extract function for command execution

2014-01-05 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: hooks: Extract function for command execution .. Patch Set 2: (1 comment) File

Change in vdsm[master]: hooks: Extract function for command execution

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Extract function for command execution .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6538/ : SUCCESS

Change in vdsm[master]: hooks: Extract devName function for openstacknet

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Extract devName function for openstacknet .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6539/ :

Change in vdsm[master]: hsm: remove master info from getStorageDomainInfo

2014-01-05 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: hsm: remove master info from getStorageDomainInfo .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22824 To unsubscribe, visit

Change in vdsm[master]: hooks: Security groups support for OVS

2014-01-05 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: hooks: Security groups support for OVS .. Patch Set 1: (1 comment) File

Change in vdsm[master]: hooks: Security groups support for OVS

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Security groups support for OVS .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6540/ : SUCCESS

Change in vdsm[master]: vdsm: Add tuneBlockDevIo interface

2014-01-05 Thread iheim
Itamar Heim has abandoned this change. Change subject: vdsm: Add tuneBlockDevIo interface .. Abandoned -- To view, visit http://gerrit.ovirt.org/14394 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: [1/x] BindingXMLRPC cleanup: Remove/inline getServerInfo

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: [1/x] BindingXMLRPC cleanup: Remove/inline getServerInfo .. Patch Set 1: (1 comment) Commit Message Line 3:

Change in vdsm[master]: hooks: Security groups support for OVS

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Security groups support for OVS .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6541/ : SUCCESS

Change in vdsm[master]: [2/x] BindingXMLRPC cleanup: Remove unused variables

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: [2/x] BindingXMLRPC cleanup: Remove unused variables .. Patch Set 1: Will be fixed in the upcoming patchset. -- To view, visit http://gerrit.ovirt.org/22836 To

Change in vdsm[master]: [3/x] Bugfix: Return lastClientIface for *current* connection

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: [3/x] Bugfix: Return lastClientIface for *current* connection .. Patch Set 1: (2 comments) Commit Message

Change in vdsm[master]: [4/x] Added netinfo:getDeviceByIP and a test

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: [4/x] Added netinfo:getDeviceByIP and a test .. Patch Set 2: (1 comment) Commit Message Line 3: AuthorDate:

Change in vdsm[master]: BindingXMLRPC cleanup: Inline getServerInfo

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC cleanup: Inline getServerInfo .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22835 To unsubscribe, visit

Change in vdsm[master]: BindingXMLRPC bugfix: Added netinfo:getDeviceByIP and a test

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Added netinfo:getDeviceByIP and a test .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22841 To unsubscribe, visit

Change in vdsm[master]: BindingXMLRPC cleanup: Remove unused variables

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC cleanup: Remove unused variables .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22836 To unsubscribe, visit

Change in vdsm[master]: BindingXMLRPC bugfix: Return lastClientIface for current con...

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22837 To unsubscribe,

Change in vdsm[master]: BindingXMLRPC bugfix: Use getDeviceByIP() for lastClientIface

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Use getDeviceByIP() for lastClientIface .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22842 To unsubscribe, visit

Change in vdsm[master]: BindingXMLRPC cleanup: Inline getServerInfo

2014-01-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BindingXMLRPC cleanup: Inline getServerInfo .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22835 To unsubscribe, visit

Change in vdsm[master]: BindingXMLRPC cleanup: Remove unused variables

2014-01-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BindingXMLRPC cleanup: Remove unused variables .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22836 To unsubscribe, visit

Change in vdsm[master]: BindingXMLRPC bugfix: Return lastClientIface for current con...

2014-01-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22837 To

Change in vdsm[master]: BindingXMLRPC cleanup: Inline getServerInfo

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: BindingXMLRPC cleanup: Inline getServerInfo .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6544/ :

Change in vdsm[master]: BindingXMLRPC bugfix: Added netinfo:getDeviceByIP and a test

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: BindingXMLRPC bugfix: Added netinfo:getDeviceByIP and a test .. Patch Set 3: Build Successful

Change in vdsm[master]: BindingXMLRPC cleanup: Remove unused variables

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: BindingXMLRPC cleanup: Remove unused variables .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6542/ : SUCCESS

Change in vdsm[master]: BindingXMLRPC bugfix: Return lastClientIface for current con...

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection .. Patch Set 2: Build Successful

Change in vdsm[master]: BindingXMLRPC bugfix: Use getDeviceByIP() for lastClientIface

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: BindingXMLRPC bugfix: Use getDeviceByIP() for lastClientIface .. Patch Set 3: Build Successful

Change in vdsm[master]: hsm: remove master info from getStorageDomainInfo

2014-01-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: remove master info from getStorageDomainInfo .. hsm: remove master info from getStorageDomainInfo The pool metadata doesn't belong in the storage

Change in vdsm[master]: hooks: Extract devName function for openstacknet

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: hooks: Extract devName function for openstacknet .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22584 To unsubscribe, visit

Change in vdsm[master]: hooks: Extract function for command execution

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: hooks: Extract function for command execution .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22583 To unsubscribe, visit

Change in vdsm[master]: sourceRouteThread: Add log for new Thread

2014-01-05 Thread mlipchuk
Maor Lipchuk has abandoned this change. Change subject: sourceRouteThread: Add log for new Thread .. Abandoned not relevant any more -- To view, visit http://gerrit.ovirt.org/22814 To unsubscribe, visit

Change in vdsm[master]: API: Replace try-except block with @traceback

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: Replace try-except block with @traceback .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6548/ : SUCCESS

Change in vdsm[master]: libvirtconnection: Fix _EventLoop.run if thread exited abnor...

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtconnection: Fix _EventLoop.run if thread exited abnormally. .. Patch Set 3: Build Successful

Change in vdsm[master]: lbvirtconnection: use root logger

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: lbvirtconnection: use root logger .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6549/ : SUCCESS

Change in vdsm[master]: libvirtconnection: Fix a race when starting the eventloop

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtconnection: Fix a race when starting the eventloop .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6547/

Change in vdsm[master]: API: Replace try-except block with @traceback

2014-01-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: API: Replace try-except block with @traceback .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.ovirt.org/22813 To unsubscribe, visit

Change in vdsm[master]: libvirtconnection: Fix a race when starting the eventloop

2014-01-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: libvirtconnection: Fix a race when starting the eventloop .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/22859 To unsubscribe, visit

Change in vdsm[master]: lbvirtconnection: use root logger

2014-01-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: lbvirtconnection: use root logger .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22907 To unsubscribe, visit

Change in vdsm[master]: libvirtconnection: Fix _EventLoop.run if thread exited abnor...

2014-01-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: libvirtconnection: Fix _EventLoop.run if thread exited abnormally. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22908 To unsubscribe,

Change in vdsm[master]: hooks: Security groups support for OVS

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: hooks: Security groups support for OVS .. Patch Set 4: Code-Review-1 (1 comment) File

Change in vdsm[master]: BindingXMLRPC cleanup: Inline getServerInfo

2014-01-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BindingXMLRPC cleanup: Inline getServerInfo .. BindingXMLRPC cleanup: Inline getServerInfo Inlining getServerInfo because: 1) It's used exactly once

Change in vdsm[master]: BindingXMLRPC cleanup: Remove unused variables

2014-01-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BindingXMLRPC cleanup: Remove unused variables .. BindingXMLRPC cleanup: Remove unused variables Change-Id: I1d36a9f71b4d192b8ba825e95055dd42fc278248

Change in vdsm[master]: BindingXMLRPC bugfix: Return lastClientIface for current con...

2014-01-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection .. BindingXMLRPC bugfix: Return lastClientIface for current connection The patch

Change in vdsm[master]: lbvirtconnection: use root logger

2014-01-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: lbvirtconnection: use root logger .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22907 To unsubscribe, visit

Change in vdsm[master]: lbvirtconnection: use root logger

2014-01-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: lbvirtconnection: use root logger .. lbvirtconnection: use root logger Assign log variable the default logger which is the root logger. The log of

Change in vdsm[master]: libvirtconnection: Fix a race when starting the eventloop

2014-01-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: libvirtconnection: Fix a race when starting the eventloop .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22859 To unsubscribe, visit

Change in vdsm[master]: libvirtconnection: Fix _EventLoop.run if thread exited abnor...

2014-01-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: libvirtconnection: Fix _EventLoop.run if thread exited abnormally. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22908 To

Change in vdsm[master]: API: Replace try-except block with @traceback

2014-01-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: API: Replace try-except block with @traceback .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22813 To unsubscribe, visit

Change in vdsm[master]: hooks: Security groups support for OVS

2014-01-05 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: hooks: Security groups support for OVS .. Patch Set 4: (1 comment) File

Change in vdsm[master]: hooks: Security groups support for OVS

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: hooks: Security groups support for OVS .. Patch Set 4: (1 comment) File vdsm_hooks/openstacknet/Makefile.am

Change in vdsm[master]: libvirtconnection: Fix a race when starting the eventloop

2014-01-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: libvirtconnection: Fix a race when starting the eventloop .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22859 To unsubscribe, visit

Change in vdsm[master]: libvirtconnection: Fix _EventLoop.run if thread exited abnor...

2014-01-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: libvirtconnection: Fix _EventLoop.run if thread exited abnormally. .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22908 To

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Return lastClientIface for current con...

2014-01-05 Thread amuller
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/22967 to review the following change. Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection ..

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Remove unused variables

2014-01-05 Thread amuller
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/22966 to review the following change. Change subject: BindingXMLRPC cleanup: Remove unused variables .. BindingXMLRPC cleanup:

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test

2014-01-05 Thread amuller
Assaf Muller has uploaded a new change for review. Change subject: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test .. BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test Change-Id:

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Inline getServerInfo

2014-01-05 Thread amuller
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/22965 to review the following change. Change subject: BindingXMLRPC cleanup: Inline getServerInfo .. BindingXMLRPC cleanup:

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test .. Patch Set 1: Verified-1 Build Failed

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Inline getServerInfo

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC cleanup: Inline getServerInfo .. Patch Set 1: Verified+1 Cherry pick into manual backport: Verified on ovirt-3.3 branch with this patch. -- To

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Remove unused variables

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC cleanup: Remove unused variables .. Patch Set 1: Verified+1 Cherry pick into manual backport: Verified on ovirt-3.3 branch with this patch. -- To

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Return lastClientIface for current con...

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection .. Patch Set 1: Verified+1 Cherry pick into manual backport: Verified on ovirt-3.3 branch

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test .. Patch Set 1: Verified+1 Cherry pick into manual backport: Verified on ovirt-3.3 branch with this

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test

2014-01-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test .. Patch Set 1: Also: This change is *not yet merged into master* -- To view, visit

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Return lastClientIface for current con...

2014-01-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection .. Patch Set 1: Code-Review-2 please open a bug about that issue, and don't rebase it over

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Remove unused variables

2014-01-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: BindingXMLRPC cleanup: Remove unused variables .. Patch Set 1: Code-Review-2 why do we need it in 3.3? does it fix anything? it doesn't look like it does, so

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test

2014-01-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test .. Patch Set 1: Code-Review-2 (1 comment) why do we need it in 3.3? does it fix anything? it doesn't

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Inline getServerInfo

2014-01-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: BindingXMLRPC cleanup: Inline getServerInfo .. Patch Set 1: Code-Review-2 why do we need it in 3.3? does it fix anything? it doesn't look like it does, so I

Change in vdsm[master]: bootstrap: Return recovery error until hsm is ready

2014-01-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: bootstrap: Return recovery error until hsm is ready .. Patch Set 5: Code-Review-1 (1 comment) -1 just to understand the True default reason

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Remove unused variables

2014-01-05 Thread amuller
Assaf Muller has abandoned this change. Change subject: BindingXMLRPC cleanup: Remove unused variables .. Abandoned I'll backport only the bugfix itself. -- To view, visit http://gerrit.ovirt.org/22966 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Inline getServerInfo

2014-01-05 Thread amuller
Assaf Muller has abandoned this change. Change subject: BindingXMLRPC cleanup: Inline getServerInfo .. Abandoned I'll backport only the bugfix itself. -- To view, visit http://gerrit.ovirt.org/22965 To unsubscribe, visit

Change in vdsm[master]: Validate VDSM user's sudoer permissions

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Validate VDSM user's sudoer permissions .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6551/ : SUCCESS

Change in vdsm[master]: Validate VDSM user's sudoer permissions

2014-01-05 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Validate VDSM user's sudoer permissions .. Patch Set 5: (1 comment) File vdsm/vdsm Line 171: # This

Change in vdsm[master]: vdsm: update size of LUN volume in prepareVolume

2014-01-05 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: vdsm: update size of LUN volume in prepareVolume .. vdsm: update size of LUN volume in prepareVolume In order to handle resize of DirectLUN disks (i.e. when a

Change in vdsm[master]: vdsm: update size of LUN volume in prepareVolume

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: update size of LUN volume in prepareVolume .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6552/ :

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test

2014-01-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test .. Patch Set 3: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/22968 To unsubscribe, visit

Change in vdsm[master]: libvirtconnection: Fix _EventLoop.run if thread exited abnor...

2014-01-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: libvirtconnection: Fix _EventLoop.run if thread exited abnormally. .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22908 To unsubscribe,

Change in vdsm[master]: API: Replace try-except block with @traceback

2014-01-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: API: Replace try-except block with @traceback .. Patch Set 11: Code-Review-1 (3 comments) Commit message needs some more love.

Change in vdsm[master]: Updating README with vdsm-tool new api

2014-01-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Updating README with vdsm-tool new api .. Patch Set 1: Code-Review+1 Nice! -- To view, visit http://gerrit.ovirt.org/22910 To unsubscribe, visit

Change in vdsm[master]: libvirtconnection: Fix a race when starting the eventloop

2014-01-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: libvirtconnection: Fix a race when starting the eventloop .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22859 To unsubscribe, visit

Change in vdsm[master]: bootstrap: Return recovery error until hsm is ready

2014-01-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: bootstrap: Return recovery error until hsm is ready .. Patch Set 5: Code-Review-1 (1 comment) Note to myself: fix the commit message.

Change in vdsm[master]: Explicit call for libvirtd service manipulations during conf...

2014-01-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Explicit call for libvirtd service manipulations during configure .. Patch Set 1: (1 comment) File

Change in vdsm[ovirt-3.3]: update NIC: having no custom properies is valid

2014-01-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: update NIC: having no custom properies is valid .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22950 To unsubscribe, visit

Change in vdsm[master]: libvirtconnection: Fix a race when starting the eventloop

2014-01-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: libvirtconnection: Fix a race when starting the eventloop .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22859 To unsubscribe,

Change in vdsm[master]: libvirtconnection: Fix _EventLoop.run if thread exited abnor...

2014-01-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: libvirtconnection: Fix _EventLoop.run if thread exited abnormally. .. libvirtconnection: Fix _EventLoop.run if thread exited abnormally. Previously

Change in vdsm[master]: libvirtconnection: Fix a race when starting the eventloop

2014-01-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: libvirtconnection: Fix a race when starting the eventloop .. libvirtconnection: Fix a race when starting the eventloop This patch fixes a race which

Change in vdsm[master]: bootstrap: Return recovery error until hsm is ready

2014-01-05 Thread abaron
Ayal Baron has posted comments on this change. Change subject: bootstrap: Return recovery error until hsm is ready .. Patch Set 5: (1 comment) File

Change in vdsm[master]: Updating README with vdsm-tool new api

2014-01-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Updating README with vdsm-tool new api .. Patch Set 1: (1 comment) File README Line 24:

Change in vdsm[master]: Changing python-cpopen requirement

2014-01-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Changing python-cpopen requirement .. Patch Set 1: Yaniv, speaking about cpopen in Fedora: I'd love to see recent upstream bug fixes in Fedora. -- To view,

Change in vdsm[master]: hsm: Rescan multipath before loading lvm cache

2014-01-05 Thread abaron
Ayal Baron has posted comments on this change. Change subject: hsm: Rescan multipath before loading lvm cache .. Patch Set 3: Code-Review+2 Actually the race doesn't exist since sdCache.refreshStorage calls

Change in vdsm[master]: hsm: Rescan multipath before loading lvm cache

2014-01-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hsm: Rescan multipath before loading lvm cache .. Patch Set 3: Actually the race doesn't exist since sdCache.refreshStorage calls lvm.invalidateCache so

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test

2014-01-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test .. Patch Set 3: Code-Review+1 Nice -- To view, visit http://gerrit.ovirt.org/22968 To unsubscribe, visit

Change in vdsm[master]: Updating README with vdsm-tool new api

2014-01-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Updating README with vdsm-tool new api .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22910 To unsubscribe, visit

Change in vdsm[master]: Updating README with vdsm-tool new api

2014-01-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Updating README with vdsm-tool new api .. Updating README with vdsm-tool new api Change-Id: I9c2f06cbb48030c1340e1a1738149c7c62e66460 Signed-off-by:

Change in vdsm[master]: Updating README with vdsm-tool new api

2014-01-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Updating README with vdsm-tool new api .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6553/ : SUCCESS

Change in vdsm[master]: bootstrap: Return recovery error until hsm is ready

2014-01-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: bootstrap: Return recovery error until hsm is ready .. Patch Set 5: (2 comments) File

  1   2   >