Change in vdsm[master]: logs: improve VDSM logs human-readability

Yoav Kleinberger has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/28869 To unsubscribe, visit

Change in vdsm[master]: logs: improve VDSM logs human-readability

oVirt Jenkins CI Server has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9512/ :

Change in vdsm[master]: logs: improve VDSM logs human-readability

Vered Volansky has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28869 To unsubscribe, visit

Change in vdsm[master]: logs: improve VDSM logs human-readability

Yoav Kleinberger has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 4: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/28869/4/vdsm/logger.conf.in File

Change in vdsm[master]: logs: improve VDSM logs human-readability

oVirt Jenkins CI Server has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9513/ :

Change in vdsm[master]: logs: improve VDSM logs human-readability

oVirt Jenkins CI Server has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9514/ :

Change in vdsm[master]: logs: improve VDSM logs human-readability

Vered Volansky has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 4: Code-Review+1 Although this patch is now reduced to de facto changing the delimeter from :: to

Change in vdsm[master]: logs: improve VDSM logs human-readability

Liron Aravot has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 4: can we get example of before/after in the commit message? -- To view, visit

Change in vdsm[master]: vdsm-tool: Add logging configuration.

Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: Add logging configuration. .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/27481/10/vdsm-tool/vdsm-tool File vdsm-tool/vdsm-tool: Line

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 12: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27193 To unsubscribe, visit

Change in vdsm[master]: logs: improve VDSM logs human-readability

Nir Soffer has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28869/3/vdsm/logger.conf.in File vdsm/logger.conf.in: Line 66:

Change in vdsm[master]: logs: improve VDSM logs human-readability

Nir Soffer has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 4: Adding Michal and Martin because this change affect every group. -- To view, visit

Change in vdsm[master]: domainMonitor: Cleanup imports

Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Cleanup imports .. Patch Set 1: Code-Review+1 Excellent -- To view, visit http://gerrit.ovirt.org/29015 To unsubscribe, visit

Change in vdsm[master]: logs: improve VDSM logs human-readability

Yoav Kleinberger has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28869/1/vdsm/logger.conf.in File vdsm/logger.conf.in:

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 1: Code-Review-1 (2 comments) just a small thing, see comment inside.

Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...

Yaniv Bronhaim has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in it's doc string. .. Patch Set 5: (1 comment)

Change in vdsm[master]: vdsm-upgrade: adds wrapper to ovirt-node-upgrade

Eyal Edri has posted comments on this change. Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade .. Patch Set 17: fabian - i don't see any ovirt-node rpm job in jenkins, so not sure if there is nightly repo

Change in vdsm[ovirt-3.4]: virt: sampling: make sure balloon values are str

Yaniv Bronhaim has submitted this change and it was merged. Change subject: virt: sampling: make sure balloon values are str .. virt: sampling: make sure balloon values are str This patch avoids XML-RPC integer overflows by

Change in vdsm[ovirt-3.4]: virt: sampling: make sure balloon values are str

Yaniv Bronhaim has posted comments on this change. Change subject: virt: sampling: make sure balloon values are str .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28973 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Fix unsafe iteration of domain monitor status

Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration of domain monitor status .. Patch Set 1: Code-Review-1 (2 comments)

Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...

mooli tayer has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in it's doc string. .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28782/5//COMMIT_MSG Commit

Change in vdsm[master]: configurator.py: Node unpersist must be called before removi...

mooli tayer has posted comments on this change. Change subject: configurator.py: Node unpersist must be called before removing a file. .. Patch Set 2: (1 comment)

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

Nir Soffer has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29014/1//COMMIT_MSG Commit Message: Line 11: was written as if

Change in vdsm[master]: domainMonitor: Fix unsafe iteration of domain monitor status

Nir Soffer has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration of domain monitor status .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29009/1/vdsm/storage/domainMonitor.py File

Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...

Nir Soffer has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in it's doc string. .. Patch Set 5: (2 comments)

Change in vdsm[master]: domainMonitor: Fix unsafe iteration of domain monitor status

Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration of domain monitor status .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29009/1/vdsm/storage/domainMonitor.py

Change in vdsm[master]: logs: improve VDSM logs human-readability

Yoav Kleinberger has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 4: Marina, the flowID is not part of the format of the log - it is generated inside VDSM's code, so

Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...

Yaniv Bronhaim has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in it's doc string. .. Patch Set 5: (1 comment)

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29014/1/vdsm/storage/domainMonitor.py File

Change in vdsm[master]: domainMonitor: Fix unsafe iteration

Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29007 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Fix unsafe iteration of domain monitor status

Nir Soffer has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration of domain monitor status .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29009/1/vdsm/storage/domainMonitor.py File

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

Nir Soffer has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29014/1/vdsm/storage/domainMonitor.py File

Change in vdsm[master]: ioprocess implementation

oVirt Jenkins CI Server has posted comments on this change. Change subject: ioprocess implementation .. Patch Set 25: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9516/

Change in vdsm[master]: oop: Add an option to configure oop implementation

oVirt Jenkins CI Server has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 26: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9515/

Change in vdsm[master]: Additional oop functionality

oVirt Jenkins CI Server has posted comments on this change. Change subject: Additional oop functionality .. Patch Set 19: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9517/ : SUCCESS

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

Itamar Heim has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 5: reading the commit message - what is the difference between unknown, fail and dead? -- To view, visit

Change in vdsm[master]: Final separation of IOProcess and RFH

oVirt Jenkins CI Server has posted comments on this change. Change subject: Final separation of IOProcess and RFH .. Patch Set 16: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9518/ : SUCCESS

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29014/1/vdsm/storage/domainMonitor.py File

Change in vdsm[master]: domainMonitor: Fix unsafe iteration of domain monitor status

Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration of domain monitor status .. Patch Set 1: Code-Review+1 (1 comment)

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

Nir Soffer has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 5: From https://git.fedorahosted.org/cgit/sanlock.git/tree/src/lockspace.c#n937 /* * After the lockspace

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

Nir Soffer has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29014/1/vdsm/storage/domainMonitor.py File

Change in vdsm[ovirt-3.4]: virt: sampling: make sure balloon values are str

oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: make sure balloon values are str .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/232/ :

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

Yoav Kleinberger has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 5: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/28873/5/tests/testrunner.py File

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/29014/1/vdsm/storage/domainMonitor.py File

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

Nir Soffer has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/28873/5/tests/testrunner.py File tests/testrunner.py: Line 53

Change in vdsm[master]: vdsm-upgrade: adds wrapper to ovirt-node-upgrade

Sandro Bonazzola has posted comments on this change. Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade .. Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/28244/17/vdsm_reg/vdsm-upgrade File

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

Yoav Kleinberger has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/clusterlock.py File

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

Nir Soffer has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/clusterlock.py File

Change in vdsm[master]: domainMonitor: Introduce cancellation points

Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Introduce cancellation points .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28721/4/vdsm/storage/domainMonitor.py File

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

Yoav Kleinberger has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/clusterlock.py File

Change in vdsm[master]: domainMonitor: Introduce cancellation points

Nir Soffer has posted comments on this change. Change subject: domainMonitor: Introduce cancellation points .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28721/4/vdsm/storage/domainMonitor.py File

Change in vdsm[master]: virt: stats: get rid of _getStatsInternal

Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: stats: get rid of _getStatsInternal .. virt: stats: get rid of _getStatsInternal it was used on just one place anyway. Change-Id:

Change in vdsm[master]: virt: stats: get rid of _getStatsInternal

Dan Kenigsberg has posted comments on this change. Change subject: virt: stats: get rid of _getStatsInternal .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26557 To unsubscribe, visit

Change in vdsm[master]: sampling: allow window=1 in AdvancedStatsFunction

Dan Kenigsberg has posted comments on this change. Change subject: sampling: allow window=1 in AdvancedStatsFunction .. Patch Set 1: Code-Review-1 -1 for visibility -- To view, visit http://gerrit.ovirt.org/28992 To

Change in vdsm[master]: janitorial: move isVdsmImage into utils

Dan Kenigsberg has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 5: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28477/5//COMMIT_MSG Commit Message: Line 7:

Change in vdsm[master]: virt: stats: get rid of _getStatsInternal

oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: get rid of _getStatsInternal .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1500/ :

Change in vdsm[master]: tests: Add symlink mount test

Nir Soffer has posted comments on this change. Change subject: tests: Add symlink mount test .. Patch Set 5: Enrico, as you can see I cheated and I don't test gfs2, but my test does reproduce the issue in a simpler way. --

Change in vdsm[master]: tests: Add symlink mount test

oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add symlink mount test .. Patch Set 5: Code-Review-1 Verified-1 Build Unstable

Change in vdsm[master]: tests: Add symlink mount test

Nir Soffer has posted comments on this change. Change subject: tests: Add symlink mount test .. Patch Set 5: Verified+1 Test fail if I disable the fix for this issue in mount.py. Succeeds with current code. -- To view,

Change in vdsm[master]: hsm: [WIP] Support force detach on orphaned Storage Domains.

Maor Lipchuk has uploaded a new change for review. Change subject: hsm: [WIP] Support force detach on orphaned Storage Domains. .. hsm: [WIP] Support force detach on orphaned Storage Domains. Force detach of storage domain only

Change in vdsm[master]: hsm: [WIP] Support force detach on orphaned Storage Domains.

oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: [WIP] Support force detach on orphaned Storage Domains. .. Patch Set 1: Build Successful

Change in vdsm[master]: misc: Simplify DynamicBarrier implemenation

Yaniv Bronhaim has posted comments on this change. Change subject: misc: Simplify DynamicBarrier implemenation .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29003/4/vdsm/storage/misc.py File vdsm/storage/misc.py: