Irit Goihman has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/62383/4/vdsm_hooks/vhostmd/after_vm_destroy.py
File
Irit Goihman has posted comments on this change.
Change subject: jsonrpcvdscli: add default value to request queue argument
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62730
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Yaniv Bronhaim has posted comments on this change.
Change subject: build: require only the same version, not release
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62672
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: add default value to request queue argument
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Irit Goihman has uploaded a new change for review.
Change subject: jsonrpcvdscli: add default value to request queue argument
..
jsonrpcvdscli: add default value to request queue argument
requestQueue argument of
gerrit-hooks has posted comments on this change.
Change subject: after_vm_start: migrate to jsonrpcvdsli
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 4:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 17:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
Yaniv Bronhaim has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62383
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 3: Code-Review+2
(2 comments)
https://gerrit.ovirt.org/#/c/61950/3/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 949:
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 4: Verified+1
(2 comments)
No significant changes, restoring V+1.
Yaniv Bronhaim has abandoned this change.
Change subject: Adding memTotal metric
..
Abandoned
not relevant for now.
--
To view, visit https://gerrit.ovirt.org/62154
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: Adding memTotal metric
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/62154
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding memTotal metric
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/62154/4/lib/vdsm/host/api.py
File lib/vdsm/host/api.py:
PS4, Line 99: _M
>
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpcvdscli: add default value to request queue argument
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62730
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: after_vm_start: migrate to jsonrpcvdsli
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62713
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding units to memory metrics name according to metrics2.0 spec
..
Patch Set 4: Code-Review-1
(2 comments)
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding units to cpu metrics name according to metrics2.0 spec
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/62156/4/lib/vdsm/virt/vmstats.py
File
gerrit-hooks has posted comments on this change.
Change subject: lvm: Never hide lvm errors
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check Public Bug::WARN, no
gerrit-hooks has posted comments on this change.
Change subject: lvm: Improve logging lv activation logging
..
Patch Set 4:
* update_tracker: OK
* Set MODIFIED::bug 1358348#1358348::IGNORE, skipping for branch 'master'
--
Adam Litke has submitted this change and it was merged.
Change subject: lvm: Never hide lvm errors
..
lvm: Never hide lvm errors
In changelv, if lvm command has failed but stdout is not empty, the
error was ignored silently.
Adam Litke has submitted this change and it was merged.
Change subject: lvm: Fix error handling when resizing lvs
..
lvm: Fix error handling when resizing lvs
We depended on undocumented and wrong behavior in lvextend,
gerrit-hooks has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has submitted this change and it was merged.
Change subject: lvm: Improve logging lv activation logging
..
lvm: Improve logging lv activation logging
Log vg name and lv names when we activate, refresh or deactivate
gerrit-hooks has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Adam Litke has submitted this change and it was merged.
Change subject: lvm: Separate lv reduce and extend
..
lvm: Separate lv reduce and extend
Reducing and extending logical volumes were mixed in a horrible and
buggy mess in
Adam Litke has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62338
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: lvm: Improve logging lv activation logging
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check
Adam Litke has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62369
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: lvm: Refresh lvs during activation
..
Patch Set 2:
* update_tracker: OK
* Set MODIFIED::bug 1358348#1358348::IGNORE, skipping for branch 'master'
--
To
Adam Litke has submitted this change and it was merged.
Change subject: lvm: Refresh lvs during activation
..
lvm: Refresh lvs during activation
Previously we used to activate only the inactive lvs, and ignore the
active lvs
gerrit-hooks has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 6:
* #1363734::Update tracker: OK
* #1364339::Update tracker: OK
* #1366176::Update tracker: OK
* Set
gerrit-hooks has posted comments on this change.
Change subject: lvm: Never hide lvm errors
..
Patch Set 4:
* update_tracker: OK
* Set MODIFIED::bug 1358348#1358348::IGNORE, skipping for branch 'master'
--
To view, visit
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62740
to review the following change.
Change subject: lvm: Separate lv reduce and extend
..
lvm: Separate lv
gerrit-hooks has posted comments on this change.
Change subject: lvm: Never hide lvm errors
..
Patch Set 1: Verified-1
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check Public
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62738
to review the following change.
Change subject: lvm: Never hide lvm errors
..
lvm: Never hide lvm errors
In changelv, if
gerrit-hooks has posted comments on this change.
Change subject: lvm: Refresh lvs during activation
..
Patch Set 1: Verified-1
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62739
to review the following change.
Change subject: lvm: Fix error handling when resizing lvs
..
lvm: Fix error
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62735
to review the following change.
Change subject: lvm: Separate lv reduce and extend
..
lvm: Separate lv
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62736
to review the following change.
Change subject: lvm: Refresh lvs during activation
..
lvm: Refresh lvs
gerrit-hooks has posted comments on this change.
Change subject: lvm: Improve logging lv activation logging
..
Patch Set 1: Verified-1
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
*
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62737
to review the following change.
Change subject: lvm: Improve logging lv activation logging
..
lvm: Improve logging lv
gerrit-hooks has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: require only the same version, not release
..
build: require only the same version, not release
The various vdsm subpackages where requiring
Dan Kenigsberg has posted comments on this change.
Change subject: build: require only the same version, not release
..
Patch Set 1: Code-Review+2
raising, does not seem dangerous
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: build: require only the same version, not release
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62731
to review the following change.
Change subject: lvm: Refresh lvs during activation
..
lvm: Refresh lvs
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62734
to review the following change.
Change subject: lvm: Fix error handling when resizing lvs
..
lvm: Fix error
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62733
to review the following change.
Change subject: lvm: Never hide lvm errors
..
lvm: Never hide lvm errors
In changelv, if
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62732
to review the following change.
Change subject: lvm: Improve logging lv activation logging
..
lvm: Improve logging lv
gerrit-hooks has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 1:
* #1363734::Update tracker: OK
* #1364339::Update tracker: OK
* #1366176::Update tracker: OK
* Check
gerrit-hooks has posted comments on this change.
Change subject: lvm: Never hide lvm errors
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check Public Bug::WARN, no
gerrit-hooks has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
gerrit-hooks has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 1: Verified-1
* #1363734::Update tracker: OK
* #1364339::Update tracker: OK
* #1366176::Update tracker: OK
gerrit-hooks has posted comments on this change.
Change subject: lvm: Refresh lvs during activation
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: lvm: Improve logging lv activation logging
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check
Edward Haas has posted comments on this change.
Change subject: net: move name resolver functions from netinfo to ip
..
Patch Set 2: Code-Review-1
(2 comments)
Edward Haas has posted comments on this change.
Change subject: net tests: separate a resolv.conf test from NetInfo tests
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/62723/1/tests/network/resolv_test.py
File
Edward Haas has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 3:
Per the current limited usage, I do not think it is worth importing a 3rd party
library (like python-atomicwrites).
That
Francesco Romani has posted comments on this change.
Change subject: build: require only the same version, not release
..
Patch Set 1: Verified+1
I updated one Centos 7.2 box of mine with patched Vdsm.
The update went well,
Irit Goihman has uploaded a new change for review.
Change subject: after_vm_start: changed vdscli to jsonrpcvdsli
..
after_vm_start: changed vdscli to jsonrpcvdsli
vdscli is deprecated and was replaced by jsonrpcvdsli
Piotr Kliczewski has posted comments on this change.
Change subject: Adding units to memory metrics name according to metrics2.0 spec
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/62155/4/lib/vdsm/host/api.py
File
gerrit-hooks has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 3:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Log RPC call arguments
..
Patch Set 2:
(1 comment)
It would be good to add some tests.
https://gerrit.ovirt.org/#/c/60572/2//COMMIT_MSG
Commit
Piotr Kliczewski has posted comments on this change.
Change subject: test: Introduce mock module for testing
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62279
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: contrib: jsonrpc: add example script to run a VM
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: yajsonrpc: switch to concurrent.thread()
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61462
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: Adding units to cpu metrics name according to metrics2.0 spec
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/62156/4/lib/vdsm/virt/vmstats.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: build: require only the same version, not release
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62672
To unsubscribe, visit
Yaniv Kaul has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 3:
(2 comments)
Why not use something like https://github.com/untitaker/python-atomicwrites ?
Francesco Romani has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 3: Code-Review+1
temporarily lowering my score to not hid Dan's
--
To view, visit
Shahar Havivi has posted comments on this change.
Change subject: v2v: Add helper that redirects stdin/out/err
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62092
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: vm: switch to concurrent.thread()
..
virt: vm: switch to concurrent.thread()
The LiveMergeCleanupThread class used to inherit from
gerrit-hooks has posted comments on this change.
Change subject: virt: migration: switch to concurrent.thread()
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
gerrit-hooks has posted comments on this change.
Change subject: virt: vm: switch to concurrent.thread()
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: after_vm_start: changed vdscli to jsonrpcvdsli
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: ovs: use Setup class directly
..
Patch Set 5:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: api: Move getAllVmStats hooks and logging from API to clientIF
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60583/2/vdsm/clientIF.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: logging: Improve logging when receiving signals
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: api: Move getAllVmStats hooks and logging from API to clientIF
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60583/2/vdsm/clientIF.py
File
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Add helper that redirects stdin/out/err
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/62092
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: migration: switch to concurrent.thread()
..
virt: migration: switch to concurrent.thread()
This patch moves all the migration threads
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: switch to concurrent.thread()
..
Patch Set 11: Code-Review+2
raising Milan's score for PS9
--
To view, visit https://gerrit.ovirt.org/61463
gerrit-hooks has posted comments on this change.
Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..
Patch Set 4:
* #1321010::Update tracker: OK
* Set MODIFIED::bug 1321010#1321010::IGNORE, skipping
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..
Revert "configurator: libvirt: do not jump on virtlogd"
This reverts commit
gerrit-hooks has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..
Patch Set 3: Verified+1
a bit more test gave good result. I think it is good enough for master.
Piotr Kliczewski has posted comments on this change.
Change subject: Fix configfile for py3 to use unicode
..
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48052
To unsubscribe, visit
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Add helper that redirects stdin/out/err
..
Patch Set 3:
Verified the topic as whole. Tried successful and unsuccessful import. In both
cases return
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 16: Verified+1
Verified the topic as whole. Tried successful and unsuccessful import. In both
cases
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: Bump version requirement on python-cpopen.
..
v2v: Bump version requirement on python-cpopen.
In order to support redirection of stderr to stdout
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 3: Verified+1
Verified the topic as whole. Tried successful and unsuccessful import. In both
gerrit-hooks has posted comments on this change.
Change subject: v2v: Bump version requirement on python-cpopen.
..
Patch Set 3:
* #1350465::Update tracker: OK
* Set MODIFIED::bug 1350465#1350465IGNORE, not all related
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 3: Code-Review-1
(1 comment)
nit, but my own pet nit
Shahar Havivi has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62094
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..
Patch Set 3: Code-Review+2
let's jump!
--
To view, visit https://gerrit.ovirt.org/61481
To
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/62094/3/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS3,
1 - 100 of 157 matches
Mail list logo
