Change in vdsm[master]: vdsm: Rely on system for logrotation

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdsm: Rely on system for logrotation .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: gluster: set selinux labels while creating bricks

2016-09-15 Thread fromani
Francesco Romani has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 5: "selinux policy levels" -> I mean: shouldn't this be set with right permissions from the

Change in vdsm[master]: jobs: Allow run and abort only from valid states

2016-09-15 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: jobs: Allow run and abort only from valid states .. jobs: Allow run and abort only from valid states Before this patch we allow abort and run from any

Change in vdsm[master]: jobs: Allow run and abort only from valid states

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Allow run and abort only from valid states .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: v2v: Support for ova exported from AWS

2016-09-15 Thread Tomas Golembiovsky
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/63517/3/lib/vdsm/v2v.py File

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

2016-09-15 Thread jtokar
Jenny Tokar has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/63748 To unsubscribe, visit

Change in vdsm[master]: automation: add a repo with a fresh nose

2016-09-15 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: automation: add a repo with a fresh nose .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63986 To unsubscribe, visit

Change in vdsm[master]: mount: Simplify deleted suffix stripping

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Simplify deleted suffix stripping .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Add missing test for deleted mounts

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add missing test for deleted mounts .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: mount: Fix un-escaping of spaces

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Fix un-escaping of spaces .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: mount: Don't un-escape mount options

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Don't un-escape mount options .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: mounts: Use more meaningful names

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mounts: Use more meaningful names .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Remove EL 6 /etc/mtab support .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: jobs: Add when_finished callback and wire up abort

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Add when_finished callback and wire up abort .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61254

Change in vdsm[master]: sdm: Wire up when_finished callback

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: Wire up when_finished callback .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61255 To unsubscribe,

Change in vdsm[master]: draft: vm_migration_libvirt_hook_plugins

2016-09-15 Thread mmirecki
Marcin Mirecki has uploaded a new change for review. Change subject: draft: vm_migration_libvirt_hook_plugins .. draft: vm_migration_libvirt_hook_plugins Quick draft for vm migration libvirt hook plugins Change-Id:

Change in vdsm[master]: net: Use Linux bonds with OVS networks

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Use Linux bonds with OVS networks .. Patch Set 24: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: test ovs info with southbound nic

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: test ovs info with southbound nic .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: Remove OVS bond implementation.

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: wip: copy_data locking

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: wip: copy_data locking .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/60825 To unsubscribe, visit

Change in vdsm[master]: wip: copy_data take resource locks

2016-09-15 Thread alitke
Adam Litke has abandoned this change. Change subject: wip: copy_data take resource locks .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61353 To unsubscribe, visit

Change in vdsm[master]: net: remove default route before adding a new one

2016-09-15 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: remove default route before adding a new one .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/63220/3/lib/vdsm/network/ip/address.py File

Change in vdsm[master]: net: test ovs info with southbound nic

2016-09-15 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: net: test ovs info with southbound nic .. net: test ovs info with southbound nic We will remove OVS bonding support in a following patch. This patch changes

Change in vdsm[master]: jobs: Guard against racy state changes

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Guard against racy state changes .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Pass the Scheduler instance to HSM

2016-09-15 Thread alitke
Adam Litke has abandoned this change. Change subject: Pass the Scheduler instance to HSM .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61253 To unsubscribe, visit

Change in vdsm[master]: jobs: Add when_finished callback and wire up abort

2016-09-15 Thread alitke
Adam Litke has abandoned this change. Change subject: jobs: Add when_finished callback and wire up abort .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61254 To unsubscribe, visit

Change in vdsm[master]: sdm: Wire up when_finished callback

2016-09-15 Thread alitke
Adam Litke has abandoned this change. Change subject: sdm: Wire up when_finished callback .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61255 To unsubscribe, visit

Change in vdsm[master]: sdm: Autoclear sdm jobs when finished

2016-09-15 Thread alitke
Adam Litke has abandoned this change. Change subject: sdm: Autoclear sdm jobs when finished .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61257 To unsubscribe, visit

Change in vdsm[master]: Pass the Scheduler instance to HSM

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Pass the Scheduler instance to HSM .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61253 To unsubscribe,

Change in vdsm[master]: sdm: Autoclear sdm jobs when finished

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: Autoclear sdm jobs when finished .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61257 To

Change in vdsm[master]: draft: vm_migration_libvirt_hook_plugins

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: draft: vm_migration_libvirt_hook_plugins .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[ovirt-4.0]: net: early IP+link setup

2016-09-15 Thread phoracek
Hello Dan Kenigsberg, Edward Haas, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/63988 to review the following change. Change subject: net: early IP+link setup .. net: early IP+link setup Host

Change in vdsm[ovirt-4.0]: net: early IP+link setup

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 2: * #1364087::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364087::OK, public bug * Check

Change in vdsm[master]: v2v: Support for ova exported from AWS

2016-09-15 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/63517/3/lib/vdsm/v2v.py File lib/vdsm/v2v.py:

Change in vdsm[master]: net: remove default route before adding a new one

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: remove default route before adding a new one .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Add tests for un-escaping spaces

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for un-escaping spaces .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sdm: Jobs may be run only when status=pending

2016-09-15 Thread alitke
Adam Litke has abandoned this change. Change subject: sdm: Jobs may be run only when status=pending .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61138 To unsubscribe, visit

Change in vdsm[master]: jobs: Guard against racy state changes

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jobs: Guard against racy state changes .. Patch Set 6: Code-Review-1 Please check this failing test: 13:17:35

Change in vdsm[master]: sdm: Jobs may be run only when status=pending

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: Jobs may be run only when status=pending .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61138 To

Change in vdsm[master]: wip: copy_data take resource locks

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: wip: copy_data take resource locks .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61353 To unsubscribe,

Change in vdsm[master]: gluster: set selinux labels while creating bricks

2016-09-15 Thread fromani
Francesco Romani has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 5: Isn't this something that must be handled at selinux policy levels? To fix it afterwards is

Change in vdsm[master]: gluster: set selinux labels while creating bricks

2016-09-15 Thread fromani
Francesco Romani has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 5: Code-Review-1 -1 for visibility -- To view, visit https://gerrit.ovirt.org/62773 To

Change in vdsm[master]: v2v: Support for ova exported from AWS

2016-09-15 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 3: > (1 comment) no, it works without extension as well: print

Change in vdsm[master]: gluster: set selinux labels while creating bricks

2016-09-15 Thread rnachimu
Ramesh N has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 5: Gluster has an selinux policy which expects the brick dirs to have specific selinux context/label

Change in vdsm[master]: wip: copy_data locking

2016-09-15 Thread alitke
Adam Litke has abandoned this change. Change subject: wip: copy_data locking .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/60825 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: tests: Move TestingJob to sdmtestlib

2016-09-15 Thread alitke
Adam Litke has abandoned this change. Change subject: tests: Move TestingJob to sdmtestlib .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61256 To unsubscribe, visit

Change in vdsm[master]: tests: Move TestingJob to sdmtestlib

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Move TestingJob to sdmtestlib .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61256 To

Change in vdsm[master]: draft: Hook nic_libvirt_migration_destination, proposal 2

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: lib: move define.py under common

2016-09-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: lib: move define.py under common .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63953 To unsubscribe, visit

Change in vdsm[master]: lib: move exception.py under common

2016-09-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: lib: move exception.py under common .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63952 To unsubscribe, visit

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: lib: move the response.py under common

2016-09-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: lib: move the response.py under common .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63954 To unsubscribe, visit

Change in vdsm[master]: API: modernize VM methods

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 15: Code-Review-1 Please address comments from version 9: https://gerrit.ovirt.org/#/c/61475/9/vdsm/API.py -- To view,

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 2: Verified-1 Rebae on master, fixing merge conflicts, no code change. I found that we report these values

Change in vdsm[master]: v2v: Support for ova exported from AWS

2016-09-15 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/63517/2/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 1187:

Change in vdsm[master]: lib: move exception.py under common

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: move exception.py under common .. Patch Set 1: Francesco, can you verify? -- To view, visit https://gerrit.ovirt.org/63952 To unsubscribe, visit

Change in vdsm[master]: lib: move define.py under common

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: move define.py under common .. Patch Set 1: Francesco, can you verify? -- To view, visit https://gerrit.ovirt.org/63953 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: stomp: use socket pending

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: stomp: use socket pending .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable

Change in vdsm[master]: lib: move the response.py under common

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: move the response.py under common .. Patch Set 2: Francesco, can you verify? -- To view, visit https://gerrit.ovirt.org/63954 To unsubscribe, visit

Change in vdsm[master]: lib: response: helper to detect valid responses

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 12: Code-Review-1 (1 comment) -1 so we dont forget the missing docstring

Change in vdsm[master]: automation: add a repo with a fresh nose

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: automation: add a repo with a fresh nose .. Patch Set 1: Code-Review+1 This fixes the build in jenkins, but does not fix the build in brew/koji. -- To view,

Change in vdsm[master]: Revert "build tests: Require NOSE 1.3.7 and up for running t...

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running tests" .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: Revert "build tests: Require NOSE 1.3.7 and up for running t...

2016-09-15 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running tests" .. Revert "build tests: Require NOSE 1.3.7 and up for running tests" NOSE is used during the

Change in vdsm[master]: net tests: Remove redundant label from func test template.

2016-09-15 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: Remove redundant label from func test template. .. Patch Set 1: Verified-1 This will no longer pass due to: https://gerrit.ovirt.org/#/c/64035/ -- To

Change in vdsm[master]: automation: add a repo with a fresh nose

2016-09-15 Thread edwardh
Edward Haas has posted comments on this change. Change subject: automation: add a repo with a fresh nose .. Patch Set 1: This makes no sense to me, it's a mess. I am reverting the nose 1.3.7 hard requirement. -- To view,

Change in vdsm[master]: Revert "build tests: Require NOSE 1.3.7 and up for running t...

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running tests" .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64035 To unsubscribe,

Change in vdsm[master]: Revert "build tests: Require NOSE 1.3.7 and up for running t...

2016-09-15 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running tests" .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/64035 To unsubscribe,

Change in vdsm[master]: build: Disable tests during build

2016-09-15 Thread edwardh
Edward Haas has posted comments on this change. Change subject: build: Disable tests during build .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/63966/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-09-15

Change in vdsm[master]: ResourceManagerLock: Disable autoRelease

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: ResourceManagerLock: Disable autoRelease .. Patch Set 1: Code-Review+2 I hate resourceManager, we must kill it soon. -- To view, visit

Change in vdsm[master]: api: Use default argument instead of None

2016-09-15 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: api: Use default argument instead of None .. api: Use default argument instead of None Since the supported versions are constant, we can define the default value

Change in vdsm[master]: api: Use default argument instead of None

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: api: Use default argument instead of None .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: lib: move define.py under common

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: move define.py under common .. Patch Set 1: Please rebase, we had lot of merges today. -- To view, visit https://gerrit.ovirt.org/63953 To unsubscribe,

Change in vdsm[master]: lib: move the response.py under common

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: move the response.py under common .. Patch Set 2: Please rebase, we had lot of merges today. -- To view, visit https://gerrit.ovirt.org/63954 To

Change in vdsm[master]: mounts: Use more meaningful names

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mounts: Use more meaningful names .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: lib: move exception.py under common

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: move exception.py under common .. Patch Set 1: Please rebase, we had lot of merges today. -- To view, visit https://gerrit.ovirt.org/63952 To unsubscribe,

Change in vdsm[master]: mount: Wait for systemd temporary mount unit

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Wait for systemd temporary mount unit .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Run mount tests multiple times

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Run mount tests multiple times .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: mount: Wait for systemd temporary mount unit

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mount: Wait for systemd temporary mount unit .. Patch Set 6: Here example mount tests from next patch: 23:47:09 mountTests.MountTests 23:47:09

Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: net libvirt hook: revert vmList change .. Patch Set 1: Ping -- To view, visit https://gerrit.ovirt.org/63762 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: revert Host.getVMList command result change

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jsonrpc: revert Host.getVMList command result change .. Patch Set 1: Ping -- To view, visit https://gerrit.ovirt.org/63761 To unsubscribe, visit

Change in vdsm[master]: upgrade: Support upgrade from v3 to v4.

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: upgrade: Support upgrade from v3 to v4. .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: implementing StorageDomain.movePV

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: implementing StorageDomain.movePV .. Patch Set 2: (15 comments) https://gerrit.ovirt.org/#/c/63270/2/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line

Change in vdsm[master]: mount: Simplify deleted suffix stripping

2016-09-15 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: mount: Simplify deleted suffix stripping .. mount: Simplify deleted suffix stripping Replace pointless loop with single if statement. Change-Id:

Change in vdsm[master]: mount: Simplify deleted suffix stripping

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Simplify deleted suffix stripping .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support

2016-09-15 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: mount: Remove EL 6 /etc/mtab support .. mount: Remove EL 6 /etc/mtab support On EL6 we used /etc/mtab to resolve loop devices backing image. On EL7 (and

Change in vdsm[master]: upgrade: Support upgrade from v3 to v4.

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: upgrade: Support upgrade from v3 to v4. .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Remove EL 6 /etc/mtab support .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: mount: Fix un-escaping of spaces

2016-09-15 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: mount: Fix un-escaping of spaces .. mount: Fix un-escaping of spaces The regular expression match '\040' (" ") but failed to match '\134' ('\'). The

Change in vdsm[master]: tests: Add missing test for deleted mounts

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add missing test for deleted mounts .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: mount: Fix un-escaping of spaces

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Fix un-escaping of spaces .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: tests: Add tests for un-escaping spaces

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for un-escaping spaces .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: tests: Add tests for un-escaping spaces

2016-09-15 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: Add tests for un-escaping spaces .. tests: Add tests for un-escaping spaces Both remote and local path may contain spaces; in this case the spaces

Change in vdsm[master]: mounts: Use more meaningful names

2016-09-15 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: mounts: Use more meaningful names .. mounts: Use more meaningful names Rename the constants and functions for un-escaping spaces to make the intent of the

Change in vdsm[master]: mounts: Use more meaningful names

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mounts: Use more meaningful names .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: mount: Don't un-escape mount options

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Don't un-escape mount options .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: mount: Don't un-escape mount options

2016-09-15 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: mount: Don't un-escape mount options .. mount: Don't un-escape mount options We used to un-escape mount options, which may be useful when mount options

Change in vdsm[master]: tests: Add missing test for deleted mounts

2016-09-15 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: Add missing test for deleted mounts .. tests: Add missing test for deleted mounts Mount path may have a " (deleted)" suffix - we strip this suffix

Change in vdsm[master]: implementing StorageDomain.reduce

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: implementing StorageDomain.reduce .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/63269/3/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line

Change in vdsm[master]: implementing StorageDomain.movePV

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: implementing StorageDomain.movePV .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/63270/2/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line

Change in vdsm[master]: mount: Wait for systemd temporary mount unit

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mount: Wait for systemd temporary mount unit .. Patch Set 6: This version uses the current option instead of a magic 5 seconds, remove the ugly duplicate code,

  1   2   >