gerrit-hooks has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: gluster: set selinux labels while creating bricks
..
Patch Set 5:
"selinux policy levels" -> I mean: shouldn't this be set with right permissions
from the
Nir Soffer has submitted this change and it was merged.
Change subject: jobs: Allow run and abort only from valid states
..
jobs: Allow run and abort only from valid states
Before this patch we allow abort and run from any
gerrit-hooks has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63517/3/lib/vdsm/v2v.py
File
Jenny Tokar has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: automation: add a repo with a fresh nose
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: mount: Simplify deleted suffix stripping
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Add missing test for deleted mounts
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: mount: Fix un-escaping of spaces
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: mount: Don't un-escape mount options
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: mounts: Use more meaningful names
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: mount: Remove EL 6 /etc/mtab support
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: jobs: Add when_finished callback and wire up abort
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/61254
gerrit-hooks has posted comments on this change.
Change subject: sdm: Wire up when_finished callback
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/61255
To unsubscribe,
Marcin Mirecki has uploaded a new change for review.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
draft: vm_migration_libvirt_hook_plugins
Quick draft for vm migration libvirt hook plugins
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: net: test ovs info with southbound nic
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: wip: copy_data locking
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/60825
To unsubscribe, visit
Adam Litke has abandoned this change.
Change subject: wip: copy_data take resource locks
..
Abandoned
Alternate solution merged.
--
To view, visit https://gerrit.ovirt.org/61353
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: remove default route before adding a new one
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/63220/3/lib/vdsm/network/ip/address.py
File
Petr Horáček has uploaded a new change for review.
Change subject: net: test ovs info with southbound nic
..
net: test ovs info with southbound nic
We will remove OVS bonding support in a following patch. This patch
changes
gerrit-hooks has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has abandoned this change.
Change subject: Pass the Scheduler instance to HSM
..
Abandoned
Alternate solution merged.
--
To view, visit https://gerrit.ovirt.org/61253
To unsubscribe, visit
Adam Litke has abandoned this change.
Change subject: jobs: Add when_finished callback and wire up abort
..
Abandoned
Alternate solution merged.
--
To view, visit https://gerrit.ovirt.org/61254
To unsubscribe, visit
Adam Litke has abandoned this change.
Change subject: sdm: Wire up when_finished callback
..
Abandoned
Alternate solution merged.
--
To view, visit https://gerrit.ovirt.org/61255
To unsubscribe, visit
Adam Litke has abandoned this change.
Change subject: sdm: Autoclear sdm jobs when finished
..
Abandoned
Alternate solution merged.
--
To view, visit https://gerrit.ovirt.org/61257
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Pass the Scheduler instance to HSM
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/61253
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: sdm: Autoclear sdm jobs when finished
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/61257
To
gerrit-hooks has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Hello Dan Kenigsberg, Edward Haas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/63988
to review the following change.
Change subject: net: early IP+link setup
..
net: early IP+link setup
Host
gerrit-hooks has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 2:
* #1364087::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364087::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63517/3/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
gerrit-hooks has posted comments on this change.
Change subject: net: remove default route before adding a new one
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for un-escaping spaces
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has abandoned this change.
Change subject: sdm: Jobs may be run only when status=pending
..
Abandoned
Alternate solution merged.
--
To view, visit https://gerrit.ovirt.org/61138
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 6: Code-Review-1
Please check this failing test:
13:17:35
gerrit-hooks has posted comments on this change.
Change subject: sdm: Jobs may be run only when status=pending
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/61138
To
gerrit-hooks has posted comments on this change.
Change subject: wip: copy_data take resource locks
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/61353
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: gluster: set selinux labels while creating bricks
..
Patch Set 5:
Isn't this something that must be handled at selinux policy levels?
To fix it afterwards is
Francesco Romani has posted comments on this change.
Change subject: gluster: set selinux labels while creating bricks
..
Patch Set 5: Code-Review-1
-1 for visibility
--
To view, visit https://gerrit.ovirt.org/62773
To
Shahar Havivi has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 3:
> (1 comment)
no, it works without extension as well:
print
Ramesh N has posted comments on this change.
Change subject: gluster: set selinux labels while creating bricks
..
Patch Set 5:
Gluster has an selinux policy which expects the brick dirs to have specific
selinux context/label
Adam Litke has abandoned this change.
Change subject: wip: copy_data locking
..
Abandoned
Alternate solution merged.
--
To view, visit https://gerrit.ovirt.org/60825
To unsubscribe, visit https://gerrit.ovirt.org/settings
Adam Litke has abandoned this change.
Change subject: tests: Move TestingJob to sdmtestlib
..
Abandoned
Alternate solution merged.
--
To view, visit https://gerrit.ovirt.org/61256
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Move TestingJob to sdmtestlib
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/61256
To
gerrit-hooks has posted comments on this change.
Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Piotr Kliczewski has posted comments on this change.
Change subject: lib: move define.py under common
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63953
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: lib: move exception.py under common
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63952
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: Remove useless volume size monitoring
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: lib: move the response.py under common
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63954
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 15: Code-Review-1
Please address comments from version 9:
https://gerrit.ovirt.org/#/c/61475/9/vdsm/API.py
--
To view,
Nir Soffer has posted comments on this change.
Change subject: vm: Remove useless volume size monitoring
..
Patch Set 2: Verified-1
Rebae on master, fixing merge conflicts, no code change.
I found that we report these values
Shahar Havivi has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63517/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 1187:
Nir Soffer has posted comments on this change.
Change subject: lib: move exception.py under common
..
Patch Set 1:
Francesco, can you verify?
--
To view, visit https://gerrit.ovirt.org/63952
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: lib: move define.py under common
..
Patch Set 1:
Francesco, can you verify?
--
To view, visit https://gerrit.ovirt.org/63953
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: stomp: use socket pending
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required for the stable
Nir Soffer has posted comments on this change.
Change subject: lib: move the response.py under common
..
Patch Set 2:
Francesco, can you verify?
--
To view, visit https://gerrit.ovirt.org/63954
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: lib: response: helper to detect valid responses
..
Patch Set 12: Code-Review-1
(1 comment)
-1 so we dont forget the missing docstring
Nir Soffer has posted comments on this change.
Change subject: automation: add a repo with a fresh nose
..
Patch Set 1: Code-Review+1
This fixes the build in jenkins, but does not fix the build in brew/koji.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running
tests"
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Edward Haas has uploaded a new change for review.
Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running
tests"
..
Revert "build tests: Require NOSE 1.3.7 and up for running tests"
NOSE is used during the
Edward Haas has posted comments on this change.
Change subject: net tests: Remove redundant label from func test template.
..
Patch Set 1: Verified-1
This will no longer pass due to:
https://gerrit.ovirt.org/#/c/64035/
--
To
Edward Haas has posted comments on this change.
Change subject: automation: add a repo with a fresh nose
..
Patch Set 1:
This makes no sense to me, it's a mess.
I am reverting the nose 1.3.7 hard requirement.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running
tests"
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64035
To unsubscribe,
Edward Haas has posted comments on this change.
Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running
tests"
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64035
To unsubscribe,
Edward Haas has posted comments on this change.
Change subject: build: Disable tests during build
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/63966/3//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-09-15
Nir Soffer has posted comments on this change.
Change subject: ResourceManagerLock: Disable autoRelease
..
Patch Set 1: Code-Review+2
I hate resourceManager, we must kill it soon.
--
To view, visit
Nir Soffer has uploaded a new change for review.
Change subject: api: Use default argument instead of None
..
api: Use default argument instead of None
Since the supported versions are constant, we can define the default
value
gerrit-hooks has posted comments on this change.
Change subject: api: Use default argument instead of None
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: lib: move define.py under common
..
Patch Set 1:
Please rebase, we had lot of merges today.
--
To view, visit https://gerrit.ovirt.org/63953
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: lib: move the response.py under common
..
Patch Set 2:
Please rebase, we had lot of merges today.
--
To view, visit https://gerrit.ovirt.org/63954
To
gerrit-hooks has posted comments on this change.
Change subject: mounts: Use more meaningful names
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: lib: move exception.py under common
..
Patch Set 1:
Please rebase, we had lot of merges today.
--
To view, visit https://gerrit.ovirt.org/63952
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: mount: Wait for systemd temporary mount unit
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Run mount tests multiple times
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: mount: Wait for systemd temporary mount unit
..
Patch Set 6:
Here example mount tests from next patch:
23:47:09 mountTests.MountTests
23:47:09
Nir Soffer has posted comments on this change.
Change subject: net libvirt hook: revert vmList change
..
Patch Set 1:
Ping
--
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: revert Host.getVMList command result change
..
Patch Set 1:
Ping
--
To view, visit https://gerrit.ovirt.org/63761
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: implementing StorageDomain.movePV
..
Patch Set 2:
(15 comments)
https://gerrit.ovirt.org/#/c/63270/2/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line
Nir Soffer has submitted this change and it was merged.
Change subject: mount: Simplify deleted suffix stripping
..
mount: Simplify deleted suffix stripping
Replace pointless loop with single if statement.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: mount: Simplify deleted suffix stripping
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: mount: Remove EL 6 /etc/mtab support
..
mount: Remove EL 6 /etc/mtab support
On EL6 we used /etc/mtab to resolve loop devices backing image. On EL7
(and
gerrit-hooks has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: mount: Remove EL 6 /etc/mtab support
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: mount: Fix un-escaping of spaces
..
mount: Fix un-escaping of spaces
The regular expression match '\040' (" ") but failed to match '\134'
('\'). The
gerrit-hooks has posted comments on this change.
Change subject: tests: Add missing test for deleted mounts
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: mount: Fix un-escaping of spaces
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for un-escaping spaces
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Add tests for un-escaping spaces
..
tests: Add tests for un-escaping spaces
Both remote and local path may contain spaces; in this case the spaces
Nir Soffer has submitted this change and it was merged.
Change subject: mounts: Use more meaningful names
..
mounts: Use more meaningful names
Rename the constants and functions for un-escaping spaces to make the
intent of the
gerrit-hooks has posted comments on this change.
Change subject: mounts: Use more meaningful names
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: mount: Don't un-escape mount options
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: mount: Don't un-escape mount options
..
mount: Don't un-escape mount options
We used to un-escape mount options, which may be useful when mount
options
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Add missing test for deleted mounts
..
tests: Add missing test for deleted mounts
Mount path may have a " (deleted)" suffix - we strip this suffix
Nir Soffer has posted comments on this change.
Change subject: implementing StorageDomain.reduce
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/63269/3/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line
Nir Soffer has posted comments on this change.
Change subject: implementing StorageDomain.movePV
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63270/2/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line
Nir Soffer has posted comments on this change.
Change subject: mount: Wait for systemd temporary mount unit
..
Patch Set 6:
This version uses the current option instead of a magic 5 seconds, remove the
ugly duplicate code,
1 - 100 of 178 matches
Mail list logo