Francesco Romani has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 1: Code-Review+1
We'll need a bug; we can piggyback on an existing one (granted it
gerrit-hooks has posted comments on this change.
Change subject: wip: jsonrpc: introduce new cli
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 21:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 10:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 9:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 9:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 10:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 10:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 9:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 10:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 14:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
Michal Skrivanek has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18:
2:1 for line removals, that's always a good thing!
--
To view, visit https://gerrit.ovirt.org/61475
To
Freddy Rolland has posted comments on this change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64505
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2: Verified+1
we add a non-code file, so if jenkins is happy, so we are
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64499
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: storage: fileUtils: drop redundant warning
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 1: Verified-1
* update_tracker: OK
* Check Bug-Url::ERROR, At least one bug-url is required for the
gerrit-hooks has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 9:
* update_tracker: OK
* Set MODIFIED::bug 1369822#1369822::IGNORE, skipping for branch 'master'
Nir Soffer has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18:
Can we get reviews from the virt guys?
--
To view, visit https://gerrit.ovirt.org/61475
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: implementing SDM.move_domain_device
..
Patch Set 7:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: lib: api: allow to return prebuilt responses
..
Patch Set 19:
* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: lib: api: allow to return prebuilt responses
..
lib: api: allow to return prebuilt responses
We want to switch to a saner approach on which responses are
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 12:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 12:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 12:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 12:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 15:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 12:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Fix calling convention.
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
Jenkins CI has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
gerrit-hooks has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2: -Verified
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 13:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 13:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 23:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 16:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 13:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Fix calling convention.
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64522
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Fix calling convention.
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64522
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Fix calling convention.
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 13:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Allon Mureinik has posted comments on this change.
Change subject: spec: Bump Fedora selinux-policy-targeted req
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64504
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64505
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 14:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 11:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 11:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 11:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 11:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 22:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 15:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 11:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 11:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
Hello Piotr Kliczewski, Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64516
to review the following change.
Change subject: logging: add and use new devel logger
..
logging: add and
Petr Horáček has posted comments on this change.
Change subject: net: canonicalize IPv4 prefix to netmask
..
Patch Set 2: Verified+1
Passed network/*_test.py and functional/networkTests.py
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: vdsm: drop the warnings module configuration
..
vdsm: drop the warnings module configuration
We used to configure the warnings module, because we used
gerrit-hooks has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 17:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 13:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 13:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: net ifcfg: fix bond rollback
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374194::OK, public bug
* Check Product::#1374194::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: canonicalize IPv4 prefix to netmask
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374194::OK, public bug
* Check
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64515
to review the following change.
Change subject: docs: add README about logging configuration
..
docs: add README about
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64514
to review the following change.
Change subject: storage: fileUtils: drop redundant warning
..
storage: fileUtils: drop
Hello Piotr Kliczewski, Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64517
to review the following change.
Change subject: vdsm: drop the warnings module configuration
..
vdsm: drop
Petr Horáček has posted comments on this change.
Change subject: net ifcfg: fix bond rollback
..
Patch Set 1: Verified+1
With this patch, network/*_test.py passed OK. It did no break
functional/networkTests.py
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Public
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/64515
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check
Freddy Rolland has posted comments on this change.
Change subject: spec: Bump Fedora selinux-policy-targeted req
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64504
To unsubscribe, visit
Liron Aravot has uploaded a new change for review.
Change subject: implementing SDM.reduce_domain_device
..
implementing SDM.reduce_domain_device
Change-Id: Id5d3f93da11edcb626c2f050d4ce2856aa8faca0
Signed-off-by: Liron Aravot
Maor Lipchuk has uploaded a new change for review.
Change subject: qemuimg: Fix calling convention.
..
qemuimg: Fix calling convention.
Use kwarg calling stype for qemuimg API calls.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 12:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 16:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: Define the SDM.reduce_domain_device API
..
Patch Set 10:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: implementing SDM.reduce_domain_device
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Nir Soffer has posted comments on this change.
Change subject: storage: Add support for generation to VolumeMetadata
..
Patch Set 2: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/64484/2//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: storage: Report generation id in volume.getInfo
..
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/64485/2/tests/storage_volume_test.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Validate generation id in volume.operation context
..
Patch Set 2: Code-Review-1
(2 comments)
Nir Soffer has posted comments on this change.
Change subject: storage: Support generation id in sdm.copy_data
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/64488/1/vdsm/storage/sdm/api/copy_data.py
Francesco Romani has uploaded a new change for review.
Change subject: **WIP** metrics: periodic: add periodic uploader
..
**WIP** metrics: periodic: add periodic uploader
**WIP**
Proof of concept to demonstrate an alternative
Francesco Romani has abandoned this change.
Change subject: **WIP** metrics: periodic: add periodic uploader
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/61107
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/64373/6/vdsm/storage/sdm/api/copy_data.py
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: py3: remove capsTests from blacklist
..
py3: remove capsTests from blacklist
This patch makes the test module not depend on specific iteration order
gerrit-hooks has posted comments on this change.
Change subject: py3: remove capsTests from blacklist
..
Patch Set 3:
* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: net: canonicalize IPv4 prefix to netmask
..
Patch Set 1: Verified-1
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374194::OK, public bug
* Check
Hello Dan Kenigsberg, Edward Haas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64509
to review the following change.
Change subject: net ifcfg: fix bond rollback
..
net ifcfg: fix bond
Nir Soffer has posted comments on this change.
Change subject: storage: Validate generation id in volume.operation context
..
Patch Set 1: Code-Review-1
(11 comments)
gerrit-hooks has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: WIP: add helper to enforce the `common` rules
..
Patch Set 9:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Francesco Romani has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18: Verified+1
fixed a bug in VM.migrate (unrelated hunk sneaked in). Now seems to work with
the basic VM flows,
gerrit-hooks has posted comments on this change.
Change subject: WIP benchmark decorator module speed
..
Patch Set 8:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: lib: api: allow to return prebuilt responses
..
Patch Set 18:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 3:
* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: net: canonicalize IPv4 prefix to netmask
..
Patch Set 3: Verified+1
Passed network/*_test.py and functional/networkTests.py OK.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 9:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 10:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: for_now
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid url.
* Check merged to
1 - 100 of 263 matches
Mail list logo