Change in vdsm[master]: py3: let bulk_sampling_test pass under py3

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: py3: let bulk_sampling_test pass under py3
..


py3: let bulk_sampling_test pass under py3

Change-Id: Ic8f148a7984fab0a092fca588b5de61bdeb4e899
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/65006
Continuous-Integration: Jenkins CI
Tested-by: Milan Zamazal 
Reviewed-by: Francesco Romani 
---
M lib/vdsm/virt/sampling.py
M lib/vdsm/virt/utils.py
M tests/Makefile.am
3 files changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Verified



-- 
To view, visit https://gerrit.ovirt.org/65006
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8f148a7984fab0a092fca588b5de61bdeb4e899
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: let bulk_sampling_test pass under py3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3: let bulk_sampling_test pass under py3
..


Patch Set 3:

* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65006
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f148a7984fab0a092fca588b5de61bdeb4e899
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: **WIP** tool: reconfigure containers networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: **WIP** tool: reconfigure containers networks
..


Patch Set 24:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6053e283c004cd61ba7727cea22ba73a631180ba
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: supervdsm: configure container networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: supervdsm: configure container networks
..


Patch Set 51:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/54998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107
Gerrit-PatchSet: 51
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: core: containers: add the container support module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: core: containers: add the container support module
..


Patch Set 40:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae
Gerrit-PatchSet: 40
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: virt: add optional container support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: virt: add optional container support
..


Patch Set 58:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/53820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f
Gerrit-PatchSet: 58
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vmxml: export container metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmxml: export container metadata
..


Patch Set 30:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ade3c0c7d300c5ce33cb23723c3d0e59e4af664
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: containers: add testsuite

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: containers: add testsuite
..


Patch Set 28:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vmxml: export container metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmxml: export container metadata
..


Patch Set 29:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ade3c0c7d300c5ce33cb23723c3d0e59e4af664
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: config: add tunables for container support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: config: add tunables for container support
..


Patch Set 7:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64243
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30e4372fc88ebb7e68cc3b982af3c2eefacef7ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: **WIP** tool: reconfigure containers networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: **WIP** tool: reconfigure containers networks
..


Patch Set 23:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6053e283c004cd61ba7727cea22ba73a631180ba
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: virt: add optional container support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: virt: add optional container support
..


Patch Set 57:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/53820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f
Gerrit-PatchSet: 57
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: supervdsm: configure container networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: supervdsm: configure container networks
..


Patch Set 50:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/54998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107
Gerrit-PatchSet: 50
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: containers: add testsuite

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: containers: add testsuite
..


Patch Set 27:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: core: containers: add the container support module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: core: containers: add the container support module
..


Patch Set 39:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae
Gerrit-PatchSet: 39
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..


Patch Set 1:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[mzamazal]

Milan Zamazal has uploaded a new change for review.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..

numa: Don't crash on hotplugged CPUs when retrieving NUMA info

getVmNumaNodeRuntimeInfo maps virtual (from Engine) nodes to physical
nodes by matching nodes and CPUs from the libvirt runtime and from the
Engine NUMA mapping.  CPUs that are not pinned to any node in the Engine
NUMA mapping (such as hotplugged CPUs) are irrelevant.  However the
matching cycle still looks for them in the Engine NUMA mapping
dictionary, resulting in KeyError.

This patch fixes the KeyError by simply skipping the CPUs not present in
the Engine NUMA mapping.

Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Signed-off-by: Milan Zamazal 
---
M lib/vdsm/numa.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/65562/1

diff --git a/lib/vdsm/numa.py b/lib/vdsm/numa.py
index 7a31a99..15a8c73 100644
--- a/lib/vdsm/numa.py
+++ b/lib/vdsm/numa.py
@@ -260,7 +260,10 @@
 vcpu_to_vnode = _get_mapping_vcpu_to_vnode(vm)
 
 for vcpu_id, pcpu_id in vcpu_to_pcpu.iteritems():
-vnode_index = str(vcpu_to_vnode[vcpu_id])
+try:
+vnode_index = str(vcpu_to_vnode[vcpu_id])
+except KeyError:# hotplugged CPU
+continue
 vm_numa_placement[vnode_index].add(pcpu_to_pnode[pcpu_id])
 vm_numa_placement[vnode_index].update(
 vcpu_to_pnode.get(vcpu_id, ()))


-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: refactor the monitorResponse handling

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: refactor the monitorResponse handling
..


Patch Set 1:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48d88dfd8cb1ad086be4b0e182fab02462f52c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: move valid states list in vmstatus.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: move valid states list in vmstatus.py
..


Patch Set 1:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69b09501ac3984bdb59db31a48fd582d06975e3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check commands timeout only on steady state

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: check commands timeout only on steady state
..


Patch Set 5:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65505
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafd83afa8ae7d0c6a172f8ceb872c2110eba1c6f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: rename statsAge parameter
..


Patch Set 4:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: move valid states list in vmstatus.py

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: virt: move valid states list in vmstatus.py
..

virt: move valid states list in vmstatus.py

It is a more fitting place.
Only code movement.

Change-Id: I69b09501ac3984bdb59db31a48fd582d06975e3e
Signed-off-by: Francesco Romani 
---
M lib/vdsm/virt/vmstatus.py
M vdsm/virt/vm.py
2 files changed, 6 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/65538/1

diff --git a/lib/vdsm/virt/vmstatus.py b/lib/vdsm/virt/vmstatus.py
index c689554..df41558 100644
--- a/lib/vdsm/virt/vmstatus.py
+++ b/lib/vdsm/virt/vmstatus.py
@@ -32,3 +32,8 @@
 WAIT_FOR_LAUNCH = 'WaitForLaunch'
 
 PAUSED_STATES = (POWERING_DOWN, REBOOT_IN_PROGRESS, UP)
+
+
+VALID_STATES = (UP, DOWN, MIGRATION_SOURCE, MIGRATION_DESTINATION,
+PAUSED, POWERING_DOWN, POWERING_UP, REBOOT_IN_PROGRESS,
+RESTORING_STATE, SAVING_STATE, WAIT_FOR_LAUNCH)
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 43dc775..cbcc037 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -114,13 +114,6 @@
 pass
 
 
-VALID_STATES = (vmstatus.DOWN, vmstatus.MIGRATION_DESTINATION,
-vmstatus.MIGRATION_SOURCE, vmstatus.PAUSED,
-vmstatus.POWERING_DOWN, vmstatus.REBOOT_IN_PROGRESS,
-vmstatus.RESTORING_STATE, vmstatus.SAVING_STATE,
-vmstatus.UP, vmstatus.WAIT_FOR_LAUNCH)
-
-
 class ConsoleDisconnectAction:
 NONE = 'NONE'
 LOCK_SCREEN = 'LOCK_SCREEN'
@@ -335,7 +328,7 @@
 raise DoubleDownError
 else:
 return
-if value not in VALID_STATES:
+if value not in vmstatus.VALID_STATES:
 self.log.error('setting state to %s', value)
 if self._lastStatus != value:
 self.saveState()


-- 
To view, visit https://gerrit.ovirt.org/65538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69b09501ac3984bdb59db31a48fd582d06975e3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: ignore more errors in isDomainReadyForCommands
..


Patch Set 6:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


Patch Set 5:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: refactor the monitorResponse handling

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: refactor the monitorResponse handling
..

vm: refactor the monitorResponse handling

Move everything in a single method, to make the flow
easier to understand and change.

No expected changes in behaviour.

Change-Id: Ic48d88dfd8cb1ad086be4b0e182fab02462f52c9
Signed-off-by: Francesco Romani 
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 43 insertions(+), 38 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/65539/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index 893bc74..993fa4e 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -40,7 +40,7 @@
 from vdsm.virt import vmstatus
 
 from virt import vm
-from virt.vm import HotunplugTimeout
+from virt.vm import HotunplugTimeout, VMMonitorState
 from virt import vmdevices
 from virt.vmdevices import hwclass
 from virt.vmtune import io_tune_merge, io_tune_dom_to_values, io_tune_to_dom
@@ -1421,9 +1421,9 @@
 def testMonitorTimeoutResponsive(self):
 with fake.VM(_VM_PARAMS) as testvm:
 self.assertFalse(testvm.isMigrating())
-stats = {'monitorResponse': '0'}
-testvm._setUnresponsiveIfTimeout(stats, 1)  # any value < timeout
-self.assertEqual(stats['monitorResponse'], '0')
+self.assertEquals(
+testvm._getVmMonitorResponse(1),  # any value < timeout
+VMMonitorState.READY)
 
 @MonkeyPatch(vm, 'config',
  make_config([('vars', 'vm_command_timeout', '1')]))
@@ -1434,11 +1434,11 @@
 ])
 def testMonitorTimeoutUnresponsive(self, runCpu):
 with fake.VM(_VM_PARAMS, runCpu=runCpu, status=vmstatus.UP) as testvm:
-self.assertEqual(testvm._monitorResponse, 0)
+self.assertEqual(testvm._monitorResponse, VMMonitorState.READY)
 self.assertFalse(testvm.isMigrating())
-stats = {'monitorResponse': '0'}
-testvm._setUnresponsiveIfTimeout(stats, 10)  # any value > timeout
-self.assertEqual(stats['monitorResponse'], '-1')
+self.assertEquals(
+testvm._getVmMonitorResponse(10),  # any value > timeout
+VMMonitorState.UNRESPONSIVE)
 
 @MonkeyPatch(vm, 'config',
  make_config([('vars', 'vm_command_timeout', '10')]))
@@ -1449,11 +1449,12 @@
 ])
 def testMonitorTimeoutOnAlreadyUnresponsive(self, runCpu):
 with fake.VM(_VM_PARAMS, runCpu=runCpu, status=vmstatus.UP) as testvm:
-self._monitorResponse = -1
+# fake existing timeout
+testvm._monitorResponse = VMMonitorState.UNRESPONSIVE
 self.assertFalse(testvm.isMigrating())
-stats = {'monitorResponse': '-1'}
-testvm._setUnresponsiveIfTimeout(stats, 1)  # any value < timeout
-self.assertEqual(stats['monitorResponse'], '-1')
+self.assertEquals(
+testvm._getVmMonitorResponse(1),  # any value < timeout
+VMMonitorState.UNRESPONSIVE)
 
 @MonkeyPatch(vm, 'config',
  make_config([('vars', 'vm_command_timeout', '1')]))
@@ -1471,10 +1472,10 @@
 ])
 def testMonitorUncheckedStatus(self, status):
 with fake.VM(_VM_PARAMS, runCpu=True, status=status) as testvm:
-self.assertEqual(testvm._monitorResponse, 0)
-stats = {'monitorResponse': '0'}
-testvm._setUnresponsiveIfTimeout(stats, 10)  # any value > timeout
-self.assertEqual(stats['monitorResponse'], '0')
+self.assertEqual(testvm._monitorResponse, VMMonitorState.READY)
+self.assertEquals(
+testvm._getVmMonitorResponse(10),  # any value > timeout
+VMMonitorState.READY)
 
 
 class TestLibVirtCallbacks(TestCaseBase):
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index cbcc037..3550a52 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -122,6 +122,11 @@
 REBOOT = 'REBOOT'
 
 
+class VMMonitorState:
+READY = '0'
+UNRESPONSIVE = '-1'
+
+
 # These strings are representing libvirt virDomainEventType values
 # http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainEventType
 _EVENT_STRINGS = (
@@ -241,7 +246,7 @@
 self.log = SimpleLogAdapter(self.log, {"vmId": self.conf['vmId']})
 self._destroy_requested = threading.Event()
 self._recovery_file = recovery.File(self.conf['vmId'])
-self._monitorResponse = 0
+self._monitorResponse = VMMonitorState.READY
 self.memCommitted = 0
 self._consoleDisconnectAction = ConsoleDisconnectAction.LOCK_SCREEN
 self._confLock = threading.Lock()
@@ -1249,7 +1254,6 @@
 """
 stats = {
 'elapsedTime': str(int(time.time() - self._startTime)),
-'monitorResponse': str(self._monitorResponse),
 'timeOffset': 

Change in vdsm[master]: virt: enable glusterfs access through libgfapi interface

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: enable glusterfs access through libgfapi interface
..


Patch Set 14:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1022961::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Prasanna Kumar Kalever 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: let bulk_sampling_test pass under py3

[fromani]

Francesco Romani has posted comments on this change.

Change subject: py3: let bulk_sampling_test pass under py3
..


Patch Set 2: Code-Review+2

I need to improve the documentation of the methods, to explain where it is safe 
to use iter*.

-- 
To view, visit https://gerrit.ovirt.org/65006
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f148a7984fab0a092fca588b5de61bdeb4e899
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt.vmdevices.core: Add Lease device

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: virt.vmdevices.core: Add Lease device
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/65465/4/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 642: __slots__ = ("id", "sd_id", "path", "offset")
Line 643: 
Line 644: @classmethod
Line 645: def update_device_info(cls, vm, device_conf):
Line 646: # TODO: update conf from libvirt info
> No, maybe this is not needed?
Depends if we expect "unmanaged leases" - can't think of other reason to look 
look for this.
Line 647: pass
Line 648: 
Line 649: def __init__(self, conf, log, **kwargs):
Line 650: super(Lease, self).__init__(conf, log, **kwargs)


Line 654: :param uuid id: Lease id, e.g. volume id for a volume lease, 
or vm id
Line 655: for a vm lease
Line 656: :param uuid sd_id: Storage domain uuid where lease file is 
located
Line 657: :param str path: Path to lease file or block device
Line 658: :param int offset: Offset in lease file in bytes
> My plan is to move all vdsm to this style (sphinx).
Was it properly discussed upstream?
Line 659: """
Line 660: # TODO: validate arguments
Line 661: 
Line 662: def setup(self):


-- 
To view, visit https://gerrit.ovirt.org/65465
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fc2be51eccdd93e4c2440008f22a4ba019c466
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org