Martin Polednik has posted comments on this change.

Change subject: virt.vmdevices.core: Add Lease device
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/65465/4/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 642:     __slots__ = ("id", "sd_id", "path", "offset")
Line 643: 
Line 644:     @classmethod
Line 645:     def update_device_info(cls, vm, device_conf):
Line 646:         # TODO: update conf from libvirt info
> No, maybe this is not needed?
Depends if we expect "unmanaged leases" - can't think of other reason to look 
look for this.
Line 647:         pass
Line 648: 
Line 649:     def __init__(self, conf, log, **kwargs):
Line 650:         super(Lease, self).__init__(conf, log, **kwargs)


Line 654:         :param uuid id: Lease id, e.g. volume id for a volume lease, 
or vm id
Line 655:             for a vm lease
Line 656:         :param uuid sd_id: Storage domain uuid where lease file is 
located
Line 657:         :param str path: Path to lease file or block device
Line 658:         :param int offset: Offset in lease file in bytes
> My plan is to move all vdsm to this style (sphinx).
Was it properly discussed upstream?
Line 659:         """
Line 660:         # TODO: validate arguments
Line 661: 
Line 662:     def setup(self):


-- 
To view, visit https://gerrit.ovirt.org/65465
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fc2be51eccdd93e4c2440008f22a4ba019c466
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to