Change in vdsm[master]: tests: adding BondOptionsTests to func_bond_basic_test.py

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tests: adding BondOptionsTests to func_bond_basic_test.py .. Patch Set 3: Code-Review-1 please remove from

Change in vdsm[ovirt-4.1]: vdsm client: add vdsm-client script

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm client: add vdsm-client script .. Patch Set 3: why f25 keeps failing? -- To view, visit

Change in vdsm[master]: storage: move dispatcher to lib/vdsm/storage

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move dispatcher to lib/vdsm/storage .. Patch Set 1: (1 comment)

Change in vdsm[master]: spec: require python-blivet1

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: spec: require python-blivet1 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/69790 To

Change in vdsm[master]: storage: move task and taskManager to lib

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move task and taskManager to lib .. Patch Set 5: ci please build -- To view, visit

Change in vdsm[master]: spec: fedora: vdsm-gluster should require python-blivet1

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has abandoned this change. Change subject: spec: fedora: vdsm-gluster should require python-blivet1 .. Abandoned https://gerrit.ovirt.org/#/c/69790/1 -- To view, visit

Change in vdsm[master]: spec: require python-blivet1

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: require python-blivet1 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/69790 To

Change in vdsm[master]: replace dir() with vars() in few places

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has abandoned this change. Change subject: replace dir() with vars() in few places .. Abandoned -- To view, visit https://gerrit.ovirt.org/68679 To unsubscribe, visit

Change in vdsm[ovirt-4.1]: vdsm-client: Use passed arguments

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm-client: Use passed arguments .. vdsm-client: Use passed arguments client.main() accept arguments and

Change in vdsm[ovirt-4.1]: vdsm-client: Use passed arguments

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-client: Use passed arguments .. Patch Set 4: Code-Review+2 Continuous-Integration+1 -- To view, visit

Change in vdsm[master]: spec: require python-blivet1

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: require python-blivet1 .. Patch Set 1: Verified+1 builds and installs. -- To view, visit

Change in vdsm[master]: spec: require python-blivet1

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: require python-blivet1 .. spec: require python-blivet1 fedora 25 introduced python-blivet1 package

Change in vdsm[ovirt-4.1]: vdsm-client: Refine complex argument examples

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-client: Refine complex argument examples .. Patch Set 5: Code-Review+2 Verified+1 -- To view, visit

Change in vdsm[ovirt-4.1]: vdsm-client: Make executable in the source

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-client: Make executable in the source .. Patch Set 4: Continuous-Integration+1 -- To view, visit

Change in vdsm[ovirt-4.1]: vdsm-client: Make executable in the source

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm-client: Make executable in the source .. vdsm-client: Make executable in the source Having an

Change in vdsm[ovirt-4.1]: vdsm-client: Make executable in the source

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-client: Make executable in the source .. Patch Set 3: Code-Review+2 Continuous-Integration+1 Verified+1 -- To

Change in vdsm[master]: automation: collecting lago logs

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: automation: collecting lago logs .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/69802 To

Change in vdsm[master]: storage: move lvm.py to lib

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move lvm.py to lib .. Patch Set 5: ci please build -- To view, visit https://gerrit.ovirt.org/69327 To

Change in vdsm[master]: storage: move lvm.py to lib

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move lvm.py to lib .. Patch Set 5: Verified+1 passes storage sanity

Change in vdsm[ovirt-4.1]: vdsm-client: Fix references to jsonrpc

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm-client: Fix references to jsonrpc .. vdsm-client: Fix references to jsonrpc The client was renamed

Change in vdsm[ovirt-4.1]: vdsm-client: Remove unused code

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-client: Remove unused code .. Patch Set 3: Continuous-Integration+1 copying score -- To view, visit

Change in vdsm[ovirt-4.1]: vdsm-client: Remove unused code

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm-client: Remove unused code .. vdsm-client: Remove unused code The vdsmclient/client.py module is not

Change in vdsm[ovirt-4.1]: vdsm-client: Remove unused code

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-client: Remove unused code .. Patch Set 4: Continuous-Integration+1 -- To view, visit

Change in vdsm[ovirt-4.1]: vdsm-client: Remove unused code

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-client: Remove unused code .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/69576 To

Change in vdsm[master]: spec: fedora: vdsm-gluster should require python-blivet1

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: spec: fedora: vdsm-gluster should require python-blivet1 .. spec: fedora: vdsm-gluster should require python-blivet1

Change in vdsm[ovirt-4.1]: spec: require python-blivet1

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. Change subject: spec: require python-blivet1 .. spec: require python-blivet1 fedora 25 introduced python-blivet1 package

Change in vdsm[ovirt-4.1]: vdsm client: add vdsm-client script

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm client: add vdsm-client script .. vdsm client: add vdsm-client script vdsm API can be accessed with

Change in vdsm[ovirt-4.1]: vdsm-client: Fix references to jsonrpc

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-client: Fix references to jsonrpc .. Patch Set 3: Code-Review+2 -- To view, visit

Change in vdsm[ovirt-4.1]: vdsm-client: Fix references to jsonrpc

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-client: Fix references to jsonrpc .. Patch Set 4: Continuous-Integration+1 -- To view, visit

Change in vdsm[ovirt-4.1]: spec: require python-blivet1

2017-01-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: spec: require python-blivet1 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/69807 To

Change in vdsm[master]: storage: move resourceManager to lib

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move resourceManager to lib .. Patch Set 6: ci please build -- To view, visit

Change in vdsm[master]: executor: Don't start thread in __init__

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: executor: Don't start thread in __init__ .. Patch Set 1: Code-Review+1 -- To view, visit

Change in vdsm[master]: storage: move resourceManager to lib

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move resourceManager to lib .. Patch Set 6: Verified+1

Change in vdsm[master]: concurrent: Log threads life cycle

2017-01-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: concurrent: Log threads life cycle .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/69815 To