Change in vdsm[master]: BZ#845193 - Remove BRIDGE from nic/bond cofig file when remo...

Igor Lvovsky has uploaded a new change for review. Change subject: BZ#845193 - Remove BRIDGE from nic/bond cofig file when removing bridge .. BZ#845193 - Remove BRIDGE from nic/bond cofig file when removing bridge Change-Id:

Change in vdsm[master]: BZ#845193 - Remove BRIDGE from nic/bond cofig file when remo...

Igor Lvovsky has posted comments on this change. Change subject: BZ#845193 - Remove BRIDGE from nic/bond cofig file when removing bridge .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7600 To unsubscribe,

Change in vdsm[master]: momTest: improve test's error reports

Mark Wu has posted comments on this change. Change subject: momTest: improve test's error reports .. Patch Set 1: Looks good to me, but someone else must approve Thanks for the patch! -- To view, visit

Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up

oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 15: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/768/ :

Change in vdsm[master]: BZ#845193 - Remove BRIDGE from nic/bond cofig file when remo...

oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#845193 - Remove BRIDGE from nic/bond cofig file when removing bridge .. Patch Set 1: Build Successful

Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up

Yaniv Bronhaim has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 15: Verified -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit

Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well

Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well

Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: bootstrap: survive missing ntpq

Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well

Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. Patch Set 2: Verified Applied Dan's comments. -- To view, visit http://gerrit.ovirt.org/7596 To

Change in vdsm[master]: bootstrap: survive missing ntpq

Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 1: (1 inline comment) File vdsm_reg/deployUtil.py.in Line 693:

Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well

oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/770/

Change in vdsm[master]: momTest: improve test's error reports

Dan Kenigsberg has posted comments on this change. Change subject: momTest: improve test's error reports .. Patch Set 1: had to fix my pep8 sins. -- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit

Change in vdsm[master]: bootstrap: survive missing ntpq

Amador Pahim has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe,

Change in vdsm[master]: bootstrap: survive missing ntpq

Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 3: (1 inline comment) File vdsm_reg/deployUtil.py.in Line

Change in vdsm[master]: bootstrap: survive missing ntpq

Amador Pahim has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 3: No score Indeed. No need to the 1st if. -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit

Change in vdsm[master]: bootstrap: survive missing ntpq

Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 3: (1 inline comment) File vdsm_reg/deployUtil.py.in Line 685:

Change in vdsm[master]: bootstrap: survive missing ntpq

oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/777/ : SUCCESS -- To view,

Change in vdsm[master]: bootstrap: survive missing ntpq

Amador Pahim has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe,

Change in vdsm[master]: bootstrap: survive missing ntpq

Douglas Schilling Landgraf has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7597 To

Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well

Douglas Schilling Landgraf has posted comments on this change. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: bootstrap: survive missing ntpq

Barak Azulay has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe,

Change in vdsm[master]: tc: unsetPortMirroring: deleting a target twice is fine

oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: unsetPortMirroring: deleting a target twice is fine .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/778/ :

Change in vdsm[master]: Check if libvirtd.upstart is present before copying

Douglas Schilling Landgraf has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit

Change in vdsm[master]: tc: avoid adding non-existing devices to filter

oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: avoid adding non-existing devices to filter .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/781/ : SUCCESS

Change in vdsm[master]: BZ#833425 Change cpu topology source to /sys.

Amador Pahim has posted comments on this change. Change subject: BZ#833425 Change cpu topology source to /sys. .. Patch Set 13: Verified -- To view, visit http://gerrit.ovirt.org/5481 To unsubscribe, visit

Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging

oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging .. Patch Set 6: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/782/ :

Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up

oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 16: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/783/ :

Change in vdsm[master]: BZ#833425 Change cpu topology source to /sys.

Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#833425 Change cpu topology source to /sys. .. Patch Set 13: I still prefer the libvirt approach. We already depend of libvirt, why not use

Change in vdsm[master]: Check if libvirtd.upstart is present before copying

Dan Kenigsberg has submitted this change and it was merged. Change subject: Check if libvirtd.upstart is present before copying .. Check if libvirtd.upstart is present before copying If the (libvirt) packaged upstart script is

Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up

Dan Kenigsberg has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 16: I would prefer that you didn't submit this (1 inline comment) I like this patch! I

Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well

Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7596 To

Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well

Dan Kenigsberg has submitted this change and it was merged. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. bootstrap: node id: consider bonding MAC addresses as well The node id is constructed

Change in vdsm[master]: bootstrap: survive missing ntpq

Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit

Change in vdsm[master]: bootstrap: survive missing ntpq

Dan Kenigsberg has submitted this change and it was merged. Change subject: bootstrap: survive missing ntpq .. bootstrap: survive missing ntpq Minimal fedora installation does not have ntpq. Change-Id:

Change in vdsm[master]: bootstrap: survive missing ntpq

Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 3: (1 inline comment) File vdsm_reg/deployUtil.py.in Line

Change in vdsm[master]: BZ#845193 - Remove BRIDGE from nic/bond cofig file when remo...

Dan Kenigsberg has posted comments on this change. Change subject: BZ#845193 - Remove BRIDGE from nic/bond cofig file when removing bridge .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) minor

Change in vdsm[master]: port mirroring requires a newer kernel

Dan Kenigsberg has uploaded a new change for review. Change subject: port mirroring requires a newer kernel .. port mirroring requires a newer kernel It may be unsafe to use port mirroring due to kernel bug

Change in vdsm[master]: add simple VM creation functional test

Dan Kenigsberg has posted comments on this change. Change subject: add simple VM creation functional test .. Patch Set 6: I would prefer that you didn't submit this (3 inline comments) thanks for this rebase. would you review

Change in vdsm[master]: Move VM logic to it's own module (pt.1)

Adam Litke has posted comments on this change. Change subject: Move VM logic to it's own module (pt.1) .. Patch Set 4: (2 inline comments) File vdsm/API.py Line 134: Line

Change in vdsm[master]: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf

oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf .. Patch Set 7: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/784/ :

Change in vdsm[master]: port mirroring requires a newer kernel

oVirt Jenkins CI Server has posted comments on this change. Change subject: port mirroring requires a newer kernel .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/785/ : SUCCESS -- To

Change in vdsm[master]: fix TypeError of _eqSplit in vdsClient.py

Dan Kenigsberg has submitted this change and it was merged. Change subject: fix TypeError of _eqSplit in vdsClient.py .. fix TypeError of _eqSplit in vdsClient.py if the arg is string 'xyz', the _eqSplit will into the 'else'

Change in vdsm[master]: fix TypeError of _eqSplit in vdsClient.py

Dan Kenigsberg has posted comments on this change. Change subject: fix TypeError of _eqSplit in vdsClient.py .. Patch Set 6: Verified; Looks good to me, approved Taken, with minor changes. I hope you do not mind. Thanks. --

Change in vdsm[master]: Added _execGlusterXml()

Dan Kenigsberg has posted comments on this change. Change subject: Added _execGlusterXml() .. Patch Set 6: I would prefer that you didn't submit this (3 inline comments)

Change in vdsm[master]: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf

Greg Padgett has posted comments on this change. Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf .. Patch Set 7: Verified Rebased and verified that this works as it was written, with the message in the

Change in vdsm[master]: Added _execGlusterXml()

Dan Kenigsberg has posted comments on this change. Change subject: Added _execGlusterXml() .. Patch Set 6: (1 inline comment) File vdsm/gluster/cli.py Line 78: msg =

Change in vdsm[master]: Move load_needed_modules to vdsm-tool

Wenyi Gao has posted comments on this change. Change subject: Move load_needed_modules to vdsm-tool .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/7487 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: momTest: improve test's error reports

Mark Wu has posted comments on this change. Change subject: momTest: improve test's error reports .. Patch Set 2: Looks good to me, but someone else must approve I didn't notice that :( -- To view, visit

Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...

Royce Lv has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 6: (1 inline comment) File

Change in vdsm[master]: change startup process for vdsm and supervdsm

Royce Lv has posted comments on this change. Change subject: change startup process for vdsm and supervdsm .. Patch Set 10: Saggi, Thanks a lot for review.About tunnel all os.kill to a single point: (1)vdsm check if supervdsm

Change in vdsm[master]: tests: Honour PYTHONPATH if set on the host

Deepak C Shetty has uploaded a new change for review. Change subject: tests: Honour PYTHONPATH if set on the host .. tests: Honour PYTHONPATH if set on the host run_tests_local.sh doesn't honour PYTHONPATH if it was set. This

Change in vdsm[master]: tests: Honour PYTHONPATH if set on the host

oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Honour PYTHONPATH if set on the host .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/787/ : SUCCESS --

Change in vdsm[master]: Add a basic xmlrpc functional test

Zhou Zheng Sheng has posted comments on this change. Change subject: Add a basic xmlrpc functional test .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5788 To