Change in vdsm[master]: BZ#845193 - Remove BRIDGE from nic/bond cofig file when remo...
Igor Lvovsky has uploaded a new change for review.
Change subject: BZ#845193 - Remove BRIDGE from nic/bond cofig file when
removing bridge
..
BZ#845193 - Remove BRIDGE from nic/bond cofig file when removing bridge
Change-Id: I4b1c678469cee610d346d1e4905ee1f02f58f4bc
Signed-off-by: Igor Lvovsky ilvov...@redhat.com
---
M vdsm/configNetwork.py
1 file changed, 11 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/7600/1
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index 58117f8..74d19c7 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -1034,18 +1034,21 @@
if network and bridged:
configWriter.removeBridge(network)
+name = None
if vlan:
configWriter.removeVlan(vlan, bonding or nics[0])
-
-# When removing bridgeless non-VLANed network
-# we need to remove IP/NETMASK from the cfg file
-name = None
-if not bridged and not vlan:
+else:
name = bonding if bonding else nics[0]
-# Just edit the bond/nic cfg file
cf = configWriter.NET_CONF_PREF + name
-for key in ('IPADDR', 'NETMASK', 'GATEWAY', 'BOOTPROTO'):
-configWriter._updateConfigValue(cf, key, '', True)
+if not bridged:
+# When removing bridgeless non-VLANed network
+# we need to remove IP/NETMASK from the cfg file
+for key in ('IPADDR', 'NETMASK', 'GATEWAY', 'BOOTPROTO'):
+configWriter._updateConfigValue(cf, key, '', True)
+else:
+# When removing bridged non-VLANed network
+# we need to remove BRIDGE from the cfg file
+configWriter._updateConfigValue(cf, 'BRIDGE', '', True)
# The (relatively) new setupNetwork verb allows to remove a network
# defined on top of an bonding device without break the bond itself.
--
To view, visit http://gerrit.ovirt.org/7600
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b1c678469cee610d346d1e4905ee1f02f58f4bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#845193 - Remove BRIDGE from nic/bond cofig file when remo...
Igor Lvovsky has posted comments on this change. Change subject: BZ#845193 - Remove BRIDGE from nic/bond cofig file when removing bridge .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b1c678469cee610d346d1e4905ee1f02f58f4bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: momTest: improve test's error reports
Mark Wu has posted comments on this change. Change subject: momTest: improve test's error reports .. Patch Set 1: Looks good to me, but someone else must approve Thanks for the patch! -- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 15: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/768/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#845193 - Remove BRIDGE from nic/bond cofig file when remo...
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#845193 - Remove BRIDGE from nic/bond cofig file when removing bridge .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/769/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b1c678469cee610d346d1e4905ee1f02f58f4bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Yaniv Bronhaim has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 15: Verified -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: node id: consider bonding MAC addresses as well
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
File vdsm_reg/deployUtil.py.in
Line 307: readline().replace(\n, )
Line 308: macs.append(mac)
Line 309:
Line 310: for b in glob.glob('/proc/net/bonding/*'):
Line 311: lines = file(b).readlines()
I find this code a bit too complicated for our needs. how about
for line in file(b)
if line.startswith(Permanent HW addr: ):
macs.append(line.split(: )[1].replace(\n, ))
return set(macs) - set([, 00:00:00:00:00:00])
Line 312: try:
Line 313: line = (string for i, string in enumerate(lines) \
Line 314: if Permanent HW addr: in string).next()
Line 315: macs.append(line.split(: )[1].replace(\n, ))
--
To view, visit http://gerrit.ovirt.org/7596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae0713f95c25e3e05b24bf8254499e4cd8e64d10
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: node id: consider bonding MAC addresses as well
..
Patch Set 1: (1 inline comment)
File vdsm_reg/deployUtil.py.in
Line 307: readline().replace(\n, )
Line 308: macs.append(mac)
Line 309:
Line 310: for b in glob.glob('/proc/net/bonding/*'):
Line 311: lines = file(b).readlines()
The for loop is what I wrote initially... I thought you won't like it... :)
The set thing is nice.
Line 312: try:
Line 313: line = (string for i, string in enumerate(lines) \
Line 314: if Permanent HW addr: in string).next()
Line 315: macs.append(line.split(: )[1].replace(\n, ))
--
To view, visit http://gerrit.ovirt.org/7596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae0713f95c25e3e05b24bf8254499e4cd8e64d10
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) File vdsm_reg/deployUtil.py.in Line 693: Line 694: out = Line 695: if os.path.exists(EX_NTPQ): Line 696: out, err, rc = _logExec([EX_NTPQ, -c, rv]) Line 697: if 'clock_sync' in out: I think a slightly safer (works for other failures to run ntpq) and even smaller(!) way would be if out and 'clock_sync' in out: Line 698: logging.debug(setHostTime: Time is synchronised to NTP server.) Line 699: else: Line 700: try: Line 701: ttp = time.strptime(VDCTime, '%Y-%m-%dT%H:%M:%S') -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. Patch Set 2: Verified Applied Dan's comments. -- To view, visit http://gerrit.ovirt.org/7596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae0713f95c25e3e05b24bf8254499e4cd8e64d10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 1: (1 inline comment) File vdsm_reg/deployUtil.py.in Line 693: Line 694: out = Line 695: if os.path.exists(EX_NTPQ): Line 696: out, err, rc = _logExec([EX_NTPQ, -c, rv]) Line 697: if 'clock_sync' in out: Done Line 698: logging.debug(setHostTime: Time is synchronised to NTP server.) Line 699: else: Line 700: try: Line 701: ttp = time.strptime(VDCTime, '%Y-%m-%dT%H:%M:%S') -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/770/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae0713f95c25e3e05b24bf8254499e4cd8e64d10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: momTest: improve test's error reports
Dan Kenigsberg has posted comments on this change. Change subject: momTest: improve test's error reports .. Patch Set 1: had to fix my pep8 sins. -- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
Amador Pahim has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 3: (1 inline comment) File vdsm_reg/deployUtil.py.in Line 685: Line 686: out = None Line 687: if os.path.exists(EX_NTPQ): Line 688: out, err, rc = _logExec([EX_NTPQ, -c, rv]) Line 689: if out and 'clock_sync' in out: I was not clear, I'm afraid. I was saying that checking for existence is not really needed. On error, out is set to None, and that's all that needs to be added. Line 690: logging.debug(setHostTime: Time is synchronised to NTP server.) Line 691: else: Line 692: try: Line 693: ttp = time.strptime(VDCTime, '%Y-%m-%dT%H:%M:%S') -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
Amador Pahim has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 3: No score Indeed. No need to the 1st if. -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 3: (1 inline comment) File vdsm_reg/deployUtil.py.in Line 685: Line 686: out = None Line 687: if os.path.exists(EX_NTPQ): Line 688: out, err, rc = _logExec([EX_NTPQ, -c, rv]) Line 689: if out and 'clock_sync' in out: I got an exception... but will try again. Line 690: logging.debug(setHostTime: Time is synchronised to NTP server.) Line 691: else: Line 692: try: Line 693: ttp = time.strptime(VDCTime, '%Y-%m-%dT%H:%M:%S') -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/777/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
Amador Pahim has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
Douglas Schilling Landgraf has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well
Douglas Schilling Landgraf has posted comments on this change. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae0713f95c25e3e05b24bf8254499e4cd8e64d10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
Barak Azulay has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: unsetPortMirroring: deleting a target twice is fine
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: unsetPortMirroring: deleting a target twice is fine .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/778/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90f90164557548d38aa0e6991c4020055f892edb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Check if libvirtd.upstart is present before copying
Douglas Schilling Landgraf has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: avoid adding non-existing devices to filter
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: avoid adding non-existing devices to filter .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/781/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c1b459557985a3a894f182880411889f2c8a06f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#833425 Change cpu topology source to /sys.
Amador Pahim has posted comments on this change. Change subject: BZ#833425 Change cpu topology source to /sys. .. Patch Set 13: Verified -- To view, visit http://gerrit.ovirt.org/5481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging .. Patch Set 6: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/782/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 16: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/783/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#833425 Change cpu topology source to /sys.
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#833425 Change cpu topology source to /sys. .. Patch Set 13: I still prefer the libvirt approach. We already depend of libvirt, why not use functions that libvirt already contain? Anyway, the code looks good to me. -- To view, visit http://gerrit.ovirt.org/5481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Check if libvirtd.upstart is present before copying
Dan Kenigsberg has submitted this change and it was merged. Change subject: Check if libvirtd.upstart is present before copying .. Check if libvirtd.upstart is present before copying If the (libvirt) packaged upstart script is present in the rpm list of files but is absent from the filesystem the initscript was failing because the cp command couldn't copy it. This is mostly interesting in stripped down installations as the ovirt-node. RHBZ: 849984 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc --- M vdsm/vdsmd.init.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Dan Kenigsberg has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 16: I would prefer that you didn't submit this (1 inline comment) I like this patch! I would like to see its follow up patch, too (the one with function renaming and other fixes). however please note my comment regarding the commit message. Commit Message Line 3: AuthorDate: 2012-08-30 16:51:25 +0300 Line 4: Commit: Yaniv Bronhaim ybron...@redhat.com Line 5: CommitDate: 2012-08-30 16:51:25 +0300 Line 6: Line 7: BZ#734847- vdsmd always restarts libvirtd upon start-up please note to an annoying comment of mine from http://gerrit.ovirt.org/#/c/7331/13..16//COMMIT_MSG Line 8: Line 9: When starting vdsm we need to verify that libvirt is running by Line 10: upstart and not by SysV. When processing start() we stop libvirtd Line 11: service only if upstart exists and not configured. -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae0713f95c25e3e05b24bf8254499e4cd8e64d10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well
Dan Kenigsberg has submitted this change and it was merged. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. bootstrap: node id: consider bonding MAC addresses as well The node id is constructed using the lowest MAC address. If bonding is applied after initial node id was taken, it may shade the minimal address. This change adds to the MAC addresses of bonding interfaces to the MAC address addresses to consider. Sync with engine command used for same purpose. Change-Id: Iae0713f95c25e3e05b24bf8254499e4cd8e64d10 Signed-off-by: Alon Bar-Lev alo...@redhat.com --- M vdsm_reg/deployUtil.py.in 1 file changed, 19 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Douglas Schilling Landgraf: Looks good to me, but someone else must approve Barak Azulay: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae0713f95c25e3e05b24bf8254499e4cd8e64d10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
Dan Kenigsberg has submitted this change and it was merged. Change subject: bootstrap: survive missing ntpq .. bootstrap: survive missing ntpq Minimal fedora installation does not have ntpq. Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Signed-off-by: Alon Bar-Lev alo...@redhat.com --- M vdsm_reg/deployUtil.py.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Douglas Schilling Landgraf: Looks good to me, but someone else must approve Amador Pahim: Looks good to me, but someone else must approve Barak Azulay: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: survive missing ntpq
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: survive missing ntpq .. Patch Set 3: (1 inline comment) File vdsm_reg/deployUtil.py.in Line 685: Line 686: out = None Line 687: if os.path.exists(EX_NTPQ): Line 688: out, err, rc = _logExec([EX_NTPQ, -c, rv]) Line 689: if out and 'clock_sync' in out: you are not at fault here. _logExec() has cruel and unusual semantics.. Line 690: logging.debug(setHostTime: Time is synchronised to NTP server.) Line 691: else: Line 692: try: Line 693: ttp = time.strptime(VDCTime, '%Y-%m-%dT%H:%M:%S') -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#845193 - Remove BRIDGE from nic/bond cofig file when remo...
Dan Kenigsberg has posted comments on this change. Change subject: BZ#845193 - Remove BRIDGE from nic/bond cofig file when removing bridge .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) minor comment about the comment. Commit Message Line 3: AuthorDate: 2012-08-29 18:04:58 +0300 Line 4: Commit: Igor Lvovsky ilvov...@redhat.com Line 5: CommitDate: 2012-08-30 09:44:45 +0300 Line 6: Line 7: BZ#845193 - Remove BRIDGE from nic/bond cofig file when removing bridge I'm afraid we should start using Bug-Id: https://bugzilla.redhat.com/845193 Line 8: Line 9: Change-Id: I4b1c678469cee610d346d1e4905ee1f02f58f4bc -- To view, visit http://gerrit.ovirt.org/7600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b1c678469cee610d346d1e4905ee1f02f58f4bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: port mirroring requires a newer kernel
Dan Kenigsberg has uploaded a new change for review. Change subject: port mirroring requires a newer kernel .. port mirroring requires a newer kernel It may be unsafe to use port mirroring due to kernel bug https://bugzilla.redhat.com/show_bug.cgi?id=846585 Please do not push this patch before kernel-2.6.32-301 is available in el6, and kernel-3.6 is available in Fedora. Change-Id: If689c1bf846465044403757408cefc35adde6053 Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/7642/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 0d1b195..2b8876a 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -59,7 +59,7 @@ Requires: iscsi-initiator-utils = 6.2.0.872-15 Requires: device-mapper-multipath = 0.4.9-52 Requires: e2fsprogs = 1.41.12-11 -Requires: kernel = 2.6.32-265 +Requires: kernel = 2.6.32-301 Requires: sanlock = 2.3-3, sanlock-python %else # Subprocess and thread bug was found on python 2.7.2 @@ -72,7 +72,7 @@ Requires: iscsi-initiator-utils = 6.2.0.872-14 Requires: device-mapper-multipath = 0.4.9-18 Requires: e2fsprogs = 1.41.14 -Requires: kernel = 3.4 +Requires: kernel = 3.6 Requires: sanlock = 2.4-2, sanlock-python Requires: sed = 4.2.1-10 %endif -- To view, visit http://gerrit.ovirt.org/7642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If689c1bf846465044403757408cefc35adde6053 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add simple VM creation functional test
Dan Kenigsberg has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 6: I would prefer that you didn't submit this
(3 inline comments)
thanks for this rebase. would you review (and not only verify) my
http://gerrit.ovirt.org/#/c/5788/3 ?
File tests/functional/xmlrpcTests.py
Line 78: # code == 0 means OK
Line 79: self.assertEquals(vdsResult['status']['code'], 0)
Line 80:
Line 81: def testStartEmptyVM(self):
Line 82: VMID = '----'
I've liked this whitespace. why kill it?
Line 83: r = self.s.create({'memSize': '100', 'display': 'vnc', 'vmId':
VMID,
Line 84:'vmName': 'foo'})
Line 85: self.assertVdsOK(r)
Line 86: try:
Line 91: self.assertVdsOK(r)
Line 92:
Line 93: # This test relies a initramfs in /boot, so it is marked as
brokentest
Line 94: # until we add support for those distros with initrd in /boot.
Line 95: @brokentest
I know that I suggested brokentest, but it would hide real Fedora failures,
too. Better raise SkipTest if initramfsPath is not found.
Line 96: def testStartSmallVM(self):
Line 97: VMID = '----'
Line 98: kernelVer = os.uname()[2]
Line 99: kernelPath = /boot/vmlinuz- + kernelVer
Line 121: self.retryAssert(assertVMAndGuestUp, 65, 1)
Line 122: except Exception:
Line 123: # If the guest OS gets stuck when boot, or other
exception raised,
Line 124: # destroy the VM anyway to release the resources.
Line 125: self.s.destroy(VMID)
I think it would be nicer to put
r = self.s.destroy(VMID)
in a finally block, and
self.assertVdsOK(r)
in an external block. Then, you would not need to write self.s.destroy(VMID)
twice, and the comments won't be really needed.
Line 126: raise
Line 127: else:
Line 128: # guest OS boot OK, assert we destroy the machine properly
--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move VM logic to it's own module (pt.1)
Adam Litke has posted comments on this change. Change subject: Move VM logic to it's own module (pt.1) .. Patch Set 4: (2 inline comments) File vdsm/API.py Line 134: Line 135: for methName in GUEST_AGENT_METHODS: Line 136: self.setattr(attrName, partial(guestTrampoline, methName)) Line 137: Line 138: def _runThinMethod(self, methodName, *args, **kwargs): Sorry, not convinced... I don't buy the not pythonic argument. Just because Python allows you to write dynamic function wrappers doesn't mean we need to use them all of the time when straightforward static code will do. You may prefer code that looks like this, but my opinion is that it is less readable and is not necessary. If you think that these methods will gain more substance over time, then there is even fewer reasons to invent this wrapping scheme because over time fewer and fewer functions will be using it. If you are worried about typos, you could write a small Python script that generates the easy-to-read code I am suggesting. You write / change code much less often than you have to read code. Because of this, I'm still not a big fan of paying a code readability cost every time I look at a file in order to make it more interesting to write the first time. A much better way to communicate the redundant nature of this file is with a straightforward comment at the top that explains it. That is a lot clearer than trying to communicate that through the style in which the code is written. Line 139: v = self._cif.vmContainer.get(self._UUID) Line 140: if not v: Line 141: return errCode['noVM'] Line 142: File vdsm/vmContainer.py Line 34: Line 35: container_len = len(self._vms) Line 36: Line 37: vm.run() Line 38: self.log.debug(Total desktops after creation of %s is %d % Nope, fair point. I will not dispute this logic. Line 39:(vmId, container_len)) Line 40: Line 41: return vm Line 42: -- To view, visit http://gerrit.ovirt.org/7423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc54c1d0ab7ad535d825dcd72fd2f4583b690f44 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf .. Patch Set 7: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/784/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/5368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: port mirroring requires a newer kernel
oVirt Jenkins CI Server has posted comments on this change. Change subject: port mirroring requires a newer kernel .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/785/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If689c1bf846465044403757408cefc35adde6053 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix TypeError of _eqSplit in vdsClient.py
Dan Kenigsberg has submitted this change and it was merged. Change subject: fix TypeError of _eqSplit in vdsClient.py .. fix TypeError of _eqSplit in vdsClient.py if the arg is string 'xyz', the _eqSplit will into the 'else' branch. and then k = ['xyz']. but list type can not be a hash key. TypeError will come up. throw a Exception to report this case, it is more clear what has happended. Change-Id: I98b5573499adaa1b64f8343b445cc16df8f60f3d Signed-off-by: ShaoHe Feng shao...@linux.vnet.ibm.com --- M vdsm_cli/vdsClient.py 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98b5573499adaa1b64f8343b445cc16df8f60f3d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix TypeError of _eqSplit in vdsClient.py
Dan Kenigsberg has posted comments on this change. Change subject: fix TypeError of _eqSplit in vdsClient.py .. Patch Set 6: Verified; Looks good to me, approved Taken, with minor changes. I hope you do not mind. Thanks. -- To view, visit http://gerrit.ovirt.org/7200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98b5573499adaa1b64f8343b445cc16df8f60f3d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added _execGlusterXml()
Dan Kenigsberg has posted comments on this change.
Change subject: Added _execGlusterXml()
..
Patch Set 6: I would prefer that you didn't submit this
(3 inline comments)
File vdsm/gluster/cli.py
Line 72: rc, out, err = utils.execCmd(cmd)
Line 73: if rc != 0:
Line 74: raise ge.GlusterCmdExecFailedException(rc, out, err)
Line 75: try:
Line 76: tree = etree.fromstring('\n'.join(out))
you'd save some time if you call execCmd(raw=True)
Line 77: rv = tree.find('opRet').text
Line 78: msg = tree.find('opErrstr').text
Line 79: except (etree.ParseError, AttributeError):
Line 80: raise ge.GlusterXmlErrorException(err=out)
Line 78: msg = tree.find('opErrstr').text
Line 79: except (etree.ParseError, AttributeError):
Line 80: raise ge.GlusterXmlErrorException(err=out)
Line 81: if rv == '0':
Line 82: return (tree, out)
'tree' is 'out' parsed. so why do you need to return both?
Line 83: else:
Line 84: raise ge.GlusterCmdFailedException(rc=rv, err=[msg])
Line 85:
Line 86:
Line 80: raise ge.GlusterXmlErrorException(err=out)
Line 81: if rv == '0':
Line 82: return (tree, out)
Line 83: else:
Line 84: raise ge.GlusterCmdFailedException(rc=rv, err=[msg])
here rc is set to a string; else where it is an int. that's legal but confusing.
Line 85:
Line 86:
Line 87: def _parseVolumeInfo(out):
Line 88: if not out[0].strip():
--
To view, visit http://gerrit.ovirt.org/6999
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I385f992005d446b417be84eb7ff484e4edf6e5b6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf
Greg Padgett has posted comments on this change. Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf .. Patch Set 7: Verified Rebased and verified that this works as it was written, with the message in the log. A patch that sends an alert (and an accompanying engine patch) is forthcoming as soon as I clean it up a bit. -- To view, visit http://gerrit.ovirt.org/5368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added _execGlusterXml()
Dan Kenigsberg has posted comments on this change.
Change subject: Added _execGlusterXml()
..
Patch Set 6: (1 inline comment)
File vdsm/gluster/cli.py
Line 78: msg = tree.find('opErrstr').text
Line 79: except (etree.ParseError, AttributeError):
Line 80: raise ge.GlusterXmlErrorException(err=out)
Line 81: if rv == '0':
Line 82: return (tree, out)
Bala: Unfortunately, its not possible to convert cElementTree object to
string. So cli output in xml is passed to command specific functions.
why etree.tostring(tree) is not good enough for the rare cases you need the
string?
Line 83: else:
Line 84: raise ge.GlusterCmdFailedException(rc=rv, err=[msg])
Line 85:
Line 86:
--
To view, visit http://gerrit.ovirt.org/6999
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I385f992005d446b417be84eb7ff484e4edf6e5b6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move load_needed_modules to vdsm-tool
Wenyi Gao has posted comments on this change. Change subject: Move load_needed_modules to vdsm-tool .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/7487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdc8f9d07a7150c4a846228811d6c5dcb17fa358 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao we...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Wenyi Gao we...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: momTest: improve test's error reports
Mark Wu has posted comments on this change. Change subject: momTest: improve test's error reports .. Patch Set 2: Looks good to me, but someone else must approve I didn't notice that :( -- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Royce Lv has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 6: (1 inline comment) File vdsm.spec.in Line 65: Requires: python = 2.7.3 Line 66: Requires: qemu-kvm = 2:0.15.0-4 Line 67: Requires: qemu-img = 2:0.15.0-4 Line 68: #readonly lease ignored by default on 0.9.11.4-3 Line 69: Requires: libvirt = 0.9.13-1 Igor, As this package is a rel one, I will bump the rhel version. I checked the community release for fc, 0.9.13 does not include patch: fix key error for qemuMonitorGetBlockStatsInfo as changelog mentioned, this patch is included in 0.10.0, so I'll use this version Line 70: Requires: libvirt-python, libvirt-lock-sanlock Line 71: Requires: iscsi-initiator-utils = 6.2.0.872-14 Line 72: Requires: device-mapper-multipath = 0.4.9-18 Line 73: Requires: e2fsprogs = 1.41.14 -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: change startup process for vdsm and supervdsm
Royce Lv has posted comments on this change. Change subject: change startup process for vdsm and supervdsm .. Patch Set 10: Saggi, Thanks a lot for review.About tunnel all os.kill to a single point: (1)vdsm check if supervdsm died and killed itself. (2)vdsm check call supervdsm failed and kill self(the hsm or clientIF will except the error) (3)supervdsm check if vdsm alive or killed itself. I thought they could not be tunneled to a single point. Please feel free to correct me.In fact I wait on IRC for few days wanting to ask about this:) -- To view, visit http://gerrit.ovirt.org/4145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69aae6b0b9529c80291d90c6ad14ff82b21aea53 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Wenyi Gao we...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Honour PYTHONPATH if set on the host
Deepak C Shetty has uploaded a new change for review. Change subject: tests: Honour PYTHONPATH if set on the host .. tests: Honour PYTHONPATH if set on the host run_tests_local.sh doesn't honour PYTHONPATH if it was set. This causes issues with the tests (sometimes) if user was using a custom path for say libvirt ( running from a git src, rather than installed rpm path). This path add $PYTHONPATH to the script to fix the issue. Change-Id: Ia4a3ac4d238da59abf558b628fa34cae90006b6e Signed-off-by: Deepak C Shetty deepa...@linux.vnet.ibm.com --- M tests/run_tests_local.sh.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/7648/1 diff --git a/tests/run_tests_local.sh.in b/tests/run_tests_local.sh.in index c4bc5c8..bb43538 100644 --- a/tests/run_tests_local.sh.in +++ b/tests/run_tests_local.sh.in @@ -1,2 +1,2 @@ #!/bin/sh -PYTHONDONTWRITEBYTECODE=1 LC_ALL=C PYTHONPATH=@builddir@/vdsm:@top_srcdir@/vdsm:@top_srcdir@/vdsm_cli @PYTHON@ @top_srcdir@/tests/testrunner.py --local-modules $@ +PYTHONDONTWRITEBYTECODE=1 LC_ALL=C PYTHONPATH=$PYTHONPATH:@builddir@/vdsm:@top_srcdir@/vdsm:@top_srcdir@/vdsm_cli @PYTHON@ @top_srcdir@/tests/testrunner.py --local-modules $@ -- To view, visit http://gerrit.ovirt.org/7648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia4a3ac4d238da59abf558b628fa34cae90006b6e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Honour PYTHONPATH if set on the host
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Honour PYTHONPATH if set on the host .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/787/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4a3ac4d238da59abf558b628fa34cae90006b6e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a basic xmlrpc functional test
Zhou Zheng Sheng has posted comments on this change. Change subject: Add a basic xmlrpc functional test .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
