Nir Soffer has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2:
Correct commit message - it is not libvirt but us creating that thread in
libvirtconnection.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6047/ : SUCCESS
Vinzenz Feenstra has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2: Verified+1 Code-Review+1
Verified on both el6 hosts where the issue was originally
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix syntax error
..
Patch Set 2: Verified+1 Code-Review+2
waiting for acks
--
To view, visit http://gerrit.ovirt.org/22310
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix syntax error
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/327/ : SUCCESS
--
To view, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix syntax error
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Nir Soffer has uploaded a new change for review.
Change subject: libvirtconnection: Do not start event loop on import
..
libvirtconnection: Do not start event loop on import
Starting a thread on import is very bad idea. This
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconnection: Do not start event loop on import
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6048/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2:
The event loop implicit start is handled by http://gerrit.ovirt.org/#/c/22322/.
--
To view,
Dan Kenigsberg has uploaded a new change for review.
Change subject: libvirtconn: starting a thread on import is impolite
..
libvirtconn: starting a thread on import is impolite
This patch ensures that libvirt's event loop is
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconn: starting a thread on import is impolite
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: Fix syntax error
..
Patch Set 2:
the commit message could improve, if you have time. it's spec: related. what
commit caused this bug?
--
To view, visit
Hello Federico Simoncelli, Dan Kenigsberg, Michal Skrivanek,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22324
to review the following change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
Antoni Segura Puimedon has posted comments on this change.
Change subject: libvirtconn: starting a thread on import is impolite
..
Patch Set 1: Code-Review-1
(1 comment)
scoping suggestion.
Francesco Romani has posted comments on this change.
Change subject: libvirtconnection: Do not start event loop on import
..
Patch Set 1: Code-Review+1
Like very much the idea. Looks good to me.
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22324
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: libvirtconn: starting a thread on import is impolite
..
Patch Set 1: Code-Review-1
This is better: http://gerrit.ovirt.org/#/c/22322/
--
To view, visit
Nir Soffer has abandoned this change.
Change subject: Testing pinger thread
..
Abandoned
Tested, not needed any more.
--
To view, visit http://gerrit.ovirt.org/22305
To unsubscribe, visit http://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: Run pinger in separate process
..
Patch Set 2:
This should be less fragile but with this patch we get lot of strange failures
in the network functional tests.
Nir Soffer has posted comments on this change.
Change subject: Run pinger in separate process
..
Patch Set 2: Verified-1
--
To view, visit http://gerrit.ovirt.org/22293
To unsubscribe, visit http://gerrit.ovirt.org/settings
Vinzenz Feenstra has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 4: Verified+1
Verified on EL6 with a 100GiB VM with the stress tool running in
Antoni Segura Puimedon has posted comments on this change.
Change subject: libvirtconnection: Do not start event loop on import
..
Patch Set 1: Code-Review+1
Thanks Nir!
--
To view, visit http://gerrit.ovirt.org/22322
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: Add config option for network configurator
..
Patch Set 8:
Thanks a lot Mark!
--
To view, visit http://gerrit.ovirt.org/18210
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: Add config option for network configurator
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18210
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mkimage: do not create world-readable image
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6050/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22041
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
Francesco Romani has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 4: Verified+1
did some research about the empty /proc/meminfo issue. No luck so far neither
in
Antoni Segura Puimedon has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 4: Code-Review-1
(1 comment)
pep8 issue in the comment.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6052/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22041
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(3 comments)
File
Nir Soffer has posted comments on this change.
Change subject: securable: refactor the scurable implementation
..
Patch Set 1:
(1 comment)
File vdsm/storage/sp.py
Line 305:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mkimage: create files with explicit permissions
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6053/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22324
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(2 comments)
File vdsm/clientIF.py
Francesco Romani has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 5: Verified+1
(repasted from patchset 4)
did some research about the empty /proc/meminfo issue.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconn: starting a thread on import is impolite
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6054/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(1 comment)
File vdsm/clientIF.py
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(2 comments)
File vdsm/clientIF.py
Line
Antoni Segura Puimedon has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 22: Code-Review-1
(5 comments)
Some minor things related to compatibility in error messages.
Antoni Segura Puimedon has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 22:
For the rest, it looks very good to me. Thanks Mark!
--
To view, visit http://gerrit.ovirt.org/15301
To
Adam Litke has posted comments on this change.
Change subject: add verb for vdsm to tuneCpu params
..
Patch Set 8: Code-Review-1
Yes, I would say this has been abandoned since the last update from the
submitter was over a
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netconf: Make default rollback nullify runningConfig
..
netconf: Make default rollback nullify runningConfig
It should be possible for a unified
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(1 comment)
File vdsm/clientIF.py
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6056/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(1 comment)
File vdsm/clientIF.py
Vinzenz Feenstra has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
..
Patch Set 4: Verified+1
Verified on el6 with a setting of 1 second per GiB and a 102400 MiB swapping
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6057/ :
Itamar Heim has abandoned this change.
Change subject: add verb for vdsm to tuneCpu params
..
Abandoned
feel free to re-open if/when relevant
--
To view, visit http://gerrit.ovirt.org/7492
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
..
Patch Set 4: -Verified
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6058/ :
Tomáš Došek has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21708
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 5: Verified+1
Verified by testing on real VMs with QGA installed
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
utils: janitorial: refactor utils.readMemInfo
minor cleanup in readMemInfo:
- split the actual
Dan Kenigsberg has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 5: Code-Review+2
Maybe you can publish a request on ovirt-users, for people to grep for the
empty
Liron Ar has uploaded a new change for review.
Change subject: deactivateSD - perform nothing if the domain is already
deactivated
..
deactivateSD - perform nothing if the domain is already deactivated
When calling
Yaniv Bronhaim has posted comments on this change.
Change subject: Distribute /var/log/core with vdsm rpm.
..
Patch Set 5:
(1 comment)
File vdsm.spec.in
Line 596:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: janitorial: drop stray refs to storage.misc.execCmd
..
Patch Set 1:
I have a
sed s/sudo=False, //
rotting in my files...
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: janitorial: drop stray refs to storage.misc.execCmd
..
Patch Set 1: Verified+1
tested together with http://gerrit.ovirt.org/#/c/22041/ seems fine
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 6:
Build Successful
Francesco Romani has posted comments on this change.
Change subject: janitorial: drop remaining betterPopen references
..
Patch Set 1: Verified+1
tested with http://gerrit.ovirt.org/#/c/22041/ and seems fine.
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: deactivateSD - perform nothing if the domain is already
deactivated
..
Patch Set 1:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: janitorial: drop remaining betterPopen references
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22195
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: janitorial: drop stray refs to storage.misc.execCmd
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22219
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: janitorial: drop remaining betterPopen references
..
janitorial: drop remaining betterPopen references
betterPopen has been named cpopen long ago, and
Dan Kenigsberg has submitted this change and it was merged.
Change subject: janitorial: drop stray refs to storage.misc.execCmd
..
janitorial: drop stray refs to storage.misc.execCmd
storage.misc.execCmd was moved to
Yaniv Bronhaim has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2: -Code-Review
(1 comment)
you forgot the debian folder .. please update
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: sourcerouting: make thread daemonic
..
sourcerouting: make thread daemonic
The Python interpreter waits for non daemonic threads. The
Nir Soffer has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2:
(1 comment)
File vdsm.spec.in
Line 852:
Ayal Baron has posted comments on this change.
Change subject: sp: move reconnection info check to StoragePool
..
Patch Set 8:
(2 comments)
File vdsm/storage/hsm.py
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sourcerouting: make thread daemonic
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6061/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: sourcerouting: make thread daemonic
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22345
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: libvirtconn: starting a thread on import is impolite
..
Patch Set 2: Code-Review+1
I like the concision!
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: sourcerouting: make thread daemonic
..
Patch Set 1: -Verified Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22345
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: sourcerouting: make thread daemonic
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22345
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: sourcerouting: make thread daemonic
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22345
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: sp: encapsulate spm status in StoragePool
..
Patch Set 7:
(1 comment)
File vdsm/storage/sp.py
Line 167:
Ayal Baron has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21659
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 12:
(1 comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Fix syntax error
..
Patch Set 2:
+1 for dan's suggestion.
--
To view, visit http://gerrit.ovirt.org/22310
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
..
Patch Set 4:
(1 comment)
just one comment in vm.py
Nir Soffer has posted comments on this change.
Change subject: deactivateSD - perform nothing if the domain is already
deactivated
..
Patch Set 1:
(3 comments)
Commit
Ayal Baron has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5: Code-Review+1
(1 comment)
File
Assaf Muller has uploaded a new change for review.
Change subject: kvm group can now r/w to all newly created files in
/var/log/vdsm
..
kvm group can now r/w to all newly created files in /var/log/vdsm
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: kvm group can now r/w to all newly created files in
/var/log/vdsm
..
Patch Set 1:
Build Successful
Allon Mureinik has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2: Code-Review+1
+1, except for Yaniv's comment on debian.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2:
(1 comment)
File vdsm.spec.in
Line 852:
Allon Mureinik has posted comments on this change.
Change subject: libvirtconnection: Do not start event loop on import
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22322
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: kvm group can now r/w to all newly created files in
/var/log/vdsm
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/22349
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: kvm group can now r/w to all newly created files in
/var/log/vdsm
..
Patch Set 2:
Build Successful
Assaf Muller has posted comments on this change.
Change subject: kvm group can now r/w to all newly created files in
/var/log/vdsm
..
Patch Set 2: Verified-1
* Missing Debian post-install script mention
* Need to test if
Dan Kenigsberg has posted comments on this change.
Change subject: kvm group can now r/w to all newly created files in
/var/log/vdsm
..
Patch Set 2: Code-Review-1
(1 comment)
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: configNetwork: Fix bridgeless broken network deletion
..
configNetwork: Fix bridgeless broken network deletion
When trying to delete a broken
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configNetwork: Fix bridgeless broken network deletion
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6064/ : SUCCESS
Assaf Muller has posted comments on this change.
Change subject: kvm group can now r/w to all newly created files in
/var/log/vdsm
..
Patch Set 2:
From very minimal research it seems that the acl package might not be
Antoni Segura Puimedon has posted comments on this change.
Change subject: sourcerouting: make thread daemonic
..
Patch Set 1: Verified+1
Verified doing:
localhost vdsm (9c35a65) # ip r
10.34.60.0/22 dev eth0 proto
Yaniv Bronhaim has posted comments on this change.
Change subject: Don't reconfigure if configured when force is set
..
Patch Set 1: Verified+1
for both its alright not to override the configuration if already configured.
--
Alon Bar-Lev has posted comments on this change.
Change subject: Don't reconfigure if configured when force is set
..
Patch Set 1:
for both its alright not to override the configuration if already configured.
how do you know
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix syntax error in vdsm.spec
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/328/ : SUCCESS
--
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix syntax error in vdsm.spec
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/22310
To unsubscribe, visit
1 - 100 of 121 matches
Mail list logo
