Francesco Romani has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
......................................................................
Patch Set 4:
(1 comment)
just one comment in vm.py
....................................................
File vdsm/vm.py
Line 756:
Line 757: maxTimePerGiB = config.getint('vars',
Line 758:
'migration_max_time_per_gib_mem')
Line 759: memSize = int(self._vm.conf['memSize'])
Line 760: migrationMaxTime = maxTimePerGiB * (memSize / 1024)
Probably an unlikely corner case, but what if the memory size is not an exact
multiple of a GiB? I'm thinking about scenarios like 1536 MiB of memory, or
something like it.
Line 761: lastProgressTime = time.time()
Line 762: smallest_dataRemaining = None
Line 763:
Line 764: while not self._stop.isSet():
--
To view, visit http://gerrit.ovirt.org/21708
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2f76b9334fcb7d2db24c081cccae15e8fd0b0c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Lee Yarwood <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Tomáš Došek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
