Yaniv Bronhaim has uploaded a new change for review.
Change subject: Fixing sanlockConfigModule is-configured output
..
Fixing sanlockConfigModule is-configured output
The output was misleading and based on the return value.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fixing sanlockConfigModule is-configured output
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6141/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: init: add --pidfile option in vdsmd.service
..
Patch Set 1:
but isn't it better practice to have PIDFile option for systemd ? if you prefer
to use that can
Hunt Xu has posted comments on this change.
Change subject: storage: get currImgDir correctly in fileSD.deleteImage()
..
Patch Set 4:
(2 comments)
Commit Message
Line 3:
Yaniv Bronhaim has posted comments on this change.
Change subject: init: add --pidfile option in vdsmd.service
..
Patch Set 1:
and im not sure you're right. the --pidfile is passed to target which means to
respawn. in systemd
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileSD: Fix image deletion on gluster domain
..
Patch Set 5:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6142/ : To avoid
Nir Soffer has posted comments on this change.
Change subject: fileSD: Fix image deletion on gluster domain
..
Patch Set 5: Code-Review+1
Thanks for your nice patch!
--
To view, visit http://gerrit.ovirt.org/22359
To
Nir Soffer has posted comments on this change.
Change subject: init: add --pidfile option in vdsmd.service
..
Patch Set 1:
Please open an ovirt bug for this the pid file is not always created but
needed, and add a Bug-Url to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileSD: Fix image deletion on gluster domain
..
Patch Set 5:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6143/ : To avoid
oVirt Jenkins CI Server has posted comments on this change.
Change subject: create VMs in a bulk
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6144/ : UNSTABLE
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Forbid bare except:
..
Patch Set 3:
Nir: where do we set such rules except the pep8 run? maybe im not aware of it
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
..
Patch Set 4:
(1 comment)
File vdsm/storage/sp.py
Nir Soffer has posted comments on this change.
Change subject: build: Forbid bare except:
..
Patch Set 3:
We run pep8 and pylint. Running these tools and breaking the build when they
complain is *our* choice. pep8 is just
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1:
(3 comments)
Commit Message
Line 12: backwards
Alon Bar-Lev has posted comments on this change.
Change subject: Fixing sanlockConfigModule is-configured output
..
Patch Set 1:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6145/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: sp: specific method to validate the master version
..
Patch Set 6: Verified+1
Verified with connectStoragePool and masterMigrate.
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Fixing sanlockConfigModule is-configured output
..
Patch Set 1: Verified+1
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: specific method to validate the master version
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6146/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 4: Code-Review+2
(1 comment)
File lib/vdsm/tool/upgrade.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileSD: Fix image deletion on gluster domain
..
Patch Set 5:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6143/ : To avoid
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Forbid bare except:
..
Patch Set 3:
sounds like a way to declare standards
--
To view, visit http://gerrit.ovirt.org/22456
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 4: Code-Review-1
logger.conf.in needs a manual rebase
--
To view, visit http://gerrit.ovirt.org/22349
To
Ayal Baron has posted comments on this change.
Change subject: sp: specific method to validate the master version
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22130
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] vdsm: add support for PCI passthrough
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6147/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: specific method to validate the master version
..
sp: specific method to validate the master version
The validation of the master domain version
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1:
(1 comment)
File vdsm/guestIF.py
Line 302: def
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6149/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6148/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6150/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: ksm: janitorial: with construct, file() to open()
..
Patch Set 5:
(1 comment)
File vdsm/ksm.py
Line 34:
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line 2546: except:
Dan Kenigsberg has posted comments on this change.
Change subject: fileSD: Fix image deletion on gluster domain
..
Patch Set 5:
(1 comment)
Commit Message
Line 6:
Line 7:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: add node registration tool
..
Patch Set 4:
Douglas, pyflakes can be silly, and you can avoid it with things like
grep -w -v
Nir Soffer has uploaded a new change for review.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
vm: Fix attribute error when accessing drive in sampling method
Du to race when migration is
Nir Soffer has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1:
Patch for testing this issue on a user machine. Patch for upstream and ovirt
Yaniv Bronhaim has posted comments on this change.
Change subject: mkimage: do not create world-readable image
..
Patch Set 4:
(1 comment)
File vdsm.spec.in
Line 100:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6151/ : SUCCESS
Assaf Muller has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/22349
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: mkimage: create files with explicit permissions
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21965
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: add node registration tool
..
Patch Set 4:
(2 comments)
File
Dan Kenigsberg has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 5: Code-Review+2
Copying score. Thanks!
--
To view, visit http://gerrit.ovirt.org/22349
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: upgrade.log now owned by vdsm:kvm
..
upgrade.log now owned by vdsm:kvm
Bug:
If the admin installs VDSM, but before VDSM's first run
manually calls
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileSD: Fix image deletion on gluster domain
..
Patch Set 6:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6152/ : To avoid
Yaniv Bronhaim has posted comments on this change.
Change subject: threadpool: Move iteration logic to it's own method
..
Patch Set 1: Verified+1 Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22263
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/148/ :
Dan Kenigsberg has submitted this change and it was merged.
Change subject: threadpool: Move iteration logic to it's own method
..
threadpool: Move iteration logic to it's own method
By moving it to a method you use python's
Nir Soffer has posted comments on this change.
Change subject: fileSD: Fix image deletion on gluster domain
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22359
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6153/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: mkimage: do not create world-readable image
..
Patch Set 4:
(1 comment)
File vdsm.spec.in
Line 100:
Francesco Romani has posted comments on this change.
Change subject: ksm: janitorial: with construct, file() to open()
..
Patch Set 5:
(1 comment)
File vdsm/ksm.py
Line 34:
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22518
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for PCI passthrough
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6154/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/22440
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6156/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6155/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 4: Verified+1
Verified with http://gerrit.ovirt.org/21659 for the relevant flows
Ayal Baron has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22467
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8: Verified+1
Verified for the relevant flows: createStoragePool, connectStoragePool,
Federico Simoncelli has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8:
So this patch is not just cosmetic, it fixes behaviour.
@Ayal, this patch is cosmetic only as
Ayal Baron has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21659
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: sp: remove unused transaction in createMaster
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1:
Is this a backport or is it a patch needed only in ovirt-3.3?
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 4: Verified-1
Build Failed
Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1: Code-Review+1
(1 comment)
I assume that this is an upstream patch, right?
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 3:
please rebase and verify as well. thanks
--
To view, visit http://gerrit.ovirt.org/20194
To
Nir Soffer has posted comments on this change.
Change subject: vmDevices: add __slots__ to devices
..
Patch Set 2: Code-Review+1
Set only keys in __slots__ and this is perfect.
for key in self.__slots__:
Humble Devassy Chirammal has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 3:
(2 comments)
File
Nir Soffer has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1:
This is a patch for a user running 4.13.0. Patch for upstream will be in
another
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6158/ :
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices
..
vdsm: add support for hot(un)plug of pci-passthrough devices
Hot(un)plug ability for
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6159/ :
Nir Soffer has posted comments on this change.
Change subject: vmDevices: add __slots__ to devices
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line 1167:
Line 1168: class
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6160/ :
Federico Simoncelli has posted comments on this change.
Change subject: fileSD: Fix image deletion on gluster domain
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22359
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices
..
Patch Set 2: Code-Review-1
(2 comments)
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: vmfex: Add vmfex device custom properties hook
..
vmfex: Add vmfex device custom properties hook
The current vmfex hook works at the VM level which
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmfex: Add vmfex device custom properties hook
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6161/ : SUCCESS
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices
..
Patch Set 2:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmfex: Add vmfex device custom properties hook
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6162/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmfex: Add vmfex device custom properties hook
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6163/ : SUCCESS
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22440
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmfex: Add vmfex device custom properties hook
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6164/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1:
(1 comment)
Commit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1:
Ah sorry, Nir, I did not see your latest comment. How does the __slots__ patch
Nir Soffer has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1:
(1 comment)
Commit Message
Antoni Segura Puimedon has posted comments on this change.
Change subject: vmfex: Add vmfex device custom properties hook
..
Patch Set 4:
Executing the tests on a blade with SRIOV yields:
Interface before attaching to
Nir Soffer has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1:
The race is not the problem. The problem is that the code treat attributes as
Nir Soffer has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1:
Note also that in the context of _highwrite, we don't care if the vmDrive has a
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmfex: Add vmfex device custom properties hook
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6165/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmfex: Add vmfex device custom properties hook
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6166/ : SUCCESS
Yeela Kaplan has uploaded a new change for review.
Change subject: vm: Update domains list for disks attached to vm after LSM
..
vm: Update domains list for disks attached to vm after LSM
Change-Id:
Yeela Kaplan has posted comments on this change.
Change subject: vm: Update domains list for disks attached to vm after LSM
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22536
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Update domains list for disks attached to vm after LSM
..
Patch Set 1: Verified-1
Build Failed
Nir Soffer has posted comments on this change.
Change subject: fileSD: Fix image deletion on gluster domain
..
Patch Set 6:
Hunt, can you describe how you verified your change on glusterfs and nfs?
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileSD: Fix image deletion on gluster domain
..
Patch Set 6:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6168/ : To avoid
Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: factor named temp file creation
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/22379
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1: Verified+1
Verified on user machine.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1:
(1 comment)
File vdsm/guestIF.py
Line 302: def
1 - 100 of 142 matches
Mail list logo
