Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: Error out if we failed to change a bond's mode
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32657
To unsubscribe,
Antoni Segura Puimedon has posted comments on this change.
Change subject: sourceroutethread: fix logging string formatting
..
Patch Set 1: Verified+1
Getting rid of old changes, I don't think this one needs any real
Francesco Romani has posted comments on this change.
Change subject: profiling: Add support for memory profiling
..
Patch Set 3:
addressed comments; initial 'stop' implementation;
better rationale in commit message.
The
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profiling: Add support for memory profiling
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12343/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profiling: Add support for memory profiling
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12344/ :
Francesco Romani has uploaded a new change for review.
Change subject: config: introduce a devel section
..
config: introduce a devel section
This patch introduces a 'devel' configuration section,
in order to unclutter a bit
Francesco Romani has posted comments on this change.
Change subject: profiling: Add support for memory profiling
..
Patch Set 4:
cleanup patchset started on this topic branch:
Antoni Segura Puimedon has posted comments on this change.
Change subject: config: introduce a devel section
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32664
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: config: introduce a devel section
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12345/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: config: introduce a devel section
..
Patch Set 1:
(2 comments)
Looks fine but can do more - I think we can do all changes needed for
additional profiler in one
Nir Soffer has posted comments on this change.
Change subject: config: introduce a devel section
..
Patch Set 1: Code-Review+1
On the other hand, we can keep this small and add another patch for the package.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sourceroutethread: fix logging string formatting
..
sourceroutethread: fix logging string formatting
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sourceroutethread: fix logging string formatting
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1823/ :
Nir Soffer has posted comments on this change.
Change subject: profiling: Add support for memory profiling
..
Patch Set 4: Code-Review-1
(10 comments)
http://gerrit.ovirt.org/#/c/32019/4/lib/vdsm/profile_mem.py
File
Nir Soffer has posted comments on this change.
Change subject: profiling: Add support for memory profiling
..
Patch Set 4:
(1 comment)
I think we should move this into the new profiling package:
lib/vdsm/profiling/mem.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12346/ : FAILURE
Petr Horáček has posted comments on this change.
Change subject: configurators: runDhclient moved iproute2 __init__.py
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32455
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: tests: split vm tests helpers in a module
..
Patch Set 2: Code-Review+1
I would consider lowercase module names (Modules should have short,
all-lowercase
Martin Polednik has posted comments on this change.
Change subject: use super instead of direct parent call for Drive
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/32398
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: use super instead of direct parent call for Drive
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12347/ :
Martin Polednik has posted comments on this change.
Change subject: use super instead of direct parent call for NIC
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/32400
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: use super instead of direct parent call for NIC
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12348/ :
Dan Kenigsberg has posted comments on this change.
Change subject: vm: per-attribute monitor response check
..
Patch Set 11: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/23138/11/vdsm/virt/vm.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in
getVdsCaps
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32653
To
Petr Horáček has posted comments on this change.
Change subject: vdsClient: getRoute verb added
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/32115
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 4: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/25820/4//COMMIT_MSG
Commit Message:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: vm: always log when guest CPU state changes
..
Patch Set 2: Code-Review-1
requires rebase
--
To view, visit http://gerrit.ovirt.org/31697
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: do not produce stats for missing disks
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30029
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12349/ : FAILURE
Petr Horáček has uploaded a new change for review.
Change subject: revert: libvirt is happy with redefinition of nwfilter
..
revert: libvirt is happy with redefinition of nwfilter
Change-Id:
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsClient: getRoute verb added
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32115
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
Patch Set 1:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
Patch Set 2:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32691
To
Petr Horáček has posted comments on this change.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
Patch Set 2: Verified+1
Problem reproduced with libvirt-1.2.7. This patch fixed it.
--
Eli Mesika has uploaded a new change for review.
Change subject: vdsm: making PM 'on' and 'off' sync
..
vdsm: making PM 'on' and 'off' sync
Consider the following scenario:
DC1 with H1 (with PM) and H2 on cluster C1
another
Eli Mesika has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32695
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
revert: libvirt is happy with redefinition of an existing nwfilter
Change-Id:
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32696
to review the following change.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32697
to review the following change.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
oVirt Jenkins CI Server has posted comments on this change.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
Patch Set 3:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32696
To
Dan Kenigsberg has posted comments on this change.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32697
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 1: Code-Review-1 Verified-1
Build Unstable
Petr Horáček has posted comments on this change.
Change subject: revert: libvirt is happy with redefinition of an existing
nwfilter
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32696
To unsubscribe,
Eli Mesika has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/32695
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32695
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12353/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: networkTests: setupNetworksAddBondWithManyVlans bond not found
..
Patch Set 9:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: vm: always log when guest CPU state changes
..
Patch Set 3:
rebased. Move the logging into an helper.
--
To view, visit http://gerrit.ovirt.org/31697
To
Francesco Romani has posted comments on this change.
Change subject: config: introduce a devel section
..
Patch Set 1:
I will implement Nir suggestion in a followup patch.
--
To view, visit http://gerrit.ovirt.org/32664
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: always log when guest CPU state changes
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12355/ :
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 2: Code-Review-1
How did you verify this patch? We were forced to use asynchronous call to the
fence script,
Dan Kenigsberg has posted comments on this change.
Change subject: net_models: make network hierarchies iterable
..
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/32606/1/vdsm/network/models.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert 'Create default multipath.conf during install'
..
Patch Set 7:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 8:
Build Successful
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: unified_persistence: only consider bonds created/touched by vdsm
..
unified_persistence: only consider bonds created/touched by vdsm
When upgrading a
Antoni Segura Puimedon has posted comments on this change.
Change subject: unified_persistence: only consider bonds created/touched by vdsm
..
Patch Set 1: Verified+1
Verified that a machine with bonding does not report it
oVirt Jenkins CI Server has posted comments on this change.
Change subject: unified_persistence: only consider bonds created/touched by vdsm
..
Patch Set 1:
Build Successful
mooli tayer has uploaded a new change for review.
Change subject: In a recent commit changing configuration[1] I missed the
version bumping while rebasing moving around.
..
In a recent commit changing configuration[1]
I missed
mooli tayer has abandoned this change.
Change subject: In a recent commit changing configuration[1] I missed the
version bumping while rebasing moving around.
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/32704
To
Francesco Romani has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 4: -Verified
(3 comments)
http://gerrit.ovirt.org/#/c/25820/4//COMMIT_MSG
Commit Message:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: In a recent commit changing configuration[1] I missed the
version bumping while rebasing moving around.
..
Patch Set 1:
Build Failed
Francesco Romani has uploaded a new change for review.
Change subject: vm: migration: move wait countdown in a function
..
vm: migration: move wait countdown in a function
The Downtime thread is a migration helper thread
mooli tayer has uploaded a new change for review.
Change subject: tool: use natural numbers for configuration versioning.
..
tool: use natural numbers for configuration versioning.
Currently we use a vdsm version but only bump
mooli tayer has uploaded a new change for review.
Change subject: tool: bump CONF_VERSION to 4.17.
..
tool: bump CONF_VERSION to 4.17.
In a recent commit changing configuration[1]
I missed the version bumping while rebasing
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: migration: move wait countdown in a function
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12361/ :
mooli tayer has posted comments on this change.
Change subject: tool: bump CONF_VERSION to 4.17.
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32707
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: bump CONF_VERSION to 4.17.
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12362/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: use natural numbers for configuration versioning.
..
Patch Set 1:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: migration: move wait countdown in a function
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12364/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12365/ :
mooli tayer has posted comments on this change.
Change subject: tool: bump CONF_VERSION to 4.17.
..
Patch Set 1: Verified-1
(1 comment)
http://gerrit.ovirt.org/#/c/32707/1//COMMIT_MSG
Commit Message:
Line 9: In a recent
Dan Kenigsberg has posted comments on this change.
Change subject: ethtool_opts: provide a way to apply to all slaves
..
Patch Set 5:
(2 comments)
Dan Kenigsberg has posted comments on this change.
Change subject: tool: bump CONF_VERSION to 4.17.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32707/1//COMMIT_MSG
Commit Message:
Line 9: In a recent commit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ethtool_opts: provide a way to apply to all slaves
..
Patch Set 5:
Build Successful
Antoni Segura Puimedon has posted comments on this change.
Change subject: ethtool_opts: provide a way to apply to all slaves
..
Patch Set 6: Verified+1
Ran the same verification as before and checked also that even when one
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ethtool_opts: provide a way to apply to all slaves
..
Patch Set 6:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 6: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25820/6/vdsm/virt/migration.py
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: net_models: make network hierarchies iterable
..
Patch Set 1: Verified+1
Passing the exhaustive unit tests is enough for this one.
--
To view, visit
mooli tayer has uploaded a new change for review.
Change subject: tool-tests: use variable from conf version in template files.
..
tool-tests: use variable from conf version in template files.
Replace CONF_VERSION with current
mooli tayer has posted comments on this change.
Change subject: tool: bump CONF_VERSION to 4.17.
..
Patch Set 2:
Test failures fixed by dependent change.
--
To view, visit http://gerrit.ovirt.org/32707
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: tool: bump CONF_VERSION to 4.17.
..
Patch Set 2: -Verified
--
To view, visit http://gerrit.ovirt.org/32707
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: use natural numbers for configuration versioning.
..
Patch Set 2:
Build Successful
Francesco Romani has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/25820/6/vdsm/virt/migration.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: bump CONF_VERSION to 4.17.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12369/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool-tests: use variable from conf version in template files.
..
Patch Set 1:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: migration: move wait countdown in a function
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12371/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12372/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Remove duplicate names
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12373/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: tool: Remove duplicate names
..
Patch Set 7:
Rebase, no code change
--
To view, visit http://gerrit.ovirt.org/31775
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Use frozenset instead of set
..
Patch Set 5: Verified+1
Rebase and fix some new set()s added recently.
--
To view, visit http://gerrit.ovirt.org/31786
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Use frozenset instead of set
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12374/ : SUCCESS
Nir Soffer has uploaded a new change for review.
Change subject: make: Add check-all target
..
make: Add check-all target
The previous patch made it easy to skip the stress and slow tests, and
hard to run them. This make it
Nir Soffer has posted comments on this change.
Change subject: make: Add check-all target
..
Patch Set 1: Verified+1
Checked that all tests run using make check-all
--
To view, visit http://gerrit.ovirt.org/32721
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: make: Add check-all target
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12375/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: tests: Disable slow and stress tests by default
..
Patch Set 2:
Francesco, see http://gerrit.ovirt.org/32721
--
To view, visit http://gerrit.ovirt.org/32523
To
Dan Kenigsberg has posted comments on this change.
Change subject: ethtool_opts: provide a way to apply to all slaves
..
Patch Set 6:
(1 comment)
Nir Soffer has uploaded a new change for review.
Change subject: fileSD: Move private constant near the only call site
..
fileSD: Move private constant near the only call site
Keeping a private constant used by only one
Nir Soffer has posted comments on this change.
Change subject: fileSD: Move private constant near the only call site
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32724
To unsubscribe, visit
1 - 100 of 125 matches
Mail list logo
