Change in vdsm[master]: vm: move device setup into __init__
Francesco Romani has posted comments on this change. Change subject: vm: move device setup into __init__ .. Patch Set 4: just reformatted the stacktrace into the commit message to make it readable -- To view, visit http://gerrit.ovirt.org/34753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e5a8e7916bb0c0d2519949397a5c1c64085e08e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device setup into __init__
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move device setup into __init__ .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13357/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13197/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12407/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1890/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e5a8e7916bb0c0d2519949397a5c1c64085e08e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device setup into __init__
Francesco Romani has posted comments on this change. Change subject: vm: move device setup into __init__ .. Patch Set 4: Succesful partial verification with 34752: * survived an excess of 550 VM startup without issues (stress test the same which highlighed bz1143968) * succesfully recovered ~150 VMs without issues Things to be verified: - more careful recovery check - disk hotplug scenario -- To view, visit http://gerrit.ovirt.org/34753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e5a8e7916bb0c0d2519949397a5c1c64085e08e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: added NFS support to functional tests
Yoav Kleinberger has uploaded a new change for review.
Change subject: tests: added NFS support to functional tests
..
tests: added NFS support to functional tests
In this patch, I introduce a new NFS storage context for the storage
functional tests. Since there is much shared logic between NFS and
LocalFS storage context, I introduce a common superclass.
Change-Id: I1781fc400c0604855d3143dde22ccb29e6cc8013
Signed-off-by: Yoav Kleinberger yklei...@redhat.com
---
M tests/functional/basicStorageTest.py
M tests/functional/testlib/storagecontexts/base.py
A tests/functional/testlib/storagecontexts/filebased.py
M tests/functional/testlib/storagecontexts/iscsi.py
M tests/functional/testlib/storagecontexts/localfs.py
A tests/functional/testlib/storagecontexts/nfs.py
6 files changed, 249 insertions(+), 114 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/32990/1
diff --git a/tests/functional/basicStorageTest.py
b/tests/functional/basicStorageTest.py
index c01d14b..438f8c8 100644
--- a/tests/functional/basicStorageTest.py
+++ b/tests/functional/basicStorageTest.py
@@ -4,6 +4,7 @@
from functional.testlib import controlvdsm
from functional.testlib.storagecontexts import localfs
from functional.testlib.storagecontexts import iscsi
+from functional.testlib.storagecontexts import nfs
class TestBasicStorageDomain(object):
@@ -23,6 +24,9 @@
def testCreateVolumeISCSI(self):
self._testCreateVolume(iscsi.ISCSI)
+def testCreateVolumeNFS(self):
+self._testCreateVolume(nfs.NFS)
+
def _testCreateVolume(self, storageBackend):
with storageBackend() as (vdsm, verify):
storageServerID = vdsm.connectStorageServer()
diff --git a/tests/functional/testlib/storagecontexts/base.py
b/tests/functional/testlib/storagecontexts/base.py
index 7179694..2e308ad 100644
--- a/tests/functional/testlib/storagecontexts/base.py
+++ b/tests/functional/testlib/storagecontexts/base.py
@@ -73,16 +73,47 @@
class StorageBackend(object):
def __init__(self):
self._vdsmCaller = vdsmcaller.VDSMCaller()
+self._domainID = self._newUUID()
+self._poolID = self._newUUID()
+self._imageID = self._newUUID()
+self._volumeID = self._newUUID()
+self._connectionID = self._newUUID()
+
+def connectionID(self):
+return self._connectionID
+
+def volumeID(self):
+return self._volumeID
+
+def imageID(self):
+return self._imageID
+
+def poolID(self):
+return self._poolID
+
+def domainID(self):
+return self._domainID
def vdsm(self):
return self._vdsmCaller
-def newUUID(self):
+def _newUUID(self):
return str(uuid.uuid4())
def randomName(self, base):
return %s_%04d % (base, random.randint(1, 1))
+def createStoragePool(self):
+POOL_TYPE_DEPRECATED = 0
+self.vdsm().createStoragePool(
+POOL_TYPE_DEPRECATED,
+self.poolID(),
+self.randomName('pool'),
+self.domainID(),
+[self.domainID()],
+1)
+return self.poolID()
+
def connectStoragePool(self, poolID, masterDomainID):
SCSI_KEY_DEPRECATED = 0
self.vdsm().connectStoragePool(
diff --git a/tests/functional/testlib/storagecontexts/filebased.py
b/tests/functional/testlib/storagecontexts/filebased.py
new file mode 100644
index 000..bdb15d7
--- /dev/null
+++ b/tests/functional/testlib/storagecontexts/filebased.py
@@ -0,0 +1,69 @@
+import os
+import storage.volume
+import storage.image
+from . import base
+import logging
+
+
+class Verify(base.Verify):
+
+def rhevMountPoint(self):
+raise Exception('you must override this function')
+
+def storageServerConnected(self):
+self.sleepWhileVDSMCompletesTask(duration=2)
+assert os.path.exists(self.rhevMountPoint())
+
+def storageDomainCreated(self, domainID):
+self.sleepWhileVDSMCompletesTask(duration=1)
+self._directIOTestFileExists()
+domainRoot = os.path.join(self.rhevMountPoint(), domainID)
+expectedFiles = [
+'images',
+'dom_md',
+'dom_md/leases',
+'dom_md/inbox',
+'dom_md/outbox',
+'dom_md/metadata',
+'dom_md/ids']
+expectedFullPaths =\
+[os.path.join(domainRoot, path) for path in expectedFiles]
+for path in expectedFullPaths:
+logging.info('verifying path: %s' % path)
+assert os.path.exists(path)
+
+def _directIOTestFileExists(self):
+directIOTestFile = os.path.join(
+self.rhevMountPoint(),
+'__DIRECT_IO_TEST__')
+assert os.path.exists(directIOTestFile)
+
+def volumeCreated(self, volumeInfo):
+taskID, domainID, imageID, volumeID = volumeInfo
+
Change in vdsm[master]: tests: added NFS support to functional tests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: added NFS support to functional tests .. Patch Set 1: -Code-Review -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13359/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1781fc400c0604855d3143dde22ccb29e6cc8013 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot create and delete verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot create and delete verbs. .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13358/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/561/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/543/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13198/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12408/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/1/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2d1f1b2f2a675c5407222cb267a7560927ae84f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13360/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13199/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12409/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot list, restore and status verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot list, restore and status verbs. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13361/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13200/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12410/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I422fab5bc9ec9dc51d759bad46487c60051bbfc1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot config set and get verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot config set and get verbs. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13362/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13201/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12411/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee32a95cf028cda33f25776c08820c5ed80f1033 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cache: Replace utils.memoized with cache.memoized()
oVirt Jenkins CI Server has posted comments on this change. Change subject: cache: Replace utils.memoized with cache.memoized() .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13354/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13194/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12404/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1889/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2132/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12e2f2919cf92ff7d0758d70e2ed40523d66174f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: return displayIp as a string in default case
Frank Kobzik has posted comments on this change. Change subject: vm: return displayIp as a string in default case .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If211e80d731de27dd5d5154c32dd63bef5c2be2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move vm.GraphicsDevice - vmdevices.Graphics
Francesco Romani has posted comments on this change.
Change subject: virt: move vm.GraphicsDevice - vmdevices.Graphics
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34557/1/vdsm/virt/vmdevices.py
File vdsm/virt/vmdevices.py:
Line 362:
Line 363: return graphics
Line 364:
Line 365:
Line 366: def _getNetworkIp(network):
From code point of view: making classes lean VS polluting the module - imho
I spoke with network team back in time when GraphicsDevice was introduced,
apparently noone likes this poor little function, so there is no good in making
it public.
For the sake of keeping classes lean, I'd like to keep it there.
Line 367: try:
Line 368: nets = netinfo.networks()
Line 369: device = nets[network].get('iface', network)
Line 370: ip, _, _, _ = netinfo.getIpInfo(device)
--
To view, visit http://gerrit.ovirt.org/34557
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8597ce1896b308204974b60f60a19cc52fca8e0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: devices: move Graphics Device utility functions
Francesco Romani has posted comments on this change. Change subject: devices: move Graphics Device utility functions .. Patch Set 1: I was planning to go in the opposite direction, removing the staticmethod from Graphics Device class, but maybe to have this couple of function as staticmethod is actually better because provides more context on the calling site. So let's give it a try and let's see how it looks. -- To view, visit http://gerrit.ovirt.org/34558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd345f8f0eb477f6bda417c418f79900aeee53a5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13366/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13205/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12415/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1894/ :
There was an infra issue, please contact in...@ovirt.org
--
To view, visit http://gerrit.ovirt.org/34556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7a3bdb3cb2269e85e83d8c688582e61473f688f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move Drive into vmdevices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move Drive into vmdevices .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13365/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13204/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12414/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1893/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa7fe68e8a5b0d0d9203d0870523f988acbc46d4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move NetworkInterface into vmdevices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move NetworkInterface into vmdevices .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13364/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13203/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12413/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1892/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I686bf58787ffd0c670827a51d1d6792dd14a445a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: devices: move Graphics Device utility functions
oVirt Jenkins CI Server has posted comments on this change. Change subject: devices: move Graphics Device utility functions .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13363/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13202/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12412/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1891/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd345f8f0eb477f6bda417c418f79900aeee53a5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
Francesco Romani has posted comments on this change.
Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
..
Patch Set 2:
rebased
--
To view, visit http://gerrit.ovirt.org/34556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7a3bdb3cb2269e85e83d8c688582e61473f688f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move vm.GraphicsDevice - vmdevices.Graphics
Francesco Romani has posted comments on this change. Change subject: virt: move vm.GraphicsDevice - vmdevices.Graphics .. Patch Set 2: rebased. No code changes. -- To view, visit http://gerrit.ovirt.org/34557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8597ce1896b308204974b60f60a19cc52fca8e0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move Drive into vmdevices
Francesco Romani has posted comments on this change. Change subject: virt: move Drive into vmdevices .. Patch Set 2: rebased -- To view, visit http://gerrit.ovirt.org/34560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa7fe68e8a5b0d0d9203d0870523f988acbc46d4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move NetworkInterface into vmdevices
Francesco Romani has posted comments on this change. Change subject: virt: move NetworkInterface into vmdevices .. Patch Set 2: rebased -- To view, visit http://gerrit.ovirt.org/34559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I686bf58787ffd0c670827a51d1d6792dd14a445a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: devices: move Graphics Device utility functions
Francesco Romani has posted comments on this change. Change subject: devices: move Graphics Device utility functions .. Patch Set 2: moved *LegacyConf as staticmethods reordered methods in Graphics class for the sake of readability no changes in behaviour -- To view, visit http://gerrit.ovirt.org/34558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd345f8f0eb477f6bda417c418f79900aeee53a5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Adding the possibility to skip checks on rpmbuild
Yaniv Bronhaim has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Adding the possibility to skip checks on rpmbuild
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Adding the possibility to skip checks on rpmbuild .. Adding the possibility to skip checks on rpmbuild This way you can build the rpms skipping the tests just defining the variable with_check to 0 when running rpmbuild, also skipping checks by default when building on el* based hosts Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd Signed-off-by: David Caro dcaro...@redhat.com Reviewed-on: http://gerrit.ovirt.org/29213 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-on: http://gerrit.ovirt.org/34766 Tested-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm.spec.in 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild
Hello Douglas Schilling Landgraf, David Caro, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/34773
to review the following change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Adding the possibility to skip checks on rpmbuild
This way you can build the rpms skipping the tests just defining the variable
with_check to 0 when running rpmbuild, also skipping checks by default when
building on el* based hosts
Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd
Signed-off-by: David Caro dcaro...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/29213
Reviewed-by: Dan Kenigsberg dan...@redhat.com
Reviewed-by: Douglas Schilling Landgraf dougsl...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/34766
Tested-by: Yaniv Bronhaim ybron...@redhat.com
---
M vdsm.spec.in
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/34773/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 4f822e4..49a7e27 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -20,6 +20,11 @@
# touch configure.ac or Makefile.am.
%{!?enable_autotools:%define enable_autotools 0}
+# Skips check since rhel default repos lack pep8 and pyflakes
+%if ! 0%{?rhel}
+%global with_check 1
+%endif
+
# Required paths
%if 0%{?fedora} = 18
%global _polkitdir %{_datadir}/polkit-1/rules.d
@@ -107,7 +112,7 @@
BuildRequires: libtool
%endif
-%if !0%{?rhel}
+%if 0%{?with_check}
BuildRequires: pyflakes
BuildRequires: python-pep8
%endif
@@ -724,7 +729,9 @@
%endif
%check
+%if 0%{?with_check}
make check
+%endif
%clean
rm -rf %{buildroot}
--
To view, visit http://gerrit.ovirt.org/34773
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5.0
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: deepcopy result in response
Francesco Romani has posted comments on this change. Change subject: jsonrpc: deepcopy result in response .. Patch Set 2: Code-Review-1 misplaced fix -- To view, visit http://gerrit.ovirt.org/34580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d3214bce52e410428eeda5ad604fab06b27753c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Use ovirt node for persist and unpersist files
Yeela Kaplan has abandoned this change. Change subject: utils: Use ovirt node for persist and unpersist files .. Abandoned -- To view, visit http://gerrit.ovirt.org/31584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ifaf19e5f8f5beca38d34a606c3eb370385dc206d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add logs to rotateFiles
Yeela Kaplan has abandoned this change. Change subject: utils: Add logs to rotateFiles .. Abandoned -- To view, visit http://gerrit.ovirt.org/32605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If4636d54bb39db02301e2f528c9ca15f13472eaf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Adding the possibility to skip checks on rpmbuild
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/72/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/79/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/76/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/76/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: added NFS support to functional tests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: added NFS support to functional tests .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13368/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13207/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12417/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1781fc400c0604855d3143dde22ccb29e6cc8013 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: migration: exponential downtime increment
Francesco Romani has posted comments on this change. Change subject: vm: migration: exponential downtime increment .. Patch Set 9: Verified+1 re-verified while running a few migration, both with idle and busy VM: Thread-444::DEBUG::2014-11-04 11:49:30,905::migration::393::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration downtime thread started Thread-444::DEBUG::2014-11-04 11:50:00,916::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 51 Thread-444::DEBUG::2014-11-04 11:50:30,928::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 51 Thread-444::DEBUG::2014-11-04 11:51:00,933::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 53 Thread-444::DEBUG::2014-11-04 11:51:30,937::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 57 Thread-444::DEBUG::2014-11-04 11:52:00,942::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 65 Thread-444::DEBUG::2014-11-04 11:52:30,949::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 79 Thread-444::DEBUG::2014-11-04 11:53:00,953::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 108 Thread-444::DEBUG::2014-11-04 11:53:30,957::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 165 Thread-443::DEBUG::2014-11-04 11:53:51,288::migration::411::vm.Vm::(stop) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::stopping migration downtime thread Thread-444::DEBUG::2014-11-04 11:53:51,289::migration::408::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration downtime thread exiting Thread-733::DEBUG::2014-11-04 11:56:48,123::migration::393::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration downtime thread started Thread-733::DEBUG::2014-11-04 11:57:18,127::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 51 Thread-733::DEBUG::2014-11-04 11:57:48,131::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 51 Thread-733::DEBUG::2014-11-04 11:58:18,136::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 53 Thread-733::DEBUG::2014-11-04 11:58:48,140::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 57 Thread-732::DEBUG::2014-11-04 11:59:00,561::migration::411::vm.Vm::(stop) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::stopping migration downtime thread Thread-733::DEBUG::2014-11-04 11:59:00,564::migration::408::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration downtime thread exiting Thread-864::DEBUG::2014-11-04 11:59:45,684::migration::393::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration downtime thread started Thread-864::DEBUG::2014-11-04 12:00:15,687::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 51 Thread-864::DEBUG::2014-11-04 12:00:45,691::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 51 Thread-864::DEBUG::2014-11-04 12:01:15,696::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 53 Thread-864::DEBUG::2014-11-04 12:01:45,700::migration::405::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 57 Thread-863::DEBUG::2014-11-04 12:01:56,836::migration::411::vm.Vm::(stop) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::stopping migration downtime thread Thread-864::DEBUG::2014-11-04 12:01:56,839::migration::408::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration downtime thread exiting Thread-1065::DEBUG::2014-11-04 12:04:37,643::migration::393::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration downtime thread started Thread-1064::DEBUG::2014-11-04 12:04:56,465::migration::411::vm.Vm::(stop) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::stopping migration downtime thread Thread-1065::DEBUG::2014-11-04 12:04:56,468::migration::408::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration downtime thread exiting Thread-1108::DEBUG::2014-11-04 12:05:36,462::migration::393::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration downtime thread started Thread-1105::DEBUG::2014-11-04 12:05:57,641::migration::411::vm.Vm::(stop) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::stopping migration downtime thread Thread-1108::DEBUG::2014-11-04 12:05:57,644::migration::408::vm.Vm::(run)
Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild
Yaniv Bronhaim has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5.0 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: migration: exponential downtime increment
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: migration: exponential downtime increment .. vm: migration: exponential downtime increment Migration downtime is calculated using an interpolation using the current downtime step (up to a configurabile maximum) and the maximum downtime. The downtime is incremented at each downtime step until it reaches the maximum, or the migration is finished. This patch changes the interpolation formula from linear to exponential, being the new one: d = c ** s + k where d is the downtime, s is the step and c is the exponentiation base computed in such a way of when s = S (number of steps to perform), then we will have d = D (selected downtime). K is a constant added to make sure that downtime 'd' is never equal to zero. The rationale for this patch is that moving linearly from the minimum to maximum downtime limit isn't very useful: if if we took 1s downtime for a migration that could complete with 0.1s downtime, that's very bad, but if we take 11s to complete a migration that could finish in 10s, it's not a big deal. So, it makes more sense to step towards the final hard limit exponentially rather than linearly. In addition, because most of the attempts will be much shorted than the final hard limit, it won't blow out the total time to complete migration nearly as badly. Please note that this patch still preserve an linear increment of the wait time. Along the way, we take the chance to bootstrap unit tests for vdsm/virt/migration.py. Change-Id: I6401772f52ea28144452e67198bddff18f6703eb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1004101 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25820 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Martin Polednik mpoled...@redhat.com --- M tests/Makefile.am A tests/vmMigrationTests.py M vdsm/virt/migration.py 3 files changed, 132 insertions(+), 3 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Martin Polednik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6401772f52ea28144452e67198bddff18f6703eb Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema: Adding Active slave support networkTests: Test to check if active slave exists .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13369/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13208/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12418/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2133/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/32915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Genadi Chereshnya gcher...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Genadi Chereshnya gcher...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: migration: exponential downtime increment
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: migration: exponential downtime increment .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/155/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/178/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/371/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6003/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/176/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/171/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4164/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6401772f52ea28144452e67198bddff18f6703eb Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema: Adding Active slave support networkTests: Test to check if active slave exists .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Genadi Chereshnya gcher...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Genadi Chereshnya gcher...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: persist selinux booleans on ovirt node.
Yaniv Bronhaim has posted comments on this change. Change subject: tool: persist selinux booleans on ovirt node. .. Patch Set 2: Code-Review+1 Douglas, please review.. -- To view, visit http://gerrit.ovirt.org/34518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3e86a4ad1a204b9157df398affa88b61a9bdc32 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: caps: Report online logical CPUs
Yaniv Bronhaim has posted comments on this change. Change subject: caps: Report online logical CPUs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia41df1758e629dc1087416c1dad3fa4d115243fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: persist selinux booleans on ovirt node.
Douglas Schilling Landgraf has posted comments on this change. Change subject: tool: persist selinux booleans on ovirt node. .. Patch Set 2: Looks good to me. Question Mooli, have you verified this patch on node? -- To view, visit http://gerrit.ovirt.org/34518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3e86a4ad1a204b9157df398affa88b61a9bdc32 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild
Douglas Schilling Landgraf has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5.0 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device setup into __init__
Francesco Romani has posted comments on this change.
Change subject: vm: move device setup into __init__
..
Patch Set 4:
(6 comments)
Since this is a quite obscure patch changing quite obscure code, added a few
comments with the intent of making reviewer's life a bit easier.
http://gerrit.ovirt.org/#/c/34753/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2662
Line 2663
Line 2664
Line 2665
Line 2666
Up to here old code was changing devices which is a hierarchy of conf data,
which will flattened to Vm.conf['devices'] into _updateDevices.
Line 2667
Line 2668
Line 2669
Line 2670
Line 2671
This makes the Device instances from Conf data, so they are created correct and
no need to sync
Line 2654:
Line 2655: for devType, devClass in self.DeviceMapping:
Line 2656: for dev in devices[devType]:
Line 2657: devObj = devClass(self.conf, self.log, **dev)
Line 2658: self._devices[devType].append(devObj)
we need this _diskMap cache only to speedup updateDrivesFromConf below. Other
than that, just code move and rearrangement of operations.
Line 2659: if devType == DISK_DEVICES and isVdsmImage(dev):
Line 2660: self._diskMap[(dev['domainID'], dev['poolID'],
Line 2661:dev['imageID'], dev['volumeID'])]
= devObj
Line 2662:
Line 2660: self._diskMap[(dev['domainID'], dev['poolID'],
Line 2661:dev['imageID'], dev['volumeID'])]
= devObj
Line 2662:
Line 2663: def _run(self):
Line 2664: self.log.info(VM wrapper has started)
after this patch we now start the async creation with
- Vm.conf['devices'] up to date, but not saved in recovery file. This is ok
because we can always rebuild Vm.conf['device'] from the conf supplied by
Engine, so no real behaviour change here
- Vm._devices (*Device instance tree) created and synced with Vm.conf['devices']
Line 2665:
Line 2666: drives = list(self.getDiskDevicesConf())
Line 2667: self._updateDiskSizes(drives)
Line 2668: # recovery flow note:
Line 2679: # saving we will fail in inconsistent state during
recovery.
Line 2680: # So, to get proper device objects during VM recovery
flow
Line 2681: # we must to have updated conf before VM run
Line 2682: self.saveState()
Line 2683: self._updateDrivesFromConf(drives)
But here we need to sync up
Line 2684: self._diskMap = {} # no longer needed, let's clean it up
Line 2685:
Line 2686: # We should set this event as a last part of drives
initialization
Line 2687: self._pathsPreparedEvent.set()
Line 5401: if dev:
Line 5402: dev.path = drv['path']
Line 5403: dev.format = drv['format']
Line 5404: dev.apparentsize = drv['apparentsize']
Line 5405: dev.truesize = drv['truesize']
these are he fields (potentially) changed into lines 2667-2675
Line 5406: else:
Line 5407: self.log.error('missing Drive from conf: %s',
drv)
Line 5408:
Line 5409:
--
To view, visit http://gerrit.ovirt.org/34753
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e5a8e7916bb0c0d2519949397a5c1c64085e08e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild
Yaniv Bronhaim has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5.0 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: persist selinux booleans on ovirt node.
mooli tayer has posted comments on this change. Change subject: tool: persist selinux booleans on ovirt node. .. Patch Set 2: To be honest I have never been able to test anything that required creating a node iso out of a specific patch... I remember you created a guide how to do so, Shell we try again? -- To view, visit http://gerrit.ovirt.org/34518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3e86a4ad1a204b9157df398affa88b61a9bdc32 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Adding the possibility to skip checks on rpmbuild .. Adding the possibility to skip checks on rpmbuild This way you can build the rpms skipping the tests just defining the variable with_check to 0 when running rpmbuild, also skipping checks by default when building on el* based hosts Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd Signed-off-by: David Caro dcaro...@redhat.com Reviewed-on: http://gerrit.ovirt.org/29213 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-on: http://gerrit.ovirt.org/34766 Tested-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/34773 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm.spec.in 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified; Looks good to me, approved Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5.0 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild
Dan Kenigsberg has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 1: Code-Review+1 but if you need this for building in mock, go ahead. -- To view, visit http://gerrit.ovirt.org/34773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5.0 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require latest version of IOProcess
Saggi Mizrahi has posted comments on this change. Change subject: spec: require latest version of IOProcess .. Patch Set 1: Code-Review+2 Verified+1 There is no need to wait until it is in stable. This is master and it's meant for developers. If VDSM developers aren't going to test and give karma who will. The whole point of updates-testing is developers up the stack can see that their applications still work with newer versions. I do want vdsm developers to use it while it's in testing and give karma. There is no reason to wait. This is the master branch it is meant for bleeding edge development. -- To view, visit http://gerrit.ovirt.org/34403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic70d15fe0b9827707a51654e31327f7a50c479ac Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild
Dan Kenigsberg has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 1: It's not REALLY important, since 3.5.0 is a dead branch (already built and released)... -- To view, visit http://gerrit.ovirt.org/34773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5.0 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require latest version of IOProcess
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: require latest version of IOProcess .. spec: require latest version of IOProcess This version includes an important fix for IOProcess being referenced by the communication thread Change-Id: Ic70d15fe0b9827707a51654e31327f7a50c479ac Signed-off-by: Yeela Kaplan ykap...@redhat.com Reviewed-on: http://gerrit.ovirt.org/34403 Reviewed-by: Saggi Mizrahi smizr...@redhat.com Tested-by: Saggi Mizrahi smizr...@redhat.com --- M vdsm.spec.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Yeela Kaplan: Verified Saggi Mizrahi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic70d15fe0b9827707a51654e31327f7a50c479ac Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
Francesco Romani has posted comments on this change.
Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
..
Patch Set 2: Verified+1
Verification: booted a few VMs, also did a couple of recovery and migration,
everything seems fine.
--
To view, visit http://gerrit.ovirt.org/34556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7a3bdb3cb2269e85e83d8c688582e61473f688f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: caps: Report online logical CPUs
Yaniv Bronhaim has posted comments on this change. Change subject: caps: Report online logical CPUs .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34768/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 1139: # @cpuCores:The number of CPU cores present Line 1140: # Line 1141: # @cpuSockets: The number of CPU sockets Line 1142: # Line 1143: # @onlineCpus: The list of online logical CPUs fixed in version 4.16.7? Line 1144: # Line 1145: # @cpuSpeed:The speed of each CPU (in MHz) Line 1146: # Line 1147: # @cpuModel:The CPU model -- To view, visit http://gerrit.ovirt.org/34768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia41df1758e629dc1087416c1dad3fa4d115243fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Use ovirt node for persist files
Saggi Mizrahi has posted comments on this change. Change subject: utils: Use ovirt node for persist files .. Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33468/4/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 55: Line 56: try: Line 57: # If failing to import old code, then try importing the legacy code Line 58: from ovirtnode import ovirtfunctions Line 59: persist = ovirtfunctions.ovirt_store_config Should be persistFile Line 60: except ImportError: Line 61: try: Line 62: from ovirt.node.utils.fs import Config Line 63: persistFile = Config().persist -- To view, visit http://gerrit.ovirt.org/33468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice245d54497862f9fb86cb32acd13b8a790026b2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: caps: Report online logical CPUs
Yaniv Bronhaim has posted comments on this change. Change subject: caps: Report online logical CPUs .. Patch Set 1: Code-Review-1 please add added in version xxx next to the new attribute. both in master and the backport . thanks. -- To view, visit http://gerrit.ovirt.org/34768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia41df1758e629dc1087416c1dad3fa4d115243fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
Martin Polednik has posted comments on this change.
Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7a3bdb3cb2269e85e83d8c688582e61473f688f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Use ovirt node for persist files
Douglas Schilling Landgraf has posted comments on this change. Change subject: utils: Use ovirt node for persist files .. Patch Set 4: Code-Review-1 nice catch saggi -- To view, visit http://gerrit.ovirt.org/33468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice245d54497862f9fb86cb32acd13b8a790026b2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require latest version of IOProcess
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: require latest version of IOProcess .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/156/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/179/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/372/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6004/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/177/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/172/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4165/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic70d15fe0b9827707a51654e31327f7a50c479ac Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cache: Add caching decorator with invalidation
Saggi Mizrahi has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 4: Code-Review-1 Really sorry for bothering you again but you didn't update 'doc/infra/index.rst' to include you module in the list. -- To view, visit http://gerrit.ovirt.org/34709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dd8fb29d94286e3e3a3e29b8218501cbdc5c018 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cache: Add caching decorator with invalidation
Saggi Mizrahi has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 4: Also noticed it's under lib/vdsm and not lib/vdsm/infra where it should be -- To view, visit http://gerrit.ovirt.org/34709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dd8fb29d94286e3e3a3e29b8218501cbdc5c018 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hba: Rescan using SCSI layer
Saggi Mizrahi has posted comments on this change. Change subject: hba: Rescan using SCSI layer .. Patch Set 4: Code-Review-1 Original comments about writing to device directly from VDSM still not being addressed. -- To view, visit http://gerrit.ovirt.org/34245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7deb3047f1b75c4c65d59602b908835515290993 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hba: Parallel hba scanning
Saggi Mizrahi has posted comments on this change. Change subject: hba: Parallel hba scanning .. Patch Set 2: Code-Review-1 (1 comment) As I've already discussed. You can't have that be done in multiple threads. It's needlessly expensive and can get VDSM stuck in D state. http://gerrit.ovirt.org/#/c/34407/2/vdsm/storage/hba.py File vdsm/storage/hba.py: Line 63: Line 64: cond = threading.Condition(threading.Lock()) Line 65: scanning = [0] Line 66: Line 67: @utils.traceback(on=log.name) Don't use utils.traceback it's going away soon. Line 68: def scanner(path): Line 69: try: Line 70: log.debug(Scanning %s, path) Line 71: fd = os.open(path, os.O_WRONLY) -- To view, visit http://gerrit.ovirt.org/34407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bcd29551314a55bff2d2cc89f02f5c562f5d016 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: move nice ionice sid and sudo out of execCmd
Saggi Mizrahi has posted comments on this change. Change subject: utils: move nice ionice sid and sudo out of execCmd .. Patch Set 2: Code-Review-1 We are already doing work on moving those out of execCmd. dkuznets should have it up for review by monday and you can ask him for early access to drafts -- To view, visit http://gerrit.ovirt.org/33691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use utils.persist instead of importing ovirt-node Config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Use utils.persist instead of importing ovirt-node Config .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13370/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13209/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12419/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2daf816c08b8272fcac7bf6b3dd4571dc0b7852b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: change persistFile to persist
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: change persistFile to persist .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13372/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13210/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12420/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54cabe8976713169755933958d183eefbd4fac88 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add unpersist for symmetry
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add unpersist for symmetry .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13371/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13211/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12421/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61fffa6d65a655fa3cbe4342cc4ac7a0bf315129 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Use ovirt node for persist files
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Use ovirt node for persist files .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13373/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13212/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12422/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice245d54497862f9fb86cb32acd13b8a790026b2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: use utils.persist/unpersist instead of execcmd
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: use utils.persist/unpersist instead of execcmd .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13374/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13213/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12423/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab3e43b3f55ff562c35ceaf6ff83cf48119842be Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47.
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47. .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13375/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/562/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/544/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13214/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12424/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/2/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc1c30a157d6763674874113e62add82833bd070 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revised the format of output from the vdsm-tool vdsm-id comm...
Dan Kenigsberg has posted comments on this change. Change subject: Revised the format of output from the vdsm-tool vdsm-id command. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7379e969881931aaa4745dedf85ddfb61487f4a4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrew Dahms andrewjda...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...
Amador Pahim has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet .. Patch Set 17: -Verified (1 comment) setting rp_filter=2 from second session on will not work in some cases. http://gerrit.ovirt.org/#/c/31529/17/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 186: key = node.session. + key Line 187: iscsiadm.node_update(iface.name, portalStr, target.iqn, Line 188: key, value, hideValue=True) Line 189: Line 190: if iface.netIfaceName: +1 for loosening only on the second interface. I coded it (loosening only on the second interface) but had problems in my tests. If the first connection to iscsi happens through a device not expected by the OS as the device for that connection, the rp_filter=2 is needed for the first connection. I will improve this code, but I have to keep the rp_filter=2 for the first connection as well. Line 191: supervdsm.getProxy().setRpFilter(iface.netIfaceName, Line 192: _SYSCTL_RPFILTER_LOOSE) Line 193: Line 194: iscsiadm.node_login(iface.name, portalStr, target.iqn) -- To view, visit http://gerrit.ovirt.org/31529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: jian wang wjia...@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Use ovirt node for persist files
Douglas Schilling Landgraf has posted comments on this change. Change subject: utils: Use ovirt node for persist files .. Patch Set 5: Code-Review+1 jenkins issues doesn't seem related to the patch. == FAIL: testAmountOfInstancesPerPoolName (outOfProcessTests.OopWrapperTests) -- Traceback (most recent call last): File /home/jenkins/workspace/vdsm_master_unit-tests_created/vdsm/tests/outOfProcessTests.py, line 77, in testAmountOfInstancesPerPoolName self.assertEquals(wrapper(), None) AssertionError: module '?' (built-in) != None begin captured logging Storage.oop: WARNING: Cannot import IOProcess, set oop to use RFH - end captured logging - -- To view, visit http://gerrit.ovirt.org/33468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice245d54497862f9fb86cb32acd13b8a790026b2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: add function to create a new connection
Shahar Havivi has posted comments on this change. Change subject: libvirtconnection: add function to create a new connection .. Patch Set 9: Verified that the new open_connection is working with no parameters (the default) and with parameters with pending patch http://gerrit.ovirt.org/#/c/33309/ that is using with different credentials -- To view, visit http://gerrit.ovirt.org/34293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3481d56ee19afec14b36b98b412278148b26379e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make domain_descriptor.py API pep8-friendly
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make domain_descriptor.py API pep8-friendly .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13376/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13215/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12425/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1896/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/33672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aadabb0152966dae7da885b6933c440d6496f6d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...
Amador Pahim has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet .. Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/31529/17/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 186: key = node.session. + key Line 187: iscsiadm.node_update(iface.name, portalStr, target.iqn, Line 188: key, value, hideValue=True) Line 189: Line 190: if iface.netIfaceName: I coded it (loosening only on the second interface) but had problems in my Or, better, I will probe the os device using netinfo.getRouteDeviceTo() and set rp_filter=2 when os_device != netIfaceName OR len(sessions) = 1 Line 191: supervdsm.getProxy().setRpFilter(iface.netIfaceName, Line 192: _SYSCTL_RPFILTER_LOOSE) Line 193: Line 194: iscsiadm.node_login(iface.name, portalStr, target.iqn) -- To view, visit http://gerrit.ovirt.org/31529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: jian wang wjia...@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make domain_descriptor.py API pep8-friendly
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make domain_descriptor.py API pep8-friendly .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13377/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13216/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12426/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1897/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/33672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aadabb0152966dae7da885b6933c440d6496f6d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make domain_descriptor.py API pep8-friendly
Francesco Romani has posted comments on this change. Change subject: virt: make domain_descriptor.py API pep8-friendly .. Patch Set 5: Verified+1 rev 5, 6: rebased, fixed tests Verification: booted a few VMs without any surprise or errors spotted, so ticking V+1 -- To view, visit http://gerrit.ovirt.org/33672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aadabb0152966dae7da885b6933c440d6496f6d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: added NFS support to functional tests
Yoav Kleinberger has posted comments on this change. Change subject: tests: added NFS support to functional tests .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/32990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1781fc400c0604855d3143dde22ccb29e6cc8013 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: make link_cache optional for route_info
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link_cache optional for route_info .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13378/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13217/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12427/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2134/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/32950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I765cbe080f3bcff8b5d9f2eb48adf2be797d2f2f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: make link cache optional for link_info and addr_info
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link cache optional for link_info and addr_info .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13379/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13218/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12428/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2135/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/32949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e6aaac0bdb58a0052b25f588e11de03bde3e12f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: make link_cache optional for route_info
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link_cache optional for route_info .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13380/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13219/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12429/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2136/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/32950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I765cbe080f3bcff8b5d9f2eb48adf2be797d2f2f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: make link_cache optional for route_info
Petr Horáček has posted comments on this change. Change subject: libnl: make link_cache optional for route_info .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I765cbe080f3bcff8b5d9f2eb48adf2be797d2f2f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revised the format of output from the vdsm-tool vdsm-id comm...
mooli tayer has posted comments on this change. Change subject: Revised the format of output from the vdsm-tool vdsm-id command. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7379e969881931aaa4745dedf85ddfb61487f4a4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrew Dahms andrewjda...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: make link cache optional for link_info and addr_info
Petr Horáček has posted comments on this change. Change subject: libnl: make link cache optional for link_info and addr_info .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e6aaac0bdb58a0052b25f588e11de03bde3e12f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: migration: move wait countdown in a function
Francesco Romani has posted comments on this change. Change subject: vm: migration: move wait countdown in a function .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/32706/5//COMMIT_MSG Commit Message: Line 9: The Downtime thread is a migration helper thread Line 10: which is in charge of periodically updating the Line 11: migration downtime. Line 12: Line 13: This thread blindly does a configurabile number configurabile - configurable Done Line 14: of steps, and after each step it updates the Line 15: downtime according to a given law. Line 16: Line 17: Between each step, it waits for a number of http://gerrit.ovirt.org/#/c/32706/5/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 361: for i in range(steps): Line 362: yield int(offset + base ** i) Line 363: Line 364: Line 365: def linear_wait(mem_size, delay, steps): for me, calling the second arg delay_per_gib would improve readabilty. delay_per_gib is a good improvement, will do. Not really sure about hiding the parameter. It makes the function nicer to be called, but IMO this parameter is as much important as the memory size, so either both stay or both go. Since I'm not sure how to make them both go, I'll keep them for now. Line 366: wait = (delay * max(mem_size, 2048) + 1023) / 1024 Line 367: Line 368: for _ in range(steps): Line 369: yield wait / steps -- To view, visit http://gerrit.ovirt.org/32706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id808539a654e1556519ed54f6f4b67364eacf48a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: drop libnl-1 dependency
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: drop libnl-1 dependency .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13381/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/563/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/545/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13220/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12430/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2137/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/3/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a6fa58a79030d4d56bfec59b2c459830aa5e317 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: make link cache optional for link_info and addr_info
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link cache optional for link_info and addr_info .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13382/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13221/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12431/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2138/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/32949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e6aaac0bdb58a0052b25f588e11de03bde3e12f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 20: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13383/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/564/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/546/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13222/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12432/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2139/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/4/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23ea72986564c5a115e36be0e7cf679c28c8ea96 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make domain_descriptor.py API pep8-friendly
Francesco Romani has posted comments on this change. Change subject: virt: make domain_descriptor.py API pep8-friendly .. Patch Set 6: Verified+1 rev 5, 6: rebased, fixed tests Verification: booted a few VMs without any surprise or errors spotted, so ticking V+1 - in the right revision. -- To view, visit http://gerrit.ovirt.org/33672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aadabb0152966dae7da885b6933c440d6496f6d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: migration: move wait countdown in a function
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: migration: move wait countdown in a function .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13384/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13223/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12433/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1898/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/32706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id808539a654e1556519ed54f6f4b67364eacf48a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47.
Yaniv Bronhaim has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47. .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc1c30a157d6763674874113e62add82833bd070 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: remove redundant check.
Yaniv Bronhaim has posted comments on this change. Change subject: spec: remove redundant check. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50e1706e7f8c9b07b6788fbbabf61b40306801c3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: remove redundant 'Requires(X): policycoreutils-python'.
Yaniv Bronhaim has posted comments on this change. Change subject: spec: remove redundant 'Requires(X): policycoreutils-python'. .. Patch Set 1: Code-Review+1 :) thanks for the detailed explanation -- To view, visit http://gerrit.ovirt.org/34730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I293db914e41dde0020cf4da5b5f0b0723c3fac89 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Use ovirt node for persist and unpersist files
Nir Soffer has posted comments on this change. Change subject: utils: Use ovirt node for persist and unpersist files .. Patch Set 4: Why abandon? Do we have another patch replacing this? -- To view, visit http://gerrit.ovirt.org/31584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf19e5f8f5beca38d34a606c3eb370385dc206d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cache: Add caching decorator with invalidation
Nir Soffer has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 4: The module is currently not in the infra package, so there is no need to update doc/infra.rst. As I mentioned before, it is not clear how do you want to move this into infra, so we should do this later. For qemuimg module, which is the reason I added this utility, this works nicely as is, and we don't have any need to move this into the infra package. -- To view, visit http://gerrit.ovirt.org/34709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dd8fb29d94286e3e3a3e29b8218501cbdc5c018 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Antoni Segura Puimedon has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 20: Code-Review-1
(17 comments)
http://gerrit.ovirt.org/#/c/32626/20/lib/vdsm/netlink/__init__.py
File lib/vdsm/netlink/__init__.py:
Line 73: if err:
Line 74: _nl_socket_free(sock)
Line 75: raise IOError(-err, _nl_geterror())
Line 76:
Line 77: if callback_function:
is not None
Line 78: err = _nl_socket_modify_cb(sock, _NL_CB_DEFAULT, _NL_CB_CUSTOM,
Line 79:callback_function, None)
Line 80:
Line 81: err = _nl_connect(sock, _NETLINK_ROUTE)
Line 145:
Line 146: def _get_groups_codes(groups):
Line 147: groups_codes = []
Line 148: for g in groups:
Line 149: code = _KNOWN_GROUPS.get(g, None)
.get already has None as default value, no need to specify
Line 150: if not code:
Line 151: raise UnknownGroup
Line 152: groups_codes.append(code)
Line 153: return groups_codes
Line 146: def _get_groups_codes(groups):
Line 147: groups_codes = []
Line 148: for g in groups:
Line 149: code = _KNOWN_GROUPS.get(g, None)
Line 150: if not code:
if code is None
Line 151: raise UnknownGroup
Line 152: groups_codes.append(code)
Line 153: return groups_codes
Line 154:
Line 186:
Line 187: _nl_socket_alloc = CFUNCTYPE(c_void_p)(('nl_socket_alloc', LIBNL))
Line 188: _nl_socket_free = _none_proto(('nl_socket_free', LIBNL))
Line 189:
Line 190: _nl_msg_parse = _int_proto(('nl_msg_parse', LIBNL))
int nlmsg_parse(struct nlmsghdr * nlh, int hdrlen, struct nlattr * tb[],
int maxtype, struct nla_policy * policy)
So CFUNCTYPE for returning int and passing all these params above.
Line 191: _nl_socket_add_memberships = _int_proto(('nl_socket_add_memberships',
Line 192: LIBNL))
Line 193: _nl_socket_disable_seq_check =
_int_proto(('nl_socket_disable_seq_check',
Line 194:LIBNL))
Line 188: _nl_socket_free = _none_proto(('nl_socket_free', LIBNL))
Line 189:
Line 190: _nl_msg_parse = _int_proto(('nl_msg_parse', LIBNL))
Line 191: _nl_socket_add_memberships = _int_proto(('nl_socket_add_memberships',
Line 192: LIBNL))
this should have its own C prototype as it the C signature is:
int nl_socket_add_memberships(struct nl_sock * sk, int group, ... )
So you need the CFUNCTYPE with varargs of int type.
Line 193: _nl_socket_disable_seq_check =
_int_proto(('nl_socket_disable_seq_check',
Line 194:LIBNL))
Line 195: _nl_socket_drop_memberships =
_int_proto(('nl_socket_drop_memberships',
Line 196: LIBNL))
Line 196: LIBNL))
Line 197: _nl_socket_get_fd = _int_proto(('nl_socket_get_fd', LIBNL))
Line 198: _nl_socket_modify_cb = _int_proto(('nl_socket_modify_cb', LIBNL))
Line 199: _nl_object_get_type = _char_proto(('nl_object_get_type', LIBNL))
Line 200: _nl_recvmsgs_default = _int_proto(('nl_recvmsgs_default', LIBNL))
Review all of them.
Line 201:
Line 202: _nl_connect = CFUNCTYPE(c_int, c_void_p, c_int)(('nl_connect', LIBNL))
Line 203: _nl_geterror = CFUNCTYPE(c_char_p)(('nl_geterror', LIBNL))
Line 204:
http://gerrit.ovirt.org/#/c/32626/20/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 29: from addr import _addr_info
Line 30: from link import _link_info, _rtnl_link_alloc_cache
Line 31: from route import _route_info
Line 32:
Line 33: _STOP_QUEUE = 80
There should be an inline comment for knowing what this is.
Line 34:
Line 35:
Line 36: class MonitorError(Exception):
Line 37: pass
Line 65: decnet-ifaddr, decnet-route, ipv6-prefix
Line 66:
Line 67: def __init__(self):
Line 68: self.queue = Queue.Queue()
Line 69: self.thread = MonitorThread(self)
self._queue
self._thread
Don't pass self to the monitor Thread. better pass the Queue and other things
it needs here.
Line 70:
Line 71: def __iter__(self):
Line 72: try:
Line 73: while True:
Line 70:
Line 71: def __iter__(self):
Line 72: try:
Line 73: while True:
Line 74: if not self.thread.is_alive():
First process if it is alive, then the else.
Line 75: yield self.queue.get_nowait()
Line 76: else:
Line 77: value = self.queue.get()
Line 78: if value == _STOP_QUEUE:
Line 89: threading.Thread.__init__(self.thread)
Line 90: if not groups or 'all' in groups:
Line 91: self.groups = _KNOWN_GROUPS.keys()
Line 92: else:
Line 93: groups
Remove!
Line 94: self.groups = list(groups)
Change in vdsm[master]: hba: Parallel hba scanning
Nir Soffer has posted comments on this change. Change subject: hba: Parallel hba scanning .. Patch Set 2: (1 comment) Why do you think this is expensive? This also used only in supervdsm, so it cannot caused vdsm to get stuck. http://gerrit.ovirt.org/#/c/34407/2/vdsm/storage/hba.py File vdsm/storage/hba.py: Line 63: Line 64: cond = threading.Condition(threading.Lock()) Line 65: scanning = [0] Line 66: Line 67: @utils.traceback(on=log.name) Don't use utils.traceback it's going away soon. This utility is the standard way now to log unexpected exceptions in threads. Line 68: def scanner(path): Line 69: try: Line 70: log.debug(Scanning %s, path) Line 71: fd = os.open(path, os.O_WRONLY) -- To view, visit http://gerrit.ovirt.org/34407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bcd29551314a55bff2d2cc89f02f5c562f5d016 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hba: Rescan using SCSI layer
Nir Soffer has posted comments on this change. Change subject: hba: Rescan using SCSI layer .. Patch Set 4: This is addressed by the next patch. We can squash them if you like. -- To view, visit http://gerrit.ovirt.org/34245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7deb3047f1b75c4c65d59602b908835515290993 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...
Nir Soffer has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet .. Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/31529/17/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 186: key = node.session. + key Line 187: iscsiadm.node_update(iface.name, portalStr, target.iqn, Line 188: key, value, hideValue=True) Line 189: Line 190: if iface.netIfaceName: Or, better, I will probe the os device using netinfo.getRouteDeviceTo() and Can you describe in more details why changing the rpfilter does not work when adding the second session? How can we reproduce this issue? Line 191: supervdsm.getProxy().setRpFilter(iface.netIfaceName, Line 192: _SYSCTL_RPFILTER_LOOSE) Line 193: Line 194: iscsiadm.node_login(iface.name, portalStr, target.iqn) -- To view, visit http://gerrit.ovirt.org/31529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: jian wang wjia...@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device setup into __init__
Nir Soffer has posted comments on this change.
Change subject: vm: move device setup into __init__
..
Patch Set 4:
(8 comments)
The nature of the error is very clear, and it is easy to fix by iterating over
a copy of the keys or the values.
The solution you suggest is not clear.
http://gerrit.ovirt.org/#/c/34753/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2662
Line 2663
Line 2664
Line 2665
Line 2666
Up to here old code was changing devices which is a hierarchy of conf data,
I don't understand this comment - can you explain what the old code was doing,
and how the new code change it?
Line 2667
Line 2668
Line 2669
Line 2670
Line 2671
This makes the Device instances from Conf data, so they are created correct
So why did you remove it?
Line 1301: self._powerDownEvent = threading.Event()
Line 1302: self._liveMergeCleanupThreads = {}
Line 1303: self._shutdownReason = None
Line 1304:
Line 1305: self._diskMap = {}
When do we clear this cache? It looks like a temporary cache to speed up some
operation, but its exits for the entire life of the vm object - right?
Line 1306: self._setupDevices()
Line 1307:
Line 1308: def _get_lastStatus(self):
Line 1309: PAUSED_STATES = (vmstatus.POWERING_DOWN,
vmstatus.REBOOT_IN_PROGRESS,
Line 1302: self._liveMergeCleanupThreads = {}
Line 1303: self._shutdownReason = None
Line 1304:
Line 1305: self._diskMap = {}
Line 1306: self._setupDevices()
Adding more stuff to __init__ is not a good idea. Doing stuff in __init__ is
always fragile and make code harder to test.
Why we must do this here?
Line 1307:
Line 1308: def _get_lastStatus(self):
Line 1309: PAUSED_STATES = (vmstatus.POWERING_DOWN,
vmstatus.REBOOT_IN_PROGRESS,
Line 1310: vmstatus.UP)
Line 1518: return [{
Line 1519: 'type': GRAPHICS_DEVICES,
Line 1520: 'device': (
Line 1521: 'spice'
Line 1522: if self.conf.get('display') in ('qxl', 'qxlnc')
This seems unrelated to this patch.
Line 1523: else 'vnc'),
Line 1524: 'specParams': makeSpecParams(self.conf)}]
Line 1525:
Line 1526: def getConfSound(self):
Line 2654:
Line 2655: for devType, devClass in self.DeviceMapping:
Line 2656: for dev in devices[devType]:
Line 2657: devObj = devClass(self.conf, self.log, **dev)
Line 2658: self._devices[devType].append(devObj)
we need this _diskMap cache only to speedup updateDrivesFromConf below. Oth
We did not have this map before - why do we need it now?
Line 2659: if devType == DISK_DEVICES and isVdsmImage(dev):
Line 2660: self._diskMap[(dev['domainID'], dev['poolID'],
Line 2661:dev['imageID'], dev['volumeID'])]
= devObj
Line 2662:
Line 5377:
Line 5378: def getDiskDevicesConf(self):
Line 5379: for dev in self.conf['devices']:
Line 5380: if dev['type'] == DISK_DEVICES:
Line 5381: yield dev
This is not safe - while some code iterate over the list of devices using this
generator, the list may be modified by another thread.
It is better to avoid such code in multithreaded program.
The name also does not suggest that this is a generator. It looks like an
accessor.
Line 5382:
Line 5383: @property
Line 5384: def sdIds(self):
Line 5385:
Line 5401: if dev:
Line 5402: dev.path = drv['path']
Line 5403: dev.format = drv['format']
Line 5404: dev.apparentsize = drv['apparentsize']
Line 5405: dev.truesize = drv['truesize']
these are he fields (potentially) changed into lines 2667-2675
This code should be in the Drive class. If a drive need to be updated using a
dict, the drive should have an update(dict) method.
This will change this to:
for drive in drives:
drive.update(conf)
Line 5406: else:
Line 5407: self.log.error('missing Drive from conf: %s',
drv)
Line 5408:
Line 5409:
--
To view, visit http://gerrit.ovirt.org/34753
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e5a8e7916bb0c0d2519949397a5c1c64085e08e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt
Change in vdsm[master]: spec: remove redundant check.
mooli tayer has posted comments on this change. Change subject: spec: remove redundant check. .. Patch Set 2: verified on fe19: $ which hostname /bin/hostname $ rpm -qa vdsm vdsm-4.16.0-489.git6eac12d.el6.x86_64 $ cat /etc/redhat-release Red Hat Enterprise Linux Server release 6.6 (Santiago) Tomorrow I will verify on 21 just for kicks -- To view, visit http://gerrit.ovirt.org/34610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50e1706e7f8c9b07b6788fbbabf61b40306801c3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47.
Dan Kenigsberg has posted comments on this change.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47.
..
Patch Set 7: Code-Review-1
(1 comment)
-1 for visibility
http://gerrit.ovirt.org/#/c/33771/7/vdsm.spec.in
File vdsm.spec.in:
Line 89: BuildRequires: python-pthreading
Line 90: BuildRequires: qemu-img
Line 91: BuildRequires: rpm-python
Line 92: %if 0%{?rhel} == 6
Line 93: BuildRequires: policycoreutils-python 2.0.83-19.47
Don't we need this in build time also for Fedora?
Line 94: BuildRequires: python-argparse
Line 95: BuildRequires: python-ordereddict
Line 96: %endif
Line 97:
--
To view, visit http://gerrit.ovirt.org/33771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc1c30a157d6763674874113e62add82833bd070
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Ohad Basan oba...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: split slow disk access from normalization
Nir Soffer has posted comments on this change. Change subject: vm: split slow disk access from normalization .. Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34752/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1337: if 'device' not in drv: Line 1338: drv['device'] = 'disk' Line 1339: Line 1340: drv['truesize'] = 0 Line 1341: drv['apparentsize'] = 0 This is bad idea - this creates an unwanted state where disk size is set to 0, before the we call _getVdsmImgSizes. Another thread may access the wrong size and do the wrong thing based on this information. We should have only 2 states: 1. We don't know what the disk size because we did not check yet 2. We know the size Line 1342: Line 1343: def _getVdsmImgSizes(self, drv): Line 1344: if drv['device'] == 'disk': Line 1345: res = self.cif.irs.getVolumeSize(drv['domainID'], drv['poolID'], -- To view, visit http://gerrit.ovirt.org/34752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d8cb7a3c58e37540e56f4359aa67ea4dce875cc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
