Change in vdsm[ovirt-3.5]: vm: state change missing return value
Francesco Romani has posted comments on this change. Change subject: vm: state change missing return value .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: faster albeit less general deepcopy
Francesco Romani has posted comments on this change.
Change subject: utils: faster albeit less general deepcopy
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/34989/6/tests/utilsTests.py
File tests/utilsTests.py:
Line 644: self.assertEqual(utils.picklecopy(VM_STATUS_DUMP),
Line 645: copy.deepcopy(VM_STATUS_DUMP))
Line 646:
Line 647: def test_picklecopy_faster(self):
Line 648: stmt =
I would call this setup.
Done
Line 649: import copy
Line 650: from vdsm import utils
Line 651: import vmTestsData
Line 652:
http://gerrit.ovirt.org/#/c/34989/6/tests/vmTestsData.py
File tests/vmTestsData.py:
Line 228: 'device=ide, type=CONTROLLER, bootOrder=0, specParams={},
'
Line 229: 'address={bus=0x00, domain=0x, type=pci, slot=0x01, '
Line 230: 'function=0x1}, managed=false, plugged=true,
readOnly=false, '
Line 231: 'deviceAlias=ide0, customProperties={}, snapshotId=null, '
Line 232: 'logicalName=null}',
This looks wrong - are you sure the contents of the custom devices is corre
This is not the output of the first startup of a VM, hence Engine's stored
device data comes into play here. Most likely
this data becomes fancily mangled in the VDSM-Engine-DB path, but this is
just guesswork.
For the sake of this test, it doesn't really matter since the flow is identical
comparing all the call to status().
About the device name mangling, yes: this looks wrong but never heard reports
of malfunctioning due to this. Apparently this is there from a long time, I
remember to have it seen first in late 3.4 cycle.
I'd like to investigate that but because I never got report of failures even
vaguely related to this, it always slipped behind more urgent/important issues.
Line 233: 'device_4cf4bc50-87c6-44a1-b382-339929ed8350'
Line 234: 'device_bb36a3fe-5333-4a66-9708-ef7dc5dca461':
Line 235: 'VmDevice {vmId=56f693d4-2245-444a-a4e8-fcc5bbd08350, '
Line 236: 'deviceId=bb36a3fe-5333-4a66-9708-ef7dc5dca461, '
--
To view, visit http://gerrit.ovirt.org/34989
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I936a977e9f41863bdff18b9343d252ab0996d554
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: faster albeit less general deepcopy
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: faster albeit less general deepcopy .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13398/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12608/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1929/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/174/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13560/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I936a977e9f41863bdff18b9343d252ab0996d554 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: make link cache optional for link_info and addr_info
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link cache optional for link_info and addr_info .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13399/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12609/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2214/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/175/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13561/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e6aaac0bdb58a0052b25f588e11de03bde3e12f Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: make link_cache optional for route_info
Petr Horáček has posted comments on this change. Change subject: libnl: make link_cache optional for route_info .. Patch Set 11: i merged this patch into the previous one, could you please abandom? -- To view, visit http://gerrit.ovirt.org/32950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I765cbe080f3bcff8b5d9f2eb48adf2be797d2f2f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: make link cache optional for link/route/addr_info
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link cache optional for link/route/addr_info .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13400/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12610/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2215/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/176/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13562/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e6aaac0bdb58a0052b25f588e11de03bde3e12f Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: non-existing link exception
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: non-existing link exception .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13401/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12611/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2216/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/177/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13563/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cf5c7d1cb89bb77402b6e3d23fb0e76f06e122e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: ignore_enodev parameter in *_info
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: ignore_enodev parameter in *_info .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13402/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12612/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2217/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/178/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13564/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41dfc7178144ae35a6b5bb52c185a337c94138ba Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 35: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/597/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/578/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13403/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12613/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2218/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/36/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/32/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/179/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13565/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23ea72986564c5a115e36be0e7cf679c28c8ea96 Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: replace old ipwrapper event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: replace old ipwrapper event monitor .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13404/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12614/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2219/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/180/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13566/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7a9765e59a8392fff9b3fd556133159aeb60b1c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: make link cache optional for link/route/addr_info
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link cache optional for link/route/addr_info .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13405/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12615/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2220/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/181/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13567/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e6aaac0bdb58a0052b25f588e11de03bde3e12f Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: backport assertAlmostEqual
Francesco Romani has uploaded a new change for review. Change subject: tests: backport assertAlmostEqual .. tests: backport assertAlmostEqual vm migration tests depend on the 'delta' keyword argument of the assertAlmostEqual method. This patch adds the backport of this method, thus unbreaking the tests on python 2.6. Change-Id: I5fecc424fec13b01b4a9cdb81f576edb9887c3d3 Signed-off-by: Francesco Romani from...@redhat.com --- M tests/testlib.py 1 file changed, 41 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/35156/1 diff --git a/tests/testlib.py b/tests/testlib.py index 6fffb3c..553bd8c 100644 --- a/tests/testlib.py +++ b/tests/testlib.py @@ -200,6 +200,47 @@ safe_repr(container)) raise self.failureException(msg) +# FIXME: This is a forward port of the assertNotIn from python +#2.7, remove when no loger supporting earlier versions +# we need the 'delta' keyword argument, which was added in python 2.7 +def assertAlmostEqual(self, first, second, places=None, + msg=None, delta=None): +Fail if the two objects are unequal as determined by their + difference rounded to the given number of decimal places + (default 7) and comparing to zero, or by comparing that the + between the two objects is more than the given delta. + + Note that decimal places (from zero) are usually not the same + as significant digits (measured from the most signficant digit). + + If the two objects compare equal then they will automatically + compare almost equal. + +if first == second: +# shortcut +return +if delta is not None and places is not None: +raise TypeError(specify delta or places not both) + +if delta is not None: +if abs(first - second) = delta: +return + +standardMsg = '%s != %s within %s delta' % (safe_repr(first), +safe_repr(second), +safe_repr(delta)) +else: +if places is None: +places = 7 + +if round(abs(second-first), places) == 0: +return + +standardMsg = '%s != %s within %r places' % ( +safe_repr(first), safe_repr(second), places) +msg = self._formatMessage(msg, standardMsg) +raise self.failureException(msg) + class VdsmTestResult(result.TextTestResult): def __init__(self, *args, **kwargs): -- To view, visit http://gerrit.ovirt.org/35156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5fecc424fec13b01b4a9cdb81f576edb9887c3d3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: backport assertAlmostEqual
Francesco Romani has posted comments on this change. Change subject: tests: backport assertAlmostEqual .. Patch Set 1: Verified+1 run affected tests on RHEL 6.5, now they pass. -- To view, visit http://gerrit.ovirt.org/35156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fecc424fec13b01b4a9cdb81f576edb9887c3d3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: non-existing link exception
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: non-existing link exception .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13406/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12616/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2221/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/182/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13568/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cf5c7d1cb89bb77402b6e3d23fb0e76f06e122e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: backport assertAlmostEqual
Francesco Romani has posted comments on this change. Change subject: tests: backport assertAlmostEqual .. Patch Set 1: reason why this got unnoticed so far: - on automation, there is some noise already - 'make rpm' does not trigger 'make check' anymore - my deploy script was not updated to run 'make check' explicitely - now it is. -- To view, visit http://gerrit.ovirt.org/35156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fecc424fec13b01b4a9cdb81f576edb9887c3d3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: backport assertAlmostEqual
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: backport assertAlmostEqual .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13409/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12619/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/185/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13571/ : FAILURE -- To view, visit http://gerrit.ovirt.org/35156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fecc424fec13b01b4a9cdb81f576edb9887c3d3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: strip unneeded logging
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: strip unneeded logging .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13408/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12618/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/184/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13570/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c5bf3c85d105885ae5eee5024ae2f0b9f69f4f7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: non-existing link exception
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: non-existing link exception .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13407/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12617/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit// : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/183/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13569/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cf5c7d1cb89bb77402b6e3d23fb0e76f06e122e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: faster albeit less general deepcopy
Francesco Romani has posted comments on this change. Change subject: utils: faster albeit less general deepcopy .. Patch Set 7: Verified+1 verified with tests; we already pickle/unpickle to disk the very same data structure, so little worries about safety. Patched VDSMs survived multiple iteration of stress testing with no issues spotten. -- To view, visit http://gerrit.ovirt.org/34989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I936a977e9f41863bdff18b9343d252ab0996d554 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: switch to the simplejson module
Francesco Romani has posted comments on this change. Change subject: jsonrpc: switch to the simplejson module .. Patch Set 3: Verified+1 Ptched VDSMs survived multiple stress test iterations. as stated, 'json' stdlib module is based on simplejson module, plus API is the same, so little worries about possible breakages. -- To view, visit http://gerrit.ovirt.org/35024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic17aa6d75cef933ee36e002c03732aab14b39648 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: faster albeit less general deepcopy
Nir Soffer has posted comments on this change. Change subject: utils: faster albeit less general deepcopy .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I936a977e9f41863bdff18b9343d252ab0996d554 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support headless VM
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support headless VM .. Patch Set 17: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13410/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12620/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1930/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/186/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13572/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the agent file transfer
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 45: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/598/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/579/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13411/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12621/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1931/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/37/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/33/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/187/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13573/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4 Gerrit-PatchSet: 45 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: migration: move wait countdown in a function
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: migration: move wait countdown in a function .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13412/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12622/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1932/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/188/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13574/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id808539a654e1556519ed54f6f4b67364eacf48a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Bump multipath configuration version
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath: Bump multipath configuration version .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13413/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12623/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/189/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13575/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95aea50fb251bd6d22426fa63edbe4bbd770a06f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Fix booting from multipath device
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath: Fix booting from multipath device .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13414/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12624/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/190/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13576/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2fe9a609292f467b523cbc88141aa464386e15f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Fix booting from multipath device
Nir Soffer has posted comments on this change. Change subject: multipath: Fix booting from multipath device .. Patch Set 2: Verified+1 Verified that change does not cause regressions on RHEL 7 and 6.6 hosts. Tested flows - Create and remove a storage domain - Create and provision a vm - Update initramfs I cannot verify that booting from multipath device works since I don't have a system that can boot from multipath device. -- To view, visit http://gerrit.ovirt.org/34839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2fe9a609292f467b523cbc88141aa464386e15f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Bump multipath configuration version
Nir Soffer has posted comments on this change. Change subject: multipath: Bump multipath configuration version .. Patch Set 2: Verified+1 Verified that new multipath configuration is updated when installing on host with older vdsm version. -- To view, visit http://gerrit.ovirt.org/34840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95aea50fb251bd6d22426fa63edbe4bbd770a06f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hba: Rescan using SCSI layer
Adam Litke has posted comments on this change. Change subject: hba: Rescan using SCSI layer .. Patch Set 5: Code-Review+1 Looks good to me. The separate scanning process seems like a fine way to safely handle the blocking IO issues. Straightforward. -- To view, visit http://gerrit.ovirt.org/34245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7deb3047f1b75c4c65d59602b908835515290993 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the agent file transfer
Francesco Romani has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 45: Verified+1 No code changes since long time. Rebased, re-verifed using tests (new path) and in the old path after rebase to spot obvious regressions. -- To view, visit http://gerrit.ovirt.org/26917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4 Gerrit-PatchSet: 45 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the agent file transfer
Francesco Romani has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 45: Code-Review-1 need to sort out RHEL 7.x... -- To view, visit http://gerrit.ovirt.org/26917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4 Gerrit-PatchSet: 45 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multipath: add specific fail entry for emc-vnx
Federico Simoncelli has uploaded a new change for review.
Change subject: multipath: add specific fail entry for emc-vnx
..
multipath: add specific fail entry for emc-vnx
As few other storage arrays also the emc-vnx is forcing the
queue_if_no_path option on the multipath device.
This patch adds a specific section for the device maintaining
the emc defaults but forcing to fail the io instead of queuing.
In case of queuing we observed that the processes were blocked
on io and among other things it prevented the storage pool to
be reconstructed.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1098769
Change-Id: Icf5f4c89eac1273bf3a8e1afa300fec7b5b68eae
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/35072
Reviewed-by: Nir Soffer nsof...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
(cherry picked from commit 9880fdf9989718a097bb05571a6344e28c2f258b)
---
M vdsm/storage/multipath.py
1 file changed, 20 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/35179/1
diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py
index 68502ce..34573c2 100644
--- a/vdsm/storage/multipath.py
+++ b/vdsm/storage/multipath.py
@@ -53,8 +53,9 @@
OLD_TAGS = [# RHAT REVISION 0.2, # RHEV REVISION 0.3,
# RHEV REVISION 0.4, # RHEV REVISION 0.5,
# RHEV REVISION 0.6, # RHEV REVISION 0.7,
-# RHEV REVISION 0.8, # RHEV REVISION 0.9]
-MPATH_CONF_TAG = # RHEV REVISION 1.0
+# RHEV REVISION 0.8, # RHEV REVISION 0.9,
+# RHEV REVISION 1.0]
+MPATH_CONF_TAG = # RHEV REVISION 1.1
MPATH_CONF_PRIVATE_TAG = # RHEV PRIVATE
STRG_MPATH_CONF = (
\n\n
@@ -82,6 +83,23 @@
product \Compellent Vol\\n
no_path_retry fail\n
}\n
+device {\n
+# multipath.conf.default\n
+vendor \DGC\\n
+product \.*\\n
+product_blacklist \LUNZ\\n
+path_grouping_policy\group_by_prio\\n
+path_checker\emc_clariion\\n
+hardware_handler\1 emc\\n
+prio\emc\\n
+failbackimmediate\n
+rr_weight \uniform\\n
+# vdsm required configuration\n
+getuid_callout \%(scsi_id_path)s --whitelisted
+--replace-whitespace --device=/dev/%%n\\n
+features\0\\n
+no_path_retry fail\n
+}\n
}
)
MPATH_CONF_TEMPLATE = MPATH_CONF_TAG + STRG_MPATH_CONF
--
To view, visit http://gerrit.ovirt.org/35179
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf5f4c89eac1273bf3a8e1afa300fec7b5b68eae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multipath: add specific fail entry for emc-vnx
Federico Simoncelli has posted comments on this change. Change subject: multipath: add specific fail entry for emc-vnx .. Patch Set 1: Verified+1 Same as master. -- To view, visit http://gerrit.ovirt.org/35179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf5f4c89eac1273bf3a8e1afa300fec7b5b68eae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Simple jsonrpc client
Nir Soffer has uploaded a new change for review.
Change subject: contrib: Simple jsonrpc client
..
contrib: Simple jsonrpc client
This is a simple jsonrpc client for communicating with the jsonrpc
server from the command line.
Arguments
method one of the mehtods described in json schema
params optionl json object with message parameters
Examples
Calling method without arguements:
# jsonrpc Host.getVMList
{
jsonrpc: 2.0,
id: 0e043d83-294a-4d31-b1b6-6dc2f2747494,
result: [
b3f6fa00-b315-4ad4-8108-f73da817b5c5
]
}
Calling method with arguements:
# jsonrpc VM.getStats '{vmID: b3f6fa00-b315-4ad4-8108-f73da817b5c5}'
{
jsonrpc: 2.0,
id: cefd25a3-6250-4123-8a56-d7047899e19e,
result: [
{
status: Down,
exitMessage: Admin shut down from the engine,
vmId: b3f6fa00-b315-4ad4-8108-f73da817b5c5,
exitReason: 6,
timeOffset: 0,
exitCode: 0
}
]
}
Requires stomp.py library:
https://pypi.python.org/pypi/stomp.py
Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Signed-off-by: Nir Soffer nsof...@redhat.com
---
A contrib/jsonrpc
1 file changed, 104 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/35181/1
diff --git a/contrib/jsonrpc b/contrib/jsonrpc
new file mode 100755
index 000..3080193
--- /dev/null
+++ b/contrib/jsonrpc
@@ -0,0 +1,104 @@
+#!/usr/bin/python
+#
+# Copyright 2014 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+jsonrpc-cli - Vdsm jsonrpc client
+
+
+import json
+import os
+import signal
+import sys
+import time
+import uuid
+import optparse
+
+import stomp
+
+# Copied from lib/vdsm/vdscli.py
+PKIDIR = '/etc/pki/vdsm'
+KEYFILE = os.path.join(PKIDIR, 'keys/vdsmkey.pem')
+CERTFILE = os.path.join(PKIDIR, 'certs/vdsmcert.pem')
+CACERT = os.path.join(PKIDIR, 'certs/cacert.pem')
+
+PORT = 54321
+DESTINATION = /queue/_local/vdsm/requests
+
+
+class Listener(stomp.ConnectionListener):
+
+def on_error(self, headers, message):
+print 'Error: %s' % message
+terminate()
+
+def on_message(self, headers, message):
+msg = json.loads(message)
+print json.dumps(msg, indent=4)
+terminate()
+
+
+def main(args):
+parser = option_parser()
+options, args = parser.parse_args(args)
+if not args:
+parser.error(method required)
+
+msg = {
+id: str(uuid.uuid4()),
+jsonrpc: 2.0,
+method: args[0]
+}
+
+if len(args) 1:
+msg[params] = json.loads(args[1])
+
+conn = stomp.Connection10(
+host_and_ports=((options.host, PORT),),
+use_ssl=True,
+ssl_key_file=KEYFILE,
+ssl_cert_file=CERTFILE,
+ssl_ca_certs=CACERT)
+
+conn.set_listener(, Listener())
+conn.start()
+conn.send(body=json.dumps(msg), destination=DESTINATION)
+
+try:
+signal.pause()
+except KeyboardInterrupt:
+pass
+
+conn.disconnect()
+
+
+def option_parser():
+parser = optparse.OptionParser(usage='%prog [options] method [params]')
+parser.add_option(-a, --host, dest=host,
+ help=host address (default localhost))
+parser.set_defaults(host=localhost)
+return parser
+
+
+def terminate():
+os.kill(os.getpid(), signal.SIGINT)
+
+
+if __name__ == __main__:
+main(sys.argv[1:])
--
To view, visit http://gerrit.ovirt.org/35181
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Simple jsonrpc client
oVirt Jenkins CI Server has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13415/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12625/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/191/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13577/ : FAILURE -- To view, visit http://gerrit.ovirt.org/35181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Simple jsonrpc client
oVirt Jenkins CI Server has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13416/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12626/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/192/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13578/ : FAILURE -- To view, visit http://gerrit.ovirt.org/35181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multipath: add specific fail entry for emc-vnx
Dan Kenigsberg has posted comments on this change. Change subject: multipath: add specific fail entry for emc-vnx .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf5f4c89eac1273bf3a8e1afa300fec7b5b68eae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
