Candace Sheremeta has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 8: Verified+1
screenshot of output: http://i.imgur.com/YPwyCCI.png
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 8:
Screenshots are good for working on a gui, but when designing a text base
interface, text is
Candace Sheremeta has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 7:
(1 comment)
added quotes
https://gerrit.ovirt.org/#/c/37934/7/client/vdsClient.py
File
Candace Sheremeta has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 8:
Frankly, posting a clean image is better than text. It allows you to see
*exactly* what
Nir Soffer has posted comments on this change.
Change subject: tests: add more tests for custom error responses
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38665/3/tests/vmTests.py
File tests/vmTests.py:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16671/ :
Nir Soffer has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: networkTests: stop NetworkManager from managing devices using
NM_CONTROLLED=no
..
Patch Set 16:
Build Successful
Nir Soffer has posted comments on this change.
Change subject: storage: Remove validateStorageServerConnection
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38230
To unsubscribe, visit
Timothy Asir has posted comments on this change.
Change subject: gluster: Fetch disperse count and redundacy count for volume
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38305
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Fetch disperse count and redundacy count for volume
..
Patch Set 4:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: factor out _getUnderlying* methods to another class.
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16634/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
Patch Set 6:
Build Failed
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Fetch disperse count and redundacy count for volume
..
Patch Set 3:
(1 comment)
Timothy Asir has posted comments on this change.
Change subject: gluster: Fetch disperse count and redundacy count for volume
..
Patch Set 3: Verified-1
(1 comment)
Timothy Asir has posted comments on this change.
Change subject: gluster: Fetch disperse count and redundacy count for volume
..
Patch Set 3: -Verified Code-Review-1
--
To view, visit https://gerrit.ovirt.org/38305
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
Patch Set 6:
Build Failed
Timothy Asir has posted comments on this change.
Change subject: gluster: storage devices list provides device size in Mib
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38707
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py
File vdsm/API.py:
Line 1378:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: storage devices list provides device size in Mib
..
Patch Set 2:
Build Successful
Martin Peřina has posted comments on this change.
Change subject: host stats: Add number of in/out migrations
..
Patch Set 3: Verified+1
Updated schema definition of *VmMigrations to uint type.
IMO it doesn't make sense to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: host stats: Add number of in/out migrations
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16635/ : SUCCESS
Petr Horáček has posted comments on this change.
Change subject: network: persistence: skip bonds owned and used by vdsm
..
Patch Set 7: Verified+1
Solves problem in this reproduction
Timothy Asir has uploaded a new change for review.
Change subject: gluster: storage devices list provides device size in Mib
..
gluster: storage devices list provides device size in Mib
Currently it returns unit size along with
Timothy Asir has posted comments on this change.
Change subject: gluster: storage devices list provides device size in Mib
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38707/1/vdsm/gluster/storagedev.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: storage devices list provides device size in Mib
..
Patch Set 2:
(2 comments)
nits
https://gerrit.ovirt.org/#/c/38707/2//COMMIT_MSG
Commit Message:
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/2/vdsm/API.py
File vdsm/API.py:
Line 1378:
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 2: Code-Review-1
preliminary verification failed.
MOM also calls getVMList() without arguments.
Dan Kenigsberg has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/38679/3//COMMIT_MSG
Commit Message:
Line 33: wit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
Patch Set 6:
Build Successful
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/3/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16636/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: persistence: skip bonds owned and used by vdsm
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16638/
Ramesh N has posted comments on this change.
Change subject: gluster: storage devices list provides device size in Mib
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38707/1/vdsm/gluster/storagedev.py
File
Francesco Romani has uploaded a new change for review.
Change subject: spec: require MOM aware of 'onlyUUID'
..
spec: require MOM aware of 'onlyUUID'
We need a MOM capable to understand and cope
with the 'onlyUUID' parameter
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: require MOM aware of 'onlyUUID'
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/586/ :
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/38679/3//COMMIT_MSG
Commit Message:
Line 33: wit
Francesco Romani has posted comments on this change.
Change subject: virt: factor out _getUnderlying* methods to another class.
..
Patch Set 1:
(7 comments)
Very mixed feelings.
TL;DR: we need to find a better balance
Ido Barkan has posted comments on this change.
Change subject: openstacknet: add support for using the midonet plugin
..
Patch Set 6: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/36164/6//COMMIT_MSG
Commit Message:
Ido Barkan has posted comments on this change.
Change subject: virt: factor out _getUnderlying* methods to another class.
..
Patch Set 1:
(6 comments)
https://gerrit.ovirt.org/#/c/38704/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: storage devices list provides device size in Mib
..
Patch Set 1:
Build Successful
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py
File vdsm/API.py:
Line 1378:
Timothy Asir has posted comments on this change.
Change subject: gluster: storage devices list provides device size in Mib
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/38707
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: storage devices list provides device size in Mib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38707
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: factor out _getUnderlying* methods to another class.
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: spec: require MOM aware of 'onlyUUID'
..
Patch Set 2: Code-Review-1
this cannot be reviewed before a compatible mom patch (could you mention it in
the commit
Nir Soffer has posted comments on this change.
Change subject: image.py: reference exception as e when required
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38669
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vmdevices: test moving getUnderlying*Info
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38402/1/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: storage devices list provides device size in MiB
..
Patch Set 4:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: image.py: reference exception as e when required
..
Patch Set 2:
Build Failed
Dan Kenigsberg has submitted this change and it was merged.
Change subject: image.py: reference exception as e when required
..
image.py: reference exception as e when required
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: image.py: reference exception as e when required
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38669
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: openstacknet: add support for using the midonet plugin
..
Patch Set 7: Code-Review+1
(2 comments)
I'm convinced that this causes no regression o bridge and
Nir Soffer has posted comments on this change.
Change subject: lvm: Allow autobackup option in lvm module
..
Patch Set 7:
(2 comments)
Thanks Timothy! looks very nice.
Can you add simple tests for the functions you changed?
Francesco Romani has posted comments on this change.
Change subject: hostdev: fix detection of device vmId
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38668/2/vdsm/hostdev.py
File vdsm/hostdev.py:
Line 139:
Francesco Romani has posted comments on this change.
Change subject: host stats: Add number of in/out migrations
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38420
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: add more tests for custom error responses
..
Patch Set 3: Verified+1
v3 makes the code a bit nicer
--
To view, visit https://gerrit.ovirt.org/38665
Francesco Romani has uploaded a new change for review.
Change subject: virt: dev: move getUnderlyingDeviceAddress away
..
virt: dev: move getUnderlyingDeviceAddress away
make VmDevice._getUnderlyingDeviceAddress() a function
Francesco Romani has posted comments on this change.
Change subject: devices: move and rename getUnderlyingDeviceAddress
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/38714/2/vdsm/virt/vmxml.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16654/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16656/ :
Francesco Romani has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 9: Code-Review-1
after discussion on BZ, turns out we'll likely don't need this patch.
At very least,
Francesco Romani has posted comments on this change.
Change subject: api: use recommended logging
..
Patch Set 1: Code-Review-1
need to address Michal's comment. Point in case is: we do want to see that
message (do we?) but
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Remove JsonRpcClientPool
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16660/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16658/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16657/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: add ability to get dictionary directly from
JsonRpcRequest
..
Patch Set 8:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly log and return an error if the threadFactory
fails
..
Patch Set 7:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Optimize stomp encoder\decoder
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16662/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: parsing buffer refactoring
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16664/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: devices: move and rename getUnderlyingDeviceAddress
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/1/ :
Francesco Romani has abandoned this change.
Change subject: virt: dev: move getUnderlyingDeviceAddress away
..
Abandoned
obsoleted by 38714
--
To view, visit https://gerrit.ovirt.org/33749
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: devices: move and rename getUnderlyingDeviceAddress
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/38714/1/vdsm/virt/vmxml.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Have the protocol detector use the Reactor
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16653/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Pop the frame even if a frame handler isn't defined
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16655/
Francesco Romani has posted comments on this change.
Change subject: lib: introduce the 'response' module
..
Patch Set 12: Verified+1
verified with tests, both within this patch and in change 38665
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: api: make usage of doneCode uniform
..
Patch Set 1: Verified+1
trivial patch, verified with 'make check'
--
To view, visit https://gerrit.ovirt.org/38423
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and
set
..
Patch Set 7:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16663/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: dev: move getUnderlyingDeviceAddress away
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16839/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmdevices: move getUnderlyingSoundDevice to Sound device
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16667/ :
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/4/vdsm/API.py
File vdsm/API.py:
Line 1385:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: storage devices list provides device size in MiB
..
Patch Set 3:
Build Successful
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: persistence: skip bonds owned and used by vdsm
..
network: persistence: skip bonds owned and used by vdsm
When upgrading bonds to unified
Dan Kenigsberg has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/4/vdsm/API.py
File vdsm/API.py:
Line 1385:
Dan Kenigsberg has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37055
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: monitor: return whether the reported status is actual
..
monitor: return whether the reported status is actual
When the domain monitoring results are
oVirt Jenkins CI Server has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16642/ : SUCCESS
Timothy Asir has posted comments on this change.
Change subject: gluster: storage devices list provides device size in MiB
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/38707
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: marked headers as optional in ImageSharingMethodArgsHttp
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38145
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: marked headers as optional in ImageSharingMethodArgsHttp
..
vdsm: marked headers as optional in ImageSharingMethodArgsHttp
while inspecting the
Nir Soffer has posted comments on this change.
Change subject: lvm: Allow autobackup option in lvm module
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/38195/7//COMMIT_MSG
Commit Message:
Line 14: Also currently
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Fetch disperse count and redundacy count for volume
..
Patch Set 4:
(1 comment)
Nir Soffer has posted comments on this change.
Change subject: image.py: reference exception as e when required
..
Patch Set 1: Verified+1
Trivial, no verification needed.
--
To view, visit https://gerrit.ovirt.org/38669
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: openstacknet: add support for using the midonet plugin
..
Patch Set 7:
Build Failed
Timothy Asir has posted comments on this change.
Change subject: gluster: storage devices list provides device size in Mib
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/38707/2//COMMIT_MSG
Commit Message:
Line 3:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: require MOM aware of 'onlyUUID'
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/587/ :
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: storage devices list provides device size in MiB
..
gluster: storage devices list provides device size in MiB
Currently it returns unit size
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: storage devices list provides device size in MiB
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38707
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: spec: require MOM aware of 'onlyUUID'
..
Patch Set 2: Verified+1
verified on a RHEL7.0 host.
- installed patched (38709, 38710) MOM with version unofficially
1 - 100 of 131 matches
Mail list logo
