Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 1: Verified-1
It seems that one of ssl related patches was not backported to 3.6. Will push
Petr Horáček has abandoned this change.
Change subject: hooks: introduce before/after_get_stats hook points
..
Abandoned
OVS will not be backported to 3.5
--
To view, visit https://gerrit.ovirt.org/43274
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 4:
* Update tracker::#1234867::OK
--
To view, visit https://gerrit.ovirt.org/43149
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit
Petr Horáček has abandoned this change.
Change subject: net: bonding: validate options based on pre-dumped ones
..
Abandoned
OVS will not be backported to 3.5
--
To view, visit https://gerrit.ovirt.org/43148
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: net: bonding: validate options based on pre-dumped ones
..
Patch Set 3:
* Update tracker::#1234867::OK
--
To view, visit https://gerrit.ovirt.org/43148
Francesco Romani has uploaded a new change for review.
Change subject: v2v: Skip vm if XMLDesc() fails
..
v2v: Skip vm if XMLDesc() fails
The current code assumes that XMLDesc() always succeeds when dealing
foreign vms, which
automat...@ovirt.org has posted comments on this change.
Change subject: tests: proper cleanup in periodic tests
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/47361
To
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: Skip vm if XMLDesc() fails
..
Patch Set 1:
* Update tracker::#1266088::OK
* Check Bug-Url::OK
* Check Public Bug::#1266088::OK, public bug
* Check
Francesco Romani has abandoned this change.
Change subject: tests: proper cleanup in periodic tests
..
Abandoned
pushed by mistake
--
To view, visit https://gerrit.ovirt.org/47361
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Wait for udev events after unmounting
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47040
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: temporarily exclude few tests to restore CI
..
Patch Set 9:
Francesco, you should backport this instead:
https://gerrit.ovirt.org/46641
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: Fix vlan tagging missing XML node for sr-iov.
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47348
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vm: extract migration completion check
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/47086/3//COMMIT_MSG
Commit Message:
Line 6:
Martin Polednik has posted comments on this change.
Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor
and product id
..
Patch Set 11: Code-Review-1
not needed anymore due to built-in hostdev
automat...@ovirt.org has posted comments on this change.
Change subject: tests: proper cleanup in periodic tests
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: tests: v2v: add test for commit fb4c72a
..
Patch Set 2:
* Update tracker::#1265556::OK
* Check Bug-Url::OK
* Check Public Bug::#1265556::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: tests: v2v: add test for commit fb4c72a
..
Patch Set 2:
(2 comments)
Suggested way to simplify the mock.
https://gerrit.ovirt.org/#/c/47364/2/tests/v2vTests.py
Piotr Kliczewski has posted comments on this change.
Change subject: utils: Consider sleep time in deadline calculation
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46400
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 18:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has uploaded a new change for review.
Change subject: tests: v2v: refactor tests to make it extensible
..
tests: v2v: refactor tests to make it extensible
Refactor the current tests to make it easier to
add new
Francesco Romani has uploaded a new change for review.
Change subject: tests: v2v: add test for commit f8127d8
..
tests: v2v: add test for commit f8127d8
This patch adds a test to exercise the fix introduced in f8127d8
automat...@ovirt.org has posted comments on this change.
Change subject: tests: v2v: add test for commit fb4c72a
..
Patch Set 3:
* Update tracker::#1265556::OK
* Check Bug-Url::OK
* Check Public Bug::#1265556::OK, public bug
*
automat...@ovirt.org has posted comments on this change.
Change subject: tests: v2v: refactor tests to make it extensible
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: v2v: add test for commit f8127d8
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/45954/12/vdsm/virt/migration.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: introduce before/after_get_stats hook points
..
Patch Set 2:
* Update tracker::#1234867::OK
--
To view, visit https://gerrit.ovirt.org/43274
To
Petr Horáček has abandoned this change.
Change subject: network: allow custom bondOption
..
Abandoned
OVS will not be backported to 3.5
--
To view, visit https://gerrit.ovirt.org/43149
To unsubscribe, visit
Petr Horáček has abandoned this change.
Change subject: net: configurators: persist custom bond option
..
Abandoned
OVS will not be backported to 3.5
--
To view, visit https://gerrit.ovirt.org/44022
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: tests: proper cleanup in periodic tests
..
tests: proper cleanup in periodic tests
Make sure to wait for all the threads in periodicTests.tearDown, to
avoid
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: Fix getExternalVMs if getting disk size failed
..
Patch Set 1:
* Update tracker::#1265556::OK
* Check Bug-Url::OK
* Check Public Bug::#1265556::OK,
Francesco Romani has uploaded a new change for review.
Change subject: v2v: Fix getExternalVMs if getting disk size failed
..
v2v: Fix getExternalVMs if getting disk size failed
In getExternalVMs we try to report the disk size,
automat...@ovirt.org has posted comments on this change.
Change subject: tests: proper cleanup in periodic tests
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Roman Mohr has posted comments on this change.
Change subject: host stats: Add cpusStatus to vdsStats
..
Patch Set 7: Code-Review-1
Will add some kind of monitor
--
To view, visit https://gerrit.ovirt.org/46270
To
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2:
* Update tracker::#1256446::OK
* Check Bug-Url::OK
* Check Public Bug::#1256446::OK,
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2: Verified+1
Changes verified by building on local env.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2:
looks fine, giving some time to the other reviewers
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/47358
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: lvm: Check if device in VG before extend
..
lvm: Check if device in VG before extend
Before extending a VG, VDSM needs to check that none of
the
automat...@ovirt.org has posted comments on this change.
Change subject: lvm: Check if device in VG before extend
..
Patch Set 3:
* Update tracker::#1265907::OK
* Set MODIFIED::bug 1265907#1265907IGNORE, not oVirt prod
Francesco Romani has posted comments on this change.
Change subject: lvm: Check if device in VG before extend
..
Patch Set 2: Continuous-Integration+1
run CI tests manually.
--
To view, visit https://gerrit.ovirt.org/46651
Shahar Havivi has posted comments on this change.
Change subject: tests: v2v: add test for commit fb4c72a
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47364
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Fix and simplify cleanup after failures
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47326
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 18: Verified+1
Verified by build vdsm with --enable-m2c and with --disable-m2c to set default
Martin Polednik has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 12: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/45954/12/vdsm/virt/migration.py
File
Francesco Romani has posted comments on this change.
Change subject: tests: v2v: add test for commit fb4c72a
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/47364/2/tests/v2vTests.py
File tests/v2vTests.py:
Line
automat...@ovirt.org has posted comments on this change.
Change subject: tests: v2v: add test for commit fb4c72a
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has uploaded a new change for review.
Change subject: tests: v2v: add test for commit fb4c72a
..
tests: v2v: add test for commit fb4c72a
In commit fb4c72a we made sure to continue to extract VM information
if
automat...@ovirt.org has posted comments on this change.
Change subject: tests: proper cleanup in periodic tests
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: tests: v2v: add test for commit fb4c72a
..
Patch Set 2: Code-Review+1
(1 comment)
Nice, tiny cleanup would be even nicer.
Nir Soffer has posted comments on this change.
Change subject: tests: temporarily exclude few tests to restore CI
..
Patch Set 9: Code-Review-1
This patch was wrong on master. If you want to backport it, get also the patch
Piotr Kliczewski has abandoned this change.
Change subject: ssl: configurable implementation
..
Abandoned
Due to squashing this patch with https://gerrit.ovirt.org/#/c/44689/ we do not
need it anymore.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 18:
(1 comment)
Yaniv's comments fixed. Dan supports this approach.
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 18:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/44494
To
Martin Polednik has posted comments on this change.
Change subject: utils: Add @throttle decorator
..
Patch Set 4: Code-Review-1
(4 comments)
I see few minor issues within the test that unfortunately add up to -1, the
Martin Polednik has posted comments on this change.
Change subject: Fix vlan tagging missing XML node for sr-iov.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47349
To unsubscribe, visit
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 8:
ping
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: v2v: add test for commit fb4c72a
..
Patch Set 1: Verified+1
verified running the tests.
--
To view, visit https://gerrit.ovirt.org/47364
To
Nir Soffer has posted comments on this change.
Change subject: tests: Fix unsafe monkeypatching
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47208
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2: Code-Review+1
As this is a backport, why do we need to wait?
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Hidden files filtered form listings of storage domains
..
Patch Set 2:
* Update tracker::#1259279::OK
--
To view, visit
Jakub Niedermertl has abandoned this change.
Change subject: storage: Hidden files filtered form listings of storage domains
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/45645
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 3:
* Update tracker::#1256446::OK
* Set MODIFIED::bug 1256446#1256446IGNORE, not
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: increase call timeout to allow valid response
..
Patch Set 2: Code-Review-1
Why no to use 'timeout' in kwargs? We check for it in the code so we
automat...@ovirt.org has posted comments on this change.
Change subject: Fix vlan tagging missing XML node for sr-iov.
..
Patch Set 2:
* Update tracker::#1271697::OK
* Check Bug-Url::OK
* Check Public Bug::#1271697::OK, public
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Wait for udev events after unmounting
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47343
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 1: Verified+1
Patch verified on master so copying verification flag.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Fix and simplify cleanup after failures
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47342
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 4:
* Update tracker::#1256446::OK
* Set MODIFIED::bug 1256446#1256446IGNORE, not
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Skip test if mounting loop device failed
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Ido Barkan has uploaded a new change for review.
Change subject: Fix vlan tagging missing XML node for sr-iov.
..
Fix vlan tagging missing XML node for sr-iov.
This is an integration bug between the VDSM and RHEV-M. The vlanid
automat...@ovirt.org has posted comments on this change.
Change subject: Fix vlan tagging missing XML node for sr-iov.
..
Patch Set 1:
* Update tracker::#1271697::OK
* Check Bug-Url::OK
* Check Public Bug::#1271697::OK, public
automat...@ovirt.org has posted comments on this change.
Change subject: safelease: Increase spmprotect timeouts
..
Patch Set 3:
* Update tracker::#1265177::OK
* Set MODIFIED::bug 1265177#1265177IGNORE, not oVirt prod
automat...@ovirt.org has posted comments on this change.
Change subject: safelease: Unbreak safelease on systemd
..
Patch Set 3:
* Update tracker::#1265177::OK
* Set MODIFIED::bug 1265177#1265177IGNORE, not oVirt prod
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: safelease: Increase spmprotect timeouts
..
safelease: Increase spmprotect timeouts
When spmprotect.sh fail to renew the lease, it start a fencing
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: safelease: Unbreak safelease on systemd
..
safelease: Unbreak safelease on systemd
spmprotect.sh depends on Vdsm pid file for fencing Vdsm when the
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ssl: ssl socket may throw sslerror during reading
..
ssl: ssl socket may throw sslerror during reading
When client closes socket in not clean way
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46625
To unsubscribe, visit
Shmuel Leib Melamud has posted comments on this change.
Change subject: tests: Fix and simplify cleanup after failures
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47342
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: Fix vlan tagging missing XML node for sr-iov.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 8:
* Update tracker::#1264003::OK
* Check Bug-Url::OK
* Check Public Bug::#1264003::OK,
automat...@ovirt.org has posted comments on this change.
Change subject: hsm: lock pool when running upgradeStoragePool
..
Patch Set 6: -Verified
* Update tracker::#1269187::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: Fix vlan tagging missing XML node for sr-iov.
..
Patch Set 2:
* Update tracker::#1271697::OK
* Check Bug-Url::OK
* Check Public Bug::#1271697::OK, public
Ido Barkan has uploaded a new change for review.
Change subject: Fix vlan tagging missing XML node for sr-iov.
..
Fix vlan tagging missing XML node for sr-iov.
This is an integration bug between the VDSM and RHEV-M. The vlanid
automat...@ovirt.org has posted comments on this change.
Change subject: caps.py: import rpm only if available
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Ido Barkan has posted comments on this change.
Change subject: Fix vlan tagging missing XML node for sr-iov.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/47349
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Wait for udev events after unmounting
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47040
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: retry ifup if an error occured
..
Patch Set 5: Verified+1
Passed network functional tests.
--
To view, visit https://gerrit.ovirt.org/47327
To
Dan Kenigsberg has uploaded a new change for review.
Change subject: sysprep hook: unconfigure a vm clone
..
sysprep hook: unconfigure a vm clone
This hook lets you run virt-sysprep on the disk images of a VM
before it is first
Hello Piotr Kliczewski, Sandro Bonazzola, Shmuel Leib Melamud, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/47342
to review the following change.
Change subject: tests: Fix and simplify cleanup after failures
Ido Barkan has posted comments on this change.
Change subject: net: retry ifup if an error occured
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/47327/4/vdsm/network/configurators/ifcfg.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: Fix vlan tagging missing XML node for sr-iov.
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47348
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: test_rollback
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Petr Horáček has posted comments on this change.
Change subject: net: tests: test_rollback
..
Patch Set 7: Verified+1
Copying v+1, just changed a comment.
--
To view, visit https://gerrit.ovirt.org/46875
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 4:
* update_tracker: OK
* Set MODIFIED::bug 1258452#1258452IGNORE, not oVirt prod but
--
To
automat...@ovirt.org has posted comments on this change.
Change subject: net: retry ifup if an error occured
..
Patch Set 5:
* Update tracker::#1259468::OK
* Check Bug-Url::OK
* Check Public Bug::#1259468::OK, public bug
*
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vm.py: State saving in hotunplugDisk.
..
vm.py: State saving in hotunplugDisk.
VM's state was saved before detatching a disk in hotunplugDisk.
Saving
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 18: Code-Review-1
we agreed to change the implementation
--
To view, visit https://gerrit.ovirt.org/44494
To
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 17: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: sp: deactivateSd - remove domain from pending for upgrade list
..
Patch Set 8: -Verified
* Update tracker::#1269187::OK
* Check Bug-Url::OK
* Check
1 - 100 of 160 matches
Mail list logo
