Francesco Romani has submitted this change and it was merged.
Change subject: init: configure multipath on upgrade from ovirt-3.3 and 3.4
..
init: configure multipath on upgrade from ovirt-3.3 and 3.4
multipath configurator was
gerrit-hooks has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.3 and 3.4
..
Patch Set 3:
* #1290372::Update tracker: OK
* Set MODIFIED::bug 1290372#1290372OK
--
To v
Francesco Romani has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.3 and 3.4
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49510
To unsubscribe, vi
gerrit-hooks has posted comments on this change.
Change subject: Show debug message before action
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Show debug message before action
..
Show debug message before action
Print debug message before the action, in order to see it
when action fails
Chang
Dan Kenigsberg has posted comments on this change.
Change subject: Show debug message before action
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49368
To unsubscribe, visit https://gerrit.ovirt.org/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: Use tarfile instead of running tar process
..
v2v: Use tarfile instead of running tar process
using build-in package instead of execCmd.
Change-I
gerrit-hooks has posted comments on this change.
Change subject: v2v: Use tarfile instead of running tar process
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Ala Hino has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 2:
> Gerrit is not happy because you uploaded this when the master
> change was
gerrit-hooks has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 2: -Verified
* #1286565::Update tracker: OK
* Check Bug-Url::OK
* Check Publi
Jenkins CI has posted comments on this change.
Change subject: build: Add dependencies for generated .py files
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
Nir Soffer has posted comments on this change.
Change subject: build: Add dependencies for generated .py files
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50299
To unsubscribe, visit https://gerrit.ov
gerrit-hooks has posted comments on this change.
Change subject: build: Add dependencies for generated .py files
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Nir Soffer has uploaded a new change for review.
Change subject: build: Add dependencies for generated .py files
..
build: Add dependencies for generated .py files
In the past we checked .py.in files with pep8 and pyflakes. Rece
gerrit-hooks has posted comments on this change.
Change subject: build: Add dependencies for generated .py files
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Nir Soffer has posted comments on this change.
Change subject: v2v: refactor get_external_vms
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/49636/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 641: for vm i
Nir Soffer has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 17: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/
Nir Soffer has posted comments on this change.
Change subject: storage: perform image deletion in task
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/48477/4/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:
Line
Nir Soffer has posted comments on this change.
Change subject: v2v: Use tarfile instead of running tar process
..
Patch Set 4: Code-Review+2
Waiting for the test patch.
--
To view, visit https://gerrit.ovirt.org/50106
To unsu
Nir Soffer has posted comments on this change.
Change subject: v2v: test get_ova_info with tar zip and dir format
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/50158/4/tests/v2vTests.py
File tests/v2vTests.py:
Lin
Nir Soffer has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3: Code-Review+2
Can we have another review?
--
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 1: Code-Review-1
(3 comments)
Nice, the tests can be simplified.
https://gerrit.ovirt.org/#/c/50272
gerrit-hooks has posted comments on this change.
Change subject: build: Align Fedora and EL qemu requirements
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vi
Nir Soffer has submitted this change and it was merged.
Change subject: spec: Align RHEL and CentOS qemu* requiments
..
spec: Align RHEL and CentOS qemu* requiments
Since qemu-kvm-ev-2.3 is now build by the oVirt project, there
Nir Soffer has submitted this change and it was merged.
Change subject: build: Align Fedora and EL qemu requirements
..
build: Align Fedora and EL qemu requirements
Bump the Fedora requirement to 2.3.0 to better align Fedora an
gerrit-hooks has posted comments on this change.
Change subject: spec: Align RHEL and CentOS qemu* requiments
..
Patch Set 5:
* #1248400::Update tracker: OK
* Set MODIFIED::bug 1248400#1248400OK
--
To view, visit http
Nir Soffer has posted comments on this change.
Change subject: build: Align Fedora and EL qemu requirements
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50071
To unsubscribe, visit https://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: spec: Align RHEL and CentOS qemu* requiments
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49974
To unsubscribe, visit https://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: properties: Add properties module
..
Patch Set 6:
(8 comments)
https://gerrit.ovirt.org/#/c/40822/6/lib/vdsm/properties.py
File lib/vdsm/properties.py:
Line 119:
Nir Soffer has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 3:
(6 comments)
Nice, just need to cleanup up the tabs and fix the quoting.
https://gerrit.ovirt.org/
Nir Soffer has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 1: Code-Review-1
Gerrit is not happy because you uploaded this when the master
Nir Soffer has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 1:
Ala, correction, why gerrit hooks are unhappy.
--
To view, visit https://g
Nir Soffer has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 1: Code-Review+1
Ala, please check why jenkins in unhappy.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50263
To unsubscribe, visit https://gerrit
Nir Soffer has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 7:
Milan, can you document the delay (if qemu-guest-agent is not installed) in the
commit message and explain
Nir Soffer has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 25: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/48268/25/automation/check-merged.sh
File automation/check-mer
gerrit-hooks has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
Dan Kenigsberg has posted comments on this change.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Patch Set 1: Code-Review-1
Please first backport Iebc2e345877ff704b16af611edda404e2b773528 first and
include
Adam Litke has posted comments on this change.
Change subject: tests: refactor manifest_tests fake env setup
..
Patch Set 1: Verified+1
This patch only affects tests. Verified by running the manifest_tests.
--
To view, visit
Adam Litke has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 1: Verified+1
Verified by running unit tests. This is new code so there are not yet any
users.
--
Milan Zamazal has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40522
To unsubscribe, visit https://gerrit.ovi
Edward Haas has posted comments on this change.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Patch Set 1:
Please add the bug number in the commit.
--
To view, visit https://gerrit.ovirt.org/50270
To unsub
Edward Haas has posted comments on this change.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Patch Set 1: Verified+1
vdsm_install passes.
--
To view, visit https://gerrit.ovirt.org/50270
To unsubscribe, v
Francesco Romani has posted comments on this change.
Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
..
Patch Set 5:
(2 comments)
initial review
https://gerrit.ovirt.org/#/c/49505/5/vdsm/v2v.py
Fi
gerrit-hooks has posted comments on this change.
Change subject: tests: refactor manifest_tests fake env setup
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has uploaded a new change for review.
Change subject: tests: refactor manifest_tests fake env setup
..
tests: refactor manifest_tests fake env setup
The manifest_tests have a lot of boilerplate code to set up the fake
gerrit-hooks has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Adam Litke has uploaded a new change for review.
Change subject: storage: add a context manager for the domainLock
..
storage: add a context manager for the domainLock
Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Signed-
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 7:
After some discussion with Michal, we decided that the patch is probably fine
as it is for now. There's
Francesco Romani has posted comments on this change.
Change subject: v2v: extract specific classes for libvirt and ova
..
Patch Set 4:
(5 comments)
partial review, overall looks OK and less scary than the size suggests.
I'll h
Francesco Romani has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 17: Code-Review+2
seems OK, but I have this feeling I seen some similar changes elsewhere :\
Maybe I'm just
Francesco Romani has posted comments on this change.
Change subject: v2v: refactor get_external_vms
..
Patch Set 3:
-1 for visibility again, the concept is fine to me.
--
To view, visit https://gerrit.ovirt.org/49636
To unsub
Francesco Romani has posted comments on this change.
Change subject: v2v: refactor get_external_vms
..
Patch Set 3: Code-Review-1
(2 comments)
a patch purely moving code around would be ideal, but this is not terribly
importa
Jenkins CI has posted comments on this change.
Change subject: stomp: Drain pending bytes from ssl socket
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
--
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 7:
The delay doesn't make the VM unavailable (e.g. there should be no disruption
during migration because
Petr Balogh has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 1: Verified+1
Hello, I've already verified it on my 3.6 environment . If it is enough
consider it as
Francesco Romani has posted comments on this change.
Change subject: v2v: Use tarfile instead of running tar process
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50106
To unsubscribe, visit https://
Francesco Romani has posted comments on this change.
Change subject: v2v: test get_ova_info with tar zip and dir format
..
Patch Set 4: Code-Review+1
(2 comments)
If you have the chance to split the test like I suggested, this
gerrit-hooks has posted comments on this change.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url
Sagi Shnaidman has uploaded a new change for review.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Add vmfex-dev hook to default RPMs for install
Add vmfex-dev hook RPM to default ones in shell_helper for VDS
Francesco Romani has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 6:
looks good, please verify
--
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit htt
Francesco Romani has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.o
gerrit-hooks has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: stomp: make sure that subscriptions use uniqe id
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46656
To unsubscribe, visit https:/
Francesco Romani has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3: Code-Review+2
schema looks good now.
--
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50024
To unsubscribe, visit https://ger
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Add vmfex-dev hook to default RPMs for install
Add vmfex-dev hook RPM to default ones in shell_helper
gerrit-hooks has posted comments on this change.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Edward Haas has posted comments on this change.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Patch Set 2: Code-Review+1 Verified+1
--
To view, visit https://gerrit.ovirt.org/50024
To unsubscribe, visit htt
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Drain pending bytes from ssl socket
..
Patch Set 2:
The patch which caused the issue was not backported to 3.6 and we checked that
the problem do not
Francesco Romani has posted comments on this change.
Change subject: stomp: Drain pending bytes from ssl socket
..
Patch Set 2:
question: is this relevant even if b2da4effe01f was not backported (indeed it
seems we don't have
Ala Hino has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 1: Verified+1
Verified on master
--
To view, visit https://gerrit.ovirt.org/502
gerrit-hooks has posted comments on this change.
Change subject: stomp: Drain pending bytes from ssl socket
..
Patch Set 2:
* #1188543::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1188543::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 1: Code-Review+1
I usually require bugs for patches on stable branch, unless the patch does NOT
Nir Soffer has submitted this change and it was merged.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
gluster: Warn instead of failing for unsupported gluster replica modes
A previou
gerrit-hooks has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 10:
* #1286565::Update tracker: OK
* Set MODIFIED::bug 1286565#1286565:::
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: Drain pending bytes from ssl socket
..
stomp: Drain pending bytes from ssl socket
Since commit b2da4effe01f (asyncore: use default handing of read eve
gerrit-hooks has posted comments on this change.
Change subject: stomp: Drain pending bytes from ssl socket
..
Patch Set 1:
* #1274670::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1274670::OK, public bug
* Check
Adam Litke has posted comments on this change.
Change subject: properties: Add properties module
..
Patch Set 6:
(6 comments)
Very nice!
https://gerrit.ovirt.org/#/c/40822/6/tests/propertiesTests.py
File tests/propertiesTests
gerrit-hooks has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net: remove business logic out of CachingNetInfo
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-ur
Petr Balogh has uploaded a new change for review.
Change subject: code coverage: change approach how to enable it
..
code coverage: change approach how to enable it
Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Signed-off
Nir Soffer has posted comments on this change.
Change subject: storage: Introduction to transfer.py
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/50014/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json
Ido Barkan has uploaded a new change for review.
Change subject: net: add documentation for setupNetworks rollback mechanism.
..
net: add documentation for setupNetworks rollback mechanism.
Since Ifcfg is both the default implem
gerrit-hooks has posted comments on this change.
Change subject: net: add documentation for setupNetworks rollback mechanism.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: drop initial bonds' slaves IP config
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/50100/3/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
F
Amit Aviram has posted comments on this change.
Change subject: storage: Introduction to transfer.py
..
Patch Set 2:
(30 comments)
https://gerrit.ovirt.org/#/c/50014/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.js
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: rename _set/drop/remove_ip_config functions
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: rename _set/drop/remove_ip_config functions
..
hooks: ovs: rename _set/drop/remove_ip_config functions
Make difference between _drop_ip_config, _remo
gerrit-hooks has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 1: Verified-1
* #1286565::Update tracker: OK
* Check Bug-Url::OK
* Check Publ
Ala Hino has uploaded a new change for review.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
gluster: Warn instead of failing for unsupported gluster replica modes
A previous patch en
Ala Hino has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/50119
To unsubscribe, v
gerrit-hooks has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 9:
* #1286565::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#12
gerrit-hooks has posted comments on this change.
Change subject: ovs: super: tests: draft
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: use network lib instead of hardcoded path hack
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
gerrit-hooks has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Marek Libra has posted comments on this change.
Change subject: migration: track and report abort reason
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49525
To unsubscribe, visit https://gerrit.ovirt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo: report whether the kernel supports IPv6
..
netinfo: report whether the kernel supports IPv6
Change-Id: I1f16c9cf56f25509d4d5c6b6006da122bb287c
gerrit-hooks has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
1 - 100 of 170 matches
Mail list logo
