Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 23: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

2015-12-13 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: VolumeMetadata: Move getInfo and getVolumeParams .. Patch Set 24: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41999 To unsubscribe, visit https://

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-13 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/50372/1/vdsm/virt/vm.py File vds

Change in vdsm[master]: fileUtils: Convert unhelpful warnings to debug messages

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: fileUtils: Convert unhelpful warnings to debug messages .. Patch Set 9: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1129587::ERROR, private bug

Change in vdsm[master]: fileUtils: Warn about callers of fileUtils.createdir()

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: fileUtils: Warn about callers of fileUtils.createdir() .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: caps/lib: move CPU architecture details to lib/cpuarch .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/49972/2/lib/vdsm/Makefile.am File lib/vdsm/Makefile

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 1: Needs rebase? -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit https:

Change in vdsm[master]: service: change vdsm KillMode to mixed

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: Code-Review-1 (1 comment) Looks correct the commit message is not clear enough. https://gerrit.ovirt.org/#/

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: caps/lib: move CPU architecture details to lib/cpuarch .. Patch Set 2: (7 comments) Looks like a good change but: - Moving code from caps to cpuarch, we must elimi

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 22: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: service: change vdsm KillMode to mixed

2015-12-13 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: Code-Review+1 Hi Oved, I was wondering if the patch sill valid as it's old one or if it's go

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: hooks: ovs: drop initial bonds' slaves IP config .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50100 To unsubscribe, visit https://gerr

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: caps/lib: move CPU architecture details to lib/cpuarch .. Patch Set 2: Code-Review-1 (8 comments) Partial review. https://gerrit.ovirt.org/#/c/49972/2/lib/vdsm/cp

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 21: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50270 To unsubscribe, visit https://gerrit

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: VolumeMetadata: move validateDelete

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: move validateDelete .. Patch Set 23: Code-Review-1 - Move method without indirection (possible breakage) - Add indirection tests -- To view, visit

Change in vdsm[master]: VolumeMetadata: move validateDelete

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move validateDelete .. Patch Set 23: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move getInfo and getVolumeParams .. Patch Set 24: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41999 To unsubscribe, visit https://gerr

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move getInfo and getVolumeParams .. Patch Set 24: This version: - Add 2 missing redirections, one (getVmVolumeInfo) should be needed, used while pr

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move getInfo and getVolumeParams .. Patch Set 24: Verified+1 Verified using LSM and live merge with iscsi and nfs disks. -- To view, visit https:/

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getInfo and getVolumeParams .. Patch Set 24: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: image: Make progress report interval configurable

2015-12-13 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: image: Make progress report interval configurable .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch

Change in vdsm[master]: VolumeMetadata: move getVolumeSize and getVolumeTrueSize

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: move getVolumeSize and getVolumeTrueSize .. Patch Set 24: Verified+1 Verifed using LSM and live merge with iscsi and nfs storage. -- To view, visi

Change in vdsm[master]: VolumeMetadata: move getVolumeSize and getVolumeTrueSize

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: move getVolumeSize and getVolumeTrueSize .. Patch Set 24: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41998 To unsubscribe, visit http

Change in vdsm[master]: image: Make progress report interval configurable

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: image: Make progress report interval configurable .. Patch Set 2: Verified+1 Verified using lsm. -- To view, visit https://gerrit.ovirt.org/50405 To unsubscribe,

Change in vdsm[master]: image: Make progress report interval configurable

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: image: Make progress report interval configurable .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: image: Make progress report internal configurable

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: image: Make progress report internal configurable .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: image: Make progress report internal configurable

2015-12-13 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: image: Make progress report internal configurable .. image: Make progress report internal configurable Previously we logged a progress report every 60 seconds duri

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/48672/17/vdsm/v2v.py File vdsm/v2v.py: Line 646: raise L

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 17: (2 comments) https://gerrit.ovirt.org/#/c/48672/17/vdsm/v2v.py File vdsm/v2v.py: Line 647: seen = set

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 17: Code-Review-1 (2 comments) Fake libvirt connection looks wrong. https://gerrit.ovirt.org/#/c/48672/17/tests/v

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/49952/4/tox.ini File tox.ini: Line 2: envlist = py27 Lin

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/49952/4/vdsm.spec.in File vdsm.spec.in: Line 94 Line 95

Change in vdsm[master]: vdsm.conf: Add drop-in dir

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/48317/6/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 464: Line 465:

Change in vdsm[master]: storage: Introduction to transfer.py

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Introduction to transfer.py .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/50014/2/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json

Change in vdsm[master]: spec: Remove the lib64 vdsm python directory

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Remove the lib64 vdsm python directory .. Patch Set 2: Dan, Yaniv? -- To view, visit https://gerrit.ovirt.org/50115 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 4: (7 comments) https://gerrit.ovirt.org/#/c/49952/4/automation/check-patch.packages File automation/c

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Warn about missing glusterfs-cli package .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/50363/4/vdsm/gluster/cli.py File vdsm/gluster/cli.py: L

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-13 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Correctly apply MTU values on networks .. net: Correctly apply MTU values on networks Two issues have been resolved by this change: - New networks with no M

Change in vdsm[master]: net: Correctly apply MTU values on networks

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: Add tests for get_ova_info .. Patch Set 6: (3 comments) Nice! https://gerrit.ovirt.org/#/c/50158/6/tests/v2vTests.py File tests/v2vTests.py: Line 374:

Change in vdsm[master]: spec: Remove the lib64 vdsm python directory

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Remove the lib64 vdsm python directory .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50115/2/vdsm.spec.in File vdsm.spec.in: Line 338: Line 339:

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Warn about missing glusterfs-cli package .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/50363/4/vdsm/storage/storageServer.py File vdsm/storage/

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Warn about missing glusterfs-cli package .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/50363/4//COMMIT_MSG Commit Message: Line 3: AuthorDate:

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Warn about missing glusterfs-cli package .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/50363/4/vdsm/storage/storageServer.py File

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 4: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 3 -- To

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: Warn about missing glusterfs-cli package .. Patch Set 4: * #1290997::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1290997::OK, public bug

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/49438 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 4: -Verified * #1284412::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1284412::OK, public bug

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 3: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is req

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread shavivi
Shahar Havivi has restored this change. Change subject: v2v: add try/except to get_external_vms .. Restored -- To view, visit https://gerrit.ovirt.org/49438 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-Messa

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread shavivi
Shahar Havivi has abandoned this change. Change subject: v2v: add try/except to get_external_vms .. Abandoned -- To view, visit https://gerrit.ovirt.org/49438 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-Mes

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 2: * #1284412::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/49438 To unsubscribe, visit ht

Change in vdsm[master]: spec: Remove the lib64 vdsm python directory

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: Remove the lib64 vdsm python directory .. Patch Set 2: * #1279167::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279167::OK, public bug * Che

Change in vdsm[master]: spec: Remove the lib64 vdsm python directory

2015-12-13 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: spec: Remove the lib64 vdsm python directory .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/50115/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2

Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-13 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: Add tests for get_ova_info .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/50158 To unsubscribe, visit https://gerrit.ovirt.org/setti

Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: Add tests for get_ova_info .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 4: * #1182088::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1182088::OK, public bug *

Change in vdsm[master]: v2v: test get_ova_info with via zip input

2015-12-13 Thread shavivi
Shahar Havivi has abandoned this change. Change subject: v2v: test get_ova_info with via zip input .. Abandoned -- To view, visit https://gerrit.ovirt.org/50377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-M

Change in vdsm[master]: v2v: test get_ova_info with via tar input

2015-12-13 Thread shavivi
Shahar Havivi has abandoned this change. Change subject: v2v: test get_ova_info with via tar input .. Abandoned -- To view, visit https://gerrit.ovirt.org/50376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-M

Change in vdsm[master]: v2v: test get_ova_info with via zip input

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: test get_ova_info with via zip input .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/50377 To unsubsc

Change in vdsm[master]: v2v: test get_ova_info with via tar input

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: test get_ova_info with via tar input .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/50376 To unsubsc

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2015-12-13 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 3: (6 comments) https://gerrit.ovirt.org/#/c/49952/3/tox.ini File tox.ini: Line 3: skipsdist = true

Change in vdsm[master]: vdsm.conf: Add drop-in dir

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 6: Code-Review-1 (5 comments) Needs tests, remove stuff vdsm does not need. https://gerrit.ovirt.org/#/c/48317/6/lib/vdsm/

Change in vdsm[master]: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR .. Patch Set 2: Code-Review+1 I don't understand the original shell script, so removing half of it sounds like a good

Change in vdsm[master]: v2v: add try/except to get_external_vms

2015-12-13 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: v2v: add try/except to get_external_vms .. v2v: add try/except to get_external_vms Single domain error causes get_external_vms to fail. Change-Id: Iec

Change in vdsm[master]: v2v: add try/except to get_external_vms

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit h

Change in vdsm[master]: vdsm.conf: Add drop-in dir

2015-12-13 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 6: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/48317/6/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Li

Change in vdsm[master]: vdsm.conf: Add drop-in dir

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 6: * #1279555::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279555::OK, public bug * Check Product::#12795

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

2015-12-13 Thread ahino
Ala Hino has posted comments on this change. Change subject: gluster: Warn about missing glusterfs-cli package .. Patch Set 3: > (1 comment) exec the command and check the return code ? def gluster_exists(): rc, out, err = ut

Change in vdsm[master]: [WIP] vdsm standard CI arrangement

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: [WIP] vdsm standard CI arrangement .. Patch Set 25: (2 comments) https://gerrit.ovirt.org/#/c/48268/25/automation/check-merged.sh File automation/check-merged.sh:

Change in vdsm[master]: v2v: test get_ova_info with via directory input

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: test get_ova_info with via directory input .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/50158/4/tests/v2vTests.py File tests/v2vTests.py: Line 35

Change in vdsm[master]: v2v: test get_ova_info with via tar input

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: test get_ova_info with via tar input .. Patch Set 1: Code-Review-1 Should be squashed back into previous patch, see inline comments. -- To view, visit https:

Change in vdsm[master]: v2v: test get_ova_info with via zip input

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: test get_ova_info with via zip input .. Patch Set 1: Code-Review-1 Should be squashed back into first patch, see my comment in the previous patch. -- To view

Change in vdsm[master]: v2v: test get_ova_info with via tar input

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: test get_ova_info with via tar input .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/50376/1/tests/v2vTests.py File tests/v2vTests.py: Line 366:

Change in vdsm[master]: [WIP] vdsm standard CI arrangement

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: [WIP] vdsm standard CI arrangement .. Patch Set 27: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: vdsm standard CI arrangement

2015-12-13 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm standard CI arrangement .. Patch Set 25: still trying to fix all errors now we're on - libvirtError: Cannot access backing file '/var/lib/lago/store/phx_

Change in vdsm[master]: vdsm standard CI arrangement

2015-12-13 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm standard CI arrangement .. Patch Set 25: (2 comments) https://gerrit.ovirt.org/#/c/48268/25/automation/check-merged.sh File automation/check-merged.sh: L

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Warn about missing glusterfs-cli package .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/50363/3/vdsm/gluster/cli.py File vdsm/gluster/cli.py: L

Change in vdsm[master]: hsm: organize imports.

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hsm: organize imports. .. Patch Set 1: (7 comments) https://gerrit.ovirt.org/#/c/50373/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 20 Line 21 Line 22 Lin

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

2015-12-13 Thread ahino
Ala Hino has posted comments on this change. Change subject: gluster: Warn about missing glusterfs-cli package .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/50363/3/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Lin

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Warn about missing glusterfs-cli package .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/50363/3/vdsm/gluster/cli.py File vdsm/gluster/cli.py: L

Change in vdsm[master]: try to configure sebool after upgrade

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: try to configure sebool after upgrade .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Warn about missing glusterfs-cli package .. Patch Set 3: Code-Review-1 The issue is not warning the admin but backward compatibility. If gluster is not av

Change in vdsm[master]: hsm: organize imports.

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hsm: organize imports. .. Patch Set 1: Code-Review-1 We do not depend on specific tool for organizing imports, in particular non-free tools. Please do no mention

Change in vdsm[ovirt-3.6]: Include vmfex-dev-hook in vdsm install

2015-12-13 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Include vmfex-dev-hook in vdsm install .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50378 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-13 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 2: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/50270 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-13 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50270 To unsubscribe, visit https://ger

Change in vdsm[ovirt-3.6]: spec: Align RHEL and CentOS qemu* requiments

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Align RHEL and CentOS qemu* requiments .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50368 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: fc-scan: Use utilities from vdsm library.

2015-12-13 Thread nsoffer
Nir Soffer has restored this change. Change subject: fc-scan: Use utilities from vdsm library. .. Restored -- To view, visit https://gerrit.ovirt.org/38466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-Messag

Change in vdsm[master]: vm: Cleanup waiting for xml update

2015-12-13 Thread nsoffer
Nir Soffer has restored this change. Change subject: vm: Cleanup waiting for xml update .. Restored -- To view, visit https://gerrit.ovirt.org/39938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType:

Change in vdsm[master]: lib: Revert and refine error handling in tmap()

2015-12-13 Thread nsoffer
Nir Soffer has restored this change. Change subject: lib: Revert and refine error handling in tmap() .. Restored -- To view, visit https://gerrit.ovirt.org/39211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-

Change in vdsm[ovirt-3.6]: Include vmfex-dev-hook in vdsm install

2015-12-13 Thread sshnaidm
Sagi Shnaidman has posted comments on this change. Change subject: Include vmfex-dev-hook in vdsm install .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50378 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[ovirt-3.6]: Include vmfex-dev-hook in vdsm install

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Include vmfex-dev-hook in vdsm install .. Patch Set 1: * #1286997::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1286997::OK, public bug * Check Pro

Change in vdsm[ovirt-3.6]: Include vmfex-dev-hook in vdsm install

2015-12-13 Thread sshnaidm
Sagi Shnaidman has uploaded a new change for review. Change subject: Include vmfex-dev-hook in vdsm install .. Include vmfex-dev-hook in vdsm install Force installation of vmfex-dev hook together with VDSM main package Change-I

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 2: * #1286997::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1286997::OK, public bug * C

Change in vdsm[master]: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR

2015-12-13 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/50109 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: v2v: test get_ova_info with via zip input

2015-12-13 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: test get_ova_info with via zip input .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50377 To unsubscribe, visit https://gerrit.ovirt

  1   2   >