Change in vdsm[master]: machinetype: update naming

[fromani]

Francesco Romani has posted comments on this change.

Change subject: machinetype: update naming
..


Patch Set 2:

Dan, I'm just not sure this falls in the virt kingdom, I'll be more than happy 
to own it (+2) but I don't want to step into other people's toes :)

-- 
To view, visit https://gerrit.ovirt.org/54298
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ce7596a1dbf0a565ba3665eda6e9b3a6fc3d56d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt-sparsify: add inplace virt-sparsify support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt-sparsify: add inplace virt-sparsify support
..


Patch Set 1: Code-Review-1

Please change the patch to do the needed changes in the current sparsify verb.

-- 
To view, visit https://gerrit.ovirt.org/54427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a1269d71816a8ab25c4a00bfb483620cfefde8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Remove sparsify from vdsm

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Remove sparsify from vdsm
..


Patch Set 1: Code-Review-1

Looking at the replacement patch, this is not the right way to add the new 
sparsify.

You should change the way the current verb is implemented, using the current 
code.

- Change the arguments in the schema, hsm, sp, image
- Change the way we call virtsparcify

No other change is wanted.

So the best would be to leave the current code as is, and add a small patch on 
top of it simplifying the implementation.

-- 
To view, visit https://gerrit.ovirt.org/54426
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2b86035b6cc6ec74a403c3379d0b384fb6f23e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Utkarsh Singh 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: message tracking do not clean properly

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: message tracking do not clean properly
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/48616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ca7c7589fea2d7ad5a477123b14df17924fda0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: message tracking do not clean properly

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: stomp: message tracking do not clean properly
..


stomp: message tracking do not clean properly

We track message id and to know where to send message response but we
failed to clean tracking map when a response was sent.

Change-Id: Ic2ca7c7589fea2d7ad5a477123b14df17924fda0
Signed-off-by: pkliczewski 
Reviewed-on: https://gerrit.ovirt.org/48616
Reviewed-by: Yeela Kaplan 
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M lib/yajsonrpc/stompreactor.py
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yeela Kaplan: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/48616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2ca7c7589fea2d7ad5a477123b14df17924fda0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: message tracking do not clean properly

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: stomp: message tracking do not clean properly
..


Patch Set 5: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/48616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ca7c7589fea2d7ad5a477123b14df17924fda0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/network: fix hostdevChangeNumvfs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev/network: fix hostdevChangeNumvfs
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd24545ee2d81913fcd5c57bc85ebd26a2dc784f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/network: fix hostdevChangeNumvfs

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hostdev/network: fix hostdevChangeNumvfs
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd24545ee2d81913fcd5c57bc85ebd26a2dc784f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/network: fix hostdevChangeNumvfs

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: hostdev/network: fix hostdevChangeNumvfs
..


hostdev/network: fix hostdevChangeNumvfs

9888e5c3 hidden the change of name of supervdsm call ChangeNumvfs to
change_numvfs. This patch corrects the mistake.

Change-Id: Icd24545ee2d81913fcd5c57bc85ebd26a2dc784f
Signed-off-by: Martin Polednik 
Reviewed-on: https://gerrit.ovirt.org/54488
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/hostdev.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Martin Polednik: Verified



-- 
To view, visit https://gerrit.ovirt.org/54488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd24545ee2d81913fcd5c57bc85ebd26a2dc784f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network caps now reports IPv6 autoconf state

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Network caps now reports IPv6 autoconf state
..


Patch Set 2: Code-Review+1

I see that dnsmasq support various kinds of router advertisement. 

Preferably in a follow-up patch, please modify testSetupNetworksAddDelDhcp to 
test whether the new flag is correctly reported.

-- 
To view, visit https://gerrit.ovirt.org/54475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If91083ec3502a2679328e92aa63699d16c77df71
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Remove sparsify from vdsm

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove sparsify from vdsm
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54426
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2b86035b6cc6ec74a403c3379d0b384fb6f23e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Utkarsh Singh 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Rename canonize to canonicalize

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Rename canonize to canonicalize
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54464
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36bbd2623fdc6e911f8c7cecfa09a4eb623924c4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Rename canonize to canonicalize

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Rename canonize to canonicalize
..


net: Rename canonize to canonicalize

Change-Id: I36bbd2623fdc6e911f8c7cecfa09a4eb623924c4
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/54464
Continuous-Integration: Jenkins CI
Reviewed-by: Ondřej Svoboda 
Reviewed-by: Dan Kenigsberg 
---
M debian/vdsm.install
M lib/vdsm/netconfpersistence.py
M lib/vdsm/network/Makefile.am
M lib/vdsm/network/api.py
R lib/vdsm/network/canonicalize.py
M tests/network/config_network_test.py
M vdsm.spec.in
7 files changed, 23 insertions(+), 23 deletions(-)

Approvals:
  Ondřej Svoboda: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/54464
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I36bbd2623fdc6e911f8c7cecfa09a4eb623924c4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Rename canonize to canonicalize

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Rename canonize to canonicalize
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54464
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36bbd2623fdc6e911f8c7cecfa09a4eb623924c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: machinetype: update naming

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: machinetype: update naming
..


Patch Set 2: Code-Review+1

Francesco, please elaborate your worries regarding this change. I find it ok.

-- 
To view, visit https://gerrit.ovirt.org/54298
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ce7596a1dbf0a565ba3665eda6e9b3a6fc3d56d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Rename canonize to canonicalize

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: net: Rename canonize to canonicalize
..


Patch Set 1: Code-Review+1

Thanks! :-)

-- 
To view, visit https://gerrit.ovirt.org/54464
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36bbd2623fdc6e911f8c7cecfa09a4eb623924c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6.3]: restore-nets: disable IPv6 based on ifcfg files

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
..


Patch Set 3: Verified+1

To be applied before https://gerrit.ovirt.org/#/c/54478/

IPv6 was disabled after reboot on a NIC-only network and on a bridged one. 
There was no regression in functional tests, but these are currently broken on 
3.6.3:

testDhcpReplaceNicWithBridge (fails sometimes),
testSetupNetworksAddDelDhcp (non-bridged),
testSetupNetworksEmergencyDevicesCleanupVlanOverwrite(False).

-- 
To view, visit https://gerrit.ovirt.org/54362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.3
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6.3]: network: skip non-existent devices in _restore_disable_ipv6

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: network: skip non-existent devices in _restore_disable_ipv6
..


Patch Set 1: Verified+1

To be applied after https://gerrit.ovirt.org/#/c/54362/

IPv6 was disabled after reboot on a NIC-only network and on a bridged one. 
There was no regression in functional tests, but these are currently broken on 
3.6.3:

testDhcpReplaceNicWithBridge (fails sometimes),
testSetupNetworksAddDelDhcp (non-bridged),
testSetupNetworksEmergencyDevicesCleanupVlanOverwrite(False).

-- 
To view, visit https://gerrit.ovirt.org/54478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08fcd502093507b7ad5a080da181d0c88a442f1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.3
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt-sparsify: add inplace virt-sparsify support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt-sparsify: add inplace virt-sparsify support
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54427/1/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:

Line 501: 'Volume_getInfo': {'ret': 'info'},
Line 502: 'Volume_getPath': {'ret': 'path'},
Line 503: 'Volume_getSize': {'ret': Volume_getsize_Ret},
Line 504: 'Volume_extendSize': {'ret': 'uuid'},
Line 505: 'Volume_sparsifyInplace': {},
You don't need to provide an entry for empty return value.
Line 506: 'Host_getAllTasks': {'ret': 'tasks'},
Line 507: 'Host_getJobs': {'ret': 'jobs'},
Line 508: }
Line 509: 


-- 
To view, visit https://gerrit.ovirt.org/54427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a1269d71816a8ab25c4a00bfb483620cfefde8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/network: fix hostdevChangeNumvfs

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: hostdev/network: fix hostdevChangeNumvfs
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd24545ee2d81913fcd5c57bc85ebd26a2dc784f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt-sparsify: add inplace virt-sparsify support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt-sparsify: add inplace virt-sparsify support
..


Patch Set 1:

(5 comments)

https://gerrit.ovirt.org/#/c/54427/1/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 8275
Line 8276
Line 8277
Line 8278
Line 8279
Unrelated


Line 8711:   'storagedomainID': 'UUID', 'imageID': 'UUID',
Line 8712:   'legality': 'VolumeLegality'}}
Line 8713: 
Line 8714: ##
Line 8715: # @Volume.sparsifyInplace:
Should be:

@Volume.sparsify
Line 8716: #
Line 8717: # Perform an in-place sparse (e.g. not creating a new image) on 
given volume
Line 8718: #
Line 8719: # @volumeID:The UUID of the Volume


Line 8715: # @Volume.sparsifyInplace:
Line 8716: #
Line 8717: # Perform an in-place sparse (e.g. not creating a new image) on 
given volume
Line 8718: #
Line 8719: # @volumeID:The UUID of the Volume
Use the new style names as used by new sdm verbs:

vol_id
pool_id
dom_id
img_id

See SDM.create_volume.

In new verbs, we do not use the pool id - but I'm not sure we can avoid this in 
4.0. Adding Adam to review this.

Also, the order of the parameter must be:

pool > domain > image > volume

Old verbs are a mess, lest not repeat these errors.
Line 8720: #
Line 8721: # @storagepoolID:   The UUID of the image that contains the volume
Line 8722: #
Line 8723: # @storagedomainID: The Storage Pool UUID associated with the Volume


Line 8925: # @SDM:
Line 8926: #
Line 8927: # This namespace is for SDM (storage domain manager) functions.
Line 8928: #
Line 8929: # Since: 4.19
How is this change related to your patch?!

This original version is correct, 4.18 is the next version (ovirt-4.0)
Line 8930: ##
Line 8931: {'class': 'SDM'}
Line 8932: 
Line 8933: ##


https://gerrit.ovirt.org/#/c/54427/1/lib/vdsm/Makefile.am
File lib/vdsm/Makefile.am:

Line 62:udevadm.py \
Line 63:utils.py \
Line 64:v2v.py \
Line 65:vdscli.py \
Line 66:virtsparsify.py \
This is not a wrapper for virt-sparcify, so we should not call it 
virt-sparcify. It it the implementation of Vdsm's sparcify() verb, so the 
module name should be sparcify.py
Line 67:xmlrpc.py \
Line 68:$(NULL)
Line 69: 
Line 70: nodist_vdsmpylib_PYTHON = \


-- 
To view, visit https://gerrit.ovirt.org/54427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a1269d71816a8ab25c4a00bfb483620cfefde8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt-sparsify: add inplace virt-sparsify support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt-sparsify: add inplace virt-sparsify support
..


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/54427/1/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.py:

Line 34: _VIRTSPARSIFY = utils.CommandPath("virt-sparsify",
Line 35:   "/usr/bin/virt-sparsify",)
Line 36: 
Line 37: 
Line 38: def inplace(sdUUID, spUUID, imgUUID, volUUID, irs):
> virtsparsify.inplace() is nice, but since this starts a sparcify job, why n
Or better, provide the job class, and let the caller manage the job - I don't 
see the value of managing the jobs from this module.
Line 39: """
Line 40: Sparsify the volume in place
Line 41: (instead of copying from an input disk to an output disk)
Line 42: """


Line 39: """
Line 40: Sparsify the volume in place
Line 41: (instead of copying from an input disk to an output disk)
Line 42: """
Line 43: job = InplaceJob(volUUID, imgUUID, sdUUID, spUUID, irs)
> irs should be the second parameter, after the missing job_id
Actually we don't need irs, the image should be prepared and teardown like any 
other image related verbs in storage.
Line 44: job.start()
Line 45: jobs.add(job)
Line 46: 
Line 47: 


https://gerrit.ovirt.org/#/c/54427/1/tests/Makefile.am
File tests/Makefile.am:

Line 107:   schemaValidationTest.py \
Line 108:   sdm_indirection_tests.py \
Line 109:   securableTests.py \
Line 110:   sourceroutingTests.py \
Line 111:   sparsifyTests.py \
New test modules must be named now module_test.py
Line 112:   sslTests.py \
Line 113:   stompAdapterTests.py \
Line 114:   stompAsyncClientTests.py \
Line 115:   stompAsyncDispatcherTests.py \


https://gerrit.ovirt.org/#/c/54427/1/vdsm/API.py
File vdsm/API.py:

Line 893:self._imgUUID, self._UUID, 
legality)
Line 894: 
Line 895: def sparsifyInplace(self):
Line 896: return virtsparsify.inplace(self._sdUUID, self._spUUID,
Line 897: self._imgUUID, self._UUID, 
self._irs)
This should call irs.sparcify_image().

The implementation should be in lib/vdsm/storage/sparcify.py
Line 898: 
Line 899: 
Line 900: class Image(APIBase):
Line 901: ctorArgs = ['imageID', 'storagepoolID', 'storagedomainID']


-- 
To view, visit https://gerrit.ovirt.org/54427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a1269d71816a8ab25c4a00bfb483620cfefde8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt-sparsify: add inplace virt-sparsify support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt-sparsify: add inplace virt-sparsify support
..


Patch Set 1:

(7 comments)

This is storage code, should be in the lib/vdsm/storage package, and the entry 
point should be in hsm.py, like sdm_create_volume.

https://gerrit.ovirt.org/#/c/54427/1/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.py:

Line 34: _VIRTSPARSIFY = utils.CommandPath("virt-sparsify",
Line 35:   "/usr/bin/virt-sparsify",)
Line 36: 
Line 37: 
Line 38: def inplace(sdUUID, spUUID, imgUUID, volUUID, irs):
virtsparsify.inplace() is nice, but since this starts a sparcify job, why not:

start_sparcify_job()

Also, we *must* get the job id here, and jobs.Job must get the a job id as the 
first parameter.
Line 39: """
Line 40: Sparsify the volume in place
Line 41: (instead of copying from an input disk to an output disk)
Line 42: """


Line 39: """
Line 40: Sparsify the volume in place
Line 41: (instead of copying from an input disk to an output disk)
Line 42: """
Line 43: job = InplaceJob(volUUID, imgUUID, sdUUID, spUUID, irs)
irs should be the second parameter, after the missing job_id
Line 44: job.start()
Line 45: jobs.add(job)
Line 46: 
Line 47: 


Line 44: job.start()
Line 45: jobs.add(job)
Line 46: 
Line 47: 
Line 48: def delete_inplace_job(job_id):
delete_job
Line 49: return jobs.delete(job_id)
Line 50: 
Line 51: 
Line 52: def abort_inplace_job(job_id):


Line 48: def delete_inplace_job(job_id):
Line 49: return jobs.delete(job_id)
Line 50: 
Line 51: 
Line 52: def abort_inplace_job(job_id):
abort_job
Line 53: return jobs.abort(job_id)
Line 54: 
Line 55: 
Line 56: @contextmanager


Line 56: @contextmanager
Line 57: def volume(volUUID, imgUUID, sdUUID, spUUID, irs):
Line 58: res = irs.prepareImage(sdUUID, spUUID, imgUUID, volUUID)
Line 59: if response.is_error(res):
Line 60: raise Exception('Cannot find volume path for %r' % volUUID)
Should raise public exception, we cannot raise bare Exception.
Line 61: try:
Line 62: yield res['path']
Line 63: finally:
Line 64: try:


Line 61: try:
Line 62: yield res['path']
Line 63: finally:
Line 64: try:
Line 65: irs.teardownImage(sdUUID, spUUID, imgUUID)
This never raises, it fail with a failure status code like prepare image.
Line 66: except Exception:
Line 67: logging.exception('Error tearing down image: %r', imgUUID)
Line 68: raise
Line 69: 


Line 64: try:
Line 65: irs.teardownImage(sdUUID, spUUID, imgUUID)
Line 66: except Exception:
Line 67: logging.exception('Error tearing down image: %r', imgUUID)
Line 68: raise
This seems to repeat code in v2v - maybe we need to more this decorator to 
common location.
Line 69: 
Line 70: 
Line 71: class InplaceJob(jobs.Job):
Line 72: def __init__(self, volUUID, imgUUID, sdUUID, spUUID, irs):


-- 
To view, visit https://gerrit.ovirt.org/54427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a1269d71816a8ab25c4a00bfb483620cfefde8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/network: fix hostdevChangeNumvfs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev/network: fix hostdevChangeNumvfs
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd24545ee2d81913fcd5c57bc85ebd26a2dc784f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/network: fix hostdevChangeNumvfs

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: hostdev/network: fix hostdevChangeNumvfs
..

hostdev/network: fix hostdevChangeNumvfs

9888e5c3 hidden the change of name of supervdsm call ChangeNumvfs to
change_numvfs. This patch corrects the mistake.

Change-Id: Icd24545ee2d81913fcd5c57bc85ebd26a2dc784f
Signed-off-by: Martin Polednik 
---
M lib/vdsm/hostdev.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/54488/1

diff --git a/lib/vdsm/hostdev.py b/lib/vdsm/hostdev.py
index 6ba3189..bae9baf 100644
--- a/lib/vdsm/hostdev.py
+++ b/lib/vdsm/hostdev.py
@@ -242,5 +242,5 @@
 
 def change_numvfs(device_name, numvfs):
 net_name = physical_function_net_name(device_name)
-supervdsm.getProxy().changeNumvfs(name_to_pci_path(device_name), numvfs,
-  net_name)
+supervdsm.getProxy().change_numvfs(name_to_pci_path(device_name), numvfs,
+   net_name)


-- 
To view, visit https://gerrit.ovirt.org/54488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd24545ee2d81913fcd5c57bc85ebd26a2dc784f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Remove sparsify from vdsm

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Remove sparsify from vdsm
..


Patch Set 1: Code-Review+1

Adding Allon to confirm this

-- 
To view, visit https://gerrit.ovirt.org/54426
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2b86035b6cc6ec74a403c3379d0b384fb6f23e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Don't fail connect server when getting volume info

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Don't fail connect server when getting volume info
..


Patch Set 12: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/53785
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Don't fail connect server when getting volume info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Don't fail connect server when getting volume info
..


Patch Set 13:

* #1303977::Update tracker: OK
* Set MODIFIED::bug 1303977#1303977OK

-- 
To view, visit https://gerrit.ovirt.org/53785
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Don't fail connect server when getting volume info

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: gluster: Don't fail connect server when getting volume info
..


gluster: Don't fail connect server when getting volume info

When connecting to gluster server, we check volume info in order
to validate replica count. However, if gluster server is not
available, we get an exception and fail the operation. This patch
catches the thrown exception and logs a warning message indicating
that we got error when tried to connect to gluster server.

Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc
Bug-Url: https://bugzilla.redhat.com/1303977
Signed-off-by: Ala Hino 
Reviewed-on: https://gerrit.ovirt.org/53785
Continuous-Integration: Jenkins CI
Reviewed-by: Freddy Rolland 
Reviewed-by: Sahina Bose 
Reviewed-by: Nir Soffer 
---
M tests/storageServerTests.py
M vdsm/storage/storageServer.py
2 files changed, 41 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Sahina Bose: Looks good to me, but someone else must approve
  Freddy Rolland: Looks good to me, but someone else must approve
  Ala Hino: Verified



-- 
To view, visit https://gerrit.ovirt.org/53785
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move storage_exception module to lib

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Move storage_exception module to lib
..


Patch Set 6:

(7 comments)

Mostly looks good, but the new module should be:

lib/vdsm/storage/exception.py

https://gerrit.ovirt.org/#/c/54467/6/debian/vdsm-python.install
File debian/vdsm-python.install:

Line 61: ./usr/lib/python2.7/dist-packages/vdsm/sslutils.py
Line 62: ./usr/lib/python2.7/dist-packages/vdsm/storage/__init__.py
Line 63: ./usr/lib/python2.7/dist-packages/vdsm/storage/constants.py
Line 64: ./usr/lib/python2.7/dist-packages/vdsm/storage/securable.py
Line 65: ./usr/lib/python2.7/dist-packages/vdsm/storage/storage_exception.py
Since we are renaming the file (moving), this is good time to rename it to 
exception.py. We don't want to have another patch, changing all the imports 
from:

from vdsm.storage import storage_exception as se

To:

from vdsm.storage import exception as se

And verify it once now.
Line 66: ./usr/lib/python2.7/dist-packages/vdsm/supervdsm.py
Line 67: ./usr/lib/python2.7/dist-packages/vdsm/taskset.py
Line 68: ./usr/lib/python2.7/dist-packages/vdsm/tool/__init__.py
Line 69: ./usr/lib/python2.7/dist-packages/vdsm/tool/dummybr.py


https://gerrit.ovirt.org/#/c/54467/6/lib/vdsm/storage/Makefile.am
File lib/vdsm/storage/Makefile.am:

Line 24: dist_vdsmstorage_PYTHON = \
Line 25:__init__.py \
Line 26:constants.py \
Line 27:securable.py \
Line 28:storage_exception.py \
exception.py


https://gerrit.ovirt.org/#/c/54467/6/tests/blockVolumeTests.py
File tests/blockVolumeTests.py:

Line 19: #
Line 20: 
Line 21: 
Line 22: from vdsm.config import config
Line 23: from vdsm.storage import storage_exception as se
from vdsm.storage import exception as se

Same for all other imports.
Line 24: 
Line 25: from storage.blockVolume import BlockVolume
Line 26: from storage import volume
Line 27: from testlib import permutations, expandPermutations


https://gerrit.ovirt.org/#/c/54467/6/tests/main.py
File tests/main.py:

Line 22
Line 23
Line 24
Line 25
Line 26
The storage import should be here.


Line 22: import unittest
Line 23: 
Line 24: from gluster import exception as gluster_exception
Line 25: 
Line 26: from vdsm.storage import storage_exception
Lets do like gluster here:

from vdsm.storage import exception as storage_exception

And move it after the next import
Line 27: from vdsm.exception import GeneralException
Line 28: 
Line 29: from testlib import VdsmTestCase as TestCaseBase
Line 30: 


https://gerrit.ovirt.org/#/c/54467/6/vdsm/storage/storage_mailbox.py
File vdsm/storage/storage_mailbox.py:

Line 27
Line 28
Line 29
Line 30
Line 31
Here


Line 34: import sd
Line 35: import misc
Line 36: import task
Line 37: from threadPool import ThreadPool
Line 38: from vdsm.storage.storage_exception import InvalidParameterException
This should move under vdsm.config import.
Line 39: from vdsm import concurrent
Line 40: from vdsm import constants
Line 41: 
Line 42: __author__ = "ayalb"


-- 
To view, visit https://gerrit.ovirt.org/54467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network caps now reports IPv6 autoconf state

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Network caps now reports IPv6 autoconf state
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If91083ec3502a2679328e92aa63699d16c77df71
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move storage_exception module to lib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Move storage_exception module to lib
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move storage_exception module to lib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Move storage_exception module to lib
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move storage_exception module to lib

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: storage: Move storage_exception module to lib
..


Patch Set 4:

(8 comments)

https://gerrit.ovirt.org/#/c/54467/4/tests/functional/storageTests.py
File tests/functional/storageTests.py:

Line 42: from vdsm.config import config
Line 43: from vdsm.constants import VDSM_USER, VDSM_GROUP
Line 44: from vdsm.storage import storage_exception as se
Line 45: from vdsm.utils import CommandPath, RollbackContext
Line 46: from vdsm.virt import vmstatus
> Please revert this import cleanup and do it in another patch.
Done
Line 47: 
Line 48: import storage.sd
Line 49: import storage.volume
Line 50: from storage.misc import execCmd


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/clusterlock.py
File vdsm/storage/clusterlock.py:

Line 30: from vdsm import utils
Line 31: from vdsm.config import config
Line 32: from vdsm.storage import storage_exception as se
Line 33: 
Line 34: import misc
> Please avoid this unrelated changes like misc and vdsm.confg imports.
Done
Line 35: 
Line 36: 
Line 37: MAX_HOST_ID = 250
Line 38: 


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 27: import re
Line 28: 
Line 29: from vdsm import constants
Line 30: from vdsm import supervdsm
Line 31: from vdsm.storage import storage_exception as se
> This should be the only import changed in this patch, mixing this with impo
Done
Line 32: from vdsm.storage.constants import LEASE_FILEEXT
Line 33: from vdsm.utils import stripNewLines
Line 34: 
Line 35: import sd


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/glusterSD.py
File vdsm/storage/glusterSD.py:

Line 15: # along with this program; if not, write to the Free Software
Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
> Unrelated change, please add in a separate patch.
Done
Line 20: 
Line 21: import os
Line 22: 
Line 23: from vdsm.storage import storage_exception as se


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/imageSharing.py
File vdsm/storage/imageSharing.py:

Line 20: import logging
Line 21: import signal
Line 22: 
Line 23: from vdsm import commands
Line 24: from vdsm import constants
> Unrelated
Done
Line 25: from vdsm.storage import storage_exception as se
Line 26: 
Line 27: import curlImgWrap
Line 28: 


Line 23: from vdsm import commands
Line 24: from vdsm import constants
Line 25: from vdsm.storage import storage_exception as se
Line 26: 
Line 27: import curlImgWrap
> Unrelated
Done
Line 28: 
Line 29: 
Line 30: log = logging.getLogger("Storage.ImageSharing")
Line 31: # Time to wait from finishing writing data to dd, until dd exists,


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/resourceManager.py
File vdsm/storage/resourceManager.py:

Line 28: from Queue import Queue
Line 29: 
Line 30: from vdsm import concurrent
Line 31: from vdsm import utils
Line 32: from vdsm.logUtils import SimpleLogAdapter
> Unrelated
Done
Line 33: from vdsm.storage import storage_exception as se
Line 34: 
Line 35: import misc
Line 36: 


Line 31: from vdsm import utils
Line 32: from vdsm.logUtils import SimpleLogAdapter
Line 33: from vdsm.storage import storage_exception as se
Line 34: 
Line 35: import misc
> Unrelated
Done
Line 36: 
Line 37: 
Line 38: # Errors
Line 39: 


-- 
To view, visit https://gerrit.ovirt.org/54467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Remove sparsify from vdsm

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Remove sparsify from vdsm
..


Patch Set 1: Code-Review+1

it seems indeed this verb is not used. Awesome! Partial ACK until we have final 
proof.

-- 
To view, visit https://gerrit.ovirt.org/54426
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2b86035b6cc6ec74a403c3379d0b384fb6f23e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function

[fromani]

Francesco Romani has posted comments on this change.

Change subject: machinetype: split and slightly refactor cpu_models function
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54301/1/lib/vdsm/machinetype.py
File lib/vdsm/machinetype.py:

Line 112: arch = 'ppc64'
Line 113: 
Line 114: arch_element = None
Line 115: 
Line 116: arch_elements = cpu_map.findall('arch')
> but keeping it avoids needing 2 findalls
So let's keep it!
Line 117: 
Line 118: if arch_elements:
Line 119: for element in arch_elements:
Line 120: if element.get('name') == arch:


-- 
To view, visit https://gerrit.ovirt.org/54301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: message tracking do not clean properly

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: message tracking do not clean properly
..


Patch Set 5: Code-Review+1

(2 comments)

acking it, but check my comments and decide if you want to change.

https://gerrit.ovirt.org/#/c/48616/5/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 321
Line 322
Line 323
Line 324
Line 325
the change could be only to replace "id" with resp.get("id")


Line 319: Sends message to all subscribes that subscribed to destination.
Line 320: """
Line 321: def send(self, message, 
destination=stomp.LEGACY_SUBSCRIPTION_ID_RESPONSE):
Line 322: resp = json.loads(message)
Line 323: response_id = resp.get("id")
don't you prefer to put it under the try?
Line 324: 
Line 325: try:
Line 326: destination = self._req_dest[response_id]
Line 327: del self._req_dest[response_id]


-- 
To view, visit https://gerrit.ovirt.org/48616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ca7c7589fea2d7ad5a477123b14df17924fda0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6.3]: restore-nets: disable IPv6 based on ifcfg files

[automation]

gerrit-hooks has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
..


Patch Set 3:

* #1219363::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1219363::OK, public bug
* Check Product::#1219363::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.3
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6.3]: network: skip non-existent devices in _restore_disable_ipv6

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: skip non-existent devices in _restore_disable_ipv6
..


Patch Set 1:

* #1219363::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1219363::OK, public bug
* Check Product::#1219363::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08fcd502093507b7ad5a080da181d0c88a442f1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.3
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6.3]: network: skip non-existent devices in _restore_disable_ipv6

[osvoboda]

Hello Dan Kenigsberg, Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/54478

to review the following change.

Change subject: network: skip non-existent devices in _restore_disable_ipv6
..

network: skip non-existent devices in _restore_disable_ipv6

Broken networks are handled gracefully by other parts of the restoration flow
(and covered by testRestoreNetworksOnlyRestoreUnchangedDevices). Let's follow
suit and don't try to disable_ipv6 on missing devices.

Change-Id: I08fcd502093507b7ad5a080da181d0c88a442f1e
Signed-off-by: Ondřej Svoboda 
Bug-Url: https://bugzilla.redhat.com/1219363
Backport-To: 3.6.3
Reviewed-on: https://gerrit.ovirt.org/54455
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/54457
Reviewed-by: Francesco Romani 
---
M vdsm/vdsm-restore-net-config
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/54478/1

diff --git a/vdsm/vdsm-restore-net-config b/vdsm/vdsm-restore-net-config
index 5d22dde..0673179 100755
--- a/vdsm/vdsm-restore-net-config
+++ b/vdsm/vdsm-restore-net-config
@@ -367,7 +367,13 @@
 for filename in _owned_ifcfg_files():
 device = _ifcfg_dev_name(filename)
 if not _ipv6_ifcfg(device):
-sysctl.disable_ipv6(device)
+try:
+sysctl.disable_ipv6(device)
+except IOError as e:
+if e.errno == errno.ENOENT:
+pass  # the network is broken, but we have to handle it
+else:
+raise
 
 
 def _owned_ifcfg(link_name):


-- 
To view, visit https://gerrit.ovirt.org/54478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08fcd502093507b7ad5a080da181d0c88a442f1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.3
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: machinetype: update naming

[fromani]

Francesco Romani has posted comments on this change.

Change subject: machinetype: update naming
..


Patch Set 2: Code-Review+1

not sure I can own this change. If I can, I will.

-- 
To view, visit https://gerrit.ovirt.org/54298
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ce7596a1dbf0a565ba3665eda6e9b3a6fc3d56d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: machinetype: update naming

[fromani]

Francesco Romani has posted comments on this change.

Change subject: machinetype: update naming
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54298
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ce7596a1dbf0a565ba3665eda6e9b3a6fc3d56d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 17:

(20 comments)

https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:

Line 5659: needs updating
> could be missing if no GuestAgent is not available - which is not recommend
Done


Line 5693: needs updating
> could be missing entirely if VM is headless (legal).
Done


Line 5699:  needs updating
> same as timezone
Done


Line 5776: needs updating
> same as displayPort
Done


Line 5790: needs updating
> same as displayPort
Done


Line 6042: needs updating
> default: false
Done


Line 6049: needs updating
> could be missing, in this case the VM will be headless. It is legal and sup
Done


Line 6055: needs updating
> default is 'not present', that for us is equivalent to 'false'
Done


Line 6064: needs updatin
> default is 1
Done


Line 6073: needs updating
> Vdsm doesn't require this, so it could be missing. But starting from 3.6 I 
Done


Line 6083: needs updating
> default is false
Done


Line 6089:  needs updating
> default is no attribute, so maybe 'null'
Done


Line 6094:  needs updating
> newer (>= 3.5) Engines always send this.
Done


Line 6121: needs updating
> default is no explicit tuning. So maybe 'null'?
Done


Line 6126: eeds updating
> default is 1
Done


Line 8580: monitorCommand
> not actually implemented (and no plans to do so)
should we remove it?


Line 8600: description: ''
 : type: *VmDefinition
> according to the code (vm.py) this just returns response.success() or respo
hmm, so it should be no return block here. Will fix


Line 8611: sendKeys
> this is actually unsupported and kept for backward compatibility (?!) - che
should we remove it?


Line 8688: berequired
> needs spacing: be required
Thanks


Line 8697: berequired
> needs spacing: be required
Thanks


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Remove unneeded assert

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: Remove unneeded assert
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51922
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5342cac512cd441aa676e63d68c865aec77bc7da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network caps now reports IPv6 autoconf state

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: Network caps now reports IPv6 autoconf state
..

net: Network caps now reports IPv6 autoconf state

'ipv6autoconf' current status is reported through caps.

Change-Id: If91083ec3502a2679328e92aa63699d16c77df71
Signed-off-by: Edward Haas 
---
M lib/vdsm/netinfo/addresses.py
M lib/vdsm/netinfo/cache.py
M lib/vdsm/sysctl.py
M vdsm_hooks/ovs/ovs_after_get_caps.py
4 files changed, 27 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/54475/1

diff --git a/lib/vdsm/netinfo/addresses.py b/lib/vdsm/netinfo/addresses.py
index 0b9741f..acd70a6 100644
--- a/lib/vdsm/netinfo/addresses.py
+++ b/lib/vdsm/netinfo/addresses.py
@@ -25,6 +25,7 @@
 import struct
 
 from ..netlink import addr as nl_addr
+from ..sysctl import is_ipv6_local_auto as sysctl_is_ipv6_local_auto
 
 
 def getIpInfo(dev, ipaddrs=None, ipv4_gateway=None):
@@ -123,3 +124,7 @@
 
 def is_dynamic(nladdr):
 return not nl_addr.is_permanent(nladdr)
+
+
+def is_ipv6_local_auto(iface):
+return sysctl_is_ipv6_local_auto(iface)
\ No newline at end of file
diff --git a/lib/vdsm/netinfo/cache.py b/lib/vdsm/netinfo/cache.py
index 031551c..df53808 100644
--- a/lib/vdsm/netinfo/cache.py
+++ b/lib/vdsm/netinfo/cache.py
@@ -30,7 +30,7 @@
 from ..netlink import link as nl_link
 
 from vdsm import netinfo
-from .addresses import getIpAddrs, getIpInfo
+from .addresses import getIpAddrs, getIpInfo, is_ipv6_local_auto
 from . import bonding
 from . import bridges
 from .dhcp import (propose_updates_to_reported_dhcp,  update_reported_dhcp,
@@ -141,6 +141,7 @@
 'cfg': getIfaceCfg(link.name),
 'ipv4addrs': ipv4addrs,
 'ipv6addrs': ipv6addrs,
+'ipv6autoconf': is_ipv6_local_auto(link.name),
 'gateway': gateway,
 'ipv6gateway': get_gateway(routes, link.name, family=6),
 'dhcpv4': is_dhcpv4,
diff --git a/lib/vdsm/sysctl.py b/lib/vdsm/sysctl.py
index 957e61f..63c3f76 100644
--- a/lib/vdsm/sysctl.py
+++ b/lib/vdsm/sysctl.py
@@ -20,6 +20,8 @@
 
 
 from __future__ import absolute_import
+import errno
+
 _RPFILTER_STRICT = '1'
 _RPFILTER_LOOSE = '2'
 
@@ -47,3 +49,20 @@
 with open('/proc/sys/net/ipv6/conf/default/disable_ipv6') as f:
 ipv6_enabled = f.read()
 return int(ipv6_enabled)
+
+
+def is_ipv6_local_auto(dev):
+try:
+with open('/proc/sys/net/ipv6/conf/%s/autoconf' % dev) as f:
+is_autoconf = f.read()
+with open('/proc/sys/net/ipv6/conf/%s/accept_ra' % dev) as f:
+is_accept_ra = f.read()
+with open('/proc/sys/net/ipv6/conf/%s/accept_redirects' % dev) as f:
+is_accept_redirects = f.read()
+except IOError as e:
+if e.errno == errno.ENOENT:
+return False
+else:
+raise
+
+return bool(is_autoconf and is_accept_ra and is_accept_redirects)
\ No newline at end of file
diff --git a/vdsm_hooks/ovs/ovs_after_get_caps.py 
b/vdsm_hooks/ovs/ovs_after_get_caps.py
index 3855652..b7172f3 100755
--- a/vdsm_hooks/ovs/ovs_after_get_caps.py
+++ b/vdsm_hooks/ovs/ovs_after_get_caps.py
@@ -68,6 +68,7 @@
 'dhcpv4': dhcpv4,
 'ipv4addrs': ipv4addrs,
 'ipv6addrs': ipv6addrs,
+'ipv6autoconf': addresses.is_ipv6_local_auto(interface),
 'ipv6gateway': ipv6gateway,
 'dhcpv6': dhcpv6,
 'cfg': {'BOOTPROTO': 'dhcp' if dhcpv4 else 'none'}}


-- 
To view, visit https://gerrit.ovirt.org/54475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If91083ec3502a2679328e92aa63699d16c77df71
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network caps now reports IPv6 autoconf state

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Network caps now reports IPv6 autoconf state
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If91083ec3502a2679328e92aa63699d16c77df71
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: added support for convergence schedule

[fromani]

Francesco Romani has posted comments on this change.

Change subject: migration: added support for convergence schedule
..


Patch Set 21: Code-Review+2

all comments addressed. Looks good to me.

-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: added support for convergence schedule

[tjelinek]

Tomas Jelinek has posted comments on this change.

Change subject: migration: added support for convergence schedule
..


Patch Set 21: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Don't fail connect server when getting volume info

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: Don't fail connect server when getting volume info
..


Patch Set 12: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/53785
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: supervdsm: move udev-related functions to udev.py
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: supervdsm: move udev-related functions to udev.py
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/54458/6/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

Line 28: from vdsm import udevadm
Line 29: 
Line 30: from vdsm.constants import EXT_CHOWN, \
Line 31: DISKIMAGE_USER, DISKIMAGE_GROUP, \
Line 32: QEMU_PROCESS_USER, QEMU_PROCESS_GROUP
Much nicer like this!
Line 33: 
Line 34: from . import expose
Line 35: 
Line 36: _UDEV_RULE_FILE_DIR = "/etc/udev/rules.d/"


-- 
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: supervdsm: move udev-related functions to udev.py
..


Patch Set 6:

Hopefully fixed the ordering, working on the flows testing in the meantime.

-- 
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: supervdsm: move udev-related functions to udev.py
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make Vm.devMapFromDevSpecMap() private

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: virt: Make Vm.devMapFromDevSpecMap() private
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/53484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a1d8d8d80313a8b4648a255413c26689d1c4657
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmstats: reorder the calculations

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: vmstats: reorder the calculations
..


Patch Set 5: Code-Review-1

I probably don't have bigger issue with this, but I am unable to asses the 
benefits of this. Do you have some specific use cases in mind? Any of rx/tx 
stats missing?

-- 
To view, visit https://gerrit.ovirt.org/54248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6875ca2e55ac107498ee130062c665749f7f5b60
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: supervdsm: move udev-related functions to udev.py
..


Patch Set 5: Code-Review-1

(1 comment)

Minor import order issue - otherwise looks fine.

-1 so we don't merge it without verifying storage flows properly.

https://gerrit.ovirt.org/#/c/54458/5/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

Line 27: 
Line 28: from vdsm import commands
Line 29: from vdsm.constants import EXT_CHOWN, \
Line 30: DISKIMAGE_USER, DISKIMAGE_GROUP, \
Line 31: QEMU_PROCESS_USER, QEMU_PROCESS_GROUP
This should come after vdsm imports (stdlib, vdsm, vdsm.x, ...)
Line 32: from vdsm import cmdutils
Line 33: from vdsm import udevadm
Line 34: 
Line 35: 


-- 
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm.conf: Add drop-in dir

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm.conf: Add drop-in dir
..


Patch Set 8:

* #1279555::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279555::OK, public bug
* Check Product::#1279555::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48317
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I707a1865e8d60dc4dcdc0e681b52c07c75f1c409
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: supervdsm: move udev-related functions to udev.py
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: supervdsm: move udev-related functions to udev.py
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move securable module to site-packages

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storage: Move securable module to site-packages
..


storage: Move securable module to site-packages

Moving vdsm/storage/securable.py to lib/vdsm/storage/securable.py.

Change-Id: Ibe50f4ea10a9b4bb7511ed1c373a33421daf295d
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/54424
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M debian/vdsm-python.install
M debian/vdsm.install
M lib/vdsm/storage/Makefile.am
R lib/vdsm/storage/securable.py
M tests/securableTests.py
M vdsm.spec.in
M vdsm/storage/Makefile.am
M vdsm/storage/sp.py
M vdsm/storage/spbackends.py
M vdsm/storage/storage_exception.py
10 files changed, 13 insertions(+), 11 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/54424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe50f4ea10a9b4bb7511ed1c373a33421daf295d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move securable module to site-packages

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Move securable module to site-packages
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe50f4ea10a9b4bb7511ed1c373a33421daf295d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move constants module to site-packages

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Move constants module to site-packages
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I413e0b54de0d06f7eee3ecb4094f0281bb77dc51
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move constants module to site-packages

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storage: Move constants module to site-packages
..


storage: Move constants module to site-packages

Moving vsdm/storage/constants.py to lib/vdsm/storage/constants.py.

Change-Id: I413e0b54de0d06f7eee3ecb4094f0281bb77dc51
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/54404
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M debian/vdsm-python.install
M debian/vdsm.install
M lib/vdsm/storage/Makefile.am
R lib/vdsm/storage/constants.py
M vdsm.spec.in
M vdsm/storage/Makefile.am
M vdsm/storage/fileSD.py
M vdsm/storage/fileVolume.py
M vdsm/storage/hsm.py
M vdsm/storage/misc.py
M vdsm/storage/sp.py
11 files changed, 21 insertions(+), 21 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I413e0b54de0d06f7eee3ecb4094f0281bb77dc51
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: health: Warn about delays in monitor threads

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: health: Warn about delays in monitor threads
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/52524/1/lib/vdsm/health.py
File lib/vdsm/health.py:

Line 95: delay = utils.monotonic_time() - deadline
Line 96: if delay <= self._max_delay:
Line 97: self.log.debug("Woke up - delay=%.02fs", delay)
Line 98: else:
Line 99: self.log.warning("Abnormal dealy - delay=%.02fs", delay)
Typo (dealy -> delay)
Line 100: return False
Line 101: 
Line 102: def _check(self):
Line 103: self._check_garbage()


-- 
To view, visit https://gerrit.ovirt.org/52524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0a1b1a375166a08443673a097706998bbdad57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: health: Warn about delays in monitor threads

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: health: Warn about delays in monitor threads
..


Patch Set 1: Code-Review-1

(1 comment)

Document unit of max delay "(in seconds)"

https://gerrit.ovirt.org/#/c/52524/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 434: ('health_check_interval', '60',
Line 435: 'Number of seconds to wait between health checks.'),
Line 436: 
Line 437: ('health_max_delay', '0.5',
Line 438: 'Warn if health checks are delayed longer than this 
interval.'),
> Please add unit of time which is used by this delay.
Will add
Line 439: 
Line 440: ]),
Line 441: 
Line 442: # Section: [gluster]


-- 
To view, visit https://gerrit.ovirt.org/52524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0a1b1a375166a08443673a097706998bbdad57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Remove unneeded assert

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Remove unneeded assert
..


Patch Set 2:

Ping

-- 
To view, visit https://gerrit.ovirt.org/51922
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5342cac512cd441aa676e63d68c865aec77bc7da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Replace misc.RWLock

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: rwlock: Replace misc.RWLock
..


Patch Set 20:

Ping

-- 
To view, visit https://gerrit.ovirt.org/43423
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ae6064e8e031339303e64606a70673807c4083a
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Add simpler RWLock

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: rwlock: Add simpler RWLock
..


Patch Set 24:

Ping

-- 
To view, visit https://gerrit.ovirt.org/42908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add readers contention rwlock test

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Add readers contention rwlock test
..


Patch Set 3:

Ping

-- 
To view, visit https://gerrit.ovirt.org/51923
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdaf5096d0898d97db6234538233dfa01217f9ed
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move storage_exception module to lib

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Move storage_exception module to lib
..


Patch Set 4: Code-Review-1

(8 comments)

This changes mix unrelated import cleanups in many modules. It must add only 
the changes needed to move the module to lib/vdsm/storage.

https://gerrit.ovirt.org/#/c/54467/4/tests/functional/storageTests.py
File tests/functional/storageTests.py:

Line 42: from vdsm.config import config
Line 43: from vdsm.constants import VDSM_USER, VDSM_GROUP
Line 44: from vdsm.storage import storage_exception as se
Line 45: from vdsm.utils import CommandPath, RollbackContext
Line 46: from vdsm.virt import vmstatus
Please revert this import cleanup and do it in another patch.
Line 47: 
Line 48: import storage.sd
Line 49: import storage.volume
Line 50: from storage.misc import execCmd


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/clusterlock.py
File vdsm/storage/clusterlock.py:

Line 30: from vdsm import utils
Line 31: from vdsm.config import config
Line 32: from vdsm.storage import storage_exception as se
Line 33: 
Line 34: import misc
Please avoid this unrelated changes like misc and vdsm.confg imports.
Line 35: 
Line 36: 
Line 37: MAX_HOST_ID = 250
Line 38: 


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 27: import re
Line 28: 
Line 29: from vdsm import constants
Line 30: from vdsm import supervdsm
Line 31: from vdsm.storage import storage_exception as se
This should be the only import changed in this patch, mixing this with import 
cleanup makes this too hard to review.
Line 32: from vdsm.storage.constants import LEASE_FILEEXT
Line 33: from vdsm.utils import stripNewLines
Line 34: 
Line 35: import sd


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/glusterSD.py
File vdsm/storage/glusterSD.py:

Line 15: # along with this program; if not, write to the Free Software
Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Unrelated change, please add in a separate patch.
Line 20: 
Line 21: import os
Line 22: 
Line 23: from vdsm.storage import storage_exception as se


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/imageSharing.py
File vdsm/storage/imageSharing.py:

Line 20: import logging
Line 21: import signal
Line 22: 
Line 23: from vdsm import commands
Line 24: from vdsm import constants
Unrelated
Line 25: from vdsm.storage import storage_exception as se
Line 26: 
Line 27: import curlImgWrap
Line 28: 


Line 23: from vdsm import commands
Line 24: from vdsm import constants
Line 25: from vdsm.storage import storage_exception as se
Line 26: 
Line 27: import curlImgWrap
Unrelated
Line 28: 
Line 29: 
Line 30: log = logging.getLogger("Storage.ImageSharing")
Line 31: # Time to wait from finishing writing data to dd, until dd exists,


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/resourceManager.py
File vdsm/storage/resourceManager.py:

Line 28: from Queue import Queue
Line 29: 
Line 30: from vdsm import concurrent
Line 31: from vdsm import utils
Line 32: from vdsm.logUtils import SimpleLogAdapter
Unrelated
Line 33: from vdsm.storage import storage_exception as se
Line 34: 
Line 35: import misc
Line 36: 


Line 31: from vdsm import utils
Line 32: from vdsm.logUtils import SimpleLogAdapter
Line 33: from vdsm.storage import storage_exception as se
Line 34: 
Line 35: import misc
Unrelated
Line 36: 
Line 37: 
Line 38: # Errors
Line 39: 


-- 
To view, visit https://gerrit.ovirt.org/54467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move securable module to site-packages

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Move securable module to site-packages
..


Patch Set 4:

Waiting for jenkins

-- 
To view, visit https://gerrit.ovirt.org/54424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe50f4ea10a9b4bb7511ed1c373a33421daf295d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move securable module to site-packages

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Move securable module to site-packages
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe50f4ea10a9b4bb7511ed1c373a33421daf295d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move constants module to site-packages

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Move constants module to site-packages
..


Patch Set 4:

Let wait for jenkins

-- 
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I413e0b54de0d06f7eee3ecb4094f0281bb77dc51
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move constants module to site-packages

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Move constants module to site-packages
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I413e0b54de0d06f7eee3ecb4094f0281bb77dc51
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[fromani]

Francesco Romani has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 17:

(20 comments)

partial review

https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:

Line 5659: needs updating
could be missing if no GuestAgent is not available - which is not recommended 
but legal. So I guess 'null'?


Line 5693: needs updating
could be missing entirely if VM is headless (legal).
Otherwise this is owned by libvirt, so we only know the legal range


Line 5699:  needs updating
same as timezone


Line 5776: needs updating
same as displayPort


Line 5790: needs updating
same as displayPort


Line 6042: needs updating
default: false


Line 6049: needs updating
could be missing, in this case the VM will be headless. It is legal and 
supported configuration (save for bugs :))


Line 6055: needs updating
default is 'not present', that for us is equivalent to 'false'


Line 6064: needs updatin
default is 1


Line 6073: needs updating
Vdsm doesn't require this, so it could be missing. But starting from 3.6 I 
think Engine always send this.


Line 6083: needs updating
default is false


Line 6089:  needs updating
default is no attribute, so maybe 'null'


Line 6094:  needs updating
newer (>= 3.5) Engines always send this.


Line 6121: needs updating
default is no explicit tuning. So maybe 'null'?


Line 6126: eeds updating
default is 1


Line 8580: monitorCommand
not actually implemented (and no plans to do so)

def monitorCommand(self, command):
"""
Send a monitor command to the specified VM and wait for the answer.

:param vmId: uuid of the specified VM
:type vmId: UUID
:param command: a single monitor command (without terminating newline)
:type command: string
"""
return errCode['noimpl']


Line 8600: description: ''
 : type: *VmDefinition
according to the code (vm.py) this just returns response.success() or 
response.error()


Line 8611: sendKeys
this is actually unsupported and kept for backward compatibility (?!) - check 
vdsm/API.py:

def sendKeys(self, keySequence):
"""
Send a string of keys to a guest's keyboard (OBSOLETE)

Used only by QA and might be discontinued in next version.
"""
return errCode['noimpl']


Line 8688: berequired
needs spacing: be required


Line 8697: berequired
needs spacing: be required


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move constants module to site-packages

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Move constants module to site-packages
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I413e0b54de0d06f7eee3ecb4094f0281bb77dc51
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move securable module to site-packages

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: storage: Move securable module to site-packages
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe50f4ea10a9b4bb7511ed1c373a33421daf295d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move constants module to site-packages

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: storage: Move constants module to site-packages
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I413e0b54de0d06f7eee3ecb4094f0281bb77dc51
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move securable module to site-packages

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Move securable module to site-packages
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe50f4ea10a9b4bb7511ed1c373a33421daf295d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move storage_exception module to lib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Move storage_exception module to lib
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move constants module to site-packages

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Move constants module to site-packages
..


Patch Set 3:

Fred, can you rebase?

Seems that this cannot be merged now since I already merged the patch above it.

-- 
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I413e0b54de0d06f7eee3ecb4094f0281bb77dc51
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move constants module to site-packages

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Move constants module to site-packages
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I413e0b54de0d06f7eee3ecb4094f0281bb77dc51
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: group vdsm imports in hsm.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm: group vdsm imports in hsm.py
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e91e70e3ec93ab2d62dcfd7fe9fd16a91f678eb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: group vdsm imports in hsm.py

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: hsm: group vdsm imports in hsm.py
..


hsm: group vdsm imports in hsm.py

Group together vdsm import in vdsm/storage/hsm.py

Change-Id: I2e91e70e3ec93ab2d62dcfd7fe9fd16a91f678eb
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/54451
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M vdsm/storage/hsm.py
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/54451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e91e70e3ec93ab2d62dcfd7fe9fd16a91f678eb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: add virt and netinfo dir in spec

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: spec: add virt and netinfo dir in spec
..


spec: add virt and netinfo dir in spec

Add lib  virt and netinfo dir in vdsm.spec.in

Change-Id: Icf03a99b2c386a7d1990adba9456c72d7deb4776
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/54439
Reviewed-by: Francesco Romani 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Piotr Kliczewski 
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, approved
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Freddy Rolland: Verified
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54439
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf03a99b2c386a7d1990adba9456c72d7deb4776
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: add virt and netinfo dir in spec

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: add virt and netinfo dir in spec
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54439
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf03a99b2c386a7d1990adba9456c72d7deb4776
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 17:

(2 comments)

https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:

Line 4836: null
> Yes: bootproto='none'
Done


Line 4869: defaultvalue: needs updating
> Yes, or no-default will be even nicer.
Will add, no-default is OK


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move constants module to site-packages

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: storage: Move constants module to site-packages
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I413e0b54de0d06f7eee3ecb4094f0281bb77dc51
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: add virt and netinfo dir in spec

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: spec: add virt and netinfo dir in spec
..


Patch Set 2:

I verified by installing and check that the directories were removed.
Before this patch the directories were still there.

-- 
To view, visit https://gerrit.ovirt.org/54439
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf03a99b2c386a7d1990adba9456c72d7deb4776
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: group vdsm imports in hsm.py

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hsm: group vdsm imports in hsm.py
..


Patch Set 1:

Fred, can you verify?

-- 
To view, visit https://gerrit.ovirt.org/54451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e91e70e3ec93ab2d62dcfd7fe9fd16a91f678eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: group vdsm imports in hsm.py

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: hsm: group vdsm imports in hsm.py
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e91e70e3ec93ab2d62dcfd7fe9fd16a91f678eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: add virt and netinfo dir in spec

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: spec: add virt and netinfo dir in spec
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54439
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf03a99b2c386a7d1990adba9456c72d7deb4776
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: supervdsm: move udev-related functions to udev.py
..


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/54458/3/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 230
Line 231
Line 232
Line 233
Line 234
This was also moved.


-- 
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[edwardh]

Edward Haas has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 17:

(3 comments)

https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:

Line 4805: needs updating
> So should it be required?
Same as in line 4869


Line 4836: null
> Do you want to have here a string none?
Yes: bootproto='none'


Line 4869: defaultvalue: needs updating
> hmm, this is something that needs to be covered. We could have here a word 
Yes, or no-default will be even nicer.
And the key/attribute will be missing, not the value.

I have commented on this in my last reply message.


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: debian: add supervdsm_api

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: debian: add supervdsm_api
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54466
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2779caab6a4ec877faf9d0ba5141ca91cfadffb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: added support for convergence schedule

[tjelinek]

Tomas Jelinek has posted comments on this change.

Change subject: migration: added support for convergence schedule
..


Patch Set 19:

(1 comment)

https://gerrit.ovirt.org/#/c/46940/19/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 341: self._startUnderlyingMigration(time.time())
Line 342: self._finishSuccessfully()
Line 343: except libvirt.libvirtError as e:
Line 344: if (e.get_error_code() ==
Line 345: libvirt.VIR_ERR_OPERATION_ABORTED):
> nit: unneeded remove
Done
Line 346: self.status = response.error(
Line 347: 'migCancelErr', message='Migration 
canceled')
Line 348: raise
Line 349: except MigrationDestinationSetupError as e:


-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: added support for convergence schedule

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: added support for convergence schedule
..


Patch Set 21:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: added support for convergence schedule

[tjelinek]

Tomas Jelinek has posted comments on this change.

Change subject: migration: added support for convergence schedule
..


Patch Set 19:

(4 comments)

https://gerrit.ovirt.org/#/c/46940/19/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 7805: ##
Line 7806: # @ConvergenceItem:
Line 7807: #
Line 7808: # A convergence action which will be executed when the migration
Line 7809: # is stalling longer than the first arg.
> nit: no need for abbreviation. s/arg/argument.
Done
Line 7810: #
Line 7811: # @limit:   If the migration is stalling for this amount of time,
Line 7812: #   execute the action.
Line 7813: #


Line 7820: 
Line 7821: ##
Line 7822: # @ConvergenceSchedule:
Line 7823: #
Line 7824: # List of actions which will be executed before migration starts and 
list
> nit: s/List/Map
Done
Line 7825: # of actions which will be executed as a reaction to stalling.
Line 7826: #
Line 7827: # @init: The list of actions executed before migration
Line 7828: #


Line 7825: # of actions which will be executed as a reaction to stalling.
Line 7826: #
Line 7827: # @init: The list of actions executed before migration
Line 7828: #
Line 7829: # @schedule: The list of actions executed as a reaction to stalling
> nit: name could maybe be 'stalling' more appropriate?
Done
Line 7830: #
Line 7831: # Since: 4.18.0
Line 7832: ##
Line 7833: {'type': 'ConvergenceSchedule',


Line 7908:   '*tunneled': 'bool', '*abortOnError': 'bool',
Line 7909:   'consoleAddress': 'str', 'dstqemu': 'str',
Line 7910:   '*compressed': 'bool', '*autoConverge': 'bool',
Line 7911:   '*maxBandwidth': 'int',
Line 7912:   '*convergenceSchedule': 'ConvergenceSchedule'}}
> A nicer approach could be to have two new parameters: one for init actions 
renamed the "schedule" to "stalling" but left the wrapper "ConvergenceSchedul" 
type there. Hope it is ok.
Line 7913: 
Line 7914: ##
Line 7915: # @VM.migrate:
Line 7916: #


-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: added support for convergence schedule

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: added support for convergence schedule
..


Patch Set 20:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: debian: add supervdsm_api

[fromani]

Francesco Romani has posted comments on this change.

Change subject: debian: add supervdsm_api
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54466
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2779caab6a4ec877faf9d0ba5141ca91cfadffb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches