gerrit-hooks has posted comments on this change.
Change subject: net: add vlan tag to libvirt network def
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: monitor: Convert valid to read-only property
..
Patch Set 4: -Continuous-Integration
--
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Add process helpers
..
Patch Set 7:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 36:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 19:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Use module logger
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Detach read delay from storage domain
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: storage: add block device naming tests
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56802/1/tests/vmStorageTests.py
File tests/vmStorageTests.py:
Nir Soffer has posted comments on this change.
Change subject: vmdevices: make disk's makeName public
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56804/1/vdsm/virt/vmdevices/storage.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 2:
I would like to merge this soon, please repost.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 2:
Please verify, I want to merge it soon.
--
To view, visit https://gerrit.ovirt.org/56706
To
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/12/tests/vmfakelib.py
File tests/vmfakelib.py:
Line 419:
Nir Soffer has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56706
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56704/2/tests/mountTests.py
File tests/mountTests.py:
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require index
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/1/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require index
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/1/vdsm/API.py
File vdsm/API.py:
Line 112: def __init__(self,
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require index
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/1/vdsm/API.py
File vdsm/API.py:
Line 124
Line 125
Line 126
Line
Nir Soffer has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 17:
We need more reviews.
--
To view, visit https://gerrit.ovirt.org/55987
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Support initial_size parameter
..
Patch Set 10: Code-Review+1
Waiting for https://gerrit.ovirt.org/55987
--
To view, visit https://gerrit.ovirt.org/56628
To
Nir Soffer has submitted this change and it was merged.
Change subject: sdm: CreateVolumeInfo.initial_size default should be None
..
sdm: CreateVolumeInfo.initial_size default should be None
Commit 9820797d defined the
Nir Soffer has posted comments on this change.
Change subject: sdm: CreateVolumeInfo.initial_size default should be None
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56717
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: FakeLVM: LV size is rounded to VG extent size
..
FakeLVM: LV size is rounded to VG extent size
In real LVM, LV sizes must be a multiple of the VG extent
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: LV size is rounded to VG extent size
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: LV size is rounded to VG extent size
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: lvm: Use a constant to define default vg extent size
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/55987/17/vdsm/storage/sdm/volume_artifacts.py
File
Nir Soffer has submitted this change and it was merged.
Change subject: lvm: Use a constant to define default vg extent size
..
lvm: Use a constant to define default vg extent size
The default vg extent size has so far been
gerrit-hooks has posted comments on this change.
Change subject: net: add vlan tag to libvirt network def
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: add virtual port to libvirt network def
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
*
Adam Litke has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 17:
(7 comments)
https://gerrit.ovirt.org/#/c/55987/17/vdsm/storage/sdm/volume_artifacts.py
File
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Use module logger
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: monitoring: Use module logger
..
monitoring: Use module logger
Currently we have two classes using the same logger, and I want to
extract new classes that will
gerrit-hooks has posted comments on this change.
Change subject: net: add vlan tag to network def
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: add virtual port to network def
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Petr Horáček has uploaded a new change for review.
Change subject: net: add virtual port to network def
..
net: add virtual port to network def
We need to set virtualport for libvirt network in order to support
OVS.
Change-Id:
Petr Horáček has uploaded a new change for review.
Change subject: net: add vlan tag to network def
..
net: add vlan tag to network def
We need to set vlan tag for libvirt network in order to support
OVS.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Detach read delay from storage domain
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Detach read delay from storage domain
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: monitoring: Detach read delay from storage domain
..
monitoring: Detach read delay from storage domain
We used to call StorageDomain.getReadDelay() to perform a
Nir Soffer has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 17: Code-Review-1
(7 comments)
https://gerrit.ovirt.org/#/c/55987/17/vdsm/storage/sdm/volume_artifacts.py
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix volume size handling in domain_manifest_test
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Fix volume size handling in domain_manifest_test
..
tests: Fix volume size handling in domain_manifest_test
This test module is not testing the
Nir Soffer has posted comments on this change.
Change subject: lvm: Use a constant to define default vg extent size
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56715
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sdm: CreateVolumeInfo.initial_size default should be None
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56717
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 17: Verified+1
--
To view, visit https://gerrit.ovirt.org/55987
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: FakeLVM: LV size is rounded to VG extent size
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56714
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: lvm: Use a constant to define default vg extent size
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56715/3/tests/storagefakelib.py
File
gerrit-hooks has posted comments on this change.
Change subject: sdm: CreateVolumeInfo.initial_size default should be None
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: lvm: Use a constant to define default vg extent size
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: cow wip
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: tests: Fix volume size handling in domain_manifest_test
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56820
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Support initial_size parameter
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Prepare for COW_FORMAT test permutations
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: LV size is rounded to VG extent size
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: lvm: Use a constant to define default vg extent size
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56715
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitor: Convert valid to read-only property
..
Patch Set 4: Continuous-Integration+1
Jenkins failed to run the tests, ignoring it.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: lvm: Use a constant to define default vg extent size
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/56715/3/tests/storagefakelib.py
File
gerrit-hooks has posted comments on this change.
Change subject: lvm: Use a constant to define default vg extent size
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 1:
(2 comments)
seems OK, but I'd like more data about the failure.
Adam Litke has posted comments on this change.
Change subject: lvm: Use a constant to define default vg extent size
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/56715/2//COMMIT_MSG
Commit Message:
Line 7: lvm:
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: LV size is rounded to VG extent size
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Prepare for COW_FORMAT test permutations
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Support initial_size parameter
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix volume size handling in domain_manifest_test
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: sdm: CreateVolumeInfo.initial_size default should be None
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: cow wip
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: make _getVolumeTag public
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: FakeLVM: LV size is rounded to VG extent size
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56714
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: lvm: Use a constant to define default vg extent size
..
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/56715/2//COMMIT_MSG
Commit Message:
Nir Soffer has submitted this change and it was merged.
Change subject: blockVolume: make _getVolumeTag public
..
blockVolume: make _getVolumeTag public
_getVolumeTag is a useful and safe utility function for getting the tags
Nir Soffer has posted comments on this change.
Change subject: tests: marking temporarily as broken
..
Patch Set 1: Code-Review+1
(2 comments)
@brokentest needs a description
Nir Soffer has posted comments on this change.
Change subject: tests: Fix volume size handling in domain_manifest_test
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56820
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitor: Convert valid to read-only property
..
Patch Set 4:
This version updates the tests, addressing Liron comments.
--
To view, visit
David Caro has posted comments on this change.
Change subject: automation: update glusterfs repos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56813
To unsubscribe, visit
Anton Marchukov has posted comments on this change.
Change subject: automation: update glusterfs repos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56813
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: monitor: Convert valid to read-only property
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: Support initial_size parameter
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: lvm: Use a constant to define default vg extent size
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix volume size handling in domain_manifest_test
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: tests: Prepare for COW_FORMAT test permutations
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: LV size is rounded to VG extent size
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sdm: CreateVolumeInfo.initial_size default should be None
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Adam Litke has uploaded a new change for review.
Change subject: tests: Fix volume size handling in domain_manifest_test
..
tests: Fix volume size handling in domain_manifest_test
This test module is not testing the rounding of
gerrit-hooks has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: make _getVolumeTag public
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: cow wip
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
Nir Soffer has posted comments on this change.
Change subject: FakeLVM: LV size is rounded to VG extent size
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56714/1/tests/storagefakelib.py
File
Sandro Bonazzola has posted comments on this change.
Change subject: automation: update glusterfs repos
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56813
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: automation: update glusterfs repos
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Sandro Bonazzola has uploaded a new change for review.
Change subject: automation: update glusterfs repos
..
automation: update glusterfs repos
- dropped Gluster community repo for Fedora23 (reposync included):
the repo is
Adam Litke has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 14:
(9 comments)
https://gerrit.ovirt.org/#/c/55987/14/vdsm/storage/sdm/volume_artifacts.py
File
Martin Betak has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56811/1/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Martin Betak has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56811
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 27: Verified+1
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: lvm: Use a constant to define default vg extent size
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/56715/1/lib/vdsm/storage/constants.py
File
Martin Betak has uploaded a new change for review.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
rpc: Make Bridge#_type_fixup more robust
_type_fixup method assumed that all top-level arguments of rpc calls are
gerrit-hooks has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
1 - 100 of 187 matches
Mail list logo