Nir Soffer has posted comments on this change. Change subject: cdrom: API change: require index ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56805/1/vdsm/API.py File vdsm/API.py: Line 112: def __init__(self, UUID): Line 113: APIBase.__init__(self) Line 114: self._UUID = UUID Line 115: Line 116: def changeCD(self, interface, index, driveSpec): Why not keep single parameter (driveSpec), and include the interface and the index inside it? This way the api remain backward compatible - old vdsm will ignore the new parameters, and new vdsm will use them. And we don't have to change so many layers, only the definition of drivespec will change. Line 117: """ Line 118: Change the CD in the specified VM. Line 119: Line 120: :param vmId: uuid of specific VM. -- To view, visit https://gerrit.ovirt.org/56805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178c1a02bbad962f9dc9b67bed7691cf170ee896 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
