Change in vdsm[master]: net test: add net removal tests based on NetFuncTestCase

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: add net removal tests based on NetFuncTestCase
..


Patch Set 3: Verified+1

Tests passed.

-- 
To view, visit https://gerrit.ovirt.org/59575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcceb6e16a091226ffb104e50e462a89c2e3f247
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add basic bond tests based on NetFuncTestCase

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: add basic bond tests based on NetFuncTestCase
..


Patch Set 5: Verified+1

Tests passed with both 'ovs' and 'legacy'.

-- 
To view, visit https://gerrit.ovirt.org/59567
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f3fde25b268ee47bc4724a8efae2ed952a78fd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add basic bond tests based on NetFuncTestCase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: add basic bond tests based on NetFuncTestCase
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59567
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f3fde25b268ee47bc4724a8efae2ed952a78fd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Setup ipv6autoconf with OVS switch

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Setup ipv6autoconf with OVS switch
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: common tests for 'ovs' and 'legacy'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: common tests for 'ovs' and 'legacy'
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: common tests for 'ovs' and 'legacy'

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net tests: common tests for 'ovs' and 'legacy'
..


Patch Set 9: Verified+1

Tests are passing separately (when OVS is executed after legacy, it fails due 
to known bug).

to run specific switch:
./run_tests.sh -A "switch=='legacy'" network/func_net_creation_basic_test.py

When no -A specified, it runs both switches. Template is never executed.

-- 
To view, visit https://gerrit.ovirt.org/59538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add net removal tests based on NetFuncTestCase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: add net removal tests based on NetFuncTestCase
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcceb6e16a091226ffb104e50e462a89c2e3f247
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add basic bond tests based on NetFuncTestCase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: add basic bond tests based on NetFuncTestCase
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59567
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f3fde25b268ee47bc4724a8efae2ed952a78fd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: common tests for 'ovs' and 'legacy'

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net tests: common tests for 'ovs' and 'legacy'
..


Patch Set 8: -Verified

-- 
To view, visit https://gerrit.ovirt.org/59538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: common tests for 'ovs' and 'legacy'

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net tests: common tests for 'ovs' and 'legacy'
..


Patch Set 8: Verified+1

Tests are passing separately (when OVS is executed after legacy, it fails due 
to known bug).

to run specific switch:
./run_tests.sh -A "switch=='legacy'" network/func_net_creation_basic_test.py

When no -A specified, it runs both switches. Template is never executed.

-- 
To view, visit https://gerrit.ovirt.org/59538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: common tests for 'ovs' and 'legacy'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: common tests for 'ovs' and 'legacy'
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Setup ipv6autoconf with OVS switch

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Setup ipv6autoconf with OVS switch
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add net removal tests based on NetFuncTestCase

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: add net removal tests based on NetFuncTestCase
..


Patch Set 2: Verified+1

(3 comments)

Test passed.

https://gerrit.ovirt.org/#/c/59575/1/tests/network/func_net_basic_test.py
File tests/network/func_net_basic_test.py:

PS1, Line 41: NETCREAT
> How about NETCREATE and NETREMOVE ?
Done


https://gerrit.ovirt.org/#/c/59575/1/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

Line 74: Aggregates multiple network checks to ease usage.
Line 75: The checks are between the requested setup (input) and current 
reported
Line 76: state (caps).
Line 77: """
Line 78: if 'remove' in netattrs:
> Consider doing something like this to make it prettier:
Done
Line 79: self.assertNetworkDoesntExist(netname)
Line 80: self.assertBridgeDoesntExist(netname)
Line 81: self.assertNetworkDoesNotExistInRunning(netname)
Line 82: return


Line 164: netconf = netsconf[netname]
Line 165: 
Line 166: bridged = netattrs.get('bridged')
Line 167: self.assertEqual(bridged, netconf.get('bridged'))
Line 168: 
> Only the first assertion is relevant, we are checking if network exists, no
Done
Line 169: def assertNetworkDoesntExist(self, net):
Line 170: self.assertNotIn(net, self.netinfo.networks)
Line 171: 
Line 172: def assertBridgeDoesntExist(self, bridge):


-- 
To view, visit https://gerrit.ovirt.org/59575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcceb6e16a091226ffb104e50e462a89c2e3f247
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add net removal tests based on NetFuncTestCase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: add net removal tests based on NetFuncTestCase
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcceb6e16a091226ffb104e50e462a89c2e3f247
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add net removal tests based on NetFuncTestCase

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: add net removal tests based on NetFuncTestCase
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/59575/1/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

PS1, Line 166: assertNetworkDoesntExist
> How about assertNoNetworkExists?
we want to check if a specific network does not exists, not no network at all.


-- 
To view, visit https://gerrit.ovirt.org/59575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcceb6e16a091226ffb104e50e462a89c2e3f247
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add net removal tests based on NetFuncTestCase

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: add net removal tests based on NetFuncTestCase
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/59575/1/tests/network/func_net_basic_test.py
File tests/network/func_net_basic_test.py:

PS1, Line 44: self.setupNetworks(NETREMOVAL, {}, NOCHK)
> I do not see any reason to have this in a context, there is nothing to clea
then we have to change SetupNetworks to do post hook in __call__ not in 
__enter__.


-- 
To view, visit https://gerrit.ovirt.org/59575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcceb6e16a091226ffb104e50e462a89c2e3f247
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: common tests for 'ovs' and 'legacy'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: common tests for 'ovs' and 'legacy'
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: periodic: Enforce single periodic operation per vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: periodic: Enforce single periodic operation per vm
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59576
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I270e45234fe0916d2615da904d1f6d60cc8a7874
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add net removal tests based on NetFuncTestCase

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net test: add net removal tests based on NetFuncTestCase
..


Patch Set 1: Code-Review-1

(5 comments)

https://gerrit.ovirt.org/#/c/59575/1/tests/network/func_net_basic_test.py
File tests/network/func_net_basic_test.py:

PS1, Line 41: NETSETUP
How about NETCREATE and NETREMOVE ?


PS1, Line 44: self.setupNetworks(NETREMOVAL, {}, NOCHK)
I do not see any reason to have this in a context, there is nothing to cleanup 
after a removal.


https://gerrit.ovirt.org/#/c/59575/1/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

Line 74: Aggregates multiple network checks to ease usage.
Line 75: The checks are between the requested setup (input) and current 
reported
Line 76: state (caps).
Line 77: """
Line 78: if 'remove' in netattrs:
Consider doing something like this to make it prettier:
if 'remove' in ...
...
return

...
Line 79: self.assertNetworkDoesntExist(netname)
Line 80: else:
Line 81: self.assertNetworkExists(netname)
Line 82: 


PS1, Line 166: assertNetworkDoesntExist
How about assertNoNetworkExists?


Line 164: self.assertEqual(bridged, netconf.get('bridged'))
Line 165: 
Line 166: def assertNetworkDoesntExist(self, net):
Line 167: self.assertNotIn(net, self.netinfo.networks)
Line 168: self.assertNotIn(net, self.netinfo.bridges)
Only the first assertion is relevant, we are checking if network exists, 
nothing about its bridgless or its saving in the running config.

So we have here:
assertNoBridge
assertNoNetworkExistsInRunning
Line 169: if self.running_config is not None:
Line 170: self.assertNotIn(net, self.running_config.networks)
Line 171: 
Line 172: def assert_kernel_vs_running_config(self):


-- 
To view, visit https://gerrit.ovirt.org/59575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcceb6e16a091226ffb104e50e462a89c2e3f247
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add net removal tests based on NetFuncTestCase

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: add net removal tests based on NetFuncTestCase
..


Patch Set 1: Verified+1

Test passed.

-- 
To view, visit https://gerrit.ovirt.org/59575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcceb6e16a091226ffb104e50e462a89c2e3f247
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Setup ipv6autoconf with OVS switch

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Setup ipv6autoconf with OVS switch
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add net removal tests based on NetFuncTestCase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: add net removal tests based on NetFuncTestCase
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcceb6e16a091226ffb104e50e462a89c2e3f247
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add basic bond tests based on NetFuncTestCase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: add basic bond tests based on NetFuncTestCase
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59567
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f3fde25b268ee47bc4724a8efae2ed952a78fd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: common tests for 'ovs' and 'legacy'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: common tests for 'ovs' and 'legacy'
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add net removal tests based on NetFuncTestCase

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net test: add net removal tests based on NetFuncTestCase
..

net test: add net removal tests based on NetFuncTestCase

Change-Id: Idcceb6e16a091226ffb104e50e462a89c2e3f247
Signed-off-by: Petr Horáček 
---
R tests/network/func_net_basic_test.py
M tests/network/netfunctestlib.py
2 files changed, 27 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/59575/1

diff --git a/tests/network/func_net_creation_basic_test.py 
b/tests/network/func_net_basic_test.py
similarity index 75%
rename from tests/network/func_net_creation_basic_test.py
rename to tests/network/func_net_basic_test.py
index 0b37865..d64ea0d 100644
--- a/tests/network/func_net_creation_basic_test.py
+++ b/tests/network/func_net_basic_test.py
@@ -28,10 +28,18 @@
 
 
 @attr(type='functional')
-class NetworkCreateBasicTest(NetFuncTestCase):
+class NetworkBasicTest(NetFuncTestCase):
 
 def test_add_net_based_on_nic(self):
 with dummy_device() as nic:
 NETSETUP = {NETWORK_NAME: {'nic': nic}}
 with self.setupNetworks(NETSETUP, {}, NOCHK):
 self.assertNetwork(NETWORK_NAME, NETSETUP[NETWORK_NAME])
+
+def test_remove_net_based_on_nic(self):
+with dummy_device() as nic:
+NETSETUP = {NETWORK_NAME: {'nic': nic}}
+NETREMOVAL = {NETWORK_NAME: {'remove': True}}
+with self.setupNetworks(NETSETUP, {}, NOCHK), \
+self.setupNetworks(NETREMOVAL, {}, NOCHK):
+self.assertNetwork(NETWORK_NAME, NETREMOVAL[NETWORK_NAME])
diff --git a/tests/network/netfunctestlib.py b/tests/network/netfunctestlib.py
index 61476bf..52d0ece 100644
--- a/tests/network/netfunctestlib.py
+++ b/tests/network/netfunctestlib.py
@@ -75,18 +75,21 @@
 The checks are between the requested setup (input) and current reported
 state (caps).
 """
-self.assertNetworkExists(netname)
-
-bridged = netattrs.get('bridged', True)
-if bridged:
-self.assertNetworkBridged(netname)
+if 'remove' in netattrs:
+self.assertNetworkDoesntExist(netname)
 else:
-self.assertNetworkBridgeless(netname)
+self.assertNetworkExists(netname)
 
-self.assertHostQos(netname, netattrs)
+bridged = netattrs.get('bridged', True)
+if bridged:
+self.assertNetworkBridged(netname)
+else:
+self.assertNetworkBridgeless(netname)
 
-self.assertSouthboundIface(netname, netattrs)
-self.assertVlan(netattrs)
+self.assertHostQos(netname, netattrs)
+
+self.assertSouthboundIface(netname, netattrs)
+self.assertVlan(netattrs)
 
 def assertHostQos(self, netname, netattrs):
 network_caps = self.netinfo.networks[netname]
@@ -160,6 +163,12 @@
 bridged = netattrs.get('bridged')
 self.assertEqual(bridged, netconf.get('bridged'))
 
+def assertNetworkDoesntExist(self, net):
+self.assertNotIn(net, self.netinfo.networks)
+self.assertNotIn(net, self.netinfo.bridges)
+if self.running_config is not None:
+self.assertNotIn(net, self.running_config.networks)
+
 def assert_kernel_vs_running_config(self):
 """
 This is a special test, that checks setup integrity through


-- 
To view, visit https://gerrit.ovirt.org/59575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcceb6e16a091226ffb104e50e462a89c2e3f247
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: common tests for 'ovs' and 'legacy'

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net tests: common tests for 'ovs' and 'legacy'
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/59538/5//COMMIT_MSG
Commit Message:

PS5, Line 7: common tests for
Share tests between


Line 4: Commit: Petr Horáček 
Line 5: CommitDate: 2016-06-21 18:19:52 +0200
Line 6: 
Line 7: net tests: common tests for 'ovs' and 'legacy'
Line 8: 
Better add that this is a reference example of how to prepare tests that should 
run with both ovs and legacy switches.
Line 9: Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62


-- 
To view, visit https://gerrit.ovirt.org/59538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add basic bond tests based on NetFuncTestCase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: add basic bond tests based on NetFuncTestCase
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59567
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f3fde25b268ee47bc4724a8efae2ed952a78fd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add basic bond tests based on NetFuncTestCase

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net test: add basic bond tests based on NetFuncTestCase
..

net test: add basic bond tests based on NetFuncTestCase

This patch also includes bond related assertions into
netfunctestlib.py.

Change-Id: Ib9f3fde25b268ee47bc4724a8efae2ed952a78fd
Signed-off-by: Petr Horáček 
---
A tests/network/func_bond_basic_test.py
M tests/network/netfunctestlib.py
2 files changed, 103 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/59567/1

diff --git a/tests/network/func_bond_basic_test.py 
b/tests/network/func_bond_basic_test.py
new file mode 100644
index 000..947c89d
--- /dev/null
+++ b/tests/network/func_bond_basic_test.py
@@ -0,0 +1,60 @@
+#
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+from __future__ import absolute_import
+
+from nose.plugins.attrib import attr
+
+from .netfunctestlib import NetFuncTestCase, NOCHK
+from .nettestlib import dummy_device
+
+BOND_NAME = 'bond1'
+
+
+class BondCreateBasicTemplate(NetFuncTestCase):
+__test__ = False
+
+def test_add_bond_with_two_nics(self):
+with dummy_device() as nic1, dummy_device() as nic2:
+BONDSETUP = {BOND_NAME: {'nics': [nic1, nic2],
+ 'switch': self.switch}}
+with self.setupNetworks({}, BONDSETUP, NOCHK):
+self.assertBondExists(BOND_NAME, [nic1, nic2])
+
+def test_remove_bond(self):
+with dummy_device() as nic1, dummy_device() as nic2:
+BONDSETUP_ADD = {BOND_NAME: {'nics': [nic1, nic2],
+ 'switch': self.switch}}
+BONDSETUP_REMOVE = {BOND_NAME: {'remove': True}}
+with self.setupNetworks({}, BONDSETUP_ADD, NOCHK), \
+self.setupNetworks({}, BONDSETUP_REMOVE, NOCHK):
+self.assertBondDoesntExist(BOND_NAME)
+
+
+@attr(type='functional', switch='legacy')
+class BondCreateBasicLegacyTest(BondCreateBasicTemplate):
+__test__ = True
+switch = 'legacy'
+
+
+@attr(type='functional', switch='ovs')
+class BondCreateBasicOvsTest(BondCreateBasicTemplate):
+__test__ = True
+switch = 'ovs'
diff --git a/tests/network/netfunctestlib.py b/tests/network/netfunctestlib.py
index 61476bf..93a0c11 100644
--- a/tests/network/netfunctestlib.py
+++ b/tests/network/netfunctestlib.py
@@ -160,6 +160,44 @@
 bridged = netattrs.get('bridged')
 self.assertEqual(bridged, netconf.get('bridged'))
 
+def assertBondExists(self, bondName, nics=None, options=None,
+ assert_in_running_conf=True):
+self.assertIn(bondName, self.netinfo.bondings)
+if nics is not None:
+self.assertEqual(set(nics),
+ set(self.netinfo.bondings[bondName]['slaves']))
+if assert_in_running_conf and self.running_config is not None:
+self.assertIn(bondName, self.running_config.bonds)
+self.assertEqual(set(nics),
+ set(self.running_config.bonds[bondName]['nics']))
+if options is not None:
+active_opts = self._get_active_bond_opts(bondName)
+self.assertTrue(set(options.split()) <= set(active_opts))
+
+def _get_active_bond_opts(self, bondName):
+active_options = [
+opt + '=' + val for (opt, val)
+in self.netinfo.bondings[bondName]['opts'].iteritems()]
+return active_options
+
+def assertBondDoesntExist(self, bondName, nics=None):
+if nics is None:
+self.assertNotIn(bondName, self.netinfo.bondings,
+ '%s found unexpectedly' % bondName)
+else:
+bond_exists_unchanged = (
+bondName in self.netinfo.bondings and
+set(nics) != set(self.netinfo.bondings[bondName]['slaves']))
+self.assertFalse(bond_exists_unchanged,
+ '%s found unexpectedly' % bondName)
+if self.running_config is not None:
+bond_in_running_config_unchanged = (
+

Change in vdsm[master]: net test: add basic bond tests based on NetFuncTestCase

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: add basic bond tests based on NetFuncTestCase
..


Patch Set 1: Verified+1

Passed as 'ovs' and then also as 'legacy'.

-- 
To view, visit https://gerrit.ovirt.org/59567
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f3fde25b268ee47bc4724a8efae2ed952a78fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: add basic bond tests based on NetFuncTestCase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: add basic bond tests based on NetFuncTestCase
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59567
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f3fde25b268ee47bc4724a8efae2ed952a78fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: common tests for 'ovs' and 'legacy'

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net tests: common tests for 'ovs' and 'legacy'
..


Patch Set 5: Verified+1

Tests are passing separately (when OVS is executed after legacy, it fails due 
to known bug).

to run specific switch:
./run_tests.sh -A "switch=='legacy'" network/func_net_creation_basic_test.py

When no -A specified, it runs both switches. Template is never executed.

-- 
To view, visit https://gerrit.ovirt.org/59538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Setup ipv6autoconf with OVS switch

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Setup ipv6autoconf with OVS switch
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: common tests for 'ovs' and 'legacy'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: common tests for 'ovs' and 'legacy'
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Functional tests infrastructure

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Functional tests infrastructure
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4645756c575f34cabf9536ef663ffc8009655abb
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: common tests for 'ovs' and 'legacy'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: common tests for 'ovs' and 'legacy'
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: common tests for 'ovs' and 'legacy'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: common tests for 'ovs' and 'legacy'
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If866e446f508813a5fbf28e4ef38f8aa333e6f62
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: api: Use warnings to report schema inconsistencies

[fromani]

Francesco Romani has posted comments on this change.

Change subject: api: Use warnings to report schema inconsistencies
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/59512
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5077d77b3b0e18edafa5f85073feb39cb87448cb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: api: Use warnings to report schema inconsistencies

[automation]

gerrit-hooks has posted comments on this change.

Change subject: api: Use warnings to report schema inconsistencies
..


Patch Set 3:

* #1348256::Update tracker: OK
* Set MODIFIED::bug 1348256#1348256OK

-- 
To view, visit https://gerrit.ovirt.org/59512
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5077d77b3b0e18edafa5f85073feb39cb87448cb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: api: Use warnings to report schema inconsistencies

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: api: Use warnings to report schema inconsistencies
..


api: Use warnings to report schema inconsistencies

Previously we spammed the log with warnings about conflicts between the
schema and the real usage of the apis. These warnings are useful for
developers but have negative value for users.

Now we use warnings.warn instead of logging.warning, so they do not
appear in the log by default. To enable warnings in the log, change the
configuration:

[devel]
python_warnings_enable = true

When enabled, the warnings are little more verbose now, using Python
standard warning style:

jsonrpc.Executor/2::WARNING::2016-06-01
22:23:55,551::vdsmapi::148::py.warnings::(_report_inconsistency)
/usr/lib/python2.7/site-packages/api/vdsmapi.py:148: Inconsistency: No
default value specified for systemProductName parameter in
Host.getHardwareInfo
  warnings.warn(message, Inconsistency)

Change-Id: I5077d77b3b0e18edafa5f85073feb39cb87448cb
Bug-Url: https://bugzilla.redhat.com/1348256
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/58494
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/59512
Reviewed-by: Francesco Romani 
---
M lib/api/vdsmapi.py
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/59512
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5077d77b3b0e18edafa5f85073feb39cb87448cb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: migrations: change convergence schedule from time to iterations

[fromani]

Francesco Romani has posted comments on this change.

Change subject: migrations: change convergence schedule from time to iterations
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/59219/4/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 565:iterationCount)
Line 566: 
Line 567: lastDataRemaining = dataRemaining
Line 568: 
Line 569: if (now - lastProgressTime) > progress_timeout:
> I'm worried that we change `elif' to `if' here. It's not easy to tell wheth
I agree this is worth extra care.
There is an important point to consider: the old code used the 'abort' boolean 
to call abortJob() + stop() in a single place.here after this patch we inlined 
this, so we abort early.

So it should be ok from this perspective.
OTOH, we "just" need to do the accounting, so I can perhaps move the lines 
561-567 up before the if/elif/elif chain and make the change easier to review.
Line 570: # Migration is stuck, abort
Line 571: self._vm.log.warn(
Line 572: 'Migration is stuck: Hasn\'t progressed in %s 
seconds. '
Line 573: 'Aborting.' % (now - lastProgressTime))


-- 
To view, visit https://gerrit.ovirt.org/59219
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f87c954031842c35c99888c228a34ec7f19d800
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Remove empty command infos

[automation]

gerrit-hooks has posted comments on this change.

Change subject: rpc: Remove empty command infos
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/59511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86048271e462c107043c52bf1c635fb14c20d774
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Remove empty command infos

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: rpc: Remove empty command infos
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/59511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86048271e462c107043c52bf1c635fb14c20d774
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Remove empty command infos

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: rpc: Remove empty command infos
..


rpc: Remove empty command infos

Empty command info is useless; leaving it in the code lead to creation
of more of these.

Change-Id: I86048271e462c107043c52bf1c635fb14c20d774
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/59511
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Martin Polednik 
Reviewed-by: Piotr Kliczewski 
---
M lib/vdsm/rpc/Bridge.py
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/59511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86048271e462c107043c52bf1c635fb14c20d774
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Log also error codes of RPC calls

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: rpc: Log also error codes of RPC calls
..


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/59234/10/lib/vdsm/rpc/bindingxmlrpc.py
File lib/vdsm/rpc/bindingxmlrpc.py:

Line 1209: start_time = utils.monotonic_time()
Line 1210: try:
Line 1211: logLevel = logging.DEBUG
Line 1212: suppress_args = f.__name__ in ('fenceNode',)
Line 1213: res = {}
rest should be created before the try, since you are using it in finally.
Line 1214: 
Line 1215: # TODO: This password protection code is fragile and 
ugly. Password
Line 1216: # protection should be done in the wrapped methods, and 
logging
Line 1217: # shold be done in the next layers, similar to storage 
logs.


-- 
To view, visit https://gerrit.ovirt.org/59234
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I776e667fcfd1a20a9ef5f6c638d6c3d950672314
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to 
response
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/59554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to 
response
..


jsonrpc: Pass JsonRpcInternalError instance, not class, to response

If there is a problem with processing a response in
_JsonRpcServeRequestContext.sendReply, the method generates a general
error response.  However, due to missing parentheses,
JsonRpcInternalError class, instead of JsonRpcInternalError instance, is
passed as `error' argument to JsonRpcResponse.  This leads to a crash
when JsonRpcResponse tries to access `error'.

This patch fixes the error by adding the missing parentheses.

Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a
Signed-off-by: Milan Zamazal 
Backport-To: 4.0
Backport-To: 3.6
Reviewed-on: https://gerrit.ovirt.org/59355
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/59554
Reviewed-by: Francesco Romani 
---
M lib/yajsonrpc/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Verified



-- 
To view, visit https://gerrit.ovirt.org/59554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Log RPC call summary on info level

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: rpc: Log RPC call summary on info level
..


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/59080/12/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 507:   req.method, monotonic_time() - start_time)
Line 508: if response is not None:
Line 509: ctx.requestDone(response)
Line 510: 
Line 511: def _handle_request(self, ctx, req):
> Good idea, but do we really need the server address? I think this was a hac
We were using it for getCaps and lastClient details. I think that we would 
still need it. Dan?
Line 512: self._attempt_log_stats()
Line 513: logLevel = logging.DEBUG
Line 514: 
Line 515: # VDSM should never respond to any request before all 
information about


-- 
To view, visit https://gerrit.ovirt.org/59080
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde2f1ba7394f16770543f5ca13411e8c2339cc6
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Log also error codes of RPC calls

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: rpc: Log also error codes of RPC calls
..


Patch Set 10: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/59234/10/lib/vdsm/rpc/bindingxmlrpc.py
File lib/vdsm/rpc/bindingxmlrpc.py:

Line 1273: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 1274: res = errCode['noVM']
Line 1275: else:
Line 1276: res = errCode['unexpected']
Line 1277: return res
> Not sure that it is better, I like early return and smaller scope for varia
OK
Line 1278: except VdsmException as e:
Line 1279: f.__self__.cif.log.error("vdsm exception occured", 
exc_info=True)
Line 1280: res = e.response()
Line 1281: return res


-- 
To view, visit https://gerrit.ovirt.org/59234
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I776e667fcfd1a20a9ef5f6c638d6c3d950672314
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Log also error codes of RPC calls

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: rpc: Log also error codes of RPC calls
..


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/59234/10/lib/vdsm/rpc/bindingxmlrpc.py
File lib/vdsm/rpc/bindingxmlrpc.py:

Line 1273: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 1274: res = errCode['noVM']
Line 1275: else:
Line 1276: res = errCode['unexpected']
Line 1277: return res
> why to return 3 times? We have res in scope of the wrapper so we can return
Not sure that it is better, I like early return and smaller scope for 
variables, but here it seems that we need res anyway.

We are going to delete this code soon, so better minimize the changes.
Line 1278: except VdsmException as e:
Line 1279: f.__self__.cif.log.error("vdsm exception occured", 
exc_info=True)
Line 1280: res = e.response()
Line 1281: return res


-- 
To view, visit https://gerrit.ovirt.org/59234
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I776e667fcfd1a20a9ef5f6c638d6c3d950672314
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: periodic: improve logging

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: sampling: periodic: improve logging
..


Patch Set 10: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/58972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e52a9c356be212ec72aace0f8d8aa5f1580ccb3
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Log RPC call summary on info level

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: rpc: Log RPC call summary on info level
..


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/59080/12/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 507:   req.method, monotonic_time() - start_time)
Line 508: if response is not None:
Line 509: ctx.requestDone(response)
Line 510: 
Line 511: def _handle_request(self, ctx, req):
> we only need it to get server_address. Why not to pass address only?
Good idea, but do we really need the server address? I think this was a hack to 
support old engines. Do we still need it in 3.6? If not, I would remove the 
server address from the context and the bridge (in another patch).
Line 512: self._attempt_log_stats()
Line 513: logLevel = logging.DEBUG
Line 514: 
Line 515: # VDSM should never respond to any request before all 
information about


-- 
To view, visit https://gerrit.ovirt.org/59080
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde2f1ba7394f16770543f5ca13411e8c2339cc6
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Functional tests infrastructure

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net tests: Functional tests infrastructure
..


Patch Set 14: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/58329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4645756c575f34cabf9536ef663ffc8009655abb
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Functional tests infrastructure

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net tests: Functional tests infrastructure
..


Patch Set 14: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/58329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4645756c575f34cabf9536ef663ffc8009655abb
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding report_stats to host.api

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: Adding report_stats to host.api
..


Patch Set 11: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/58661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie65c865669422b7652b028492b1380157fc5e177
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Log important info from VM stats

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: rpc: Log important info from VM stats
..


Patch Set 24: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: logging: throttledlog introduced

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: logging: throttledlog introduced
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/59461/3//COMMIT_MSG
Commit Message:

PS3, Line 9:   
Why 2 spaces in few places in this message?


https://gerrit.ovirt.org/#/c/59461/3/lib/vdsm/throttledlog.py
File lib/vdsm/throttledlog.py:

PS3, Line 27: _DEFAULT_TIMEOUT_SEC
Is there any value in making it configurable?


-- 
To view, visit https://gerrit.ovirt.org/59461
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief96f74eb84880827ccf24c3e7ae854403090b8a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Functional tests infrastructure

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Functional tests infrastructure
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4645756c575f34cabf9536ef663ffc8009655abb
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to 
response
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: API: streamline and make setLogLevel correct

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: API: streamline and make setLogLevel correct
..


Patch Set 15: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/38425/15/vdsm/API.py
File vdsm/API.py:

PS15, Line 1380: 'unavail'
> 'unavail' does not fit here, I'd rather not handle the exception at all.
I am not sure whether returning internal server error is better. It would be 
returned if unexpected error is handled by rpc code.

What about value error code here?


-- 
To view, visit https://gerrit.ovirt.org/38425
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaddbb12d13bdbaa7a02255ab209da11e42d2ea97
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: vdsm: adding handling for NGN in osinfo.py
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59431
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida119527b263302bf3f78e359bac12113718b744
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding report_stats to health reports

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: Adding report_stats to health reports
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/59065
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I885720b0b70620469c985d0079c4cbe9da74edf6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Functional tests infrastructure

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Functional tests infrastructure
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4645756c575f34cabf9536ef663ffc8009655abb
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Send host reports each sampling interval from HostMonitor

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: Send host reports each sampling interval from HostMonitor
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59067
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I724199135b89f85ac8abe7dc8073412f4764bc51
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: api: Use warnings to report schema inconsistencies

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: api: Use warnings to report schema inconsistencies
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59512
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5077d77b3b0e18edafa5f85073feb39cb87448cb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Remove empty command infos

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: rpc: Remove empty command infos
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/59511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86048271e462c107043c52bf1c635fb14c20d774
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Log RPC call summary on info level

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: rpc: Log RPC call summary on info level
..


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/59080/12/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

PS12, Line 511: ctx
we only need it to get server_address. Why not to pass address only?


-- 
To view, visit https://gerrit.ovirt.org/59080
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde2f1ba7394f16770543f5ca13411e8c2339cc6
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Functional tests infrastructure

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net tests: Functional tests infrastructure
..


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/58329/12/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

Line 200: raise SetupNetworksError(msg)
Line 201: return self
Line 202: 
Line 203: def __enter__(self):
Line 204: self.post_setup_hook()
> meh, sorry, i see now...
like you said dear Edy, when this fails, no cleanup is done.
Line 205: 
Line 206: def __exit__(self, type, value, traceback):
Line 207: networks_caps = self.vdsm_proxy.netinfo.networks
Line 208: NETSETUP = {net: {'remove': True}


-- 
To view, visit https://gerrit.ovirt.org/58329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4645756c575f34cabf9536ef663ffc8009655abb
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Log also error codes of RPC calls

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: rpc: Log also error codes of RPC calls
..


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/59234/10/lib/vdsm/rpc/bindingxmlrpc.py
File lib/vdsm/rpc/bindingxmlrpc.py:

Line 1273: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 1274: res = errCode['noVM']
Line 1275: else:
Line 1276: res = errCode['unexpected']
Line 1277: return res
why to return 3 times? We have res in scope of the wrapper so we can return 
once at the end.
Line 1278: except VdsmException as e:
Line 1279: f.__self__.cif.log.error("vdsm exception occured", 
exc_info=True)
Line 1280: res = e.response()
Line 1281: return res


-- 
To view, visit https://gerrit.ovirt.org/59234
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I776e667fcfd1a20a9ef5f6c638d6c3d950672314
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Improve thread safety of discarding executor workers

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: virt: Improve thread safety of discarding executor workers
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/58146
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4cec1a4b3c1e1aa341d90c0e02f46d0b776e9c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm.conf: Add drop-in dir

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm.conf: Add drop-in dir
..


Patch Set 20:

* #1279555::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279555::OK, public bug
* Check Product::#1279555::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3849829aca50b30742e9c860d7c19296d6361015
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: removed unnecessary calls to vdsm config.read

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: removed unnecessary calls to vdsm config.read
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59513
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I965d5adf0c2d5857109cfeca936c9a3139c111cb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Send host reports each sampling interval from HostMonitor

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Send host reports each sampling interval from HostMonitor
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59067
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I724199135b89f85ac8abe7dc8073412f4764bc51
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding report_stats to host.api

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Adding report_stats to host.api
..


Patch Set 11: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/58661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie65c865669422b7652b028492b1380157fc5e177
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: externalize api_strict_mode

[fromani]

Francesco Romani has posted comments on this change.

Change subject: schema: externalize api_strict_mode
..


Patch Set 22: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93dad74177d1991c322988b6bf9f0887701ee47a
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: externalize api_strict_mode

[fromani]

Francesco Romani has posted comments on this change.

Change subject: schema: externalize api_strict_mode
..


Patch Set 22:

I guess the +2 from PS21 was lost due the rebase

-- 
To view, visit https://gerrit.ovirt.org/56386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93dad74177d1991c322988b6bf9f0887701ee47a
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: infra: moved infra package contents from lib/vdsm to lib/vds...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: infra: moved infra package contents from lib/vdsm to 
lib/vdsm/common
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ffd40750048371c58628dec5890b9f8f97d22b6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Log important info from VM stats

[fromani]

Francesco Romani has posted comments on this change.

Change subject: rpc: Log important info from VM stats
..


Patch Set 24: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rpc: Log important info from VM stats

[fromani]

Francesco Romani has posted comments on this change.

Change subject: rpc: Log important info from VM stats
..


Patch Set 24:

please rebase on top of master to get rid of jenkins error (which was real, but 
unrelated)

-- 
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

[fromani]

Francesco Romani has posted comments on this change.

Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to 
response
..


Patch Set 1:

Fair enough, let's sneak this in.

-- 
To view, visit https://gerrit.ovirt.org/59554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: logging: throttledlog introduced

[fromani]

Francesco Romani has posted comments on this change.

Change subject: logging: throttledlog introduced
..


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/59461/3//COMMIT_MSG
Commit Message:

PS3, Line 7: logging: throttledlog introduced
silly nit/for future patches: I prefer the active form "introduce throttledlog"
but *definitely* not worth a resubmit just for this.


-- 
To view, visit https://gerrit.ovirt.org/59461
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief96f74eb84880827ccf24c3e7ae854403090b8a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: logging: throttledlog introduced

[fromani]

Francesco Romani has posted comments on this change.

Change subject: logging: throttledlog introduced
..


Patch Set 3:

please rebase on top of master to get rid of jenkins error (which was real, but 
unrelated)

-- 
To view, visit https://gerrit.ovirt.org/59461
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief96f74eb84880827ccf24c3e7ae854403090b8a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to 
response
..


Patch Set 1:

> But do we have a BZ we can piggyback on?

No, we don't, it was discovered by chance and I didn't bother to file a bug for 
this simple fix.

-- 
To view, visit https://gerrit.ovirt.org/59554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

[fromani]

Francesco Romani has posted comments on this change.

Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to 
response
..


Patch Set 1: Code-Review+2

This change is trivial so I can make one exception about the BZ requirement. 
But do we have a BZ we can piggyback on?

-- 
To view, visit https://gerrit.ovirt.org/59554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: infra: moved infra package contents from lib/vdsm to lib/vds...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: infra: moved infra package contents from lib/vdsm to 
lib/vdsm/common
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ffd40750048371c58628dec5890b9f8f97d22b6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Setup ipv6autoconf with OVS switch

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Setup ipv6autoconf with OVS switch
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Create an external ifcfg bond in a context

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: Create an external ifcfg bond in a context
..


Patch Set 2:

Sorry for the noise, now I understand it.

-- 
To view, visit https://gerrit.ovirt.org/59448
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7295a9a1eafeef9a2643dd8f3aa64b25797d3810
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Create an external ifcfg bond in a context

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: Create an external ifcfg bond in a context
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59448
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7295a9a1eafeef9a2643dd8f3aa64b25797d3810
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Setup ipv6autoconf with OVS switch

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Setup ipv6autoconf with OVS switch
..


Patch Set 4: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/59444/3/lib/vdsm/sysctl.py
File lib/vdsm/sysctl.py:

PS3, Line 96: with open('/proc/sys/net/ipv6/conf/%s/accept_redirects' % 
dev, 'w') as f:
: f.write(setstate)
> fits one line now
Done


-- 
To view, visit https://gerrit.ovirt.org/59444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Setup ipv6autoconf with OVS switch

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Setup ipv6autoconf with OVS switch
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to 
response
..


Patch Set 1: Verified+1

Verified that there is no attribute error traceback when JsonRpcInternalError 
is created and that Engine receives appropriate response:

  error = Internal JSON-RPC error., code = -32603

-- 
To view, visit https://gerrit.ovirt.org/59554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: move ip configuration to ip.address module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: move ip configuration to ip.address module
..


Patch Set 13:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58447
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19fb50a41d9798b8f9b6c9c7549a4415c940f5a0
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: netswitch: split setup actions on netswitch level

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netswitch: split setup actions on netswitch level
..


Patch Set 14:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4164e09735dfbd6853b0ac296760895ee62c9449
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: netswitch: split setup actions on netswitch level

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netswitch: split setup actions on netswitch level
..


Patch Set 13:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4164e09735dfbd6853b0ac296760895ee62c9449
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to 
response
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/59554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

[mzamazal]

Hello Piotr Kliczewski,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/59554

to review the following change.

Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to 
response
..

jsonrpc: Pass JsonRpcInternalError instance, not class, to response

If there is a problem with processing a response in
_JsonRpcServeRequestContext.sendReply, the method generates a general
error response.  However, due to missing parentheses,
JsonRpcInternalError class, instead of JsonRpcInternalError instance, is
passed as `error' argument to JsonRpcResponse.  This leads to a crash
when JsonRpcResponse tries to access `error'.

This patch fixes the error by adding the missing parentheses.

Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a
Signed-off-by: Milan Zamazal 
Backport-To: 4.0
Backport-To: 3.6
Reviewed-on: https://gerrit.ovirt.org/59355
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
---
M lib/yajsonrpc/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/59554/1

diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py
index fe6daa5..ec3b5ed 100644
--- a/lib/yajsonrpc/__init__.py
+++ b/lib/yajsonrpc/__init__.py
@@ -279,7 +279,7 @@
 try:
 encodedObjects.append(response.encode())
 except:  # Error encoding data
-response = JsonRpcResponse(None, JsonRpcInternalError,
+response = JsonRpcResponse(None, JsonRpcInternalError(),
response.id)
 encodedObjects.append(response.encode())
 


-- 
To view, visit https://gerrit.ovirt.org/59554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Functional tests infrastructure

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net tests: Functional tests infrastructure
..


Patch Set 12:

(1 comment)

OVS cleanup does not work after assert failture

https://gerrit.ovirt.org/#/c/58329/12/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

Line 208: NETSETUP = {net: {'remove': True}
Line 209: for net in self.setup_networks if net in 
networks_caps}
Line 210: status, msg = self.vdsm_proxy.setupNetworks(NETSETUP, {}, 
NOCHK)
Line 211: if type is None and status != SUCCESS:
Line 212: raise SetupNetworksError(msg)
> we should log error value, not msg of removal setup
i understand now.
Line 213: 
Line 214: 
Line 215: def _normalize_caps(netinfo_from_caps):
Line 216: """


-- 
To view, visit https://gerrit.ovirt.org/58329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4645756c575f34cabf9536ef663ffc8009655abb
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Functional tests infrastructure

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net tests: Functional tests infrastructure
..


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/58329/12/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

Line 200: raise SetupNetworksError(msg)
Line 201: return self
Line 202: 
Line 203: def __enter__(self):
Line 204: self.post_setup_hook()
> why is post_setup in __enter__?
meh, sorry, i see now...
Line 205: 
Line 206: def __exit__(self, type, value, traceback):
Line 207: networks_caps = self.vdsm_proxy.netinfo.networks
Line 208: NETSETUP = {net: {'remove': True}


-- 
To view, visit https://gerrit.ovirt.org/58329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4645756c575f34cabf9536ef663ffc8009655abb
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Functional tests infrastructure

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net tests: Functional tests infrastructure
..


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/58329/12/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

Line 208: NETSETUP = {net: {'remove': True}
Line 209: for net in self.setup_networks if net in 
networks_caps}
Line 210: status, msg = self.vdsm_proxy.setupNetworks(NETSETUP, {}, 
NOCHK)
Line 211: if type is None and status != SUCCESS:
Line 212: raise SetupNetworksError(msg)
we should log error value, not msg of removal setup
Line 213: 
Line 214: 
Line 215: def _normalize_caps(netinfo_from_caps):
Line 216: """


-- 
To view, visit https://gerrit.ovirt.org/58329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4645756c575f34cabf9536ef663ffc8009655abb
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: openstacknet: add MidoNet support

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: openstacknet: add MidoNet support
..


Patch Set 2:

Verified up to the point where the xml passed to libvirt is correct.
It still needs verification to see if the generated xml will work with midonet.

-- 
To view, visit https://gerrit.ovirt.org/59255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5cb84c155b46603e05951238ad16182081dbe10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Functional tests infrastructure

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net tests: Functional tests infrastructure
..


Patch Set 12: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/58329/12/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

Line 200: raise SetupNetworksError(msg)
Line 201: return self
Line 202: 
Line 203: def __enter__(self):
Line 204: self.post_setup_hook()
why is post_setup in __enter__?
Line 205: 
Line 206: def __exit__(self, type, value, traceback):
Line 207: networks_caps = self.vdsm_proxy.netinfo.networks
Line 208: NETSETUP = {net: {'remove': True}


-- 
To view, visit https://gerrit.ovirt.org/58329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4645756c575f34cabf9536ef663ffc8009655abb
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org