Edward Haas has posted comments on this change.
Change subject: net tests: separate a resolv.conf test from NetInfo tests
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/62723/1/tests/network/resolv_test.py
File
Edward Haas has posted comments on this change.
Change subject: net: move name resolver functions from netinfo to ip
..
Patch Set 2: Code-Review-1
(2 comments)
Edward Haas has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 3:
Per the current limited usage, I do not think it is worth importing a 3rd party
library (like python-atomicwrites).
That
gerrit-hooks has posted comments on this change.
Change subject: build: require only the same version, not release
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: require only the same version, not release
..
build: require only the same version, not release
The various vdsm subpackages where requiring
Dan Kenigsberg has posted comments on this change.
Change subject: build: require only the same version, not release
..
Patch Set 1: Code-Review+2
raising, does not seem dangerous
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
gerrit-hooks has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 1:
* #1363734::Update tracker: OK
* #1364339::Update tracker: OK
* #1366176::Update tracker: OK
* Check
gerrit-hooks has posted comments on this change.
Change subject: lvm: Never hide lvm errors
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check Public Bug::WARN, no
gerrit-hooks has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 1: Verified-1
* #1363734::Update tracker: OK
* #1364339::Update tracker: OK
* #1366176::Update tracker: OK
gerrit-hooks has posted comments on this change.
Change subject: lvm: Refresh lvs during activation
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: lvm: Improve logging lv activation logging
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62740
to review the following change.
Change subject: lvm: Separate lv reduce and extend
..
lvm: Separate lv
gerrit-hooks has posted comments on this change.
Change subject: lvm: Never hide lvm errors
..
Patch Set 1: Verified-1
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check Public
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62738
to review the following change.
Change subject: lvm: Never hide lvm errors
..
lvm: Never hide lvm errors
In changelv, if
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62736
to review the following change.
Change subject: lvm: Refresh lvs during activation
..
lvm: Refresh lvs
gerrit-hooks has posted comments on this change.
Change subject: lvm: Refresh lvs during activation
..
Patch Set 1: Verified-1
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62739
to review the following change.
Change subject: lvm: Fix error handling when resizing lvs
..
lvm: Fix error
gerrit-hooks has posted comments on this change.
Change subject: lvm: Improve logging lv activation logging
..
Patch Set 1: Verified-1
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
*
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62737
to review the following change.
Change subject: lvm: Improve logging lv activation logging
..
lvm: Improve logging lv
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62735
to review the following change.
Change subject: lvm: Separate lv reduce and extend
..
lvm: Separate lv
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62731
to review the following change.
Change subject: lvm: Refresh lvs during activation
..
lvm: Refresh lvs
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62734
to review the following change.
Change subject: lvm: Fix error handling when resizing lvs
..
lvm: Fix error
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62733
to review the following change.
Change subject: lvm: Never hide lvm errors
..
lvm: Never hide lvm errors
In changelv, if
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62732
to review the following change.
Change subject: lvm: Improve logging lv activation logging
..
lvm: Improve logging lv
gerrit-hooks has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Adam Litke has submitted this change and it was merged.
Change subject: lvm: Separate lv reduce and extend
..
lvm: Separate lv reduce and extend
Reducing and extending logical volumes were mixed in a horrible and
buggy mess in
gerrit-hooks has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 6:
* #1363734::Update tracker: OK
* #1364339::Update tracker: OK
* #1366176::Update tracker: OK
* Set
gerrit-hooks has posted comments on this change.
Change subject: lvm: Never hide lvm errors
..
Patch Set 4:
* update_tracker: OK
* Set MODIFIED::bug 1358348#1358348::IGNORE, skipping for branch 'master'
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: lvm: Improve logging lv activation logging
..
Patch Set 4:
* update_tracker: OK
* Set MODIFIED::bug 1358348#1358348::IGNORE, skipping for branch 'master'
--
Adam Litke has submitted this change and it was merged.
Change subject: lvm: Improve logging lv activation logging
..
lvm: Improve logging lv activation logging
Log vg name and lv names when we activate, refresh or deactivate
Adam Litke has submitted this change and it was merged.
Change subject: lvm: Never hide lvm errors
..
lvm: Never hide lvm errors
In changelv, if lvm command has failed but stdout is not empty, the
error was ignored silently.
Adam Litke has submitted this change and it was merged.
Change subject: lvm: Fix error handling when resizing lvs
..
lvm: Fix error handling when resizing lvs
We depended on undocumented and wrong behavior in lvextend,
gerrit-hooks has posted comments on this change.
Change subject: lvm: Never hide lvm errors
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check Public Bug::WARN, no
gerrit-hooks has posted comments on this change.
Change subject: lvm: Improve logging lv activation logging
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358348::ERROR, private bug
* Check
Adam Litke has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62338
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62369
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: lvm: Refresh lvs during activation
..
Patch Set 2:
* update_tracker: OK
* Set MODIFIED::bug 1358348#1358348::IGNORE, skipping for branch 'master'
--
To
Adam Litke has submitted this change and it was merged.
Change subject: lvm: Refresh lvs during activation
..
lvm: Refresh lvs during activation
Previously we used to activate only the inactive lvs, and ignore the
active lvs
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding units to cpu metrics name according to metrics2.0 spec
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/62156/4/lib/vdsm/virt/vmstats.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding units to memory metrics name according to metrics2.0 spec
..
Patch Set 4: Code-Review-1
(2 comments)
gerrit-hooks has posted comments on this change.
Change subject: Adding memTotal metric
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/62154
To unsubscribe, visit
Yaniv Bronhaim has abandoned this change.
Change subject: Adding memTotal metric
..
Abandoned
not relevant for now.
--
To view, visit https://gerrit.ovirt.org/62154
To unsubscribe, visit https://gerrit.ovirt.org/settings
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding memTotal metric
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/62154/4/lib/vdsm/host/api.py
File lib/vdsm/host/api.py:
PS4, Line 99: _M
>
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 3: Code-Review+2
(2 comments)
https://gerrit.ovirt.org/#/c/61950/3/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 949:
Yaniv Bronhaim has posted comments on this change.
Change subject: after_vm_start: migrate to jsonrpcvdsli
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62713
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62383
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpcvdscli: add default value to request queue argument
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62730
To unsubscribe,
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 4: Verified+1
(2 comments)
No significant changes, restoring V+1.
gerrit-hooks has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 4:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 17:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: after_vm_start: migrate to jsonrpcvdsli
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Irit Goihman has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/62383/4/vdsm_hooks/vhostmd/after_vm_destroy.py
File
Irit Goihman has posted comments on this change.
Change subject: jsonrpcvdscli: add default value to request queue argument
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62730
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: add default value to request queue argument
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Irit Goihman has uploaded a new change for review.
Change subject: jsonrpcvdscli: add default value to request queue argument
..
jsonrpcvdscli: add default value to request queue argument
requestQueue argument of
Yaniv Bronhaim has posted comments on this change.
Change subject: build: require only the same version, not release
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62672
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: support configuring nameservers by ovs
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/62706/3/lib/vdsm/network/netswitch.py
File
Petr Horáček has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 3: Code-Review-1
(9 comments)
https://gerrit.ovirt.org/#/c/62705/3/lib/vdsm/network/ip/resolv.py
File
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: filter out Xen VMs with block storage
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/62368/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7:
Petr Horáček has posted comments on this change.
Change subject: net tests: separate a resolv.conf test from NetInfo tests
..
Patch Set 1: Code-Review-1
(2 comments)
Petr Horáček has posted comments on this change.
Change subject: net: move name resolver functions from netinfo to ip
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62704
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 4: Verified+1
network/*_test.py passed OK.
--
To view, visit https://gerrit.ovirt.org/61956
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: ovs: use vdsmbr_test name for test bridges
..
Patch Set 2: Verified+1
network/*_test.py passed OK.
--
To view, visit https://gerrit.ovirt.org/62303
To
Petr Horáček has posted comments on this change.
Change subject: ovs: add OVS bridges cleanup to shell_helper
..
Patch Set 5: Verified+1
Removes vdsmbr_* OVS bridges.
--
To view, visit https://gerrit.ovirt.org/61688
To
Piotr Kliczewski has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 4: Code-Review-1
(1 comment)
gerrit-hooks has posted comments on this change.
Change subject: net: support configuring nameservers by ovs
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: support configuring nameservers by ovs
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: net: move name resolver functions from netinfo to ip
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net tests: separate a resolv.conf test from NetInfo tests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Ondřej Svoboda has uploaded a new change for review.
Change subject: net tests: separate a resolv.conf test from NetInfo tests
..
net tests: separate a resolv.conf test from NetInfo tests
Change-Id:
Ondřej Svoboda has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/62705/1/lib/vdsm/network/ip/resolv.py
File
gerrit-hooks has posted comments on this change.
Change subject: stomp: use socket pending
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stomp: use socket pending
..
stomp: use socket pending
Dispatcher pending method is deprecated and we want to use socket
pending method instead.
Dan Kenigsberg has posted comments on this change.
Change subject: stomp: use socket pending
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61816
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: use socket pending
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61816
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: yml: return type fixes for StoragePool.getInfo
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: yml: return type fixes for StoragePool.getInfo
..
yml: return type fixes for StoragePool.getInfo
Signed-off-by: Piotr Kliczewski
Dan Kenigsberg has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/62383/4/vdsm_hooks/vhostmd/after_vm_destroy.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: sos: replace dumpStorageTable with dump_volume_chains
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62628/2/vdsm/sos/vdsm.py.in
File
Milan Zamazal has posted comments on this change.
Change subject: api: Move getAllVmStats hooks and logging from API to clientIF
..
Patch Set 2:
No problem, I don't think we are in an urgent need of this patch so we can wait
Dan Kenigsberg has submitted this change and it was merged.
Change subject: enabling ppc64le builds for vdsm
..
enabling ppc64le builds for vdsm
Changing repos to be multi arch and support ppc64le.
Splitting
gerrit-hooks has posted comments on this change.
Change subject: enabling ppc64le builds for vdsm
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: enabling ppc64le builds for vdsm
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/62123/17/automation/check-patch.repos.el7
File
Yaniv Bronhaim has posted comments on this change.
Change subject: enabling ppc64le builds for vdsm
..
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: enabling ppc64le builds for vdsm
..
Patch Set 17: Code-Review+2
raising, so we can get ppcle running.
--
To view, visit https://gerrit.ovirt.org/62123
To
gerrit-hooks has posted comments on this change.
Change subject: Fix configfile for py3 to use unicode
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix configfile for py3 to use unicode
..
Fix configfile for py3 to use unicode
Change-Id: I52f11a1a10cae46773d05d0c09da80ad8eb3b772
Signed-off-by:
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 4:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: ovs: add OVS bridges cleanup to shell_helper
..
Patch Set 5:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: test: Introduce mock module for testing
..
Patch Set 3: Verified-1
* #1364081::Update tracker: OK
* Check Bug-Url::ERROR, At least one bug-url is required for
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 4:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: ovs: use vdsmbr_test name for test bridges
..
Patch Set 2:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 3:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: Introduce dhclient state check.
..
Patch Set 2:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check
1 - 100 of 157 matches
Mail list logo