Change in vdsm[master]: spec: bridge-utils are required for tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: bridge-utils are required for tests
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Inline LockType.validate

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Inline LockType.validate
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63627
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8205fb724d52eeedcc86c0f53656b2502721e1d0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Flatten LockType constants

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Flatten LockType constants
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id78e07814f21a1dcf33efa2afe400eff041e3001
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused method

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Remove unused method
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d50f2dc83e5f50c3bdc4b7401e06d4813c2b1e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Flatten LockType constants

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: resourceManager: Flatten LockType constants
..

resourceManager: Flatten LockType constants

Replace the LockType class with flat constants, streamlining client
code.

Change-Id: Id78e07814f21a1dcf33efa2afe400eff041e3001
Signed-off-by: Nir Soffer 
---
M tests/resourceManagerTests.py
M tests/storage_sdm_copy_data_test.py
M tests/storage_sdm_create_volume_test.py
M tests/storage_volume_test.py
M vdsm/storage/blockVolume.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/resourceFactories.py
M vdsm/storage/resourceManager.py
M vdsm/storage/sdm/api/copy_data.py
M vdsm/storage/sdm/api/create_volume.py
M vdsm/storage/sp.py
M vdsm/storage/task.py
M vdsm/storage/volume.py
14 files changed, 119 insertions(+), 138 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/63628/1

diff --git a/tests/resourceManagerTests.py b/tests/resourceManagerTests.py
index bc3002c..91f0b20 100644
--- a/tests/resourceManagerTests.py
+++ b/tests/resourceManagerTests.py
@@ -126,7 +126,7 @@
 def testErrorInFactory(self):
 manager = self.manager
 req = manager.registerResource("error", "resource",
-   resourceManager.LockType.exclusive,
+   resourceManager.EXCLUSIVE,
lambda req, res: 1)
 self.assertTrue(req.canceled())
 
@@ -153,10 +153,9 @@
 
 manager = self.manager
 exclusive1 = manager.acquireResource(
-"failAfterSwitch", "resource", resourceManager.LockType.exclusive)
+"failAfterSwitch", "resource", resourceManager.EXCLUSIVE)
 sharedReq1 = manager.registerResource(
-"failAfterSwitch", "resource", resourceManager.LockType.shared,
-callback)
+"failAfterSwitch", "resource", resourceManager.SHARED, callback)
 exclusive1.release()
 self.assertTrue(sharedReq1.canceled())
 self.assertEquals(resources[0], None)
@@ -172,11 +171,9 @@
 def testRequestInvalidResource(self):
 manager = self.manager
 self.assertRaises(ValueError, manager.acquireResource,
-  "storage", "DOT.DOT",
-  resourceManager.LockType.shared)
+  "storage", "DOT.DOT", resourceManager.SHARED)
 self.assertRaises(ValueError, manager.acquireResource,
-  "DOT.DOT", "resource",
-  resourceManager.LockType.shared)
+  "DOT.DOT", "resource", resourceManager.SHARED)
 
 def testReleaseInvalidResource(self):
 manager = self.manager
@@ -190,7 +187,7 @@
 s = StringIO
 with manager.acquireResource(
 "string", "test",
-resourceManager.LockType.exclusive) as resource:
+resourceManager.EXCLUSIVE) as resource:
 for attr in dir(s):
 if attr == "close":
 continue
@@ -200,7 +197,7 @@
 manager = self.manager
 with manager.acquireResource(
 "string", "test",
-resourceManager.LockType.exclusive) as resource:
+resourceManager.EXCLUSIVE) as resource:
 try:
 resource.THERE_IS_NO_WAY_I_EXIST
 except AttributeError:
@@ -220,7 +217,7 @@
 
 manager = self.manager
 req = manager.registerResource(
-"string", "resource", resourceManager.LockType.shared, callback)
+"string", "resource", resourceManager.SHARED, callback)
 try:
 req.grant()
 except AttributeError:
@@ -242,7 +239,7 @@
 
 manager = self.manager
 req = manager.registerResource(
-"string", "resource", resourceManager.LockType.shared, callback)
+"string", "resource", resourceManager.SHARED, callback)
 try:
 str(req)
 finally:
@@ -259,9 +256,9 @@
 
 manager = self.manager
 req1 = manager.registerResource(
-"string", "resource", resourceManager.LockType.exclusive, callback)
+"string", "resource", resourceManager.EXCLUSIVE, callback)
 req2 = manager.registerResource(
-"string", "resource", resourceManager.LockType.exclusive, callback)
+"string", "resource", resourceManager.EXCLUSIVE, callback)
 
 self.assertNotEqual(req1, req2)
 self.assertEqual(req1, req1)
@@ -288,9 +285,9 @@
 
 manager = self.manager
 blocker = manager.acquireResource("string", "resource",
-  resourceManager.LockType.exclusive)
+  resourceManager.EXCLUSIVE)
 req = manager.registerResource(
-"string", "resource", 

Change in vdsm[master]: resourceManager: Remove unused method

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: resourceManager: Remove unused method
..

resourceManager: Remove unused method

LockType.fromState is not used. Remove it so we can replace the LockType
class with flat constants.

Change-Id: I4d50f2dc83e5f50c3bdc4b7401e06d4813c2b1e0
Signed-off-by: Nir Soffer 
---
M vdsm/storage/resourceManager.py
1 file changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/63626/1

diff --git a/vdsm/storage/resourceManager.py b/vdsm/storage/resourceManager.py
index 17ee206..82db9cb 100644
--- a/vdsm/storage/resourceManager.py
+++ b/vdsm/storage/resourceManager.py
@@ -62,14 +62,6 @@
 if ltype not in validValues:
 raise ValueError("invalid lock type '%s'" % ltype)
 
-@classmethod
-def fromState(cls, lockstate):
-if lockstate == LockState.shared:
-return cls.shared
-elif lockstate == LockState.locked:
-return cls.exclusive
-raise ValueError("invalid lockstate %s" % lockstate)
-
 
 class LockState:
 free = "free"


-- 
To view, visit https://gerrit.ovirt.org/63626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d50f2dc83e5f50c3bdc4b7401e06d4813c2b1e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Inline LockType.validate

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: resourceManager: Inline LockType.validate
..

resourceManager: Inline LockType.validate

Inline the function in the single call site, allowing replacing LockType
with flat constants.

Change-Id: I8205fb724d52eeedcc86c0f53656b2502721e1d0
Signed-off-by: Nir Soffer 
---
M vdsm/storage/resourceManager.py
1 file changed, 2 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/63627/1

diff --git a/vdsm/storage/resourceManager.py b/vdsm/storage/resourceManager.py
index 82db9cb..b766082 100644
--- a/vdsm/storage/resourceManager.py
+++ b/vdsm/storage/resourceManager.py
@@ -56,12 +56,6 @@
 shared = "shared"
 exclusive = "exclusive"
 
-@classmethod
-def validate(cls, ltype):
-validValues = ["shared", "exclusive"]
-if ltype not in validValues:
-raise ValueError("invalid lock type '%s'" % ltype)
-
 
 class LockState:
 free = "free"
@@ -530,7 +524,8 @@
 if not self._resourceNameValidator.match(name):
 raise ValueError("Invalid resource name '%s'" % name)
 
-LockType.validate(lockType)
+if lockType not in (LockType.shared, LockType.exclusive):
+raise ValueError("invalid lock type %r" % lockType)
 
 request = Request(namespace, name, lockType, callback)
 self._log.debug("Trying to register resource '%s' for lock type '%s'",


-- 
To view, visit https://gerrit.ovirt.org/63627
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8205fb724d52eeedcc86c0f53656b2502721e1d0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: Clean lease files on setup-cleanup
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/63089/9/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

Line 416: NETSETUP = {net: {'remove': True}
Line 417: for net in self.setup_networks if net in 
networks_caps}
Line 418: BONDSETUP = {bond: {'remove': True}
Line 419:  for bond in self.setup_bonds if bond in 
bonds_caps}
Line 420: status, msg = self.vdsm_proxy.setupNetworks(NETSETUP, 
BONDSETUP, NOCHK)
> This is an attempt to cleanup after a test, not after each setupNetworks.
That's my point. You cannot clean up all lease files from this setup like this. 
If you have a test where you set and removed a network it is not listed in caps 
anymore and therefore you don't have it's iface there and cannot remove the 
file.
Line 421: 
Line 422: nics_used = [attr['nic']
Line 423:  for attr in six.itervalues(self.setup_networks)
Line 424:  if 'nic' in attr]


-- 
To view, visit https://gerrit.ovirt.org/63089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net test: Clean lease files on setup-cleanup
..


Patch Set 10: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - preserve original slaves link state.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Bond - preserve original slaves link state.
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia98d01512322f88bf9819532afb2ea337cee7749
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - add refresh method to update bond config

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Bond - add refresh method to update bond config
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63445
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f36cc24833b0fc612c3af033c54c7bca4742a5a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - adding a transaction context.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Bond - adding a transaction context.
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63443
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d015ed235c3620c04131e57ad079a2ec1a0ecc
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: Clean lease files on setup-cleanup
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - Add logging to the bond driver.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Bond - Add logging to the bond driver.
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I043a6232d59cd87f6b973d856df297322f4be387
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose owned_device method through the configurator

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Expose owned_device method through the configurator
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1febd494c5a01ceecd894e8542c1adb3cda704a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 20:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - Expose the (kernel) bond list.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Bond - Expose the (kernel) bond list.
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63234
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba2b9d5ec712b268cc3775682506ec83aabbdb8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Disable special OVS handling for exteranal network

[edwardh]

Edward Haas has posted comments on this change.

Change subject: virt net: Disable special OVS handling for exteranal network
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63621/1/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_migrate_hook.py:

Line 85: def _set_bridge_interfaces(devices, target_vm_conf):
Line 86: target_vm_nets_by_vnic_mac = {dev['macAddr']: dev['network']
Line 87:   for dev in target_vm_conf['devices']
Line 88:   if dev.get('type') == 'interface'}
Line 89: exernal_by_mac = {dev['macAddr']: dev.get('custom').
I understand the need, but it looks so strange mixing this into this whole 
thing.
If the external network is injected as a vdsm hook, why is it mentioned in a 
non-hook code? (although this is a libvirt hook, it is a permanent one injected 
by VDSM, not an optional one).

If we are to place it here, I think we need a hook point inside this hook (wow, 
hook in hook) and make sure that the external network package/hook sets itself 
into it.
What do you think? Is that possible?
Line 90:   get('provider_type') == EXTERNAL_NETWORK
Line 91:   for dev in target_vm_conf['devices']
Line 92:   if dev.get('type') == 'interface' and 
dev.get('custom')}
Line 93: 


-- 
To view, visit https://gerrit.ovirt.org/63621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0aa5846040a80773a65a14d3e93624e4491c229
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: StorageDomain.getInfo - report lvm metadata device for block sd

[alitke]

Adam Litke has posted comments on this change.

Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..


Patch Set 4:

(1 comment)

Update to the commit message is needed.

https://gerrit.ovirt.org/#/c/63027/4//COMMIT_MSG
Commit Message:

Line 4: Commit: Liron Aravot 
Line 5: CommitDate: 2016-09-05 09:46:20 +0300
Line 6: 
Line 7: StorageDomain.getInfo - report lvm metadata device for block sd
Line 8: 
Please add a sentence here to explain what this is needed for.  Someone looking 
at this commit will have no context why this is needed.
Line 9: Change-Id: I32c847ae89b9f8f512c3dd8a0fff96fbc753ee5b


-- 
To view, visit https://gerrit.ovirt.org/63027
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32c847ae89b9f8f512c3dd8a0fff96fbc753ee5b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 17:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: sdm: Use guarded.context in copy_data
..


sdm: Use guarded.context in copy_data

Take the appropriate ResourceManager locks and a Volume Lease on the
destination volume when performing a copy_data operation.

Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/61693
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M tests/storage_sdm_copy_data_test.py
M vdsm/storage/sdm/api/copy_data.py
2 files changed, 86 insertions(+), 24 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Pass scheduler to jobs.start

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Pass scheduler to jobs.start
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5004b49b992ae0f7171a0f0549465cc8782d05da
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Move run from sdm.base.Job to jobs.Job

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jobs: Move run from sdm.base.Job to jobs.Job
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I194eb154d70e846b7ec5d462faa26b3aa35d2ff6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Autodelete

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jobs: Autodelete
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aafd2271397bd9bc4289dc1aab723398d475add
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 16: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 16: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 15: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 15:

(4 comments)

https://gerrit.ovirt.org/#/c/61693/14/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 39
Line 40
Line 41
Line 42
Line 43
> This tests copying divs, maybe rename to TestCopyDataDIV?
Done


Line 48
Line 49
Line 50
Line 51
Line 52
> Same
Done


https://gerrit.ovirt.org/#/c/61693/15/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 40: 
Line 41: import storage.sdm.api.copy_data
Line 42: 
Line 43: 
Line 44: class fake_guarded_context(object):
> Why use non standard class name?
context managers are supposed to be lowercase.  that's why we have 
guarded.context and not guarded.Context
Line 45: 
Line 46: def __init__(self):
Line 47: self.locks = None
Line 48: 


Line 47: self.locks = None
Line 48: 
Line 49: def __call__(self, locks=None):
Line 50: if locks is not None:
Line 51: self.locks = locks
> Why do we need this check? each time we call this, we want to save the new 
Nope.  We call it when checking the locks (to get the instance) and in that 
case we don't want to overwrite the locks that were set by copy_data.
Line 52: return self
Line 53: 
Line 54: def __enter__(self):
Line 55: return self


-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 15: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/61693/15/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 40: 
Line 41: import storage.sdm.api.copy_data
Line 42: 
Line 43: 
Line 44: class fake_guarded_context(object):
Why use non standard class name?
Line 45: 
Line 46: def __init__(self):
Line 47: self.locks = None
Line 48: 


Line 47: self.locks = None
Line 48: 
Line 49: def __call__(self, locks=None):
Line 50: if locks is not None:
Line 51: self.locks = locks
Why do we need this check? each time we call this, we want to save the new 
locks - always.
Line 52: return self
Line 53: 
Line 54: def __enter__(self):
Line 55: return self


-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 17:

(1 comment)

https://gerrit.ovirt.org/#/c/62831/17/lib/vdsm/network/link/setup.py
File lib/vdsm/network/link/setup.py:

PS17, Line 46: attrs
> I'm not sure if i understand. You say that only removal has potential to le
Your are correct: "But what if first slaves addition fail?"
I missed that one.

if this is the case, then I think there is no need to use the initial bond 
object trick, it can just be reused and let it fall back to a 'stable' state 
(one that is saved in running config).

I'll try that, thanks.


-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Drop support for thread-local job_id

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Drop support for thread-local job_id
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62083
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4697f2d3f5e6826e0e95e03a10445c2df2abddf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Drop support for thread-local job_id

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdm: Drop support for thread-local job_id
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62083/2/tests/storage_sdm_api_test.py
File tests/storage_sdm_api_test.py:

Line 36
Line 37
Line 38
Line 39
Line 40
> What are we testing here now?
This is a utility used by other tests.  It still tests that the job starts in 
pending stage.  Otherwise, it runs and waits for a job.  I'd like to keep it.


-- 
To view, visit https://gerrit.ovirt.org/62083
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4697f2d3f5e6826e0e95e03a10445c2df2abddf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Pass scheduler to jobs.start

[alitke]

Adam Litke has posted comments on this change.

Change subject: Pass scheduler to jobs.start
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62000/2/tests/jobsTests.py
File tests/jobsTests.py:

Line 63: class JobsTests(VdsmTestCase):
Line 64: TIMEOUT = 1
Line 65: 
Line 66: def setUp(self):
Line 67: scheduler = schedule.Scheduler()
> I would not create a real scheduler, this will make it much harder to test 
Done
Line 68: jobs.start(scheduler)
Line 69: 
Line 70: def tearDown(self):
Line 71: jobs.stop()


-- 
To view, visit https://gerrit.ovirt.org/62000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5004b49b992ae0f7171a0f0549465cc8782d05da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net test: Clean lease files on setup-cleanup
..


Patch Set 9: -Verified

(3 comments)

https://gerrit.ovirt.org/#/c/63089/9/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

Line 416: NETSETUP = {net: {'remove': True}
Line 417: for net in self.setup_networks if net in 
networks_caps}
Line 418: BONDSETUP = {bond: {'remove': True}
Line 419:  for bond in self.setup_bonds if bond in 
bonds_caps}
Line 420: status, msg = self.vdsm_proxy.setupNetworks(NETSETUP, 
BONDSETUP, NOCHK)
> if we do manual lease removal here, why it is not needed in case we remove 
This is an attempt to cleanup after a test, not after each setupNetworks.
If we do not do this, we are left with hundreds of lease files, as each test 
uses random iface names.
Line 421: 
Line 422: nics_used = [attr['nic']
Line 423:  for attr in six.itervalues(self.setup_networks)
Line 424:  if 'nic' in attr]


PS9, Line 430: set
> frozenset
Done


Line 430: self._cleanup_lease_files(set(NETSETUP) | set(BONDSETUP) | 
sb_ifaces)
Line 431: 
Line 432: return status, msg
Line 433: 
Line 434: def _cleanup_lease_files(self, ifaces):
> you can move it outside the class
Done
Line 435: for iface in ifaces:
Line 436: utils.rmFile(dhclient.LEASE_FILE.format('', iface))
Line 437: utils.rmFile(dhclient.LEASE_FILE.format('6', iface))
Line 438: 


-- 
To view, visit https://gerrit.ovirt.org/63089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 14:

(14 comments)

https://gerrit.ovirt.org/#/c/61693/14/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 39
Line 40
Line 41
Line 42
Line 43
> This tests copying divs, maybe rename to TestCopyDataDIV?
Done


Line 48
Line 49
Line 50
Line 51
Line 52
> Same
Done


Line 48: self._ctx = self.fake_guarded_context(locks)
Line 49: return self._ctx
Line 50: 
Line 51: def validate(self, locks):
Line 52: return sorted(locks) == sorted(self._ctx.locks)
> This create very bad failures:
Done
Line 53: 
Line 54: class fake_guarded_context(object):
Line 55: 
Line 56: def __init__(self, locks):


Line 48: self._ctx = self.fake_guarded_context(locks)
Line 49: return self._ctx
Line 50: 
Line 51: def validate(self, locks):
Line 52: return sorted(locks) == sorted(self._ctx.locks)
> This create very bad failures:
Done
Line 53: 
Line 54: class fake_guarded_context(object):
Line 55: 
Line 56: def __init__(self, locks):


Line 59: def __enter__(self):
Line 60: return self
Line 61: 
Line 62: def __exit__(self, exc_type, exc_val, exc_tb):
Line 63: pass
> We can make it much simpler:
Done
Line 64: 
Line 65: 
Line 66: @expandPermutations
Line 67: class CopyDataTests(VdsmTestCase):


Line 59: def __enter__(self):
Line 60: return self
Line 61: 
Line 62: def __exit__(self, exc_type, exc_val, exc_tb):
Line 63: pass
> We can make it much simpler:
Done
Line 64: 
Line 65: 
Line 66: @expandPermutations
Line 67: class CopyDataTests(VdsmTestCase):


Line 74: def get_vols(self, storage_type, src_fmt, dst_fmt, chain_length=1):
Line 75: with fake_env(storage_type) as env:
Line 76: rm = FakeResourceManager()
Line 77: with MonkeyPatchScope([
Line 78: (storage.sdm.api.copy_data, 'guarded', self._guarded),
> Why not mock the guarded.context? This way we don't have to create a fake m
Done
Line 79: (storage.sdm.api.copy_data, 'sdCache', env.sdcache),
Line 80: (volume, 'sdCache', env.sdcache),
Line 81: (resourceManager.ResourceManager,
Line 82:  'getInstance', lambda cls: rm),


Line 76: rm = FakeResourceManager()
Line 77: with MonkeyPatchScope([
Line 78: (storage.sdm.api.copy_data, 'guarded', self._guarded),
Line 79: (storage.sdm.api.copy_data, 'sdCache', env.sdcache),
Line 80: (volume, 'sdCache', env.sdcache),
> Same, we don't call any method of VolumeLease, right?
Done
Line 81: (resourceManager.ResourceManager,
Line 82:  'getInstance', lambda cls: rm),
Line 83: (blockVolume, 'rmanager', rm),
Line 84: ]):


Line 77: with MonkeyPatchScope([
Line 78: (storage.sdm.api.copy_data, 'guarded', self._guarded),
Line 79: (storage.sdm.api.copy_data, 'sdCache', env.sdcache),
Line 80: (volume, 'sdCache', env.sdcache),
Line 81: (resourceManager.ResourceManager,
> Do we realy need to mock resourceManager when we mock the context?
Done
Line 82:  'getInstance', lambda cls: rm),
Line 83: (blockVolume, 'rmanager', rm),
Line 84: ]):
Line 85: src_vols = make_qemu_chain(env, self.SIZE, src_fmt,


Line 102: 
Line 103: def expected_locks(self, src_vol, dst_vol):
Line 104: # We expect:
Line 105: # 1) a domain lock for each volume
Line 106: # 2) an image lock in exclusive mode for each volume
> Exclusive only for the destination volume.
Done
Line 107: # 3) Destination volume lease
Line 108: src_img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, 
src_vol.sdUUID)
Line 109: dst_img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, 
dst_vol.sdUUID)
Line 110: ret = [


Line 106: # 2) an image lock in exclusive mode for each volume
Line 107: # 3) Destination volume lease
Line 108: src_img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, 
src_vol.sdUUID)
Line 109: dst_img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, 
dst_vol.sdUUID)
Line 110: ret = [
> # domain lock or each volume
Done
Line 111: resourceManager.ResourceManagerLock(
Line 112: sc.STORAGE, src_vol.sdUUID, 
resourceManager.LockType.shared),
Line 113: resourceManager.ResourceManagerLock(
Line 114: sc.STORAGE, dst_vol.sdUUID, 
resourceManager.LockType.shared),


Line 110: ret = [
Line 111: resourceManager.ResourceManagerLock(
Line 112: sc.STORAGE, src_vol.sdUUID, 
resourceManager.LockType.shared),
Line 113:  

Change in vdsm[master]: sampling: Retrieve backing chain stats

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sampling: Retrieve backing chain stats
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/60888/4/lib/vdsm/virt/sampling.py
File lib/vdsm/virt/sampling.py:

Line 499: if fast_path:
Line 500: # This is expected to be the common case.
Line 501: # If everything's ok, we can skip all the costly 
checks.
Line 502: bulk_stats = 
self._conn.getAllDomainStats(self._stats_flags,
Line 503:   extra_flags)
We should get rid of these "better" names, and use the same names used in 
libvirt documentation:

- stats_flags -> stats
- extra_flags -> flags

See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainListGetStats

And also the online docs:

domainListGetStats(self, doms, stats=0, flags=0)

Calling this function as:

domainListGetStats(self, doms, stats, flags)

Is bad practice - should be:

domainListGetStats(self, doms, stats=stats, flags=flags)
Line 504: else:
Line 505: # A previous call got stuck, or not every domain
Line 506: # has properly recovered. Thus we must whitelist 
domains.
Line 507: doms = self._get_responsive_doms()


-- 
To view, visit https://gerrit.ovirt.org/60888
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bbb8643d1c86e90d1e2de7cb2a5b00116c71453
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: Retrieve backing chain stats

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sampling: Retrieve backing chain stats
..


Patch Set 4: Code-Review-1

(1 comment)

We want to explore another approach, getting watermarks for current domain 
before and after a merge.

https://gerrit.ovirt.org/#/c/60888/4/lib/vdsm/virt/sampling.py
File lib/vdsm/virt/sampling.py:

Line 506: # has properly recovered. Thus we must whitelist 
domains.
Line 507: doms = self._get_responsive_doms()
Line 508: if doms:
Line 509: bulk_stats = self._conn.domainListGetStats(
Line 510: doms, self._stats_flags, extra_flags)
This seems to be the way to get stats only for certain domains, in our case we 
want to filter always to one domain.
Line 511: else:
Line 512: bulk_stats = []
Line 513: except Exception:
Line 514: self._log.exception("vm sampling failed")


-- 
To view, visit https://gerrit.ovirt.org/60888
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bbb8643d1c86e90d1e2de7cb2a5b00116c71453
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 14: Code-Review-1

(12 comments)

https://gerrit.ovirt.org/#/c/61693/14/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 39
Line 40
Line 41
Line 42
Line 43
This tests copying divs, maybe rename to TestCopyDataDIV?

We will probably have later TestCopyDataDIVCeph etc.


Line 48
Line 49
Line 50
Line 51
Line 52
Same


Line 48: self._ctx = self.fake_guarded_context(locks)
Line 49: return self._ctx
Line 50: 
Line 51: def validate(self, locks):
Line 52: return sorted(locks) == sorted(self._ctx.locks)
This create very bad failures:

True != False

Instead of the very useful output of assertEqual.
Line 53: 
Line 54: class fake_guarded_context(object):
Line 55: 
Line 56: def __init__(self, locks):


Line 59: def __enter__(self):
Line 60: return self
Line 61: 
Line 62: def __exit__(self, exc_type, exc_val, exc_tb):
Line 63: pass
We can make it much simpler:

class FakeContext(object):
def __init__(self):
self.locks = []
def __enter__(self, locks):
self.locks = locks
return self
def __exit__(self, *args):
pass

And do this for each test:

@MonkeyPatch(gourded, 'context', FakeContext())
def test_foo():
...
self.assertEqual(sorted(guarded.context.locks),
sorted(expected_locks))
Line 64: 
Line 65: 
Line 66: @expandPermutations
Line 67: class CopyDataTests(VdsmTestCase):


Line 74: def get_vols(self, storage_type, src_fmt, dst_fmt, chain_length=1):
Line 75: with fake_env(storage_type) as env:
Line 76: rm = FakeResourceManager()
Line 77: with MonkeyPatchScope([
Line 78: (storage.sdm.api.copy_data, 'guarded', self._guarded),
Why not mock the guarded.context? This way we don't have to create a fake 
module, only a fake context manager.
Line 79: (storage.sdm.api.copy_data, 'sdCache', env.sdcache),
Line 80: (volume, 'sdCache', env.sdcache),
Line 81: (resourceManager.ResourceManager,
Line 82:  'getInstance', lambda cls: rm),


Line 76: rm = FakeResourceManager()
Line 77: with MonkeyPatchScope([
Line 78: (storage.sdm.api.copy_data, 'guarded', self._guarded),
Line 79: (storage.sdm.api.copy_data, 'sdCache', env.sdcache),
Line 80: (volume, 'sdCache', env.sdcache),
Same, we don't call any method of VolumeLease, right?
Line 81: (resourceManager.ResourceManager,
Line 82:  'getInstance', lambda cls: rm),
Line 83: (blockVolume, 'rmanager', rm),
Line 84: ]):


Line 77: with MonkeyPatchScope([
Line 78: (storage.sdm.api.copy_data, 'guarded', self._guarded),
Line 79: (storage.sdm.api.copy_data, 'sdCache', env.sdcache),
Line 80: (volume, 'sdCache', env.sdcache),
Line 81: (resourceManager.ResourceManager,
Do we realy need to mock resourceManager when we mock the context?
Line 82:  'getInstance', lambda cls: rm),
Line 83: (blockVolume, 'rmanager', rm),
Line 84: ]):
Line 85: src_vols = make_qemu_chain(env, self.SIZE, src_fmt,


Line 102: 
Line 103: def expected_locks(self, src_vol, dst_vol):
Line 104: # We expect:
Line 105: # 1) a domain lock for each volume
Line 106: # 2) an image lock in exclusive mode for each volume
Exclusive only for the destination volume.

Since this text kind of duplicate the lock list below, maybe integrate the text 
in the list?
Line 107: # 3) Destination volume lease
Line 108: src_img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, 
src_vol.sdUUID)
Line 109: dst_img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, 
dst_vol.sdUUID)
Line 110: ret = [


Line 106: # 2) an image lock in exclusive mode for each volume
Line 107: # 3) Destination volume lease
Line 108: src_img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, 
src_vol.sdUUID)
Line 109: dst_img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, 
dst_vol.sdUUID)
Line 110: ret = [
# domain lock or each volume
Line 111: resourceManager.ResourceManagerLock(
Line 112: sc.STORAGE, src_vol.sdUUID, 
resourceManager.LockType.shared),
Line 113: resourceManager.ResourceManagerLock(
Line 114: sc.STORAGE, dst_vol.sdUUID, 
resourceManager.LockType.shared),


Line 110: ret = [
Line 111: resourceManager.ResourceManagerLock(
Line 112: sc.STORAGE, src_vol.sdUUID, 
resourceManager.LockType.shared),
Line 113: 

Change in vdsm[master]: spec: bridge-utils are required for tests

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: spec: bridge-utils are required for tests
..


Patch Set 1:

No magic automation I'm aware of.

-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: upgrade: Support upgrade to v4 from v3
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63547/1/vdsm/storage/imageRepository/formatConverter.py
File vdsm/storage/imageRepository/formatConverter.py:

Line 343: log.debug("Switching the cluster lock for domain %s", 
domain.sdUUID)
Line 344: domain._clusterLock = newClusterLock
Line 345: 
Line 346: def v4DomainConverter(repoPath, hostId, domain, isMsd):
Line 347: log = logging.getLogger('Storage.v4DomainConverter')
> Same problem exists in all the converters iiuc. Should be handled in a sepa
+1
Line 348: targetVersion = 4
Line 349: 
Line 350: if domain.getStorageType() in sd.BLOCK_DOMAIN_TYPES:
Line 351: log.debug("Trying to upgrade domain %s to tag based metadata "


-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bec2881040566261cc6ffaeb8df97eef477a7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Refuse to cancel post-copy migrations

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Refuse to cancel post-copy migrations
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670ab48ed3fe69582646675d8b683bcdb3cfa038
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Disable special OVS handling for exteranal network

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt net: Disable special OVS handling for exteranal network
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0aa5846040a80773a65a14d3e93624e4491c229
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Disable special OVS handling for exteranal network

[mmirecki]

Marcin Mirecki has uploaded a new change for review.

Change subject: virt net: Disable special OVS handling for exteranal network
..

virt net: Disable special OVS handling for exteranal network

Exteranal network rely of changes introduced by hooks into domxml
and hence should not undergo the special handling meant for OVS

Change-Id: Id0aa5846040a80773a65a14d3e93624e4491c229
Signed-off-by: mirecki 
---
M vdsm/virt/vm_migrate_hook.py
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/63621/1

diff --git a/vdsm/virt/vm_migrate_hook.py b/vdsm/virt/vm_migrate_hook.py
index 633e4f0..86c4373 100755
--- a/vdsm/virt/vm_migrate_hook.py
+++ b/vdsm/virt/vm_migrate_hook.py
@@ -31,6 +31,7 @@
 
 _DEBUG_MODE = False
 LOG_FILE = '/tmp/libvirthook_ovs_migrate.log'
+EXTERNAL_NETWORK = 'EXTERNAL_NETWORK'
 
 
 class VmMigrationHookError(Exception):
@@ -85,7 +86,15 @@
 target_vm_nets_by_vnic_mac = {dev['macAddr']: dev['network']
   for dev in target_vm_conf['devices']
   if dev.get('type') == 'interface'}
+exernal_by_mac = {dev['macAddr']: dev.get('custom').
+  get('provider_type') == EXTERNAL_NETWORK
+  for dev in target_vm_conf['devices']
+  if dev.get('type') == 'interface' and dev.get('custom')}
+
 for interface in devices.findall('interface'):
+if exernal_by_mac.get(interface.find('mac').get('address')):
+continue
+
 if interface.get('type') == 'bridge':
 _bind_iface_to_bridge(interface, target_vm_nets_by_vnic_mac)
 


-- 
To view, visit https://gerrit.ovirt.org/63621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0aa5846040a80773a65a14d3e93624e4491c229
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 14: Verified+1

Verified through unit testing and functional testing of the copy_data verb.

-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 19: Code-Review-1

(1 comment)

-1 for attention

https://gerrit.ovirt.org/#/c/62831/17/lib/vdsm/network/link/setup.py
File lib/vdsm/network/link/setup.py:

PS17, Line 46: nds.
> I don't think so, but perhaps you have a proposal for all this mess here.
I'm not sure if i understand. You say that only removal has potential to leave 
bondings in broken state. But what if first slaves addition fail? Then all 
following bonds will end up in partial state.

My (maybe invalid) proposal is this:
Call _config.setBonding() after each removal of slaves. Thanks to our two stage 
editation, bonds are valid after each one-bond-change.

- If we fail while changing a bond, partial changes (on given bond) will be 
rolled back by it's transaction.
- Then we fail, raise exception up to setupNetworks rollback and it will be 
able to change bonds to initial state (just compare running_config).

Example - Change slaves of two bonds:
- Remove slaves from the first OK
- Update first bond in _config.
- Remove from the second, fist slave removal OK, second FAIL
- Rollback to initial bond state (add back the first slave)
- Raise exception up to setupNetworks
- setupNetworks compares initial and current state. It sees that in the initial 
one the first bond used to have two slaves, now it has none. So it executes 
setupNetworks with bonds={'first_bond': {'nics': [...]}}


-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: Clean lease files on setup-cleanup
..


Patch Set 9: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/63089/9/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

Line 416: NETSETUP = {net: {'remove': True}
Line 417: for net in self.setup_networks if net in 
networks_caps}
Line 418: BONDSETUP = {bond: {'remove': True}
Line 419:  for bond in self.setup_bonds if bond in 
bonds_caps}
Line 420: status, msg = self.vdsm_proxy.setupNetworks(NETSETUP, 
BONDSETUP, NOCHK)
if we do manual lease removal here, why it is not needed in case we remove it 
the 'normal' way inside a test?

if you change __call__ and execute _cleanup after every setup, you have to make 
sure you run it before post_setup_hook (which will update networks_caps and 
initial networks with their ifaces will disappear)
Line 421: 
Line 422: nics_used = [attr['nic']
Line 423:  for attr in six.itervalues(self.setup_networks)
Line 424:  if 'nic' in attr]


PS9, Line 430: set
frozenset


Line 430: self._cleanup_lease_files(set(NETSETUP) | set(BONDSETUP) | 
sb_ifaces)
Line 431: 
Line 432: return status, msg
Line 433: 
Line 434: def _cleanup_lease_files(self, ifaces):
you can move it outside the class
Line 435: for iface in ifaces:
Line 436: utils.rmFile(dhclient.LEASE_FILE.format('', iface))
Line 437: utils.rmFile(dhclient.LEASE_FILE.format('6', iface))
Line 438: 


-- 
To view, visit https://gerrit.ovirt.org/63089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: upgrade: Support upgrade to v4 from v3
..


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/63547/1/vdsm/storage/imageRepository/formatConverter.py
File vdsm/storage/imageRepository/formatConverter.py:

Line 343: log.debug("Switching the cluster lock for domain %s", 
domain.sdUUID)
Line 344: domain._clusterLock = newClusterLock
Line 345: 
Line 346: def v4DomainConverter(repoPath, hostId, domain, isMsd):
Line 347: log = logging.getLogger('Storage.v4DomainConverter')
> This logger will never be released. Please use module level logger. 
Same problem exists in all the converters iiuc. Should be handled in a separate 
patch (before this one, and then have this one done right)
Line 348: targetVersion = 4
Line 349: 
Line 350: if domain.getStorageType() in sd.BLOCK_DOMAIN_TYPES:
Line 351: log.debug("Trying to upgrade domain %s to tag based metadata "


PS1, Line 348: targetVersion = 4
Umm, you don't seem to actually do anything with it. I assume you're missing 
something like:

 domain.setMetaParam(sd.DMDK_VERSION, targetVersion)


PS1, Line 350: if domain.getStorageType() in sd.BLOCK_DOMAIN_TYPES:
 : log.debug("Trying to upgrade domain %s to tag based 
metadata "
 :   "version %s", domain.sdUUID, targetVersion)
 : 
 : __convertDomainMetadataToTags(domain, targetVersion)
V3 is already based on tags, and we don't support direct upgrade from [0, 2], 
so this is redundant.


-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 5:

* #1368474::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1368474::OK, public bug
* Check Product::#1368474::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[automation]

gerrit-hooks has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 14:

* #1365007::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1365007::OK, public bug
* Check Product::#1365007::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: change getConnectedStoragePoolsList result key
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org