Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan
Dan Kenigsberg has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 4: Could you at least check the ifcfg for BRIDGE, or explain why even this test is unattainable? -- To view, visit https://gerrit.ovirt.org/65231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: blockSD: Fix off-by-one error in slot allocation
Jenkins CI has posted comments on this change. Change subject: blockSD: Fix off-by-one error in slot allocation .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/65649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I400d24f843dd71c233c2bb8139300129a7d1aebf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: blockSD: Fix off-by-one error in slot allocation
gerrit-hooks has posted comments on this change. Change subject: blockSD: Fix off-by-one error in slot allocation .. Patch Set 2: * Update Tracker::#1386732::IGNORE, not relevant for Red Hat classification * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1386732::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I400d24f843dd71c233c2bb8139300129a7d1aebf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: blockSD: Fix off-by-one error in slot allocation
gerrit-hooks has posted comments on this change. Change subject: blockSD: Fix off-by-one error in slot allocation .. Patch Set 1: * Update Tracker::#1386732::IGNORE, not relevant for Red Hat classification * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1386732::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I400d24f843dd71c233c2bb8139300129a7d1aebf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: blockSD: Fix off-by-one error in slot allocation
Nir Soffer has uploaded a new change for review.
Change subject: blockSD: Fix off-by-one error in slot allocation
..
blockSD: Fix off-by-one error in slot allocation
If one slot was free between two occupied slots it was skipped during
allocation. This patch Fixes the calculation and add missing tests
cases.
Change-Id: I400d24f843dd71c233c2bb8139300129a7d1aebf
Bug-Url: https://bugzilla.redhat.com/1386732
Reported-By: nijin ashok
Signed-off-by: Nir Soffer
---
M tests/domain_manifest_test.py
M vdsm/storage/blockSD.py
2 files changed, 17 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/65649/1
diff --git a/tests/domain_manifest_test.py b/tests/domain_manifest_test.py
index e333d79..494ef8c 100644
--- a/tests/domain_manifest_test.py
+++ b/tests/domain_manifest_test.py
@@ -23,6 +23,9 @@
from vdsm.storage import constants as sc
from testlib import VdsmTestCase, recorded
+from testlib import make_uuid
+from testlib import expandPermutations, permutations
+
from storagetestlib import (
make_file_volume,
fake_block_env,
@@ -144,19 +147,27 @@
self.assertEquals(1024, new_manifest.phyBlkSize)
+@expandPermutations
class BlockDomainMetadataSlotTests(VdsmTestCase):
-def test_metaslot_selection(self):
+@permutations([
+# used_slots, free_slot
+# Note: the first 4 slots (0-3) are reserved for domain metadata
+([], 4),
+([4], 5),
+([4, 6], 5),
+([4, 7], 5),
+])
+def test_metaslot_selection(self, used_slots, free_slot):
with fake_block_env() as env:
-lvs = ('0b6287f0-3679-4c4d-8be5-9bbfe3ec9c1f',
- 'ea13af29-b64a-4d1a-b35f-3e6ab15c3b04')
-for lv, offset in zip(lvs, [4, 7]):
+for offset in used_slots:
+lv = make_uuid()
sduuid = env.sd_manifest.sdUUID
env.lvm.createLV(sduuid, lv, VOLSIZE / MB)
tag = sc.TAG_PREFIX_MD + str(offset)
env.lvm.addtag(sduuid, lv, tag)
with env.sd_manifest.acquireVolumeMetadataSlot(None, 1) as mdSlot:
-self.assertEqual(mdSlot, 5)
+self.assertEqual(mdSlot, free_slot)
def test_metaslot_lock(self):
with fake_block_env() as env:
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index f39d41a..f486681 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -751,7 +751,7 @@
freeSlot = (SD_METADATA_SIZE + self.logBlkSize - 1) / self.logBlkSize
for offset, size in occupiedSlots:
-if offset - freeSlot > slotSize:
+if offset >= freeSlot + slotSize:
break
freeSlot = offset + size
--
To view, visit https://gerrit.ovirt.org/65649
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I400d24f843dd71c233c2bb8139300129a7d1aebf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Inform Engine about switching to post-copy
Francesco Romani has posted comments on this change. Change subject: virt: Inform Engine about switching to post-copy .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/64149/10/vdsm/virt/vm.py File vdsm/virt/vm.py: PS10, Line 1336: _getVmPauseCodeStats ok for now; in a future patch, we should probably transform those to update. From: stats.update(self._getVmPauseCodeStats()) To self._updateVmPauseCodeStats(stats) with def _updateVmPauseCodeStats(self): with self._confLock: if 'pauseCode' in self.conf: stats['pauseCode'] = self.conf['pauseCode'] -- To view, visit https://gerrit.ovirt.org/64149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I281ec36a6bd65b816afbdeef79205e6241d4a27c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Inform Engine about switching to post-copy
Francesco Romani has posted comments on this change. Change subject: virt: Inform Engine about switching to post-copy .. Patch Set 10: Code-Review+2 bah, we still need confLock :( Not this patch's fault, obviously. -- To view, visit https://gerrit.ovirt.org/64149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I281ec36a6bd65b816afbdeef79205e6241d4a27c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Distinguish between switching to and entering post-cop...
Francesco Romani has posted comments on this change. Change subject: virt: Distinguish between switching to and entering post-copy migration .. Patch Set 7: Code-Review-1 (3 comments) -1 for discussion https://gerrit.ovirt.org/#/c/64143/7//COMMIT_MSG Commit Message: Line 15: request phase and the post-copy switch phase. For instance, we should Line 16: block canceling migrations very early to avoid timing issues and Line 17: possibly canceling a post-copy migration. On the other hand we should Line 18: report a true VM state to Engine, so we can report post-copy only after Line 19: the VM actually enters it. do we need two separate variables or can we turn the boolean in one state attribute? (maybe post_copy_phase?) I think in this case, given the rationale above, the state variable makes a bit more sense. Furthermore, in general I'm against attributes proliferation. We could do like this: class PostCopyPhase: # this should be a python >= 3.4 enum, really DISABLED = 0 # aka precopy REQUESTED = 1 RUNNING = 2 or something like it. What do you think? Line 20: Line 21: Change-Id: I88dddeab84a609ebd3d5d9139724adff9cdb1352 Line 22: Signed-off-by: Milan Zamazal https://gerrit.ovirt.org/#/c/64143/7/vdsm/virt/migration.py File vdsm/virt/migration.py: PS7, Line 811: if ret >= 0: : self._post_copy_initiated = True not related to this patch, but I realized just now. Why do we need more state variables in the migration helper threads? Couldn't we just use one (or few) variables in the vm class? In general, I have the feeling we are duplicating the state, which makes the code more fragile. (see "here" in vm.py) https://gerrit.ovirt.org/#/c/64143/7/vdsm/virt/vm.py File vdsm/virt/vm.py: PS7, Line 1436: if self._migrationSourceThread.post_copy_initiated or \ :self._in_post_copy: here -- To view, visit https://gerrit.ovirt.org/64143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88dddeab84a609ebd3d5d9139724adff9cdb1352 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Report paused VM status in post-copy
Francesco Romani has posted comments on this change. Change subject: virt: Report paused VM status in post-copy .. Patch Set 9: Code-Review+2 I see no issues here, and if it makes Engine's life easier, let it be. -- To view, visit https://gerrit.ovirt.org/64147 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4738a7519f8d1af2ee30bfe766f3407853263cf2 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Distinguish between switching to and entering post-cop...
Francesco Romani has posted comments on this change. Change subject: virt: Distinguish between switching to and entering post-copy migration .. Patch Set 7: the basic idea of distinguishing post copy phases is fine for me. -- To view, visit https://gerrit.ovirt.org/64143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88dddeab84a609ebd3d5d9139724adff9cdb1352 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Prevent monitoring of VMs in post-copy
Francesco Romani has posted comments on this change. Change subject: virt: Prevent monitoring of VMs in post-copy .. Patch Set 9: Code-Review+1 Most likely https://gerrit.ovirt.org/#/c/65590/ will be merged earlier than this patch, because 65590 wants to fix one bug. You may want to rebase this on top of 65590. Let's keep it as-is until that moment. -- To view, visit https://gerrit.ovirt.org/64146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I010d3311ce497081720a871e2a3c715f53dcb299 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Start all VM related stuff after switching to post-cop...
Francesco Romani has posted comments on this change.
Change subject: virt: Start all VM related stuff after switching to post-copy
migration
..
Patch Set 8: Code-Review-1
(1 comment)
-1 because inline questions
https://gerrit.ovirt.org/#/c/63551/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 263: self._lastStatus = vmstatus.WAIT_FOR_LAUNCH
Line 264: self._migrationSourceThread = migration.SourceThread(self)
Line 265: self._kvmEnable = self.conf.get('kvmEnable', 'true')
Line 266: self._incomingMigrationFinished = threading.Event()
Line 267: self._incoming_migration_vm_running = threading.Event()
Why can't we just do incomingMigrationFinished.set() earlier?
I read the commit message reference about the status; I wonder if we can't just
unblock the VM here and run with status == MIGRATION_DESTINATION, instead of
keeping the creation thread around
Once libvirt delivers the event, we can just change state.
Would the above work?
Line 268: self.id = self.conf['vmId']
Line 269: self._volPrepareLock = threading.Lock()
Line 270: self._initTimePauseCode = None
Line 271: self._initTimeRTC = int(self.conf.get('timeOffset', 0))
--
To view, visit https://gerrit.ovirt.org/63551
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8b17e58f63cbd9db09e4420871a562eaa0b3f3d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Stop guest agent before switching to post-copy
Francesco Romani has posted comments on this change. Change subject: virt: Stop guest agent before switching to post-copy .. Patch Set 8: Code-Review+1 (1 comment) overall, minor comments, hence +1 https://gerrit.ovirt.org/#/c/64145/8/vdsm/virt/migration.py File vdsm/virt/migration.py: PS8, Line 820: except at very least let's make this except Exception: Besides that, any chance to narrow this down? -- To view, visit https://gerrit.ovirt.org/64145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd855ee36847b293009ac35d8d03b01521aaace8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Add new api to get the IO tune policies for all vms
Martin Sivák has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms .. Patch Set 11: (2 comments) https://gerrit.ovirt.org/#/c/63748/10/vdsm/virt/vm.py File vdsm/virt/vm.py: PS10, Line 2601: > we don't want anymore to build response objects in the API layer (see topic We discussed this over irc. Moving the response object construction out of here would involve catching libvirt exceptions and that won't make code nicer. We need to backport this as well so I am in favour of a followup patches instead of prepending a patch. PS10, Line 2628: Image( > the vm field is named "log", so it should be Done -- To view, visit https://gerrit.ovirt.org/63748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jenny Tokar Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Add new api to get the IO tune policies for all vms
gerrit-hooks has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms .. Patch Set 11: * Update Tracker::#1374988::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1374988::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jenny Tokar Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.
Andrej Krejcir has posted comments on this change. Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes. .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.
Andrej Krejcir has posted comments on this change. Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes. .. Patch Set 6: -Verified -- To view, visit https://gerrit.ovirt.org/65565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.
Martin Polednik has posted comments on this change. Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes. .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.
Andrej Krejcir has posted comments on this change.
Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/65565/6/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
PS6, Line 511: mode = numaTune.get('mode', 'strict')
> No support per-memnode numa mode? Any specific reason for that?
I don't know of any specific reason,
engine doesn't support it right now.
It can be added when needed.
--
To view, visit https://gerrit.ovirt.org/65565
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir
Gerrit-Reviewer: Andrej Krejcir
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Phillip Bailey
Gerrit-Reviewer: Roman Mohr
Gerrit-Reviewer: Yanir Quinn
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.
Andrej Krejcir has posted comments on this change. Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes. .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vm: rename statsAge parameter
Milan Zamazal has posted comments on this change. Change subject: vm: rename statsAge parameter .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vm: rename statsAge parameter
Francesco Romani has posted comments on this change. Change subject: vm: rename statsAge parameter .. Patch Set 6: Verified+1 covered and verified by tests -- To view, visit https://gerrit.ovirt.org/65508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vm: introduce a `monitorable' attribute
gerrit-hooks has posted comments on this change. Change subject: vm: introduce a `monitorable' attribute .. Patch Set 4: * Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification * Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1382578::OK, public bug * Check Public Bug::#1382583::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout
gerrit-hooks has posted comments on this change. Change subject: vm: reformat setUnresponsiveIfTimeout .. Patch Set 6: * Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1382578::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65504 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands
gerrit-hooks has posted comments on this change. Change subject: vm: ignore more errors in isDomainReadyForCommands .. Patch Set 7: * Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1382578::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vm: rename statsAge parameter
gerrit-hooks has posted comments on this change. Change subject: vm: rename statsAge parameter .. Patch Set 6: * Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1382578::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vm: rename statsAge parameter
Francesco Romani has posted comments on this change. Change subject: vm: rename statsAge parameter .. Patch Set 5: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/65508/5//COMMIT_MSG Commit Message: PS5, Line 11: onyl only* -- To view, visit https://gerrit.ovirt.org/65508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vm: introduce a `monitorable' attribute
Milan Zamazal has posted comments on this change. Change subject: vm: introduce a `monitorable' attribute .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vm: introduce a `monitorable' attribute
gerrit-hooks has posted comments on this change. Change subject: vm: introduce a `monitorable' attribute .. Patch Set 3: * Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification * Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1382578::OK, public bug * Check Public Bug::#1382583::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
