Change in vdsm[master]: dockerfile: add magic and blivet

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: dockerfile: add magic and blivet .. dockerfile: add magic and blivet Recent commit 4b8ce058 added new requirements

Change in vdsm[master]: Move caps module to vdsm.host.caps

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Move caps module to vdsm.host.caps .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57533 To

Change in vdsm[master]: tests: Avoid global state modification using forked

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Avoid global state modification using forked .. tests: Avoid global state modification using forked

Change in vdsm[master]: tests: Avoid global state modification using forked

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tests: Avoid global state modification using forked .. Patch Set 2: Code-Review+2 ok, let's unbreak travis -- To

Change in vdsm[master]: Move caps module to vdsm.host.caps

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Move caps module to vdsm.host.caps .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/57533/5/vdsm/virt/vm.py

Change in vdsm[master]: rwtab.d: Remove vdsm entry

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: rwtab.d: Remove vdsm entry .. rwtab.d: Remove vdsm entry oVirt Node Legacy is read-only file system, which

Change in vdsm[master]: Add ovirt-hosted-engine-ha package to key packages

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Add ovirt-hosted-engine-ha package to key packages .. Patch Set 1: Code-Review+2 -- To view, visit

Change in vdsm[master]: testValidation: Add @skipif decorator

2016-12-01 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: testValidation: Add @skipif decorator .. Patch Set 2: Code-Review+1 -- To view, visit

Change in vdsm[master]: Move gluster package to vdsm.gluster

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: Move gluster package to vdsm.gluster .. Move gluster package to vdsm.gluster Change-Id:

Change in vdsm[master]: Move gluster package to vdsm.gluster

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Move gluster package to vdsm.gluster .. Patch Set 14: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57530

Change in vdsm[master]: Enable metrics by default

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: Enable metrics by default .. Enable metrics by default To avoid restart of vdsm service after first engine

Change in vdsm[master]: Adding clientIF get_instance interface to vdsm.lib

2016-12-01 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has abandoned this change. Change subject: Adding clientIF get_instance interface to vdsm.lib .. Abandoned not needed -- To view, visit

Change in vdsm[master]: client: add gluster namespace as well

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: client: add gluster namespace as well .. client: add gluster namespace as well added gluster_enabled

Change in vdsm[master]: client: introduce MissingSchemaError exception

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: client: introduce MissingSchemaError exception .. client: introduce MissingSchemaError exception As part of

Change in vdsm[master]: Move gluster package to vdsm.gluster

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Move gluster package to vdsm.gluster .. Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57530

Change in vdsm[master]: Move gluster package to vdsm.gluster

2016-12-01 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Move gluster package to vdsm.gluster .. Patch Set 14: Code-Review+1 -- To view, visit

Change in vdsm[master]: client: introduce MissingSchemaError exception

2016-12-01 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: client: introduce MissingSchemaError exception .. Patch Set 4: Code-Review+1 -- To view, visit

Change in vdsm[master]: client: add gluster namespace as well

2016-12-01 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: client: add gluster namespace as well .. Patch Set 7: Code-Review+1 -- To view, visit

Change in vdsm[master]: Enable metrics by default

2016-12-01 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Enable metrics by default .. Patch Set 9: ready too. -- To view, visit https://gerrit.ovirt.org/66257 To

Change in vdsm[master]: vdsmapi: fix a typo in string formatting

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsmapi: fix a typo in string formatting .. vdsmapi: fix a typo in string formatting There was a typo in

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: Adding simple client for sending gauge metrics to statsd port using udp .. Adding simple client for sending

Change in vdsm[master]: client: introduce MissingSchemaError exception

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: client: introduce MissingSchemaError exception .. Patch Set 2: Continuous-Integration+1 10:46:33

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-12-01 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Adding simple client for sending gauge metrics to statsd port using udp .. Patch Set 17: ping? seems ready for

Change in vdsm[master]: vdsmapi: fix a typo in string formatting

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsmapi: fix a typo in string formatting .. Patch Set 2: Code Review - Error Cannot merge

Change in vdsm[master]: network: devices: properly initialize attributes

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network: devices: properly initialize attributes .. Patch Set 2: Code-Review-1 (1 comment)

Change in vdsm[master]: API: move vm parameters fixup in a method

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: API: move vm parameters fixup in a method .. API: move vm parameters fixup in a method After the VM

Change in vdsm[master]: hostdev: add test for massive number of devices

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: add test for massive number of devices .. hostdev: add test for massive number of devices We have

Change in vdsm[master]: rename method wrapApiMethod to _wrap_api_method

2016-12-01 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: rename method wrapApiMethod to _wrap_api_method .. Patch Set 2: Code-Review+1 -- To view, visit

Change in vdsm[master]: Remove the usage of clientIF from GlusterApi

2016-12-01 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Remove the usage of clientIF from GlusterApi .. Patch Set 3: Code-Review+1 (1 comment)

Change in vdsm[master]: hostdev: add test for massive number of devices

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: hostdev: add test for massive number of devices .. Patch Set 7: Code-Review+2 -- To view, visit

Change in vdsm[master]: vmfakecon: optimize HostDeviceStub

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: vmfakecon: optimize HostDeviceStub .. vmfakecon: optimize HostDeviceStub HostDeviceStub processed the XML

Change in vdsm[master]: Remove the usage of clientIF from GlusterApi

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Remove the usage of clientIF from GlusterApi .. Patch Set 2: Code-Review+1 -- To view, visit

Change in vdsm[master]: rename method wrapApiMethod to _wrap_api_method

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: rename method wrapApiMethod to _wrap_api_method .. Patch Set 1: Code-Review+2 -- To view, visit

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-12-01 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Adding simple client for sending gauge metrics to statsd port using udp .. Patch Set 17: Verified+1 -- To view,

Change in vdsm[master]: hostdev: use *c*ElementTree

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: use *c*ElementTree .. hostdev: use *c*ElementTree cElementTree is *the* recommended ETree

Change in vdsm[master]: hostdev: add caching of device tree

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: hostdev: add caching of device tree .. Patch Set 7: (2 comments) very partial

Change in vdsm[master]: hostdev: add test for massive number of devices

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: hostdev: add test for massive number of devices .. Patch Set 7: (1 comment)

Change in vdsm[master]: Remove the usage of clientIF from GlusterApi

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Remove the usage of clientIF from GlusterApi .. Patch Set 1: Code-Review-1 (2 comments)

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Adding simple client for sending gauge metrics to statsd port using udp .. Patch Set 17: Code-Review+2 -- To view,

Change in vdsm[master]: py3: make fileUtilsTests pass on Python 3

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: py3: make fileUtilsTests pass on Python 3 .. py3: make fileUtilsTests pass on Python 3 This patch takes StringTypes

Change in vdsm[master]: client: document ConnectionError exception

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: client: document ConnectionError exception .. client: document ConnectionError exception ConnectionError

Change in vdsm[master]: py3: take Queue from six.moves

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: py3: take Queue from six.moves .. py3: take Queue from six.moves Affected modules are still not complient

Change in vdsm[master]: py3: take Queue from six.moves

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: py3: take Queue from six.moves .. Patch Set 4: Verified+1 spm kicks in, VM starts -- To view, visit

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-12-01 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Adding simple client for sending gauge metrics to statsd port using udp .. Patch Set 16: Verified+1 (1 comment)

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-12-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Adding simple client for sending gauge metrics to statsd port using udp .. Patch Set 15: (1 comment)