Change in vdsm[master]: xmlrpc: Move related classes to new xmlrpc module

Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Move related classes to new xmlrpc module .. Patch Set 1: Code-Review-1 I'm fine with moving the code to a more specific place. -1 for the minor commit

Change in vdsm[master]: vdsm-tool: Add args to remove_saslpasswd

Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: Add args to remove_saslpasswd .. Patch Set 1: Code-Review+2 Please remember to backport this to the new ovirt-3.5 branch! -- To view, visit http://

Change in vdsm[ovirt-3.4]: vdscli: remove usage of VDSMBRIDGE

Hello Antoni Segura Puimedon, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/29181 to review the following change. Change subject: vdscli: remove usage of VDSMBRIDGE .. vdscli: remove usage of VDSM

Change in vdsm[ovirt-3.4]: vdscli: avoid ssl-specific localhost heuristic

Hello Alon Bar-Lev, Nir Soffer, Federico Simoncelli, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/29182 to review the following change. Change subject: vdscli: avoid ssl-specific localhost heuristic .

Change in vdsm[master]: netlink: move netlink into a lib vdsm subpackage

Dan Kenigsberg has posted comments on this change. Change subject: netlink: move netlink into a lib vdsm subpackage .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27472 To unsubscribe, visit http://ger

Change in vdsm[master]: netlink: simplify string conversion methods

Dan Kenigsberg has posted comments on this change. Change subject: netlink: simplify string conversion methods .. Patch Set 5: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/27473/5/lib/vdsm/netlink/__init__.py File lib

Change in vdsm[master]: netlink: add route retrieval capability

Dan Kenigsberg has posted comments on this change. Change subject: netlink: add route retrieval capability .. Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/27317/8/lib/vdsm/netlink/__init__.py File lib/vdsm/netlink/__i

Change in vdsm[ovirt-3.4]: vdscli: remove usage of VDSMBRIDGE

Dan Kenigsberg has posted comments on this change. Change subject: vdscli: remove usage of VDSMBRIDGE .. Patch Set 2: Verified+1 Verified with follow up patch. robot is wrong to require a Bug-Url here, Related-To should be eno

Change in vdsm[ovirt-3.4]: vdscli: avoid ssl-specific localhost heuristic

Dan Kenigsberg has posted comments on this change. Change subject: vdscli: avoid ssl-specific localhost heuristic .. Patch Set 1: Verified+1 Patch already exists in ovirt-3.4 branch. Verified to skip heuristic and access a run

Change in vdsm[master]: multipath: Rescan also FC devices

Dan Kenigsberg has submitted this change and it was merged. Change subject: multipath: Rescan also FC devices .. multipath: Rescan also FC devices When rescanning devices, we used to update ISCSI devices, and then run multipath

Change in vdsm[master]: vdsm-tool: Add args to remove_saslpasswd

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: Add args to remove_saslpasswd .. vdsm-tool: Add args to remove_saslpasswd In a recent patch added, all commands receive arguments, starting

Change in vdsm[master]: xmlrpc: Move related classes to new xmlrpc module

Dan Kenigsberg has submitted this change and it was merged. Change subject: xmlrpc: Move related classes to new xmlrpc module .. xmlrpc: Move related classes to new xmlrpc module The xmlrpc infrastructure is not general utility

Change in vdsm[master]: xmlrpc: Move related classes to new xmlrpc module

Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Move related classes to new xmlrpc module .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29024 To unsubscribe, visit http://ge

Change in vdsm[master]: log: Remove metadata.log

Dan Kenigsberg has submitted this change and it was merged. Change subject: log: Remove metadata.log .. log: Remove metadata.log This log exists only in the spec file and logger.conf. Removing because not used by VDSM. Change-

Change in vdsm[master]: misc: Fix possible deadlock when entering sampling method

Dan Kenigsberg has submitted this change and it was merged. Change subject: misc: Fix possible deadlock when entering sampling method .. misc: Fix possible deadlock when entering sampling method If a thread entered a sampling m

Change in vdsm[master]: janitorial: move isVdsmImage into utils

Dan Kenigsberg has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: virt: do not access devices directly outside Vm

Dan Kenigsberg has posted comments on this change. Change subject: virt: do not access devices directly outside Vm .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28478 To unsubscribe, visit http://gerr

Change in vdsm[master]: virt: do not access devices directly outside Vm

Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: do not access devices directly outside Vm .. virt: do not access devices directly outside Vm VmStatsThread used to access directly the _devices a

Change in vdsm[master]: vm: extract a method to wait for migration

Dan Kenigsberg has posted comments on this change. Change subject: vm: extract a method to wait for migration .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28509/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3592:

Change in vdsm[master]: vdsm-upgrade: adds wrapper to ovirt-node-upgrade

Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade .. Patch Set 17: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28244/17/vdsm.spec.in File vdsm.spec.in

Change in vdsm[master]: virt: move METADATA_VM_TUNE_URI into utils

Dan Kenigsberg has posted comments on this change. Change subject: virt: move METADATA_VM_TUNE_URI into utils .. Patch Set 1: Code-Review-1 this is way too public in my opinion. is there any reason not to declare it module-pri

Change in vdsm[master]: vm: add optimizations for hyperv

Dan Kenigsberg has posted comments on this change. Change subject: vm: add optimizations for hyperv .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/27619/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1780: class Missin

Change in vdsm[master]: vdsm: adding docstring to MultiProtocolAcceptor and Connecte...

Dan Kenigsberg has posted comments on this change. Change subject: vdsm: adding docstring to MultiProtocolAcceptor and ConnectedTcpServer .. Patch Set 7: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28806/7/vdsm/prot

Change in vdsm[master]: vdsm: Removal of management_ip info in getCaps

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Removal of management_ip info in getCaps .. vdsm: Removal of management_ip info in getCaps 'management_ip' property containing ip of vdsm was rem

Change in vdsm[master]: vdsm: Removal of management_ip info in getCaps

Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Removal of management_ip info in getCaps .. Patch Set 3: Code-Review+2 Thanks! -- To view, visit http://gerrit.ovirt.org/28993 To unsubscribe, visit htt

Change in vdsm[master]: Adding the possibility to skip checks on rpmbuild

Dan Kenigsberg has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 7: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/29213/7/vdsm.spec.in File vdsm.spec.in

Change in vdsm[master]: hook: add one more dummy device

Dan Kenigsberg has abandoned this change. Change subject: hook: add one more dummy device .. Abandoned -- To view, visit http://gerrit.ovirt.org/28921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType:

Change in vdsm[master]: Adding the possibility to skip checks on rpmbuild

Dan Kenigsberg has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 8: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/29213/8/vdsm.spec.in File vdsm.spec.in:

Change in vdsm[master]: janitorial: move isVdsmImage into utils

Dan Kenigsberg has submitted this change and it was merged. Change subject: janitorial: move isVdsmImage into utils .. janitorial: move isVdsmImage into utils this patch moves vdsm/virt/vm.isVdsmImage into utils without code ch

Change in vdsm[master]: vdsm-upgrade: adds wrapper to ovirt-node-upgrade

Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade .. Patch Set 18: Code-Review+2 yes, it's an unrelated ImportError: No module named pyflakes issue. -- To v

Change in vdsm[master]: vdsm-upgrade: adds wrapper to ovirt-node-upgrade

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade .. vdsm-upgrade: adds wrapper to ovirt-node-upgrade Currently ovirt-node provides ovirt-node-upgrade t

Change in vdsm[master]: vm: hyperv: initial windows hyperv support

Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: hyperv: initial windows hyperv support .. vm: hyperv: initial windows hyperv support This patch adds explicit support for hyperv optimizations. The

Change in vdsm[master]: vm: hyperv: make hw clock friendlier to windows

Dan Kenigsberg has posted comments on this change. Change subject: vm: hyperv: make hw clock friendlier to windows .. Patch Set 2: Code-Review+2 raising score -- To view, visit http://gerrit.ovirt.org/29233 To unsubscribe, vi

Change in vdsm[master]: vm: hyperv: make hw clock friendlier to windows

Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: hyperv: make hw clock friendlier to windows .. vm: hyperv: make hw clock friendlier to windows This patch sets the local time as windows reportedly

Change in vdsm[master]: vm: hyperv: initial windows hyperv support

Dan Kenigsberg has posted comments on this change. Change subject: vm: hyperv: initial windows hyperv support .. Patch Set 8: Code-Review+2 Convinced. -- To view, visit http://gerrit.ovirt.org/27619 To unsubscribe, visit http

Change in vdsm[master]: vm: hyperv: hyperv enlightenment optimizations

Dan Kenigsberg has posted comments on this change. Change subject: vm: hyperv: hyperv enlightenment optimizations .. Patch Set 2: Code-Review-1 According to fromani, this requires a new libvirt/qemu that are unavailable in el6

Change in vdsm[ovirt-3.5]: vdsm-upgrade: adds wrapper to ovirt-node-upgrade

Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29279 To unsubscribe, visit http://ger

Change in vdsm[master]: Adding the possibility to skip checks on rpmbuild

Dan Kenigsberg has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 10: Code-Review+2 Thanks! -- To view, visit http://gerrit.ovirt.org/29213 To unsubscribe, visit

Change in vdsm[master]: Adding the possibility to skip checks on rpmbuild

Dan Kenigsberg has submitted this change and it was merged. Change subject: Adding the possibility to skip checks on rpmbuild .. Adding the possibility to skip checks on rpmbuild This way you can build the rpms skipping the tes

Change in vdsm[master]: vdscli: no need to generate using autoconf

Dan Kenigsberg has posted comments on this change. Change subject: vdscli: no need to generate using autoconf .. Patch Set 3: Verified+1 I did not refer to any of the comments on the previous version. They should be addressed

Change in vdsm[master]: detach: Support force detach on Storage Domains with old pools.

Dan Kenigsberg has submitted this change and it was merged. Change subject: detach: Support force detach on Storage Domains with old pools. .. detach: Support force detach on Storage Domains with old pools. Force detach of stor

Change in vdsm[ovirt-3.5]: detach: Support force detach on Storage Domains with old pools.

Dan Kenigsberg has posted comments on this change. Change subject: detach: Support force detach on Storage Domains with old pools. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29303 To unsubscribe, v

Change in vdsm[master]: vdscli: no need to generate using autoconf

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdscli: no need to generate using autoconf .. vdscli: no need to generate using autoconf .in files are cumbersome and non-pythonic. As such, they shoul

Change in vdsm[master]: vdscli: no need to generate using autoconf

Dan Kenigsberg has posted comments on this change. Change subject: vdscli: no need to generate using autoconf .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28676 To unsubscribe, visit http://gerrit.ov

Change in vdsm[master]: test: fixing cif getinstance issue

Dan Kenigsberg has posted comments on this change. Change subject: test: fixing cif getinstance issue .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29188 To unsubscribe, visit http://gerrit.ovirt.org/

Change in vdsm[master]: test: fixing cif getinstance issue

Dan Kenigsberg has submitted this change and it was merged. Change subject: test: fixing cif getinstance issue .. test: fixing cif getinstance issue During running jsonrpc test cif.getInstance fails due to missing logger. We mo

Change in vdsm[master]: vdsm: disable virtio-rng on rhel < 7.1

Dan Kenigsberg has posted comments on this change. Change subject: vdsm: disable virtio-rng on rhel < 7.1 .. Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28838/2/vdsm/caps.py File vdsm/caps.py: Line 499

Change in vdsm[master]: vdsmcli: Add a contrib command line client alternative

Dan Kenigsberg has posted comments on this change. Change subject: vdsmcli: Add a contrib command line client alternative .. Patch Set 1: Code-Review+2 I'd prefer something that parses the schema, but we can take it in, and see

Change in vdsm[master]: net: remove last dependency on ifcfg persistence

Dan Kenigsberg has posted comments on this change. Change subject: net: remove last dependency on ifcfg persistence .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28530 To unsubscribe, visit http://ger

Change in vdsm[ovirt-3.5]: ifcfg: make default route network be started by sysV

Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: make default route network be started by sysV .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29312/1//COMMIT_MSG Commit Message: Line 7: ifcf

Change in vdsm[ovirt-3.5]: ifcfg: make default route network be started by sysV

Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: make default route network be started by sysV .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29312 To unsubscribe, visit http:/

Change in vdsm[master]: vdsm: adding docstring to MultiProtocolAcceptor and Connecte...

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: adding docstring to MultiProtocolAcceptor and ConnectedTcpServer .. vdsm: adding docstring to MultiProtocolAcceptor and ConnectedTcpServer Multi

Change in vdsm[master]: vdsm: adding docstring to MultiProtocolAcceptor and Connecte...

Dan Kenigsberg has posted comments on this change. Change subject: vdsm: adding docstring to MultiProtocolAcceptor and ConnectedTcpServer .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28806 To unsubs

Change in vdsm[master]: vdsm: verifyingTransport testing

Dan Kenigsberg has posted comments on this change. Change subject: vdsm: verifyingTransport testing .. Patch Set 7: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28858/7/tests/sslTests.py File tests/sslTests.py: Line

Change in vdsm[master]: virt: migration: add monitor thread control loop

Dan Kenigsberg has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 22: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/25976/22/vdsm/virt/migration.py File v

Change in vdsm[master]: Extract the DOM to Drive name, alias and path logic to reusa...

Dan Kenigsberg has posted comments on this change. Change subject: Extract the DOM to Drive name, alias and path logic to reusable method .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29059 To unsubs

Change in vdsm[master]: Extract the DOM to Drive name, alias and path logic to reusa...

Dan Kenigsberg has submitted this change and it was merged. Change subject: Extract the DOM to Drive name, alias and path logic to reusable method .. Extract the DOM to Drive name, alias and path logic to reusable method Chang

Change in vdsm[master]: Improve the _validateIoTuneParams so the params are passed a...

Dan Kenigsberg has posted comments on this change. Change subject: Improve the _validateIoTuneParams so the params are passed as argument .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28713 To unsubs

Change in vdsm[master]: vm: extract a method to wait for migration

Dan Kenigsberg has posted comments on this change. Change subject: vm: extract a method to wait for migration .. Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28509/2/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: vm: janitorial: detect if dom is running

Dan Kenigsberg has posted comments on this change. Change subject: vm: janitorial: detect if dom is running .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28510 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: vm: janitorial: detect if dom is running

Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: janitorial: detect if dom is running .. vm: janitorial: detect if dom is running this patch extracts a little helper method to detect if the underl

Change in vdsm[master]: vm: detect migration completed on recovery

Dan Kenigsberg has posted comments on this change. Change subject: vm: detect migration completed on recovery .. Patch Set 9: Code-Review-1 (4 comments) minor questions http://gerrit.ovirt.org/#/c/28511/9//COMMIT_MSG Commit M

Change in vdsm[master]: net: skip network restoration if its physical devs are missing

Dan Kenigsberg has posted comments on this change. Change subject: net: skip network restoration if its physical devs are missing .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/29313/1/vdsm/vdsm-restore-

Change in vdsm[master]: janitorial: move Vm._reportError into utils

Dan Kenigsberg has posted comments on this change. Change subject: janitorial: move Vm._reportError into utils .. Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28835/3/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: virt: replace status string with constant

Dan Kenigsberg has posted comments on this change. Change subject: virt: replace status string with constant .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29110 To unsubscribe, visit http://gerrit.ovi

Change in vdsm[master]: virt: replace status string with constant

Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: replace status string with constant .. virt: replace status string with constant during the extraction of migration.py some status strings surviv

Change in vdsm[master]: virt: migration: cleanup the migration mode

Dan Kenigsberg has posted comments on this change. Change subject: virt: migration: cleanup the migration mode .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29111 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: virt: migration: cleanup the migration mode

Dan Kenigsberg has posted comments on this change. Change subject: virt: migration: cleanup the migration mode .. Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/29111/3/vdsm/virt/migration.py File vdsm/virt

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 13: Code-Review+2 raising score -- To view, visit http://gerrit.ovirt.org/27193 To unsubscribe, visit http://

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: Change upgrade mechanism .. vdsm-tool: Change upgrade mechanism The upgrade decorator is a mechanism within vdsm-tool to allow commands to o

Change in vdsm[master]: vdsm-tool: Add logging configuration.

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: Add logging configuration. .. vdsm-tool: Add logging configuration. Added the following flags: -l/--logfile -v/vv/vvv/--v/vv/vvverbose -a/--

Change in vdsm[master]: vdsm-tool: Add logging configuration.

Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: Add logging configuration. .. Patch Set 11: Code-Review+2 raising score -- To view, visit http://gerrit.ovirt.org/27481 To unsubscribe, visit http:

Change in vdsm[ovirt-3.5]: ifcfg: make default route network be started by sysV

Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: make default route network be started by sysV .. Patch Set 3: -Code-Review Ok, Yaniv convinced me that we should first solve this in master (either prop

Change in vdsm[master]: sd: fix volume path returned by linkBCImage

Dan Kenigsberg has posted comments on this change. Change subject: sd: fix volume path returned by linkBCImage .. Patch Set 1: Code-Review+2 Oops, this should have been merge the moment we declared ovirt-3.3 as unsupported. -

Change in vdsm[master]: sd: fix volume path returned by linkBCImage

Dan Kenigsberg has posted comments on this change. Change subject: sd: fix volume path returned by linkBCImage .. Patch Set 3: Same as former version, save for a move of a logging line. -- To view, visit http://gerrit.ovirt.o

Change in vdsm[master]: sd: fix volume path returned by linkBCImage

Dan Kenigsberg has posted comments on this change. Change subject: sd: fix volume path returned by linkBCImage .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24315 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: faqemu hook: move memory limitation to config

Dan Kenigsberg has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 5: Code-Review+2 No objection on the mailing list; Gil just gave me an ack over the phone. -- To vi

Change in vdsm[master]: faqemu hook: move memory limitation to config

Dan Kenigsberg has submitted this change and it was merged. Change subject: faqemu hook: move memory limitation to config .. faqemu hook: move memory limitation to config *** WARNING: this patch changes default behaviour for fa

Change in vdsm[master]: Add missing validateQemuReadable to oop

Dan Kenigsberg has posted comments on this change. Change subject: Add missing validateQemuReadable to oop .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29398 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: utils: Remove duplicate set non-blocking functions

Dan Kenigsberg has posted comments on this change. Change subject: utils: Remove duplicate set non-blocking functions .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29413/1/lib/vdsm/utils.py File lib/vdsm/utils.py:

Change in vdsm[master]: Add missing validateQemuReadable to oop

Dan Kenigsberg has submitted this change and it was merged. Change subject: Add missing validateQemuReadable to oop .. Add missing validateQemuReadable to oop Change-Id: I6598619c7acd18e41b51c15018627973f1eb263a Bug-Url: https:

Change in vdsm[master]: utils: Remove duplicate set non-blocking functions

Dan Kenigsberg has posted comments on this change. Change subject: utils: Remove duplicate set non-blocking functions .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29413/1/lib/vdsm/utils.py File lib/vdsm/utils.py: L

Change in vdsm[master]: vm: add direct import of advancedstats helpers

Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: add direct import of advancedstats helpers .. vm: add direct import of advancedstats helpers This is purely a transitional patch towards the move o

Change in vdsm[master]: vm: add direct import of advancedstats helpers

Dan Kenigsberg has posted comments on this change. Change subject: vm: add direct import of advancedstats helpers .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28480 To unsubscribe, visit http://gerr

Change in vdsm[master]: sampling: allow window=1 in AdvancedStatsFunction

Dan Kenigsberg has posted comments on this change. Change subject: sampling: allow window=1 in AdvancedStatsFunction .. Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/28992/8/tests/samplingTests.py File tests/samplingTes

Change in vdsm[master]: tests: make api check support falsey values

Dan Kenigsberg has posted comments on this change. Change subject: tests: make api check support falsey values .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29438 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: janitorial: move generic error reporting to utils

Dan Kenigsberg has posted comments on this change. Change subject: janitorial: move generic error reporting to utils .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28835 To unsubscribe, visit http://ge

Change in vdsm[master]: migration: add properties and string constants

Dan Kenigsberg has posted comments on this change. Change subject: migration: add properties and string constants .. Patch Set 5: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/29111/5/vdsm/virt/migration.py File vdsm/

Change in vdsm[master]: virt: move XML processing in a module

Dan Kenigsberg has posted comments on this change. Change subject: virt: move XML processing in a module .. Patch Set 2: Code-Review-1 Ack from me for the general split; the module and class names are not very pretty, but I do

Change in vdsm[master]: netlink: simplify string conversion methods

Dan Kenigsberg has posted comments on this change. Change subject: netlink: simplify string conversion methods .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27473 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: netlink: move netlink into a lib vdsm subpackage

Dan Kenigsberg has posted comments on this change. Change subject: netlink: move netlink into a lib vdsm subpackage .. Patch Set 6: Code-Review+2 no rebase glitches found -- To view, visit http://gerrit.ovirt.org/27472 To uns

Change in vdsm[master]: netlink: simplify string conversion methods

Dan Kenigsberg has posted comments on this change. Change subject: netlink: simplify string conversion methods .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27473 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: api: Make remove optional

Dan Kenigsberg has posted comments on this change. Change subject: api: Make remove optional .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29465 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: ipwrapper: do not report devices that disappear

Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper: do not report devices that disappear .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29442 To unsubscribe, visit http://gerr

Change in vdsm[master]: bridge: Show more info when method call fail

Dan Kenigsberg has submitted this change and it was merged. Change subject: bridge: Show more info when method call fail .. bridge: Show more info when method call fail When the bridge try to run a method dynamically and the nu

Change in vdsm[master]: ipwrapper: do not report devices that disappear

Dan Kenigsberg has submitted this change and it was merged. Change subject: ipwrapper: do not report devices that disappear .. ipwrapper: do not report devices that disappear There was a race in getLinks that consisted on devic

Change in vdsm[master]: bridge: Show more info when method call fail

Dan Kenigsberg has posted comments on this change. Change subject: bridge: Show more info when method call fail .. Patch Set 3: Code-Review+2 Raising score -- To view, visit http://gerrit.ovirt.org/29457 To unsubscribe, visit

Change in vdsm[master]: sd: fix volume path returned by linkBCImage

Dan Kenigsberg has submitted this change and it was merged. Change subject: sd: fix volume path returned by linkBCImage .. sd: fix volume path returned by linkBCImage In a previous commit (c072945 One shot prepare) we involunta

Change in vdsm[master]: vdsm: disable virtio-rng on rhel < 7.1

Dan Kenigsberg has posted comments on this change. Change subject: vdsm: disable virtio-rng on rhel < 7.1 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28838 To unsubscribe, visit http://gerrit.ovirt.

Change in vdsm[master]: HostStats: stop storing list of host ifids and speeds

Dan Kenigsberg has uploaded a new change for review. Change subject: HostStats: stop storing list of host ifids and speeds .. HostStats: stop storing list of host ifids and speeds Current code keeps an almost-up-to-date list of

<    1   2   3   4   5   6   7   8   9   10   >