Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: spec: add BuildRequires: python-cpopen
..
spec: add BuildRequires: python-cpopen
Commit 6cb118c5 adds AX_PYTHON_MODULE([cpopen], [fatal])
to
Hello Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/24874
to review the following change.
Change subject: packaging: update python-cpopen requirement to 1.3
..
packaging: update
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: eliminate the VDSMBRIDGE macro
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24814
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: update python-cpopen requirement to 1.3
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24874
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 10:
Toni, did you send it to 3.4 branch too?
--
To view, visit http://gerrit.ovirt.org/24603
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Adding vdsm.conf.example to rhel build
..
Patch Set 1:
Please check jenkins failure.
Checking for unpackaged file(s): /usr/lib/rpm/check-files
Douglas Schilling Landgraf has posted comments on this change.
Change subject: unified pers: fix restoration when moving from ifcfg pers
..
Patch Set 2:
I got the same behavior from my bug#1064530. Toni, I can provide logs or
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: sos: Support to SOS 3
..
sos: Support to SOS 3
This patch will add support to sos 3 API and keep compatible
with old API.
Change-Id:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support to SOS 3
..
Patch Set 1: Verified+1
Tested on RHEL6.4 and Fedora20 using command sosreport -o vdsm
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support to SOS 3
..
Patch Set 1:
Going to fix the jenkins alarm. new patch soon
--
To view, visit http://gerrit.ovirt.org/25188
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support SOS version 3
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/25188
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: unified pers: fix restoration when moving from ifcfg pers
..
Patch Set 2:
Toni, As you know, my previous tests were with wrong vdsm because during
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support SOS version 3
..
Patch Set 2:
Tested on RHEL6.4 and Fedora20 using command sosreport -o vdsm
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support SOS version 3
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25188/2/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Line 18:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: unified pers: fix restoration when moving from ifcfg pers
..
Patch Set 3: Verified+1
jenkins failure not related to the patch.
Toni, do you mind to
Douglas Schilling Landgraf has posted comments on this change.
Change subject: nit: sudoers: drop unused executable
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25250
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: unified pers: fix restoration when moving from ifcfg pers
..
Patch Set 3:
thanks a lot. Users will enjoy the doc.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Install vdsm.conf.example during build
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24945
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support SOS version 3
..
Patch Set 3:
Tested on RHEL6.4 and Fedora20 using command sosreport -o vdsm
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support SOS version 3
..
Patch Set 4:
Tested on RHEL6.4 and Fedora20 using command sosreport -o vdsm
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support SOS version 3
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/25188
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support SOS version 3
..
Patch Set 4:
jenkins failured not related to the patch.
--
To view, visit http://gerrit.ovirt.org/25188
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Install vdsm.conf.example during build
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25450
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support SOS version 3
..
Patch Set 5: Verified+1
Tested on RHEL6.5 and Fedora20 using command sosreport -o vdsm
--
To view, visit
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/25553
to review the following change.
Change subject: sos: Support SOS version 3
..
sos: Support SOS version 3
This patch will
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support SOS version 3
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/25553
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: libvirt_configure: unpersist logrotate.d/libvirt
..
libvirt_configure: unpersist logrotate.d/libvirt
On commit 247a76e7 we moved the libvirt
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure: unpersist logrotate.d/libvirt
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/25700
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure: unpersist logrotate.d/libvirt
..
Patch Set 2:
(1 comment)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure: unpersist logrotate.d/libvirt
..
Patch Set 2:
(1 comment)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: iscsi: Use tpgt when login, update or remove iscsi node
..
Patch Set 1: Verified-1
(1 comment)
-1 for pep8
./vdsm/storage/iscsi.py:148:80: E501
Douglas Schilling Landgraf has posted comments on this change.
Change subject: iscsi: Use tpgt when login, update or remove iscsi node
..
Patch Set 1: -Verified Code-Review-1
--
To view, visit http://gerrit.ovirt.org/25706
To
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: iscsi.py: cleanup - remove temp variable
..
iscsi.py: cleanup - remove temp variable
Don't need to assign new variable to use target.iqn
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/25759
to review the following change.
Change subject: vdsm-reg: collect vdsm-config.log
..
vdsm-reg: collect vdsm-config.log
Douglas Schilling Landgraf has abandoned this change.
Change subject: vdsm-reg: collect vdsm-config.log
..
Abandoned
ops wrong gerrit url
--
To view, visit http://gerrit.ovirt.org/25759
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure: unpersist logrotate.d/libvirt
..
Patch Set 1: Verified+1 Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25756
To
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: autogen.sh: deprecate --system
..
autogen.sh: deprecate --system
The original goal for autogen.sh script is generate the scripts to build the
Douglas Schilling Landgraf has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 1: Verified+1
tested using --system and without it
--
To view, visit http://gerrit.ovirt.org/25804
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 1:
I do believe users and Kiril will approve it! ;-)
--
To view, visit http://gerrit.ovirt.org/25804
Douglas Schilling Landgraf has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/25804
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 2:
tested with ./autogen.sh and autogen.sh --system
--
To view, visit http://gerrit.ovirt.org/25804
Douglas Schilling Landgraf has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25804/1/autogen.sh
File autogen.sh:
Line 37: if test -z $*
Douglas Schilling Landgraf has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/25804
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/25804
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add the host uptime in seconds to host stats
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25835
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add vdsm/ut directory to the tarball
..
Patch Set 1: Code-Review-1
(1 comment)
-1 for now, please see my comment. Thanks for the catch and patch.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add vdsm/ut directory to the tarball
..
Patch Set 1:
IMHO, would be nice to have a better descriptive dir ;-) 'ut' can be many
things but it's not
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add vdsm/ut directory to the tarball
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25861/2/vdsm/ut/Makefile.am
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 4:
(3 comments)
http://gerrit.ovirt.org/#/c/25804/4/autogen.sh
File autogen.sh:
Line 43:
Line 44: if
Douglas Schilling Landgraf has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 5:
If I got right your point, below my answer:
in that case maybe we need to have --local flag for
Douglas Schilling Landgraf has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 3: Code-Review-1
Hey Francesco,
Question, is it possible to include this change also into
Douglas Schilling Landgraf has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/25804
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: hsm: Rename _BCInitiatorNameResolve function
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25701
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add vdsm/ut directory to the tarball
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25861
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add vdsm/ut directory to the tarball
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/25861/6//COMMIT_MSG
Commit Message:
Line 4: Commit:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25860
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: pre-start: touch/configure vdsm logs
..
pre-start: touch/configure vdsm logs
During pre-start of vdsm we must create vdsm logs files
with proper
Douglas Schilling Landgraf has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 2: Code-Review-1
(1 comment)
minor comment
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vm: report exit reason for migration failed
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25164
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 2: Verified+1
Generated RPMs at http://people.redhat.com/dlandgra/newRPMS and ryan barry
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sampling: Collect kdump status
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25926
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 2:
(8 comments)
http://gerrit.ovirt.org/#/c/25912/2//COMMIT_MSG
Commit Message:
Line 6:
Line
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/25912
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25912/4/init/vdsmd_init_common.sh.in
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/25912
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: libvirt_configure: persist cmd qemu-sanlock.conf
..
libvirt_configure: persist cmd qemu-sanlock.conf
On a ovirt-node if executing vdsm-tool
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: tools: configurator must persist usermod changes
..
tools: configurator must persist usermod changes
vdsm-tool configure --force adds to
Douglas Schilling Landgraf has posted comments on this change.
Change subject: tools: configurator must persist usermod changes
..
Patch Set 1:
Should we use approach like this or sys.append.path(/usr/share/vdsm) import
caps
Hello Federico Simoncelli, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/25985
to review the following change.
Change subject: spec: add missing requirement for sanlock on el7
..
Hello Kiril Nesenko, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/25986
to review the following change.
Change subject: spec: use Requires %{name}
..
spec: use Requires %{name}
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 1: Verified+1
Helps rhel7 build
--
To view, visit http://gerrit.ovirt.org/25985
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 1:
helps el7 build which is based on 3.4
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: use Requires %{name}
..
Patch Set 1: Verified+1
helps el7 build which is based on 3.4. Jenkins failure not related to patch.
--
To view,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 1:
jenkins failured not related to the patch.
--
To view, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: libvirt_configure: move unpersist up
..
libvirt_configure: move unpersist up
On commit b4efa0036e065 we have fixed the failure on
mv command to
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure: move unpersist up
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/25990
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: tools: configurator must persist usermod changes
..
Patch Set 4: Verified+1
installed ovirt-node, host became UP. rebooted host, vdsm starting
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 5:
I have tested, it worked.
--
To view, visit http://gerrit.ovirt.org/25912
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: tools: configurator must persist usermod changes
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25974/4//COMMIT_MSG
Commit Message:
Line
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure: move unpersist up
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/25990
To unsubscribe, visit
Hello Fabian Deutsch, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/25992
to review the following change.
Change subject: libvirt_configure: persist cmd qemu-sanlock.conf
..
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure: persist cmd qemu-sanlock.conf
..
Patch Set 1: Verified+1
backport only
--
To view, visit http://gerrit.ovirt.org/25992
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 5:
If we do not support a raw ./autogen.sh (without --system) why do we have it at
all? I already saw
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 5:
Douglas, HOW did you test it? Did you try running
vdsm-tool --force configure
when
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: configurator: move usermod to spec
..
configurator: move usermod to spec
vdsm-tool configure --force adds to /etc/group (qemu/kvm) sanlock
but
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1:
need to be tested with ovirt-node
--
To view, visit http://gerrit.ovirt.org/26055
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: tools: configurator must persist usermod changes
..
Patch Set 4:
(1 comment)
Ok, create another patch to move to spec file. I think the best test
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1:
jenkins failure not related to the patch.
--
To view, visit http://gerrit.ovirt.org/26055
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 2:
need to be tested in case looks good to reviewers.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 2:
I mean, tested in the rhev-h
--
To view, visit http://gerrit.ovirt.org/26055
To unsubscribe,
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: configurator: use sanlock user constant
..
configurator: use sanlock user constant
Replace the static value with a constant.
Change-Id:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 4:
Requires: http://gerrit.ovirt.org/#/c/26080/ Jenkins said nothing to do with
26080 and I
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: configurator: move usermod to spec
..
configurator: move usermod to spec
vdsm-tool configure --force adds to /etc/group (qemu/kvm) sanlock
but
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 4: Code-Review-1
Need to be resync, since we are splitting into http://gerrit.ovirt.org/26089
--
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1:
If all reviewers agree, need to be tested under ovirt-node.
--
To view, visit
Douglas Schilling Landgraf has abandoned this change.
Change subject: tools: configurator must persist usermod changes
..
Abandoned
We are going to use http://gerrit.ovirt.org/#/c/26089/
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 2: Verified+1
Generated a ISO, after install the groups were added correct.
Second test, registered
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/26080
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/25912
To unsubscribe, visit
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26094
to review the following change.
Change subject: configurator: move usermod to spec
..
configurator: move usermod to spec
501 - 600 of 1676 matches
Mail list logo
