Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26095
to review the following change.
Change subject: pre-start: touch/configure vdsm logs
..
pre-start: touch/configure vdsm
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1: Verified+1
- created a vm on Fedora and on oVirt Node
- Suspended and resume the vm
--
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 1: Verified+1
- created a vm on Fedora and on oVirt Node
- Suspended and resume the vm
--
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 4:
Test: generated a iso with this change and after install I see the sanlock user
into
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2: Code-Review-1
I got from cherry-pick:
Automatic cherry-pick failed. After
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
(8 comments)
Hello Yeela, few comments.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add logging to fs operations in supervdsmServer
..
Patch Set 1: Code-Review+1
Please verify the patch.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26123/2//COMMIT_MSG
Commit Message:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 4:
A test for move a static value for constant? I don't get it.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: lvm: Disable usage of lv_metad daemon
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25408
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add logging to rules operations in supervdsmServer
..
Patch Set 4: Code-Review+1
needs to be verified.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: collect vdsm-config.log
..
Patch Set 2: Verified+1
I have tested under ovirt-node the change, it generate the log under
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 4:
Ah I got. Yes, I would prefer small and separate steps.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: update sanlock dependencies
..
Patch Set 1: Code-Review-1
requires rebase and verify.
--
To view, visit http://gerrit.ovirt.org/12292
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: eliminate the VDSMBRIDGE macro
..
Patch Set 2: Verified+1
I could register a ovirt-node into engine.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vm tests: avoid leaving /tmp/blechs.recovery behind
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26197
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: py3: introduce a compatibility helper
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26196
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: Change cpopen import
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26204
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: Change cpopen import
..
Patch Set 1:
please verify
--
To view, visit http://gerrit.ovirt.org/26204
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: destroy storage pool using command type 1
..
Patch Set 7: Code-Review-1
./vdsm/storage/hsm.py:43: 'MAX_DOMAINS' imported but unused
--
To view,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: lvm: remove unused add/remove tags
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit
Douglas Schilling Landgraf has abandoned this change.
Change subject: autogen.sh: deprecate --system
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/25804
To unsubscribe, visit http://gerrit.ovirt.org/settings
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 7: Code-Review-1
./vdsm_reg/engine.py.in:151: local variable 'item' is assigned to but never
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 7: -Code-Review
--
To view, visit http://gerrit.ovirt.org/22462
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 7:
pep failured not related to patch
--
To view, visit http://gerrit.ovirt.org/22462
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 7: Code-Review-1
(1 comment)
-1 since I have a question.
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm_reg: remove engine.py.in
..
vdsm_reg: remove engine.py.in
engine.py.in was stored in vdsm_reg as part of ovirt-node
TUI registration stuff.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_reg: remove engine.py.in
..
Patch Set 1: Code-Review-1
going to update..
--
To view, visit http://gerrit.ovirt.org/26411
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_reg: remove engine.py.in
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/26411
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_reg: remove engine.py.in
..
Patch Set 2:
jenkins failure not related to patch
./vdsm/network/sourceroute.py:159: list comprehension redefines
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: add vdsm user to cdrom group
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26541/1/vdsm.spec.in
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: add vdsm user to cdrom group
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26541/1/vdsm.spec.in
File vdsm.spec.in:
Line 689:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: add vdsm user to cdrom group
..
Patch Set 1:
-1 from dan's comment only
--
To view, visit http://gerrit.ovirt.org/26541
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: nit: remove duplicate command
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26540
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: allow to boot VMs from host CD-ROM
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26541
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 8: Code-Review-1
(3 comments)
few comments
Douglas Schilling Landgraf has posted comments on this change.
Change subject: rpmspec: Drop Fedora 19 special cases
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26582
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: rpmspec: Drop Fedora 19 special cases
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26582
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Add support for vdsm3 package
..
Patch Set 1: Code-Review+1
please verify
the jenkins not related to patch:
LibvirtModuleConfigureTests
Douglas Schilling Landgraf has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 10: Code-Review+1
Jenkins error not related to this patch.
Error:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Add support for vdsm3 package
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26685
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: rpmspec: Drop Fedora 19 special cases
..
Patch Set 3: Verified+1
I could install and remove vdsm on Fedora19
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bridge_options: Add custom network hook for applying
bridge_options
..
Patch Set 1: Code-Review-1
(3 comments)
kind of trivial but I have
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: publish custom network properties
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/26671/1//COMMIT_MSG
Commit Message:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: schema: publish custom network properties
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26671
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm_config: move download certificate
..
vdsm_config: move download certificate
Exist a case where dhcp server may delay to deliver
the ip
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 8: Verified+1
I could register a node via autoinstall (no manual steps) providing only
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 8:
jenkins failured not related to the patch
testLibvirtConfigureToSSLFalse
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 8:
(4 comments)
http://gerrit.ovirt.org/#/c/26718/8/vdsm_reg/vdsm-config
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 9: Code-Review-1
going to update
--
To view, visit http://gerrit.ovirt.org/26718
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 11: Verified+1
I could register a node via autoinstall (no manual steps) providing only
Douglas Schilling Landgraf has posted comments on this change.
Change subject: typo in function call should be 'skipontest'
..
Patch Set 1:
jenkins failure not related.
testLibvirtConfigureToSSLFalse
Douglas Schilling Landgraf has posted comments on this change.
Change subject: lib: rename qemuImg to qemuimg for pep8 compliancy
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26866
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17895
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge
..
Patch Set 6:
Humble, can you please provide the use case or bugzilla if possible?
--
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: iscsi.py: cleanup - remove temp variable
..
Patch Set 2:
required rebase
--
To view, visit http://gerrit.ovirt.org/25710
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: iscsi.py: cleanup - remove temp variable
..
Patch Set 2: Verified+1
tested iscsi with vdsm master and it worked
--
To view, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm-reg-setup: fix logging call
..
vdsm-reg-setup: fix logging call
_createUpgradeDir() uses log.error() which log is not defined.
This patch fix
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg-setup: fix logging call
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/26914
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg-setup: fix logging call
..
Patch Set 2:
jenkins failure not related.
LibvirtModuleConfigureTests
testLibvirtConfigureToSSLFalse
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 11:
(3 comments)
http://gerrit.ovirt.org/#/c/26718/11/vdsm_reg/vdsm-config
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 12: Verified+1
I could register a node via autoinstall (no manual steps) providing only
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 12:
jenkins failure not related to patch.
LibvirtModuleConfigureTests
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg-setup: fix logging call
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26914/2/vdsm_reg/vdsm-reg-setup.in
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg-setup: fix logging call
..
Patch Set 3: Verified+1
Verified: added port and host into vdsm-reg.conf and restarted vdsm-reg daemon.
The
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg-setup: fix logging call
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/26914
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg-setup: fix logging call
..
Patch Set 4:
failure not related to the patch.
testLibvirtConfigureToSSLFalse
Douglas Schilling Landgraf has posted comments on this change.
Change subject: dmi: remove the printInfo function
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26813
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: require libvirt 0.10.2-29.el6_5.4
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26961
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/26718/11/vdsm_reg/vdsm-config
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/26718/11/vdsm_reg/vdsm-config
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Add selinux enforcement reporting.
..
Patch Set 1:
(3 comments)
please verify
http://gerrit.ovirt.org/#/c/26951/1//COMMIT_MSG
Commit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Add selinux enforcement reporting.
..
Patch Set 1: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/26951
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Add selinux enforcement reporting.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26951/1/vdsm/caps.py
File vdsm/caps.py:
Line
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 13: Verified+1
I have tested with autoinstall using: firstboot storage_init=/dev/sda
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm-reg-setup: use os.errno.EEXIST
..
vdsm-reg-setup: use os.errno.EEXIST
During vdsm-reg service start it throw an error about errno.EEXIST
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg-setup: add import errno
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26994/1/vdsm_reg/vdsm-reg-setup.in
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg-setup: add import errno
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/26994
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: Makefile: add vdsm-reg-setup.in to pyflakes
..
Makefile: add vdsm-reg-setup.in to pyflakes
We should run pyflakes in vdsm-reg-setup.in as well.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Makefile: add vdsm-reg-setup.in to pyflakes
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/27025
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 13:
(2 comments)
http://gerrit.ovirt.org/#/c/26718/13/vdsm_reg/vdsm-config
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Add selinux enforcement reporting.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26951/2//COMMIT_MSG
Commit Message:
Line 6:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: collect vdsm-config.log
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/25759
To unsubscribe, visit
Douglas Schilling Landgraf has restored this change.
Change subject: vdsm-reg: collect vdsm-config.log
..
Restored
Good to have such change.
--
To view, visit http://gerrit.ovirt.org/25759
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 13:
(5 comments)
http://gerrit.ovirt.org/#/c/26718/13/vdsm_reg/vdsm-reg-setup.in
File
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: spec: add BuildRequires: rpm-python
..
spec: add BuildRequires: rpm-python
During the make check, the tests modules can import
caps.py which uses
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: add BuildRequires: rpm-python
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/27059
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: spec: remove duplicate entry for BuildRequires
..
spec: remove duplicate entry for BuildRequires
Change-Id:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: remove duplicate entry for BuildRequires
..
Patch Set 1: Verified+1
few lines (70) above appears again.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 14:
(5 comments)
http://gerrit.ovirt.org/#/c/26718/14/vdsm_reg/vdsm-reg-setup.in
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 16: Verified+1
I could register a node via autoinstall and approve it, host is up.
--
To
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/27076
to review the following change.
Change subject: spec: remove duplicate entry for BuildRequires
..
spec: remove duplicate
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/27075
to review the following change.
Change subject: spec: add BuildRequires: rpm-python
..
spec: add BuildRequires:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: add BuildRequires: rpm-python
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/27075
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: remove duplicate entry for BuildRequires
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/27076
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Add support for vdsm3 package
..
Patch Set 1: Code-Review-1
el7 not using vdsm3 anymore
--
To view, visit http://gerrit.ovirt.org/26685
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Add support for vdsm3 package
..
Patch Set 2: Code-Review-1
el7 not using vdsm3 anymore
--
To view, visit http://gerrit.ovirt.org/26627
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 17: Verified+1
--
To view, visit http://gerrit.ovirt.org/26718
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: typo in function call should be 'skipontest'
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/26742
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: typo in function call should be 'skipontest'
..
Patch Set 1:
it's a typo, need to be replaced. verified+1
--
To view, visit
601 - 700 of 1676 matches
Mail list logo