Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.

Gal Hammer has posted comments on this change. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit

Change in vdsm[master]: BZ#841555 A migration failure with an AttributeError excep...

Gal Hammer has posted comments on this change. Change subject: BZ#841555 A migration failure with an AttributeError exception. .. Patch Set 1: No score -- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit

Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.

Gal Hammer has posted comments on this change. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Patch Set 1: No score -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit

Change in vdsm[master]: BZ#841555 A migration failure with an AttributeError excep...

Gal Hammer has posted comments on this change. Change subject: BZ#841555 A migration failure with an AttributeError exception. .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: BZ#829110 Remove a Domain not found error from stats threa...

Gal Hammer has uploaded a new change for review. Change subject: BZ#829110 Remove a Domain not found error from stats thread. .. BZ#829110 Remove a Domain not found error from stats thread. Removed redundant code which changed

Change in vdsm[master]: [RFE] Integrate Smartcard support

Gal Hammer has posted comments on this change. Change subject: [RFE] Integrate Smartcard support .. Patch Set 3: (1 inline comment) File vdsm/libvirtvm.py Line 787:

Change in vdsm[master]: Related to BZ#845020 - Catch bad VM drive specification.

Gal Hammer has posted comments on this change. Change subject: Related to BZ#845020 - Catch bad VM drive specification. .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Added a support for a guest hibernate command.

Gal Hammer has posted comments on this change. Change subject: Added a support for a guest hibernate command. .. Patch Set 8: (1 inline comment) File vdsm/API.py Line 342:

Change in vdsm[master]: [RFE] Integrate Smartcard support

Gal Hammer has posted comments on this change. Change subject: [RFE] Integrate Smartcard support .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8450 To unsubscribe,

Change in vdsm[master]: BZ#841555 A migration failure with an AttributeError excep...

Gal Hammer has posted comments on this change. Change subject: BZ#841555 A migration failure with an AttributeError exception. .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.

Gal Hammer has uploaded a new change for review. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. BZ#867439 VM unexpectedly was shutdown after migration. Change-Id:

Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.

Gal Hammer has posted comments on this change. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8774 To unsubscribe, visit

Change in vdsm[master]: add -d parameter when umouning in mk_sysprep_floppy

Gal Hammer has posted comments on this change. Change subject: add -d parameter when umouning in mk_sysprep_floppy .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8770

Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.

Gal Hammer has posted comments on this change. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. Patch Set 1: (1 inline comment) Commit Message Line

Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.

Gal Hammer has posted comments on this change. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/8774 To unsubscribe, visit

Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.

Gal Hammer has posted comments on this change. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. Patch Set 2: I don't agree with you. The thread is released in the same code path where vdsm get aware

Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.

Gal Hammer has posted comments on this change. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. Patch Set 2: I don't agree with you. The thread is released in the same code path where vdsm get aware

Change in vdsm[master]: Added a support for a guest hibernate command.

Gal Hammer has posted comments on this change. Change subject: Added a support for a guest hibernate command. .. Patch Set 8: I don't understand. Do you want me to re-write the patch in such a way that it will break backward

Change in vdsm[master]: Added a support for a guest hibernate command.

Gal Hammer has posted comments on this change. Change subject: Added a support for a guest hibernate command. .. Patch Set 8: (1 inline comment) Now it is: def vmHibernate(self, vmId, target=API.VM.HibernateTarget.DISK) I

Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.

Gal Hammer has posted comments on this change. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. Patch Set 4: Verified; Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Add qemu's memory usage to VM statistics.

Gal Hammer has uploaded a new change for review. Change subject: Add qemu's memory usage to VM statistics. .. Add qemu's memory usage to VM statistics. Change-Id: Ibeb35759454c4a9b41e1303956267e93ca3545a0 Bug-Url:

Change in vdsm[master]: Add qemu's memory usage to VM statistics.

Gal Hammer has posted comments on this change. Change subject: Add qemu's memory usage to VM statistics. .. Patch Set 2: (2 inline comments) Commit Message Line 6: Line 7:

Change in vdsm[master]: Add qemu's memory usage to VM statistics.

Gal Hammer has posted comments on this change. Change subject: Add qemu's memory usage to VM statistics. .. Patch Set 3: (1 inline comment) File vdsm/libvirtvm.py Line 173:

Change in vdsm[master]: A new method to read from VMs' channels.

Gal Hammer has uploaded a new change for review. Change subject: A new method to read from VMs' channels. .. A new method to read from VMs' channels. Replaced having a thread-per-VM that monitor and read from the VM's virtual

Change in vdsm[master]: A new method to read from VMs' channels.

Gal Hammer has posted comments on this change. Change subject: A new method to read from VMs' channels. .. Patch Set 2: (3 inline comments) File vdsm/clientIF.py Line 119:

Change in vdsm[master]: Added an option to create a memory balloon device.

Gal Hammer has posted comments on this change. Change subject: Added an option to create a memory balloon device. .. Patch Set 3: (1 inline comment) File vdsm/vm.py Line

Change in vdsm[master]: Added an option to create a memory balloon device.

Gal Hammer has posted comments on this change. Change subject: Added an option to create a memory balloon device. .. Patch Set 5: (4 inline comments) File vdsm/libvirtvm.py

Change in vdsm[master]: Added an option to create a memory balloon device.

Gal Hammer has posted comments on this change. Change subject: Added an option to create a memory balloon device. .. Patch Set 6: (1 inline comment) File vdsm/libvirtvm.py

Change in vdsm[master]: A new method to read from VMs' channels.

Gal Hammer has posted comments on this change. Change subject: A new method to read from VMs' channels. .. Patch Set 10: (5 inline comments) File vdsm/vmChannels.py Line 65:

Change in vdsm[master]: Added a support for a guest hibernate command.

Gal Hammer has posted comments on this change. Change subject: Added a support for a guest hibernate command. .. Patch Set 5: (8 inline comments) File vdsm/API.py Line 408:

Change in vdsm[master]: libvirtvm.py: Refactor device xml generation

Gal Hammer has posted comments on this change. Change subject: libvirtvm.py: Refactor device xml generation .. Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) Looks okay, other than a minor

Change in vdsm[master]: remove /rhel/data-center after vdsm unstalled

Gal Hammer has posted comments on this change. Change subject: remove /rhel/data-center after vdsm unstalled .. Patch Set 4: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: additional capsTests

Gal Hammer has posted comments on this change. Change subject: additional capsTests .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4185 To unsubscribe, visit

Change in vdsm[master]: remove /rhel/data-center after vdsm uninstalled

Gal Hammer has posted comments on this change. Change subject: remove /rhel/data-center after vdsm uninstalled .. Patch Set 5: Why not to use %attr(0775, vdsm, qemu) in the spec file to create the directory with a specific

Change in vdsm[master]: remove /rhel/data-center after vdsm uninstalled

Gal Hammer has posted comments on this change. Change subject: remove /rhel/data-center after vdsm uninstalled .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4026 To

Change in vdsm[master]: Add support for redir devices

Gal Hammer has posted comments on this change. Change subject: Add support for redir devices .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4133 To unsubscribe, visit

Change in vdsm[master]: libvirtvm.py: Refactor device xml generation

Gal Hammer has posted comments on this change. Change subject: libvirtvm.py: Refactor device xml generation .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4132 To

Change in vdsm[master]: rest-api: Model VMs

Gal Hammer has posted comments on this change. Change subject: rest-api: Model VMs .. Patch Set 6: I would prefer that you didn't submit this (4 inline comments) I didn't look at the code yet as I think that the REST api (as

Change in vdsm[master]: rest-api: Model VMs

Gal Hammer has posted comments on this change. Change subject: rest-api: Model VMs .. Patch Set 6: (1 inline comment) Commit Message Line 16: - Create a new VM and

Change in vdsm[master]: vdsm: require updated libvirt for USB support

Gal Hammer has posted comments on this change. Change subject: vdsm: require updated libvirt for USB support .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4584 To

Change in vdsm[master]: additional capsTests

Gal Hammer has posted comments on this change. Change subject: additional capsTests .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4185 To unsubscribe, visit

Change in vdsm[master]: BZ#737104 Disallow cross-vendor virtualization.

Gal Hammer has uploaded a new change for review. Change subject: BZ#737104 Disallow cross-vendor virtualization. .. BZ#737104 Disallow cross-vendor virtualization. Change-Id: Id52f757971e28058257d819036e58e0f1925c44d

Change in vdsm[master]: BZ#737104 Disallow cross-vendor virtualization.

Gal Hammer has posted comments on this change. Change subject: BZ#737104 Disallow cross-vendor virtualization. .. Patch Set 2: (4 inline comments) Commit Message Line 8:

Change in vdsm[master]: additional capsTests

Gal Hammer has posted comments on this change. Change subject: additional capsTests .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4185 To unsubscribe, visit

Change in vdsm[master]: BZ#737104 Disallow cross-vendor virtualization.

Gal Hammer has posted comments on this change. Change subject: BZ#737104 Disallow cross-vendor virtualization. .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/5035 To unsubscribe, visit

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

Gal Hammer has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 2: I would prefer that you didn't submit this (4 inline comments) I think that the code that

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

Gal Hammer has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 2: (1 inline comment) File vdsm/vm.py

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

Gal Hammer has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

Gal Hammer has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 7: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

Gal Hammer has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 7: I would prefer that you didn't submit this Ops. Gave it +1 by mistake. See my comment about

Change in vdsm[master]: Change source of CPU sockets/cores to /sys and add cpuThre...

Gal Hammer has posted comments on this change. Change subject: Change source of CPU sockets/cores to /sys and add cpuThreads. .. Patch Set 2: I would prefer that you didn't submit this (4 inline comments)

Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.

Gal Hammer has uploaded a new change for review. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Change waitForMigrationDestinationPrepare function waiting. The change is to avoid timeouts during

Change in vdsm[master]: Add a channel in vdsm for introducing qemu-ga

Gal Hammer has posted comments on this change. Change subject: Add a channel in vdsm for introducing qemu-ga .. Patch Set 12: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5640 To

Change in vdsm[master]: Add a channel in vdsm for introducing qemu-ga

Gal Hammer has posted comments on this change. Change subject: Add a channel in vdsm for introducing qemu-ga .. Patch Set 13: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5640 To

Change in vdsm[master]: Add a channel in vdsm for introducing qemu-ga

Gal Hammer has posted comments on this change. Change subject: Add a channel in vdsm for introducing qemu-ga .. Patch Set 13: Fails; I would prefer that you didn't submit this (1 inline comment) Please fix the code and +1

Change in vdsm[master]: Related to BZ#843387 - Payload should set volPath or raise.

Gal Hammer has posted comments on this change. Change subject: Related to BZ#843387 - Payload should set volPath or raise. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Related to BZ#843387 - Payload should set volPath or raise.

Gal Hammer has posted comments on this change. Change subject: Related to BZ#843387 - Payload should set volPath or raise. .. Patch Set 2: Looks good to me, but someone else must approve I think that the try's else is

Change in vdsm[master]: Add a channel in vdsm for introducing qemu-ga

Gal Hammer has posted comments on this change. Change subject: Add a channel in vdsm for introducing qemu-ga .. Patch Set 14: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5640 To

Change in vdsm[master]: Added a support for a guest hibernate command.

Gal Hammer has posted comments on this change. Change subject: Added a support for a guest hibernate command. .. Patch Set 7: (1 inline comment) File vdsm/BindingXMLRPC.py

Change in vdsm[master]: BZ#841555 A migration failure with an AttributeError excep...

Gal Hammer has uploaded a new change for review. Change subject: BZ#841555 A migration failure with an AttributeError exception. .. BZ#841555 A migration failure with an AttributeError exception. Libvirt sometimes send the

Change in vdsm[master]: BZ#842771 Fix for exception TypeError: cannot marshal None

Gal Hammer has uploaded a new change for review. Change subject: BZ#842771 Fix for exception TypeError: cannot marshal None .. BZ#842771 Fix for exception TypeError: cannot marshal None The VM's mirror and mirrorPath properties

Change in vdsm[master]: BZ#845994 VM failed to start after file injection.

Gal Hammer has uploaded a new change for review. Change subject: BZ#845994 VM failed to start after file injection. .. BZ#845994 VM failed to start after file injection. The before_vm_start hook created a file inside the

Change in vdsm[master]: BZ#845994 VM failed to start after file injection.

Gal Hammer has posted comments on this change. Change subject: BZ#845994 VM failed to start after file injection. .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/6956 To unsubscribe, visit

Change in vdsm[master]: BZ#845994 VM failed to start after file injection.

Gal Hammer has posted comments on this change. Change subject: BZ#845994 VM failed to start after file injection. .. Patch Set 2: (3 inline comments) File

Change in vdsm[master]: BZ#842771 Fix for exception TypeError: cannot marshal None

Gal Hammer has posted comments on this change. Change subject: BZ#842771 Fix for exception TypeError: cannot marshal None .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: BZ#845994 VM failed to start after file injection.

Gal Hammer has posted comments on this change. Change subject: BZ#845994 VM failed to start after file injection. .. Patch Set 3: (2 inline comments) File

Change in vdsm[master]: BZ#845994 VM failed to start after file injection.

Gal Hammer has posted comments on this change. Change subject: BZ#845994 VM failed to start after file injection. .. Patch Set 4: Verified; Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Report host hyperthreads as real cores

Gal Hammer has posted comments on this change. Change subject: Report host hyperthreads as real cores .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7097 To

Change in vdsm[master]: configNetworkTests: use context to manage monkey patches

Gal Hammer has posted comments on this change. Change subject: configNetworkTests: use context to manage monkey patches .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: rename xml.dom.minidom.parseString to _domParseStr in libvir...

Gal Hammer has posted comments on this change. Change subject: rename xml.dom.minidom.parseString to _domParseStr in libvirtvm .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: vdsm: Try to reconnect on vmchannel after timeout

Gal Hammer has posted comments on this change. Change subject: vdsm: Try to reconnect on vmchannel after timeout .. Patch Set 2: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: vdsm: Try to reconnect on vmchannel after errors

Gal Hammer has posted comments on this change. Change subject: vdsm: Try to reconnect on vmchannel after errors .. Patch Set 12: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11977

Change in vdsm[master]: vdsm: Add additional exception handling within vmChannels.py

Gal Hammer has posted comments on this change. Change subject: vdsm: Add additional exception handling within vmChannels.py .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit