Change in vdsm[master]: tests: split vm tests helpers in a module

Nir Soffer has posted comments on this change. Change subject: tests: split vm tests helpers in a module .. Patch Set 2: Francesco, can you claim that there are no changes in the code moved from one file to the other? If you

Change in vdsm[master]: tests: split vm tests helpers in a module

Nir Soffer has posted comments on this change. Change subject: tests: split vm tests helpers in a module .. Patch Set 2: Ok, you already did that. Please ignore my comment. -- To view, visit http://gerrit.ovirt.org/32650 To

Change in vdsm[master]: tests: split vm tests helpers in a module

Nir Soffer has posted comments on this change. Change subject: tests: split vm tests helpers in a module .. Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/32650/2/tests/vmtestlib.py File tests/vmtestlib.py: Line 16: #

Change in vdsm[master]: tests: new functional tests for vdsm storage

Nir Soffer has posted comments on this change. Change subject: tests: new functional tests for vdsm storage .. Patch Set 4: (9 comments) Please address all my comments in patchset 2 (change or explain why you won't change).

Change in vdsm[master]: tests: new functional tests for vdsm storage

Nir Soffer has posted comments on this change. Change subject: tests: new functional tests for vdsm storage .. Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/32496/4/tests/functional/testlib/storagebackends/iscsi.py

Change in vdsm[master]: make: Run fast checks before slow ones

Nir Soffer has posted comments on this change. Change subject: make: Run fast checks before slow ones .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32532/1/Makefile.am File Makefile.am: Line 109: done ; \

Change in vdsm[master]: config: introduce a devel section

Nir Soffer has posted comments on this change. Change subject: config: introduce a devel section .. Patch Set 1: (2 comments) Looks fine but can do more - I think we can do all changes needed for additional profiler in one

Change in vdsm[master]: config: introduce a devel section

Nir Soffer has posted comments on this change. Change subject: config: introduce a devel section .. Patch Set 1: Code-Review+1 On the other hand, we can keep this small and add another patch for the package. -- To view,

Change in vdsm[master]: profiling: Add support for memory profiling

Nir Soffer has posted comments on this change. Change subject: profiling: Add support for memory profiling .. Patch Set 4: Code-Review-1 (10 comments) http://gerrit.ovirt.org/#/c/32019/4/lib/vdsm/profile_mem.py File

Change in vdsm[master]: profiling: Add support for memory profiling

Nir Soffer has posted comments on this change. Change subject: profiling: Add support for memory profiling .. Patch Set 4: (1 comment) I think we should move this into the new profiling package: lib/vdsm/profiling/mem.py

Change in vdsm[master]: tool: Remove duplicate names

Nir Soffer has posted comments on this change. Change subject: tool: Remove duplicate names .. Patch Set 7: Rebase, no code change -- To view, visit http://gerrit.ovirt.org/31775 To unsubscribe, visit

Change in vdsm[master]: tests: Use frozenset instead of set

Nir Soffer has posted comments on this change. Change subject: tests: Use frozenset instead of set .. Patch Set 5: Verified+1 Rebase and fix some new set()s added recently. -- To view, visit http://gerrit.ovirt.org/31786 To

Change in vdsm[master]: make: Add check-all target

Nir Soffer has uploaded a new change for review. Change subject: make: Add check-all target .. make: Add check-all target The previous patch made it easy to skip the stress and slow tests, and hard to run them. This make it

Change in vdsm[master]: make: Add check-all target

Nir Soffer has posted comments on this change. Change subject: make: Add check-all target .. Patch Set 1: Verified+1 Checked that all tests run using make check-all -- To view, visit http://gerrit.ovirt.org/32721 To

Change in vdsm[master]: tests: Disable slow and stress tests by default

Nir Soffer has posted comments on this change. Change subject: tests: Disable slow and stress tests by default .. Patch Set 2: Francesco, see http://gerrit.ovirt.org/32721 -- To view, visit http://gerrit.ovirt.org/32523 To

Change in vdsm[master]: fileSD: Move private constant near the only call site

Nir Soffer has uploaded a new change for review. Change subject: fileSD: Move private constant near the only call site .. fileSD: Move private constant near the only call site Keeping a private constant used by only one

Change in vdsm[master]: fileSD: Move private constant near the only call site

Nir Soffer has posted comments on this change. Change subject: fileSD: Move private constant near the only call site .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32724 To unsubscribe, visit

Change in vdsm[master]: tool: use natural numbers for configuration versioning.

Nir Soffer has posted comments on this change. Change subject: tool: use natural numbers for configuration versioning. .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32708/2/lib/vdsm/tool/configurators/libvirt.py

Change in vdsm[master]: tool: use natural numbers for configuration versioning.

Nir Soffer has posted comments on this change. Change subject: tool: use natural numbers for configuration versioning. .. Patch Set 2: Code-Review-1 According to

Change in vdsm[master]: tool: bump CONF_VERSION to 4.17.

Nir Soffer has posted comments on this change. Change subject: tool: bump CONF_VERSION to 4.17. .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32707/2//COMMIT_MSG Commit Message: Line 9: In a recent commit changing

Change in vdsm[master]: tests: Remove dead code

Nir Soffer has uploaded a new change for review. Change subject: tests: Remove dead code .. tests: Remove dead code Commit 36a81b5aef added the legacy getServices interface, which is not part of the ModuleConfigurator. The new

Change in vdsm[master]: tests: Remove dead code

Nir Soffer has posted comments on this change. Change subject: tests: Remove dead code .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32725 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: tests: Use more clear name

Nir Soffer has uploaded a new change for review. Change subject: tests: Use more clear name .. tests: Use more clear name false_mock is misterious name, specially when used as false_mock=False. Reading the code reveal that

Change in vdsm[master]: tests: Use more clear name

Nir Soffer has posted comments on this change. Change subject: tests: Use more clear name .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32726 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: tests: Use frozenset instead of set

Nir Soffer has posted comments on this change. Change subject: tests: Use frozenset instead of set .. Patch Set 5: No, I don't have a development environment with Python 2.6, but some of the jenkins machines may run this

Change in vdsm[master]: multipath: Disable queuing on all multipath devices

Nir Soffer has posted comments on this change. Change subject: multipath: Disable queuing on all multipath devices .. Patch Set 3: Verified-1 When a device is unmapped on the server, multipath detect the failure and

Change in vdsm[master]: multipath: Disable queuing on all multipath devices

Nir Soffer has posted comments on this change. Change subject: multipath: Disable queuing on all multipath devices .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/32277/3/vdsm/storage/vdsm-multipath.rules.in File

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 1: (6 comments) Nice! http://gerrit.ovirt.org/#/c/32796/1/tests/vmTests.py File tests/vmTests.py: Line

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32796/1//COMMIT_MSG Commit Message: Line 8: Line 9: Changed

Change in vdsm[master]: tests: split vm tests helpers in a module

Nir Soffer has posted comments on this change. Change subject: tests: split vm tests helpers in a module .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32650/2/tests/vmtestlib.py File tests/vmtestlib.py: Line 137:

Change in vdsm[master]: make: Add check-all target

Nir Soffer has posted comments on this change. Change subject: make: Add check-all target .. Patch Set 2: Verified+1 Rebase, still works -- To view, visit http://gerrit.ovirt.org/32721 To unsubscribe, visit

Change in vdsm[master]: lvm: Exclude faulty devices from lvm long filter

Nir Soffer has posted comments on this change. Change subject: lvm: Exclude faulty devices from lvm long filter .. Patch Set 3: Remove noisy log message and update the commit message. -- To view, visit

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32796/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5597:

Change in vdsm[master]: tests: split tests fakes in a module

Nir Soffer has posted comments on this change. Change subject: tests: split tests fakes in a module .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/32650/3/tests/vmApiTests.py File tests/vmApiTests.py: Line 64: Line

Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images

Nir Soffer has uploaded a new change for review. Change subject: qemuimg: Create qcow2 compat 0.10 images .. qemuimg: Create qcow2 compat 0.10 images Recent qemu versions introduced a new default qcow2 format (1.1), which is

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 2: I don't see any changes in the code except the reformatting of the commit message - did you submit

Change in vdsm[master]: tool: bump CONF_VERSION to 4.17.

Nir Soffer has posted comments on this change. Change subject: tool: bump CONF_VERSION to 4.17. .. Patch Set 2: I think a system that avoid unneeded configuration is good. If we don't use it, we probably should fix the code

Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images

Nir Soffer has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32836/1//COMMIT_MSG Commit Message: Line 17: use the -o ? option

Change in vdsm[master]: tool: bump CONF_VERSION to 4.17.

Nir Soffer has posted comments on this change. Change subject: tool: bump CONF_VERSION to 4.17. .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32707/2//COMMIT_MSG Commit Message: Line 9: In a recent commit changing

Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images

Nir Soffer has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32836/1/tests/qemuimgTests.py File tests/qemuimgTests.py: Line

Change in vdsm[master]: Configure iSCSI iface.net_ifacename

Nir Soffer has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename .. Patch Set 11: Code-Review-1 (5 comments) Partial review. http://gerrit.ovirt.org/#/c/31534/11/vdsm/storage/iscsi.py File

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 2: Fabio, did you try git review? it is much easier to use than manually pushing to gerrit. Here is

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 4: (5 comments) Thanks Fabio! You should remove the unrelated changes and fix the indentation.

Change in vdsm[master]: tests: Unify fake execCmd mechanism

Nir Soffer has uploaded a new change for review. Change subject: tests: Unify fake execCmd mechanism .. tests: Unify fake execCmd mechanism qemuimg tests were using two mechanisms for faking utils.execCmd. The old one was

Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images

Nir Soffer has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. Patch Set 2: Fix the part about upgrading the image format in the commit message. -- To view, visit

Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images

Nir Soffer has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32836/1/tests/qemuimgTests.py File tests/qemuimgTests.py: Line

Change in vdsm[master]: tests: split tests fakes in a module

Nir Soffer has posted comments on this change. Change subject: tests: split tests fakes in a module .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/32650/3/tests/vmApiTests.py File tests/vmApiTests.py: Line 64: Line

Change in vdsm[master]: tests: Unify fake execCmd mechanism

Nir Soffer has posted comments on this change. Change subject: tests: Unify fake execCmd mechanism .. Patch Set 1: Verified+1 Tests still pass -- To view, visit http://gerrit.ovirt.org/32884 To unsubscribe, visit

Change in vdsm[master]: tool-tests: use variable from conf version in template files.

Nir Soffer has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32713/1/tests/toolTests.py File

Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images

Nir Soffer has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32836/2/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 136:

Change in vdsm[master]: utils: Use ovirt node for persist and unpersist files

Nir Soffer has posted comments on this change. Change subject: utils: Use ovirt node for persist and unpersist files .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31584 To unsubscribe, visit

Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator

Nir Soffer has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator .. Patch Set 9: (1 comment) The patch is in great shape now. Unfortunately a rebase is required after

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 5: (2 comments) A deeper cleanup is required in vm.py. Otherwise this is fine. Thanks Fabio!

Change in vdsm[master]: Revert 'Create default multipath.conf during install'

Nir Soffer has posted comments on this change. Change subject: Revert 'Create default multipath.conf during install' .. Patch Set 8: Code-Review+1 Note that this can be merged only after http://gerrit.ovirt.org/30909 is

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 6: Code-Review+1 Looks great - Thanks Fabio! -- To view, visit http://gerrit.ovirt.org/32796 To

Change in vdsm[master]: tests: Use more clear name

Nir Soffer has posted comments on this change. Change subject: tests: Use more clear name .. Patch Set 2: Rebase, no code change -- To view, visit http://gerrit.ovirt.org/32726 To unsubscribe, visit

Change in vdsm[master]: tests: Use more clear name

Nir Soffer has posted comments on this change. Change subject: tests: Use more clear name .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/32726 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 7: Fix typo in the tests, running make check is useful. Tests pass now. -- To view, visit

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32796 To unsubscribe, visit

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/32796/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2872

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/32796/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2872

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/32796/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2872 Line

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/32796/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2872 Line

Change in vdsm[master]: vm: implement VM.sdIds as read-only property

Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 8: Code-Review+1 Thanks Fabio and sorry for the bike-shedding. -- To view, visit

Change in vdsm[master]: tests: split tests fakes in a module

Nir Soffer has posted comments on this change. Change subject: tests: split tests fakes in a module .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/32650/3/tests/vmApiTests.py File tests/vmApiTests.py:

Change in vdsm[master]: vm: return diskMapping on status()

Nir Soffer has posted comments on this change. Change subject: vm: return diskMapping on status() .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/31700/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2433: def

Change in vdsm[master]: Configure iSCSI iface.net_ifacename

Nir Soffer has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename .. Patch Set 12: (2 comments) Partial review http://gerrit.ovirt.org/#/c/31534/12/vdsm/storage/iscsi.py File

Change in vdsm[master]: Configure iSCSI iface.net_ifacename

Nir Soffer has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename .. Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/31534/12/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 110:

Change in vdsm[master]: test: fix typos and repair vmTests

Nir Soffer has posted comments on this change. Change subject: test: fix typos and repair vmTests .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32965/1/tests/vmTests.py File tests/vmTests.py: Line 1311:

Change in vdsm[master]: test: fix typos and repair vmTests

Nir Soffer has posted comments on this change. Change subject: test: fix typos and repair vmTests .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32965/1/tests/vmTests.py File tests/vmTests.py: Line 1342:

Change in vdsm[ovirt-3.5]: jsonrpc: wrong usage of optional arguments in ctor

Nir Soffer has posted comments on this change. Change subject: jsonrpc: wrong usage of optional arguments in ctor .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/32980/1/vdsm/rpc/Bridge.py File

Change in vdsm[master]: jsonrpc: sslerror during accept should be logged on warning

Nir Soffer has posted comments on this change. Change subject: jsonrpc: sslerror during accept should be logged on warning .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/32985/1/vdsm/protocoldetector.py

Change in vdsm[master]: test: fix typos and repair vmTests

Nir Soffer has posted comments on this change. Change subject: test: fix typos and repair vmTests .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/32965/1/tests/vmTests.py File tests/vmTests.py: Line

Change in vdsm[master]: jsonrpc: sslerror during accept should be logged on warning

Nir Soffer has posted comments on this change. Change subject: jsonrpc: sslerror during accept should be logged on warning .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32985 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: sslerror during accept should be logged on warning

Nir Soffer has posted comments on this change. Change subject: jsonrpc: sslerror during accept should be logged on warning .. Patch Set 2: -Code-Review Seems that the review was too quick :-) -- To view, visit

Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images

Nir Soffer has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. Patch Set 2: Verified+1 Verified on mixed cluster with rhel7 and rhel6.5 hosts: - create vm on rhel7 - verify that

Change in vdsm[master]: jsonrpc: sslerror during accept should be logged on warning

Nir Soffer has posted comments on this change. Change subject: jsonrpc: sslerror during accept should be logged on warning .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32985 To unsubscribe, visit

Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...

Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/32928/3//COMMIT_MSG Commit Message: Line

Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...

Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/32928/3/vdsm/virt/libvirt-hook.sh File

Change in vdsm[master]: tests: split tests fakes in a module

Nir Soffer has posted comments on this change. Change subject: tests: split tests fakes in a module .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32650 To unsubscribe, visit

Change in vdsm[master]: vm: return diskMapping on status()

Nir Soffer has posted comments on this change. Change subject: vm: return diskMapping on status() .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31700 To unsubscribe, visit

Change in vdsm[master]: vm, guestagent: return hash should include also the disk map...

Nir Soffer has posted comments on this change. Change subject: vm, guestagent: return hash should include also the disk mapping .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31701 To unsubscribe,

Change in vdsm[master]: Configure iSCSI iface.net_ifacename

Nir Soffer has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename .. Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/31534/13/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 401:

Change in vdsm[ovirt-3.5]: jsonrpc: sslerror during accept should be logged on warning

Nir Soffer has posted comments on this change. Change subject: jsonrpc: sslerror during accept should be logged on warning .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33016 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: qemuimg: Create qcow2 compat 0.10 images

Hello Federico Simoncelli, Allon Mureinik, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/33020 to review the following change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. qemuimg:

Change in vdsm[ovirt-3.5]: qemuimg: Create qcow2 compat 0.10 images

Nir Soffer has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. Patch Set 1: Verified+1 Verified on master, no relevant code changed in the modified module. -- To view, visit

Change in vdsm[master]: Configure iSCSI iface.net_ifacename

Nir Soffer has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename .. Patch Set 13: (3 comments) http://gerrit.ovirt.org/#/c/31534/13/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line

Change in vdsm[ovirt-3.4]: qemuimg: Create qcow2 compat 0.10 images

Hello Federico Simoncelli, Allon Mureinik, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/33022 to review the following change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. qemuimg:

Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...

Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/32928/4//COMMIT_MSG Commit Message:

Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...

Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe,

Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...

Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/32928/5/vdsm/virt/libvirt-hook.sh File

Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...

Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 5: -Code-Review -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe,

Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...

Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/32928/5/vdsm/virt/libvirt-hook.sh File

Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...

Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe,

Change in vdsm[master]: utils: Add changehash function for change detection

Nir Soffer has uploaded a new change for review. Change subject: utils: Add changehash function for change detection .. utils: Add changehash function for change detection We use Python built-in hash to detect changes in vm

Change in vdsm[master]: utils: Add changehash function for change detection

Nir Soffer has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 1: I hope that engine treat this as opaque string, hopefully one of the reviewers can confirm

Change in vdsm[master]: tool-tests: use variable from conf version in template files.

Nir Soffer has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32713/1/tests/toolTests.py File

Change in vdsm[master]: tool: bump CONF_VERSION to 4.17.

Nir Soffer has posted comments on this change. Change subject: tool: bump CONF_VERSION to 4.17. .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/32707/2/lib/vdsm/tool/configurators/libvirt.py File

Change in vdsm[master]: utils: Add changehash function for change detection

Nir Soffer has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33045/1//COMMIT_MSG Commit Message: Line 6: Line 7:

Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator

Nir Soffer has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator .. Patch Set 9: (4 comments) http://gerrit.ovirt.org/#/c/30909/9/lib/vdsm/tool/configurators/multipath.py

<    6   7   8   9   10   11   12   13   14   15   >