Piotr Kliczewski has posted comments on this change.
Change subject: stomp: parsing buffer refactoring
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38666/4//COMMIT_MSG
Commit Message:
Line 7: stomp: parsing
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Fix callMethod in JsonRpcClient
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/35935/9/lib/yajsonrpc/__init__.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Pop the frame even if a frame handler isn't defined
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/35940/9/lib/yajsonrpc/stomp.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 25: Code-Review+1
Api and schema changes looks good.
--
To view, visit https://gerrit.ovirt.org/35498
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 8: Verified+1
Verified with engine based on latest master
--
To view, visit https://gerrit.ovirt.org/38451
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 7: Verified-1
Failed verification with engine using latest master.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: protocoldetector: Make cleanup more deterministic
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37248
To unsubscribe, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add glusterStorageDevicesList verb
..
Patch Set 13: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/35028/13/vdsm/rpc/vdsmapi-gluster
Piotr Kliczewski has posted comments on this change.
Change subject: Move NUMA collecting code to stats thread
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36906
To unsubscribe, visit http
Piotr Kliczewski has abandoned this change.
Change subject: Revert jsonrpc: Image_upload missing in command_info
..
Abandoned
Already reverted by Oved
--
To view, visit http://gerrit.ovirt.org/36538
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36806
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: protocoldetector: Fix race in protocoldetector tests
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37046
To unsubscribe, visit
Piotr Kliczewski has reverted this change.
Change subject: Revert jsonrpc: Image_upload missing in command_info
..
Patch Set 2: Reverted
This patchset was reverted in change: Ie0bff90c45e23a5cb62749cf54b6ea8c6e7bdc49
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Fetch disperse count and redundacy count for volume
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/38305/4/vdsm/rpc/vdsmapi
Piotr Kliczewski has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 2: -Code-Review
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Fix callMethod in JsonRpcClient
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/35935/6//COMMIT_MSG
Commit Message:
Line 11
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 5:
Verified that communication with engine 3.5 works but not checked event
infrastructure yet.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Add feature to create dispersed volume
..
Patch Set 3: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/37474/3/vdsm/rpc/vdsmapi-gluster-schema.json
Piotr Kliczewski has posted comments on this change.
Change subject: Revert jsonrpc: Image_upload missing in command_info
..
Patch Set 1: Verified+1
Marking verified flag since it is a revert
--
To view, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: vm: add missing vm id to get stats of down vm
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37694
To unsubscribe, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/37055/4/lib/yajsonrpc/betterAsyncore.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 13:
(1 comment)
http://gerrit.ovirt.org/#/c/35498/13/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: regression on setupNetworks
..
jsonrpc: regression on setupNetworks
During schema and code alignemnt Host_setupNetowrks entry was removed
from
Piotr Kliczewski has posted comments on this change.
Change subject: vm: add debug log for getStats()
..
Patch Set 2:
(1 comment)
You gave -1 already
http://gerrit.ovirt.org/#/c/36732/2/lib/yajsonrpc/__init__.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 16: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35498/16/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 13: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35498/13/vdsm/gluster/apiwrapper.py
File vdsm/gluster
Piotr Kliczewski has posted comments on this change.
Change subject: infra: Introduce EventFD support
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37051
To unsubscribe, visit http://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: Add feature to create dispersed volume
..
Patch Set 4: Code-Review+1
api and schema changes looks good
--
To view, visit http://gerrit.ovirt.org/37474
Piotr Kliczewski has posted comments on this change.
Change subject: Revert supervdsm: Add zombiereaper to supervdsm
..
Patch Set 2: Verified+1
Verified by running on rhel 66.
--
To view, visit http://gerrit.ovirt.org/36961
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: volume snapshot activate and deactivate verbs.
..
Patch Set 6: Code-Review+1
api and schema changes looks good
--
To view, visit http
Piotr Kliczewski has uploaded a new change for review.
Change subject: Revert jsonrpc: Image_upload missing in command_info
..
Revert jsonrpc: Image_upload missing in command_info
This entry already was merged on master
Piotr Kliczewski has posted comments on this change.
Change subject: Add remoteServer parameter into gluster volumes list
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/36783/2/vdsm/rpc/vdsmapi-gluster
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Added geo-replication session list and session status
..
Patch Set 25: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/18414/25/vdsm/rpc
Piotr Kliczewski has uploaded a new change for review.
Change subject: Revert supervdsm: Add zombiereaper to supervdsm
..
Revert supervdsm: Add zombiereaper to supervdsm
Introduction of zombiereaper is causing communication
Piotr Kliczewski has posted comments on this change.
Change subject: detector
..
Patch Set 1:
(1 comment)
This patch seems to be work in progress I am not sure how it should work at
this stage. Please update it or push
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Added geo-replication session list and session status
..
Patch Set 26: Code-Review+1
Schema and api changes looks good.
--
To view, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Fix too delicate tests
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37249
To unsubscribe, visit http://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/37097/3/lib/yajsonrpc/stomp.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Fix callMethod in JsonRpcClient
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35935
To unsubscribe, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: geo-replication pause and resume session
..
Patch Set 8: Code-Review+1
api/schema changes looks good
--
To view, visit http://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: Add remoteServer parameter into gluster volumes list
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36783
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 11: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35498/11/vdsm/gluster/apiwrapper.py
File vdsm/gluster
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Change _AsyncoreEvent to use EventFD
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37052
To unsubscribe, visit http
Piotr Kliczewski has uploaded a new change for review.
Change subject: Re-post: supervdsm: Add zombiereaper to supervdsm
..
Re-post: supervdsm: Add zombiereaper to supervdsm
This is re-post of commit
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: geo-replication pause and resume session
..
Patch Set 7: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/31069/7/vdsm/rpc/vdsmapi-gluster
Piotr Kliczewski has posted comments on this change.
Change subject: betterAsyncore: Bind the dispatcher implementation
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35252
To unsubscribe, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: volume snapshot create and delete verbs.
..
Patch Set 15: Code-Review+1
api and schema changes looks good
--
To view, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: zombiereaper: Raise if used incorrectly
..
Patch Set 2: Code-Review+1
Please make sure to have it in 3.5 as well.
--
To view, visit http://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: geo-replication configuration related verbs.
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/30162/10/vdsm/rpc/vdsmapi-gluster-schema.json
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move AsyncoreEvent to betterAsyncore
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37053
To unsubscribe, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: [WIP]Use jsonrpc during migration of vms
..
Patch Set 3:
(4 comments)
http://gerrit.ovirt.org/#/c/36701/3/vdsm/virt/migration.py
File vdsm/virt/migration.py
Piotr Kliczewski has posted comments on this change.
Change subject: [wip] hornetq changes
..
Patch Set 1:
(4 comments)
http://gerrit.ovirt.org/#/c/36361/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-12-23 17:29:34
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: volume snapshot config list and set verbs.
..
Patch Set 10: Code-Review+1
(2 comments)
I am ok with api and schema related changes. I have a single
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add _getDeviceDict function to reuse common code
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37643
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: json-rpc: fix the Host.getVMList return value
..
Patch Set 1:
This is what I was afraid of. The engine expects different type and we see
marshalling issue
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 22: Code-Review+1
api and schema relates changes looks good.
--
To view, visit http://gerrit.ovirt.org/35498
Piotr Kliczewski has posted comments on this change.
Change subject: broker_support
..
Patch Set 1: Code-Review-1
(6 comments)
http://gerrit.ovirt.org/#/c/36368/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: volume snapshot config list and set verbs.
..
Patch Set 13: Code-Review+1
Schema and api changes looks good.
--
To view, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Add ValidateNotRunningAsRoot
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37939
To unsubscribe, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and
set
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35937
Piotr Kliczewski has uploaded a new change for review.
Change subject: Re-post: hba: Run fc-scan in supervdsm
..
Re-post: hba: Run fc-scan in supervdsm
This is re-post of commit: 5a6ae1a266e6808861a10933d7cacb81838050f1
Piotr Kliczewski has posted comments on this change.
Change subject: Revert hba: Run fc-scan in supervdsm
..
Patch Set 3:
Both revered patches re-posted as drafts:
http://gerrit.ovirt.org/#/c/37319/
http://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: geo-replication configuration related verbs.
..
Patch Set 11: Code-Review+1
api and schema related changes looks good
--
To view, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: dynamic tick support
..
Patch Set 4:
(1 comment)
Please add a test for this change.
http://gerrit.ovirt.org/#/c/37057/4/lib/yajsonrpc/stomp.py
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: use monotonic timer instead of clock
..
Patch Set 4: Code-Review+1
Please update the patch description with benefits of using os.times() over
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: for checking the event use the class method
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37832
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/37509/2/client/vdsClient.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 12:
(1 comment)
http://gerrit.ovirt.org/#/c/35498/12/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc/vdsmapi
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Added geo-replication session list and session status
..
Patch Set 24: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/18414/24/vdsm/gluster
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: volume snapshot config list and set verbs.
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/34741/10/vdsm/rpc/vdsmapi-gluster-schema.json
Piotr Kliczewski has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 1: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/37509/1/client/vdsClient.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Remove AsyncChat
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37096
To unsubscribe, visit http://gerrit.ovirt.org
Piotr Kliczewski has abandoned this change.
Change subject: [wip] hornetq changes
..
Abandoned
This change is not needed
--
To view, visit http://gerrit.ovirt.org/36361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Added gluster snapshot restore verb.
..
Patch Set 11: Code-Review+1
api and schema looks good
--
To view, visit http://gerrit.ovirt.org/34638
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35934
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/37055/13/lib/yajsonrpc/betterAsyncore.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Remove JsonRpcClientPool
..
Patch Set 7: Verified+1
Verified by running engine 3.5, host installing vdsm and checking the logs
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Remove redundant code
..
Patch Set 6: Verified+1
Verified by running engine 3.5, host installing vdsm and checking the logs for
potential issues
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: parsing buffer refactoring
..
Patch Set 1: Verified+1
Verified by running engine 3.5, host installing vdsm and checking the logs for
potential issues
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 23: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/35498/23/vdsm/gluster/apiwrapper.py
File vdsm/gluster
Piotr Kliczewski has uploaded a new change for review.
Change subject: getAllVmStats: failing to parse vmids
..
getAllVmStats: failing to parse vmids
Bug-Url: https://bugzilla.redhat.com/1196735
Change-Id
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Fix callMethod in JsonRpcClient
..
Patch Set 6: Verified+1
Verified by running engine 3.5, host installing vdsm and checking the logs for
potential
Piotr Kliczewski has posted comments on this change.
Change subject: [WIP] broker_support
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/36368/5/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py
Piotr Kliczewski has posted comments on this change.
Change subject: [WIP]Use jsonrpc during migration of vms
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/36701/4/vdsm/virt/migration.py
File vdsm/virt
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Properly log and return an error if the threadFactory
fails
..
Patch Set 6: Verified+1
Verified by running engine 3.5, host installing vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError
..
Patch Set 6: Verified+1
Verified by running engine 3.5, host installing vdsm and checking
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: add ability to get dictionary directly from
JsonRpcRequest
..
Patch Set 7: Verified+1
I had to miss this one when setting bulk verification flag
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 12:
(2 comments)
https://gerrit.ovirt.org/#/c/37097/12/lib/yajsonrpc/betterAsyncore.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 12: Verified+1
Verified by using engine 3.5 to host install vdsm and checking the logs to see
Piotr Kliczewski has posted comments on this change.
Change subject: getVMList: using internal function instead of vm.status
..
Patch Set 1:
tests performed on f20
--
To view, visit https://gerrit.ovirt.org/38513
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Pop the frame even if a frame handler isn't defined
..
Patch Set 6: Verified+1
Verified by running engine 3.5, host installing vdsm and checking
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/37097/11/lib/yajsonrpc/stompReactor.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/4/vdsm/API.py
File vdsm/API.py:
Line 1385
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 4: Verified-1
We do not send heartbeats anymore.
--
To view, visit https://gerrit.ovirt.org/38451
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 5:
Using engine 3.5 to host install vdsm and seeing no communication issues.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Fetch disperse count and redundacy count for volume
..
Patch Set 5: Code-Review+1
Schema change looks good
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py
File vdsm/API.py:
Line 1388
Piotr Kliczewski has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py
File vdsm/API.py
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 6: Verified-1
We do not send heartbeats anymore.
--
To view, visit https://gerrit.ovirt.org/36368
1 - 100 of 2901 matches
Mail list logo