Piotr Kliczewski has posted comments on this change.
Change subject: json-rpc: fix the Host.getVMList return value
..
Patch Set 1: Verified+1
Verified by Omer on master branch.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38433
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: Have the protocol detector use the Reactor
..
Patch Set 7: Verified+1
Verified by installing a host and seeing communication going between engine and
vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer
..
Patch Set 5:
Thank you for bringing this up. This patch as it is was used as base for
https
Piotr Kliczewski has posted comments on this change.
Change subject: getVMList: using internal function instead of vm.status
..
Patch Set 1: Verified+1
Verified by using engine 3.6 and creating storage domain, running a vm
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Optimize stomp encoder\decoder
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/35255/6//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: dynamic tick support
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/37057/11/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: [WIP] EVENTS
..
Patch Set 4: Verified-1
jsonrpc code is not working for el6
--
To view, visit https://gerrit.ovirt.org/38069
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 24: Code-Review+1
schema and api changes looks good
--
To view, visit https://gerrit.ovirt.org/35498
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 14: Verified-1
There was rebase only so I still need to fix Francesco's comments.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 15: Verified+1
Rebased and added docstring in betterAsyncore as requested. Copying verify flag
due
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 14: Verified+1
Rebased, added requested docstring. Verified with engine 3.5
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer
..
Patch Set 8: Verified+1
I would like to keep this patch as sanity check since I have seen it useful
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 8: Verified+1
Rebased, verified with engine 3.5
--
To view, visit https://gerrit.ovirt.org/36368
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 6:
Rebased, communication with engine 3.5 works but events not verified yet.
--
To view, visit https://gerrit.ovirt.org/38069
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: dynamic tick support
..
Patch Set 15: Verified+1
Fixed comments and rebased. Verified with engine 3.5
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: Have the protocol detector use the Reactor
..
Patch Set 12: Verified+1
Rebased, fix comments. Verified with engine 3.5
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Fix callMethod in JsonRpcClient
..
Patch Set 8: Verified+1
Rebased, updated commit message. Verified with engine 3.5.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 6: Verified+1
Rebased, fixed comments, Verified with engine 3.5
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: parsing buffer refactoring
..
Patch Set 3: Verified+1
Rebased, fixed comments. Verified with engine 3.5
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Stomp encoder\decoder improvements
..
Patch Set 9: Verified+1
Rebased and commit message updated to make it clear what type of changes this
patch
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Pop the frame even if a frame handler isn't defined
..
Patch Set 8: Verified+1
Rebased, comment fixed. Verified with engine 3.5
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Optimize stomp encoder\decoder
..
Patch Set 8:
From my perspective it is not really optimization but bug fixing of stomp frame
encoding/decoding. I
Piotr Kliczewski has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: API: getVMList: compatibity with internal clients
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/38805/2//COMMIT_MSG
Commit Message
Piotr Kliczewski has posted comments on this change.
Change subject: API: getVMList: compatibity with internal clients
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38805
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: API: getVMList: compatibity with internal clients
..
Patch Set 2:
How does it looks from the engine perspective? Can you look for getVMFullList?
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: API: getVMList: compatibity with internal clients
..
Patch Set 2: -Code-Review
Logs seems good. Please check with master and if that works I am fine
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 7: Verified+1
Rebased, added event test and verified with engine 3.5.
--
To view, visit https://gerrit.ovirt.org/38069
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: outgoing connection to a broker
..
stomp: outgoing connection to a broker
Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843
Signed-off
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 8: Verified+1
Updaed __init__.py by moving part of change from broker patch which belong to
this patch. Verified with engine
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 1: Verified-1
(1 comment)
Connection to broker not tested yet.
https://gerrit.ovirt.org/#/c/38819/1/lib
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Adds new verbs to setup gluster geo-replication.
..
Patch Set 9: Code-Review+1
api and schema changes looks good
--
To view, visit https
Piotr Kliczewski has uploaded a new change for review.
Change subject: events: vm status notifications
..
events: vm status notifications
Whenever vm changes status we send notification to an engine with vmid
and new status
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 1:
Verified with engine containing vm status updates via events. I tested creation
of a vm and suspending it. I
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Pop the frame even if a frame handler isn't defined
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/35940/10//COMMIT_MSG
Commit Message
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/38069/10/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 145:
Line 146: def
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/38937/1/tests/jsonRpcTests.py
File tests/jsonRpcTests.py:
Line 59
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/38451/9/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 10:
(4 comments)
https://gerrit.ovirt.org/#/c/36368/10/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/38451/9/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/38451/9/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Patch adds geo-replication create and delete verbs.
..
Patch Set 30: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/17644/30/vdsm/gluster
Piotr Kliczewski has uploaded a new change for review.
Change subject: asyncore: adding __impl attribute
..
asyncore: adding __impl attribute
Change-Id: I16f4a9f98a1d8ca490db3e29d6becedb4ac52ea8
Signed-off-by: pkliczewski
Piotr Kliczewski has posted comments on this change.
Change subject: tests: making as broken
..
Patch Set 1: Verified+1
Verified locally and by jenkins
--
To view, visit https://gerrit.ovirt.org/39001
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 11: Verified+1
Rebased, fixed comments, verified with latest engine (master).
--
To view, visit https://gerrit.ovirt.org/38069
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: heartbeat fix
..
Patch Set 1: Verified+1
Verified with latest engine (master) by installing host and adding storage. No
heartbeat issues found
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Stomp encoder\decoder improvements
..
Patch Set 12: Verified+1
Verified with latest engine (master)
--
To view, visit https://gerrit.ovirt.org/35255
-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org
-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo
-MessageType: newchange
Gerrit-Change-Id: I2b1f4d8e6c2c4e6ae1bb2c7371804c35e905ee95
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
___
vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: parsing buffer refactoring
..
Patch Set 6: Verified+1
Patch split in 3 and rebased. Verified with latest engine.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: extending buffer size
..
Patch Set 1: Verified+1
This change was part of stomp: parsing buffer refactoring. Verified with
latest engine (master
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 10: Code-Review+1
Rebased, fixed comments, verified with latest engine (master).
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 11: Verified+1
Rebased, fixed comments, verified with latest engine (master).
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
Communication verified with latest engine (master). VM status changes are sent
very fast and sometimes db
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Fix callMethod in JsonRpcClient
..
Patch Set 11: Verified+1
Rebased. Verified with latest engine (master).
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Always pop the frame for frame handler
..
Patch Set 11: Verified+1
Rebased, verified with latest engine (master).
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 5: Verified+1
Rebased, fixed event queue name (engine side comment). Not verified with broker
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: modified parsing logic in snapshot config list.
..
Patch Set 1: Verified+1
Schema change looks good.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4: Code-Review+1
Schema change looks good
--
To view, visit https://gerrit.ovirt.org/38766
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: dynamic tick support
..
Patch Set 14:
(2 comments)
https://gerrit.ovirt.org/#/c/37057/14/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: parsing buffer refactoring
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38666/2/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Pop the frame even if a frame handler isn't defined
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/35940/7/lib/yajsonrpc/stomp.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: Have the protocol detector use the Reactor
..
Patch Set 11:
(8 comments)
https://gerrit.ovirt.org/#/c/37098/11/lib/vdsm/sslutils.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer
..
Patch Set 7:
I sill would like to keep. During development I have seen it being thrown so
let's use
Piotr Kliczewski has posted comments on this change.
Change subject: tests: making sure that after events changes all tests passes
..
Patch Set 4: Verified+1
Verified locally and by jenkins (schema validation failed the build
Piotr Kliczewski has posted comments on this change.
Change subject: schema: temporarily skip getMigrationStatus
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39062
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Patch adds geo-replication create and delete verbs.
..
Patch Set 32: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/17644
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Fix arguments name for geo-replication status verb.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39222
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: detecting loop on centos7
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/39343/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: detecting loop on centos7
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/39343/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: detecting loop on centos7
..
Patch Set 2:
Verified by running functional/networkTests.py on centos7 and confirmed that
there is no regression
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Stomp encoder\decoder improvements
..
Patch Set 12:
(3 comments)
https://gerrit.ovirt.org/#/c/35255/12/lib/yajsonrpc/stomp.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: detecting loop on centos7
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/39343
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has uploaded a new change for review.
Change subject: xmlrpc: detecting loop on centos7
..
xmlrpc: detecting loop on centos7
When we process newly incoming connection we receive read event and we
detect xmlrpc
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: detecting loop on centos7
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/39343/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: detecting loop on centos7
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/39343/4/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: vdscliTests: add a test for connect with a timeout
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/38806/8/tests/functional
Piotr Kliczewski has posted comments on this change.
Change subject: migration: Use jsonrpc during migration of vms
..
Patch Set 5: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/36701/5/lib/yajsonrpc/__init__.py
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Fix arguments name for geo-replication status verb.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39222
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/38766/4/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Adds new verb to setup geo-rep mount broker.
..
Patch Set 6: Code-Review+1
Schema and api changes looks good
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Modified geo-rep verbs to include newly added user
..
Patch Set 3: Code-Review+1
api and schema changes looks good
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: extending buffer size
..
Patch Set 1:
I will update commit message
--
To view, visit https://gerrit.ovirt.org/38989
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: parsing buffer refactoring
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/38666/6/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/36368/11//COMMIT_MSG
Commit Message:
Line 7: stomp: client side
Piotr Kliczewski has posted comments on this change.
Change subject: schema: temporarily hide getMigrationStatus return
..
Patch Set 1:
What do you think about adding VM.getMigrationStatus to IGNORED_CMDS in
schemaValidation
Piotr Kliczewski has uploaded a new change for review.
Change subject: tests: making sure that after events changes all tests passes
..
tests: making sure that after events changes all tests passes
Change-Id
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: heartbeat fix
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/38988/1/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: virt: remove unwanted 'response' aliasing
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38803
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: detecting loop on centos7
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/39343/5/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 54
Piotr Kliczewski has posted comments on this change.
Change subject: tests: making sure that after events changes all tests passes
..
Patch Set 5: Verified+1
Verified by running local build on f20.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/38937/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1578
Piotr Kliczewski has uploaded a new change for review.
Change subject: xmlrpc: fd leak on centos7
..
xmlrpc: fd leak on centos7
We found that when running functional test networkTests we are leaking
fds. Each seperate call ends
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: detecting loop on centos7
..
Patch Set 6: Verified+1
Verified on centos7
--
To view, visit https://gerrit.ovirt.org/39343
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: fd leak on centos7
..
Patch Set 1: Verified+1
Verified on centos7
--
To view, visit https://gerrit.ovirt.org/39506
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: betterAsyncore: Fix event loop data stealing [1/2]
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39513
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: betterAsyncore: Fix event loop data stealing [2/2]
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39514
To unsubscribe, visit
201 - 300 of 2901 matches
Mail list logo