Change in vdsm[master]: gluster:enforce gluster fencing policies

2016-07-24 Thread emesika
Eli Mesika has posted comments on this change. Change subject: gluster:enforce gluster fencing policies .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59600 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: vdsm: adding handling for NGN in osinfo.py

2016-07-10 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60433 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: vdsm: adding handling for NGN in osinfo.py

2016-07-10 Thread emesika
of the PRETTY_NAME value (if exists) from that file. Change-Id: Ida119527b263302bf3f78e359bac12113718b744 Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1324447 Signed-off-by: emesika <emes...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/59431 Continuous-Integration: Jenkins CI Re

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-06-29 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/59431 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding support for version 4.1

2016-06-20 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/59308/3/lib/vdsm/dsaversion.py.in File lib/vdsm/dsaversion.py.in:

Change in vdsm[master]: vdsm: adding support for version 4.1

2016-06-19 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/59308 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding support for version 4.1

2016-06-19 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59308/2/lib/vdsm/dsaversion.py.in File lib/vdsm/dsaversion.py.in:

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-06-19 Thread emesika
Eli Mesika has abandoned this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Abandoned Abandoned due to Dans comment , solution will have a different approach for NGN using the original osname, release

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-06-19 Thread emesika
: Ida119527b263302bf3f78e359bac12113718b744 Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1324447 Signed-off-by: emesika <emes...@redhat.com> --- M lib/api/vdsm-api.yml M lib/vdsm/osinfo.py 2 files changed, 32 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/59431/1 diff

Change in vdsm[master]: vdsm: adding support for version 4.1

2016-06-19 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59308/2/lib/vdsm/dsaversion.py.in File lib/vdsm/dsaversion.py.in:

Change in vdsm[master]: vdsm: adding support for version 4.1

2016-06-16 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/59308 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding support for version 4.1

2016-06-16 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/59308/1/lib/vdsm/dsaversion.py.in File lib/vdsm/dsaversion.py.in:

Change in vdsm[master]: vdsm: adding support for version 4.1

2016-06-16 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/59308 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding support for version 4.1

2016-06-16 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: vdsm: adding support for version 4.1 .. vdsm: adding support for version 4.1 Change-Id: I7aaaf4d6ebf6c1e0fdcb37a158993a7b84c7f06d Signed-off-by: emesika <e

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-19 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-19 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/57620/7/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-19 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-19 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/57620/5/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line 92:

Change in vdsm[ovirt-3.6]: vdsm: return error when status cmd fail

2016-05-18 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: return error when status cmd fail .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/57641 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-18 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 5: -Code-Review Verified+1 -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-18 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-18 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-18 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-18 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-18 Thread emesika
Change-Id: I17337643cd4e986c09b07137d80da3555161ee70 Signed-off-by: emesika <emes...@redhat.com> --- M lib/vdsm/osinfo.py 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/57620/1 diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py index 8ad99a1.

Change in vdsm[master]: vdsm: return error when status cmd fail

2016-05-15 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: return error when status cmd fail .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/57463 To unsubscribe, visit

Change in vdsm[master]: vdsm: return error when status cmd fail

2016-05-15 Thread emesika
, the code returned a 0 error code which masks the error message. To fix that, the real error code is returned in the case that the status is not 'on' or 'off' Change-Id: I9b076349e01412ef9757e3b3346d1dc17183bf84 Signed-off-by: emesika <emes...@redhat.com> --- M vdsm/API.py 1 file chan

Change in vdsm[master]: adding compatibility for ovirt-engine 4.0 support

2015-11-25 Thread emesika
Eli Mesika has posted comments on this change. Change subject: adding compatibility for ovirt-engine 4.0 support .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in File

Change in vdsm[master]: adding compatibility for ovirt-engine 4.0 support

2015-11-25 Thread emesika
Eli Mesika has posted comments on this change. Change subject: adding compatibility for ovirt-engine 4.0 support .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49060 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: vdsm: No need to 'import threading'

2014-09-30 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: No need to 'import threading' .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33522 To unsubscribe, visit

Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

2014-09-29 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 7: Verified+1 Verified after manually applied JSON patch http://gerrit.ovirt.org/#/c/33424/ -- To view, visit

Change in vdsm[ovirt-3.5]: vdsm: making PM 'on' and 'off' sync

2014-09-29 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: vdsm: making PM 'on' and 'off' sync .. vdsm: making PM 'on' and 'off' sync Consider the following scenario: DC1 with H1 (with PM) and H2 on cluster C1 another

Change in vdsm[ovirt-3.5]: vdsm: making PM 'on' and 'off' sync

2014-09-29 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/33469 To unsubscribe, visit

Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

2014-09-22 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/32695/5/vdsm/API.py File vdsm/API.py: Line 1234:

Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

2014-09-22 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/32695 To unsubscribe, visit

Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

2014-09-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/32695/4/vdsm/API.py File vdsm/API.py: Line 1227: try: Line

Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

2014-09-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 5: Verified+1 verified and working as expected on engine 3.3 -- To view, visit http://gerrit.ovirt.org/32695 To

Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

2014-09-16 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 3: -Verified (1 comment) http://gerrit.ovirt.org/#/c/32695/3/vdsm/API.py File vdsm/API.py: Line 1253:

Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

2014-09-16 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/32695/3/vdsm/API.py File vdsm/API.py: Line 1253:

Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

2014-09-15 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32695/2/vdsm/API.py File vdsm/API.py: Line 1247:

Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

2014-09-15 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/32695 To unsubscribe, visit

Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

2014-09-09 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: vdsm: making PM 'on' and 'off' sync .. vdsm: making PM 'on' and 'off' sync Consider the following scenario: DC1 with H1 (with PM) and H2 on cluster C1 another

Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

2014-09-09 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32695 To unsubscribe, visit

Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

2014-09-09 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/32695 To unsubscribe, visit

Change in vdsm[master]: init: Normalize shutdown timeout

2014-03-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: init: Normalize shutdown timeout .. Patch Set 3: I don't think that a change from 2 to 10 sec will do a change since we are computing the host load in soft

Change in vdsm[master]: init: Normalize shutdown timeout

2014-03-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: init: Normalize shutdown timeout .. Patch Set 3: Just reminding again that we want to prevent to enlarge recovery time for HA VMs , so , 10 sec is OK 30 or bigger

Change in vdsm[master]: fencing: stop using a deprecated command

2014-02-11 Thread emesika
Eli Mesika has posted comments on this change. Change subject: fencing: stop using a deprecated command .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24303 To unsubscribe, visit

Change in vdsm[master]: Remove verbosity from restorecon hack for /var/log/core.

2013-12-01 Thread emesika
Eli Mesika has posted comments on this change. Change subject: Remove verbosity from restorecon hack for /var/log/core. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21888 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add ioTune support at vm creation

2013-05-28 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: Add ioTune support at vm creation .. Patch Set 12: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14636 To

Change in vdsm[master]: infra: adding debug log to vdsm daemon init script

2012-08-23 Thread emesika
Eli Mesika has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7340

Change in vdsm[master]: infra: adding debug log to vdsm daemon init script

2012-08-21 Thread emesika
Eli Mesika has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script .. Patch Set 2: (4 inline comments) File vdsm/vdsmd.init.in

Change in vdsm[master]: fenceNode API is missing the options argument

2012-08-09 Thread emesika
Eli Mesika has posted comments on this change. Change subject: fenceNode API is missing the options argument .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7058 To

Change in vdsm[master]: BZ#840386: vms with shared disk will pause...

2012-07-30 Thread emesika
Eli Mesika has posted comments on this change. Change subject: BZ#840386: vms with shared disk will pause... .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/6283 To unsubscribe, visit

Change in vdsm[master]: BZ#840386: vms with shared disk will pause...

2012-07-17 Thread emesika
Eli Mesika has posted comments on this change. Change subject: BZ#840386: vms with shared disk will pause... .. Patch Set 4: (1 inline comment) File vdsm/vm.py Line 519:

Change in vdsm[master]: BZ#834893: vms with shared disk will pause...

2012-07-16 Thread emesika
Eli Mesika has posted comments on this change. Change subject: BZ#834893: vms with shared disk will pause... .. Patch Set 2: (2 inline comments) Commit Message Line 10:

Change in vdsm[master]: BZ#834893: vms with shared disk will pause...

2012-07-16 Thread emesika
Eli Mesika has posted comments on this change. Change subject: BZ#834893: vms with shared disk will pause... .. Patch Set 3: (3 inline comments) Commit Message Line 7:

Change in vdsm[master]: BZ#840386: vms with shared disk will pause...

2012-07-16 Thread emesika
Eli Mesika has posted comments on this change. Change subject: BZ#840386: vms with shared disk will pause... .. Patch Set 4: (1 inline comment) File vdsm/vm.py Line 519:

Change in vdsm[master]: vdsm:vms with shared disk will pause...(#834893)

2012-07-15 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: vdsm:vms with shared disk will pause...(#834893) .. vdsm:vms with shared disk will pause...(#834893) vms with shared disk will pause due to I/O errors on double

Change in vdsm[master]: vdsm:vms with shared disk will pause...(#834893)

2012-07-15 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm:vms with shared disk will pause...(#834893) .. Patch Set 1: (2 inline comments) Commit Message Line 7:

Change in vdsm[master]: vdsm:vdsm is not looking for new libvirt-daemon...

2012-07-09 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: vdsm:vdsm is not looking for new libvirt-daemon... .. vdsm:vdsm is not looking for new libvirt-daemon... https://bugzilla.redhat.com/838591 vdsm is not looking

Change in vdsm[master]: vdsm: set ballooon device model properly

2012-05-31 Thread emesika
Eli Mesika has abandoned this change. Change subject: vdsm: set ballooon device model properly .. Patch Set 2: Abandoned -- To view, visit http://gerrit.ovirt.org/4900 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: vdsm: set ballooon device model properly

2012-05-31 Thread emesika
Eli Mesika has abandoned this change. Change subject: vdsm: set ballooon device model properly .. Patch Set 2: Restored -- To view, visit http://gerrit.ovirt.org/4900 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: vdsm: set ballooon device model properly

2012-05-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: set ballooon device model properly .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4900 To unsubscribe, visit