Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(3 comments)
File
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(2 comments)
File
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5: Code-Review+2
(1 comment)
Minor nit. But overall is +2.
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Rename confusing lastCheck variable
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21879
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Rename confusing lastCheck variable
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21879
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: securable: refactor the scurable implementation
..
Patch Set 1:
(2 comments)
File tests/main.py
Line
Federico Simoncelli has posted comments on this change.
Change subject: vdsm hooks: Add missing snapshot=no attribute to disk
ellements.
..
Patch Set 2: Code-Review+1
(1 comment)
Code is ok but I'd prefer to see the commit
Federico Simoncelli has posted comments on this change.
Change subject: vdsm hooks: Add missing snapshot=no attribute to disk
ellements.
..
Patch Set 2:
(1 comment)
Code is ok but I'd prefer to see the commit message fixed.
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: consolidate getMasterVersion in one method
..
sp: consolidate getMasterVersion in one method
Change-Id: I8a055c9eb21cc5681d1f9afde5e7eab899aa65c0
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: _refreshDomainLinks must not change the metadata
..
sp: _refreshDomainLinks must not change the metadata
Change-Id:
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: refactor out the metadata access from StoragePool
..
sp: refactor out the metadata access from StoragePool
Change-Id:
Federico Simoncelli has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
..
Patch Set 1: Code-Review-1
(1 comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Improve logging
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21936
To unsubscribe, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: domainMonitor: Improve logging
..
domainMonitor: Improve logging
We have logs in domain monitor thread, and we can see when a monitor
starts or
Federico Simoncelli has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1:
@Nir, why aren't we using the mocking libraries suggested in the python
documentation:
Federico Simoncelli has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1: Code-Review+1
(1 comment)
Code is fine but the commit message should be improved.
Federico Simoncelli has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22058
To unsubscribe, visit
Federico Simoncelli has uploaded a new change for review.
Change subject: securable: refactor the scurable implementation
..
securable: refactor the scurable implementation
Change-Id: Id5a8be7536748481746795e27701fbecc7c3318c
Federico Simoncelli has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2537:
Federico Simoncelli has posted comments on this change.
Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state
..
Patch Set 1: Code-Review+1
(1 comment)
Minor question for Michal.
Federico Simoncelli has posted comments on this change.
Change subject: avoid redundant domain produce() in createStoragePool
..
Patch Set 2: Code-Review-1
(1 comment)
I like the idea but the implementation has a problem that
Federico Simoncelli has posted comments on this change.
Change subject: bz#831938 raise exception when error occurs in
connectStorageServer
..
Patch Set 1: Code-Review-1
(1 comment)
Federico Simoncelli has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2: Code-Review-1
(1 comment)
Finally!!!
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35: Code-Review+1
I see just minor comments. +1
--
To view, visit http://gerrit.ovirt.org/15829
To
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 4: Code-Review-1
(2 comments)
File vdsm/vm.py
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 14:
(1 comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20074
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21832
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21878
To
Federico Simoncelli has posted comments on this change.
Change subject: vm: Refix vm unpausing during recovery
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21892
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21487
To
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: avoid masking uuid in StoragePool methods
..
sp: avoid masking uuid in StoragePool methods
For some unknown reason during an unrelated refactoring
Federico Simoncelli has posted comments on this change.
Change subject: getStorageDomainInfo: SP keys when disconnected.
..
Patch Set 2: Code-Review-1
(1 comment)
Commit
Federico Simoncelli has posted comments on this change.
Change subject: getStorageDomainInfo: SP keys when disconnected.
..
Patch Set 2:
(1 comment)
File
Federico Simoncelli has uploaded a new change for review.
Change subject: Revert Ubuntu: make hard coded group names configurable in
configurator.py
..
Revert Ubuntu: make hard coded group names configurable in configurator.py
Federico Simoncelli has uploaded a new change for review.
Change subject: Revert Introducing configurator package in vdsm-tool
..
Revert Introducing configurator package in vdsm-tool
This reverts commit
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
..
Patch Set 2:
(1 comment)
File vdsm/clientIF.py
Line 454:
Federico Simoncelli has posted comments on this change.
Change subject: sp: remove the getFormat method
..
Patch Set 3:
why? Until we get rid of the whole thing Format is actually the correct
terminology (vs. the old
Federico Simoncelli has posted comments on this change.
Change subject: hsm: Log unhandled exceptions in storage refresh thread
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21486
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21778
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: storage: drop an unused configurable sd_validate_timeout
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21060
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: sp: move reconnection info check to StoragePool
..
Patch Set 3:
(4 comments)
File
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: remove the getFormat method
..
sp: remove the getFormat method
Change-Id: Ifb292ef57f94e1fea67f3111e5f414cc41c346a9
Signed-off-by: Federico
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: refresh metadata on hsm when listing domains
..
sp: refresh metadata on hsm when listing domains
In this patch:
- validatePoolSD and
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: move validatePoolSD in the StoragePool class
..
sp: move validatePoolSD in the StoragePool class
It's the StoragePool duty to validate if an
Federico Simoncelli has posted comments on this change.
Change subject: bootstrap: Return recovery error during lvm bootstrap
..
Patch Set 4: Code-Review+1
(2 comments)
The patch seems more or less ok to me. But I am really
Federico Simoncelli has posted comments on this change.
Change subject: Misc storage exception class name style
..
Patch Set 1: Code-Review+1
Ok. But it should be rebased and verified (checking that there are no other new
Federico Simoncelli has posted comments on this change.
Change subject: get max_tasks and thread_pool_size from config by getint()
..
Patch Set 1: Code-Review+1
OK, it seems that these values are already used to be compared
Federico Simoncelli has posted comments on this change.
Change subject: vm: Fix vm unpausing during recovery
..
Patch Set 2: Code-Review+1
I have to double check if this might affect the pool upgrade (it shouldn't but
I want
Federico Simoncelli has posted comments on this change.
Change subject: [wip] Implement extendVolume in fileSD/Volume.
..
Patch Set 2: Code-Review-1
This patch is obsoleted by the disk resize implementation at
Federico Simoncelli has posted comments on this change.
Change subject: vm: Fix vm unpausing during recovery
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21649
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: vm: Fix vm unpausing during recovery
..
Patch Set 2:
I wanted to check if the upgrade callback could be, in any way, affected by
this new event. Since
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: pre-defined range for spice/vnc ports
..
Patch Set 4: Code-Review+1
Please update the commit message.
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: refactor buildConfDevices and getConfDevices into single
function
..
Patch Set 5: Code-Review+2
(1 comment)
Federico Simoncelli has submitted this change and it was merged.
Change subject: vdsm: Accents in the vm name break the migration
..
vdsm: Accents in the vm name break the migration
Added utf-8 encoding of the configuration
Federico Simoncelli has submitted this change and it was merged.
Change subject: Ensure cancellation of migrations gets handled correctly
..
Ensure cancellation of migrations gets handled correctly
If the migration is
Federico Simoncelli has posted comments on this change.
Change subject: sp: turn spm status attributes private
..
Patch Set 2:
(1 comment)
File vdsm/storage/sp.py
Line 141:
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: notify on the first status check
..
Patch Set 1: Code-Review-1
(3 comments)
File
Federico Simoncelli has posted comments on this change.
Change subject: sp: move reconnection info check to StoragePool
..
Patch Set 3:
Ayal, your comments are mostly correct, but sadly this patch is at the base of
many
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: add setMasterDomain to StoragePool
..
sp: add setMasterDomain to StoragePool
It turns out that getMasterDomain is used mostly as a setter for
the
Federico Simoncelli has posted comments on this change.
Change subject: Revert gluster prepareImage: return gluster-specific
information
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21508
To
Federico Simoncelli has posted comments on this change.
Change subject: api: remove the uploadVolume command
..
Patch Set 3: Verified+1
Verified: rpm build successfully
--
To view, visit http://gerrit.ovirt.org/21425
To
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: remove unused scsiFencing parameter
..
sp: remove unused scsiFencing parameter
Change-Id: I7d9b62c08cf8925fbc1856655dc49dd41eacd2d9
Signed-off-by:
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: remove unused recoveryMode from spmStart
..
sp: remove unused recoveryMode from spmStart
Change-Id: I4be0a2aad270e87cf6a83f8b1fd36d928312104e
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: remove scsiKey from connectStoragePool
..
sp: remove scsiKey from connectStoragePool
Change-Id: I39c02f9256b1ef802ca4ec434a19aeecfea1f87a
Federico Simoncelli has abandoned this change.
Change subject: vdscli: fix missing method in TransportWrapper
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/21429
To unsubscribe, visit http://gerrit.ovirt.org/settings
Federico Simoncelli has posted comments on this change.
Change subject: lvm: Deactivate lvs during bootstrap
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21501
To unsubscribe, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: lvm: Allow multiple LVs to be refreshed at once
..
lvm: Allow multiple LVs to be refreshed at once
lvm.refreshLV() function used to accept only
Federico Simoncelli has posted comments on this change.
Change subject: Fix calculation of file volume allocated size
..
Patch Set 2:
(1 comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21500
To unsubscribe, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: lvm: Deactivate lvs during bootstrap
..
lvm: Deactivate lvs during bootstrap
When using FC storage, physical volumes are connected during boot,
Federico Simoncelli has posted comments on this change.
Change subject: sp: [wip] receive domains map in connectStoragePool
..
Patch Set 1:
(2 comments)
File vdsm/API.py
Federico Simoncelli has posted comments on this change.
Change subject: sp: [wip] receive domains map in connectStoragePool
..
Patch Set 1:
(1 comment)
File vdsm/API.py
Federico Simoncelli has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 7: Code-Review+2
(1 comment)
When/if properly tested this is good enough for me.
Federico Simoncelli has posted comments on this change.
Change subject: sp: [wip] receive domains map in connectStoragePool
..
Patch Set 1:
(1 comment)
File vdsm/API.py
Federico Simoncelli has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once.
..
Patch Set 10: Code-Review+2
(1 comment)
No need to block on my minor comments if you don't want to.
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Log exceptions in domain monitor thread
..
Patch Set 1: Code-Review-1
(1 comment)
Federico Simoncelli has posted comments on this change.
Change subject: Revert xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21489
To
Federico Simoncelli has uploaded a new change for review.
Change subject: vm: improve extension check in extendDrivesIfNeeded
..
vm: improve extension check in extendDrivesIfNeeded
Change-Id:
Federico Simoncelli has posted comments on this change.
Change subject: vm: improve extension check in extendDrivesIfNeeded
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: [wip] receive domains map in connectStoragePool
..
sp: [wip] receive domains map in connectStoragePool
Change-Id:
Federico Simoncelli has uploaded a new change for review.
Change subject: sd: [wip] add getClusterLockOwnerId method
..
sd: [wip] add getClusterLockOwnerId method
Change-Id: I10e64d74319ea6591a7edf8e17809d367a758386
Federico Simoncelli has uploaded a new change for review.
Change subject: api: remove the uploadVolume command
..
api: remove the uploadVolume command
Change-Id: Ie2b26aded19f482751196ef642386dcf92d81ce4
Signed-off-by: Federico
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: move reconnection info check to StoragePool
..
sp: move reconnection info check to StoragePool
The entire reconnection info logic belongs to the
Federico Simoncelli has posted comments on this change.
Change subject: api: remove the uploadVolume command
..
Patch Set 1:
Dan, remind me, was there something that I should have attended when we remove
a verb? (e.g. should
Federico Simoncelli has uploaded a new change for review.
Change subject: vdscli: fix missing method in TransportWrapper
..
vdscli: fix missing method in TransportWrapper
TransportWrapper should also provide the request method
Federico Simoncelli has posted comments on this change.
Change subject: api: remove the uploadVolume command
..
Patch Set 1:
(1 comment)
File vdsm/storage/sp.py
Line 23:
Federico Simoncelli has submitted this change and it was merged.
Change subject: domainMonitor: tag pool monitored domains
..
domainMonitor: tag pool monitored domains
As part of the monitoring implementation:
7b1cc6a Adding
Hello Ayal Baron,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21357
to review the following change.
Change subject: domainMonitor: tag pool monitored domains
..
domainMonitor: tag pool
Federico Simoncelli has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5: Code-Review+1
(3 comments)
Few comments. +1 for now, I still have doubts.
Federico Simoncelli has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 3: -Code-Review
(1 comment)
File vdsm/vm.py
Line
Hello Ayal Baron, Sergey Gotliv,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21382
to review the following change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
vm: unify
Hello Ayal Baron, Yeela Kaplan, Sergey Gotliv, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21383
to review the following change.
Change subject: vm: prevent faulty volume extensions
Federico Simoncelli has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
Patch Set 1: Verified+1
Same as upstream.
--
To view, visit http://gerrit.ovirt.org/21382
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 1: Verified+1
Same as upstream.
--
To view, visit http://gerrit.ovirt.org/21383
To unsubscribe, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
vm: unify _highWrite and _onAbnormalStop
Both _highWrite and _onAbnormalStop should share the same
Federico Simoncelli has submitted this change and it was merged.
Change subject: vm: prevent faulty volume extensions
..
vm: prevent faulty volume extensions
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443
Hello Ayal Baron,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21274
to review the following change.
Change subject: vm: refresh raw disk before live extension
..
vm: refresh raw disk before
Federico Simoncelli has posted comments on this change.
Change subject: vm: refresh raw disk before live extension
..
Patch Set 1: Verified+1 Code-Review+2
Same as master.
--
To view, visit http://gerrit.ovirt.org/21274
To
Federico Simoncelli has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
..
Patch Set 17:
(4 comments)
Nice. Few minor questions.
File
1 - 100 of 1323 matches
Mail list logo
