Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-29 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 6:

* #1314371::Update tracker: OK
* Set MODIFIED::bug 1314371#1314371IGNORE, not all related patches are 
closed, check 58810

-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-29 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: hooks: openstack hook should wait a while for nic activation
..


hooks: openstack hook should wait a while for nic activation

The vm will be stated in a paused state if a nic managed by
an external openstack network provider is present. The openstack
hook after_vm_start  must then wait a given time to allow the
nic to be activated before unpausing the vm.

Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Bug-Url: https://bugzilla.redhat.com/1314371
Signed-off-by: mirecki 
Reviewed-on: https://gerrit.ovirt.org/58917
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Francesco Romani 
---
A vdsm_hooks/openstacknet/after_vm_start.py
M vdsm_hooks/openstacknet/before_device_create.py
M vdsm_hooks/openstacknet/openstacknet_utils.py
3 files changed, 84 insertions(+), 0 deletions(-)

Approvals:
  Marcin Mirecki: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-29 Thread mmirecki 
Marcin Mirecki has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-28 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/58917/5/vdsm_hooks/openstacknet/after_vm_start.py
File vdsm_hooks/openstacknet/after_vm_start.py:

Line 25: 
Line 26: def resume_paused_vm(vm_id):
Line 27: unpause_file = MARK_FOR_UNPAUSE_PATH % vm_id
Line 28: if os.path.isfile(unpause_file):
Line 29: vdscli.connect().cont(vm_id)
next time please avoid chain of calls. Better:

  conn = vdscli.connect()
  conn.cont(vm_id)

here we are in a hook, so no big deal.
Line 30: os.remove(unpause_file)
Line 31: 
Line 32: 
Line 33: def main():


-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-27 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-27 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 5:

* #1314371::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1314371::OK, public bug
* Check Product::#1314371::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-27 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 4:

* #1314371::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1314371::OK, public bug
* Check Product::#1314371::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-22 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 3: Code-Review+2

Do we have to wait for so long (60 seconds)? is that the typical neutron wait 
time?

-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-20 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 3: Code-Review+1

as long as we know the sleep() code is fragile and temporary, it's ok for me. 
Deeper review later.

-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-20 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 3:

* #1314371::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1314371::OK, public bug
* Check Product::#1314371::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-20 Thread mmirecki 
Marcin Mirecki has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 2:

(5 comments)

https://gerrit.ovirt.org/#/c/58917/2/vdsm_hooks/openstacknet/after_vm_start.py
File vdsm_hooks/openstacknet/after_vm_start.py:

PS2, Line 37: time.sleep
> Please add a big TODO: we need to wait here until the port is bound in Neut
Done


PS2, Line 37: time.sleep
> this is still fragile: you don't know how long could Vdsm take to actually 
This patch is temporary, until we decide on the details on how to solve the 
issue checking the nic state against neutron.
The better solution comes in the next patch:
https://gerrit.ovirt.org/#/c/58810/5


https://gerrit.ovirt.org/#/c/58917/2/vdsm_hooks/openstacknet/before_device_create.py
File vdsm_hooks/openstacknet/before_device_create.py:

PS2, Line 152: pause_flag
> either drop completely or use PAUSE_FLAG, as this never changes.
Done


PS2, Line 153: flag
> flagS please (plural)
Done


PS2, Line 156:  libvirt.VIR_DOMAIN_START_PAUSED
> minor, perhaps silly:
Done


-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-20 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/58917/2/vdsm_hooks/openstacknet/after_vm_start.py
File vdsm_hooks/openstacknet/after_vm_start.py:

PS2, Line 37: time.sleep
> this is still fragile: you don't know how long could Vdsm take to actually 
Please add a big TODO: we need to wait here until the port is bound in Neutron.

Any commit that might be seen as trying to "fix" a race with a sleep must have 
a big sign saying "yes, I know that this is a fragile hack".


https://gerrit.ovirt.org/#/c/58917/2/vdsm_hooks/openstacknet/before_device_create.py
File vdsm_hooks/openstacknet/before_device_create.py:

PS2, Line 152: pause_flag
either drop completely or use PAUSE_FLAG, as this never changes.


-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-16 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 2: Code-Review-1

(2 comments)

-1 for visibility, most important question is in after_vm_start.py

https://gerrit.ovirt.org/#/c/58917/2/vdsm_hooks/openstacknet/before_device_create.py
File vdsm_hooks/openstacknet/before_device_create.py:

PS2, Line 153: flag
flagS please (plural)


PS2, Line 156:  libvirt.VIR_DOMAIN_START_PAUSED
minor, perhaps silly:

  flag |= pause_flag

?


-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-16 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/58917/2/vdsm_hooks/openstacknet/after_vm_start.py
File vdsm_hooks/openstacknet/after_vm_start.py:

PS2, Line 37: time.sleep
this is still fragile: you don't know how long could Vdsm take to actually 
start the VM.
The real fix is to have a proper event emitted by Vdsm, and to wait for it 
here. But this requires some changes to jsonrpcvdscli which I don't think are 
planned or will be available soon.


-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-16 Thread mmirecki 
Marcin Mirecki has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/58917/1/vdsm_hooks/openstacknet/after_vm_start.py
File vdsm_hooks/openstacknet/after_vm_start.py:

PS1, Line 24: vdscli.connect(vdscli.cannonizeHostPort('0'), True, None)
> just call vdscli.connect(). It has some sane heuristics regarding how to co
Done


Line 26: 
Line 27: def main():
Line 28: vm_id = os.environ[VM_ID_KEY]
Line 29: launch_flags = hooking.load_vm_launch_flags_from_file(vm_id)
Line 30: if launch_flags == libvirt.VIR_DOMAIN_START_PAUSED:
> this has a bug if the admin asked to start the VM in PAUSED state. this act
Done
Line 31: time.sleep(OPENSTACK_NIC_WAIT_TIME)
Line 32: resume_paused_vm(vm_id)
Line 33: 
Line 34: 


https://gerrit.ovirt.org/#/c/58917/1/vdsm_hooks/openstacknet/before_device_create.py
File vdsm_hooks/openstacknet/before_device_create.py:

Line 136:  % (vNicId, providerType, pluginType))
Line 137: addOpenstackVnic(domxml, pluginType, vNicId, 
hasSecurityGroups)
Line 138: hooking.write_domxml(domxml)
Line 139: if pluginType == PT_OVS:
Line 140: flag = libvirt.VIR_DOMAIN_START_PAUSED
> we must first READ the lauchflags file (remember it somewhere) and only the
Done
Line 141: 
hooking.dump_vm_launch_flags_to_file(os.environ[VM_ID_KEY], flag)
Line 142: 
Line 143: 
Line 144: def test(ovs, withSecurityGroups):


-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-16 Thread mmirecki 
Marcin Mirecki has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

2016-06-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 2:

* #1314371::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1314371::OK, public bug
* Check Product::#1314371::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org