Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: janitorial: cleanup temporary directories
..
tests: janitorial: cleanup temporary directories
A few tests don't cleanup the temporary
Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 4:
(1 comment)
File tests/hooksTests.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6254/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 5: Verified+1
Marked as Verified. Rationale:
* test behave as before
* no more leaks in /tmp
Dan Kenigsberg has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 5: Code-Review+2
I'd call it NamedTemproraryDir, with a leading uppercase, to look more like
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6234/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 4:
Refactor more aggressively the affected test to do proper cleanup. I think the
result is
Dan Kenigsberg has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 4: Code-Review+1
(1 comment)
File
Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 3: Verified+1
Patch set 3: address Dan's comment and always clean up
marking as verified:
* no
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6204/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 3: Code-Review-1
(2 comments)
File
Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 3:
(2 comments)
File tests/hooksTests.py
Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
..
Patch Set 2: -Verified
--
To view, visit http://gerrit.ovirt.org/22377
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
..
Patch Set 2: Verified+1
mistankenly took out the verified flag
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
..
Patch Set 2: Verified+1
verified:
- tests do run as before (and pass both with and without the patch)
-
Michal Skrivanek has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
..
Patch Set 2: Code-Review+1
Dan,
any comment to your -1?
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
..
Patch Set 1:
(1 comment)
File tests/hooksTests.py
Dan Kenigsberg has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
..
Patch Set 2:
It seems that a race condition in gerrit (or a human one) made me post -1
without the
Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
..
Patch Set 2:
I wonder, it is better to split up this patch in two, one addressing the
cleanup and the
Francesco Romani has uploaded a new change for review.
Change subject: tests: janitorial: cleanup temporary directories.
..
tests: janitorial: cleanup temporary directories.
A few tests don't cleanup the temporary directories
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6075/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6076/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
..
Patch Set 2:
PatchSet v2: extended the comment.
--
To view, visit http://gerrit.ovirt.org/22377
To
Dan Kenigsberg has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
..
Patch Set 2: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/22377
To unsubscribe, visit
24 matches
Mail list logo
