Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
vdsm: prepareVolumePath correct path handling for cdrom
prepareVolumePath looked for 'path'
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6: Code-Review+2
thanks, I'll review the test later.
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6:
Test added in http://gerrit.ovirt.org/#/c/22194/
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20074
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20074
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6:
Ok, I'm convinced that we have to maintain the specParam nonsese (though it
could be
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5805/ :
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6: Verified+1
fixed wrong specParams handling, verified XML against standard cdrom, empty
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 5: Verified+1
cdrom path is always passed in specParams when starting VM from template
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 5:
(1 comment)
It should not be that hard to check this in two branches: engine-3.1 and
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 5:
Build Successful
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/20074
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 3:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4978/ :
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 3: Code-Review-1
(1 comment)
File
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
vdsm: prepareVolumePath correct path handling for cdrom
prepareVolumePath checked looked 'path'
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4896/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4898/ :
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 2: Verified+1
path is now set even if specParams['path'] is empty
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4903/ :
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/20074
To unsubscribe, visit
21 matches
Mail list logo