Dan Kenigsberg has posted comments on this change. Change subject: vdsm: prepareVolumePath correct path handling for cdrom ......................................................................
Patch Set 3: Code-Review-1 (1 comment) .................................................... File vdsm/clientIF.py Line 303: volPath = self._getUUIDSpecPath(drive["UUID"]) Line 304: Line 305: # leave path == '' for empty cdrom and floppy drives ... Line 306: elif (drive['device'] in ('cdrom', 'floppy') and Line 307: hasattr(drive, 'specParams') and It's awfully confusing but here drive is a dict. Keep using 'in'. Also, IMO we should not about ['specParams']['path']. Please explain why we should keep it. Line 308: drive.specParams.get('path', '') == '' and Line 309: drive.get('path', '') == ''): Line 310: volPath = '' Line 311: -- To view, visit http://gerrit.ovirt.org/20074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches