Nir Soffer has submitted this change and it was merged.
Change subject: virt: add device setup and teardown
..
virt: add device setup and teardown
More and more devices require some action to be taken before VM is
started -
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 17: Verified+1
Tested with currently broken hostdev -> works fine, nothing else uses it yet.
The tests pass,
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 17: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/15/vdsm/virt/vmdevices/core.py
File
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File tests/vmTests.py:
Line 1114:
Line
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File tests/vmTests.py:
Line 1114:
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File tests/vmTests.py:
Line 1114:
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File tests/vmTests.py:
Line 1114:
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File tests/vmTests.py:
Line 1114:
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
(2 comments)
https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File tests/vmTests.py:
Line 1114:
Line
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
(3 comments)
https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File tests/vmTests.py:
Line 1114:
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
(2 comments)
partial review
https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
(5 comments)
https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File tests/vmTests.py:
Line 1114:
Line
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/12/tests/vmfakelib.py
File tests/vmfakelib.py:
Line 419:
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/12/tests/vmfakelib.py
File tests/vmfakelib.py:
Line 419:
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 12: Verified+1
Tested whole hostdev + hotplug/hotunplug flow VM flow.
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/12/tests/vmfakelib.py
File tests/vmfakelib.py:
Line 419:
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/12/tests/vmfakelib.py
File tests/vmfakelib.py:
Line 419:
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 12:
(1 comment)
Will review later
https://gerrit.ovirt.org/#/c/55135/12/tests/vmTests.py
File tests/vmTests.py:
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 12: Code-Review+1
partial review
--
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 11:
(7 comments)
Partial review
https://gerrit.ovirt.org/#/c/55135/11/tests/vmTests.py
File tests/vmTests.py:
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 10:
(10 comments)
https://gerrit.ovirt.org/#/c/55135/7/tests/vmfakelib.py
File tests/vmfakelib.py:
Line
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 10: Code-Review-1
let's make sure Nir's comments are not lost
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 10:
Martin, please check my comments from version 7 and answer all to them.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 10:
(5 comments)
partial review
https://gerrit.ovirt.org/#/c/55135/10/tests/vmfakelib.py
File
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 8: Verified+1
works w/ supplied tests, fixes hostdev, doesn't break general usage
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1688: """
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/7/tests/vmTests.py
File tests/vmTests.py:
Line 1136:
Line
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/55135/7/tests/vmTests.py
File tests/vmTests.py:
Line 1136:
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 7: Code-Review-1
(18 comments)
Looks good and nicely tested, see the comments
Milan Zamazal has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 7: Code-Review+1
Looks basically OK to me.
--
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 7: Code-Review+1
(3 comments)
I've minor nits, but not worthy a resubmit. Full ACK on hold to avoid hiding
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/6/tests/vmTests.py
File tests/vmTests.py:
PS6, Line
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/6/tests/vmTests.py
File tests/vmTests.py:
PS6, Line 1119:
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 6: Code-Review+1
(3 comments)
partial review looks good so far.
Few questions/suggestions about the tests
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/55135/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1691:
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 5: Code-Review+1
good point about error handling: let's set rules about that. Temporary lowering
score
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 5: Code-Review-1
(2 comments)
Nice, but we need to think more about error handling.
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS4, Line 1690:
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 4:
Verified w/ the followup patches, standard VM run
--
To view, visit https://gerrit.ovirt.org/55135
To
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS4, Line 1690:
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 4: Code-Review+1
(3 comments)
conceptually fine, we may want to tune some details of the implementation.
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/55135/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS4, Line 1689:
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1685:
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/55135/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1685:
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 2:
I'm ok with the other answers you gave to my previous comments.
We can work out later the asymmetry
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 2: Code-Review-1
(2 comments)
one minor comment inside
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vmdevices/core.py
File
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vmdevices/core.py
File
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS1, Line 1866:
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 1: Code-Review-1
(3 comments)
I like the idea, but we need to tune some details. -1 for visibility while we
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has uploaded a new change for review.
Change subject: virt: add device setup and teardown
..
virt: add device setup and teardown
More and more devices require some action to be taken before VM is
started - even
73 matches
Mail list logo
