Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[automation]

gerrit-hooks has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


Patch Set 3:

* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


yml: parameter type fixes for StoragePool.spmStart


Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Signed-off-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/59704
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Adam Litke 
---
M lib/api/vdsm-api.yml
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Adam Litke: Looks good to me, approved
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[alitke]

Adam Litke has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


Patch Set 2:

Let's keep this patch for some time longer

-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


Patch Set 2: Verified+1

Verified by running schema verification tests

-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/59704/1/tests/vdsmapi_test.py
File tests/vdsmapi_test.py:

Line 580: 
Line 581: _schema.schema().verify_retval(
Line 582: vdsmapi.MethodRep('Host', 'hostdevListByCaps'), ret)
Line 583: 
Line 584: def test_start_spm(self):
> This test is harmful.
As in previous patch.
Line 585: params = {u'prevLver': u'-1',
Line 586:   u'enableScsiFencing': u'false',
Line 587:   u'storagepoolID': 
u'636d9c59-f7ba-4115-87a1-44d6563a9610',
Line 588:   u'prevID': -1,


-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


Patch Set 1: Code-Review-1

(1 comment)

Code looks good, tests is harmful.

https://gerrit.ovirt.org/#/c/59704/1/tests/vdsmapi_test.py
File tests/vdsmapi_test.py:

Line 580: 
Line 581: _schema.schema().verify_retval(
Line 582: vdsmapi.MethodRep('Host', 'hostdevListByCaps'), ret)
Line 583: 
Line 584: def test_start_spm(self):
This test is harmful.
Line 585: params = {u'prevLver': u'-1',
Line 586:   u'enableScsiFencing': u'false',
Line 587:   u'storagepoolID': 
u'636d9c59-f7ba-4115-87a1-44d6563a9610',
Line 588:   u'prevID': -1,


-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


Patch Set 1: Verified+1

Verified by running unit test. The message was copied from Nir's vdsm log.

-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[automation]

gerrit-hooks has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[piotr . kliczewski]

Piotr Kliczewski has uploaded a new change for review.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..

yml: parameter type fixes for StoragePool.spmStart


Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Signed-off-by: Piotr Kliczewski 
---
M lib/api/vdsm-api.yml
M tests/vdsmapi_test.py
2 files changed, 17 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/59704/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index a289b7f..670eed7 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -8602,11 +8602,13 @@
 
 -   description: Deprecated.  The lver of the previous SPM
 name: prevLver
-type: int
+type: string
+datatype: int
 
 -   description: This parameter is not used
 name: enableScsiFencing
-type: boolean
+type: string
+datatype: boolean
 
 -   defaultvalue: null
 description: The maximum number of hosts that could be in the cluster
@@ -8616,7 +8618,8 @@
 -   defaultvalue: null
 description: The expected Storage Domain version of the master domain
 name: domVersion
-type: int
+type: string
+datatype: int
 return:
 description: A task UUID
 type: *UUID
diff --git a/tests/vdsmapi_test.py b/tests/vdsmapi_test.py
index bff578c..04297b1 100644
--- a/tests/vdsmapi_test.py
+++ b/tests/vdsmapi_test.py
@@ -580,3 +580,14 @@
 
 _schema.schema().verify_retval(
 vdsmapi.MethodRep('Host', 'hostdevListByCaps'), ret)
+
+def test_start_spm(self):
+params = {u'prevLver': u'-1',
+  u'enableScsiFencing': u'false',
+  u'storagepoolID': u'636d9c59-f7ba-4115-87a1-44d6563a9610',
+  u'prevID': -1,
+  u'domVersion': u'3',
+  u'maxHostID': 250}
+
+_schema.schema().verify_args(
+vdsmapi.MethodRep('StoragePool', 'spmStart'), params)


-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org